Bug#932612: git-debpush: detect unstitched gdr branch

2019-07-22 Thread Ian Jackson
Sean Whitton writes ("Bug#932612: git-debpush: detect unstitched gdr branch"): > On Mon 22 Jul 2019 at 02:40PM +01, Ian Jackson wrote: > > We could add a failing git-debpush invocation to some random gdr-test. > > (adding the dependency and regenerating d/t/control) >

Bug#932612: git-debpush: detect unstitched gdr branch

2019-07-22 Thread Sean Whitton
Hello, On Mon 22 Jul 2019 at 02:40PM +01, Ian Jackson wrote: > Another way to detect this would be that the branch is not ff of where > it is going to be pushed. Indeed, it will be not ff of the local > tracking branch for the remote. This might be a useful thing to check > anyway: it seems

Bug#932612: git-debpush: detect unstitched gdr branch

2019-07-22 Thread Ian Jackson
> On Sun 21 Jul 2019 at 03:02PM +01, Ian Jackson wrote: > > Look for the ffq-prev ref. Any gdr unstitched branch will have such a > > corresponding ref. See STITCHING, PSEUDO-MERGES, FFQ RECORD in > > git-debrebase(5). > > Thanks. Patch enclosed. Nice work. LGTM. One tiny code comment.

Bug#932612: git-debpush: detect unstitched gdr branch

2019-07-22 Thread Sean Whitton
control: tag -1 +patch Hello, On Sun 21 Jul 2019 at 03:02PM +01, Ian Jackson wrote: > Sean Whitton writes ("Bug#932612: git-debpush: detect unstitched gdr branch"): >> Package: git-debpush >> Version: 9.4 >> Severity: wishlist > ... >> There should be a

Bug#932612: git-debpush: detect unstitched gdr branch

2019-07-21 Thread Ian Jackson
Sean Whitton writes ("Bug#932612: git-debpush: detect unstitched gdr branch"): > Package: git-debpush > Version: 9.4 > Severity: wishlist ... > There should be a check for an unstitched gdr branch. Ian, can you > chime in with how this ought to be detected, please?

Bug#932612: git-debpush: detect unstitched gdr branch

2019-07-21 Thread Sean Whitton
Package: git-debpush Version: 9.4 Severity: wishlist Hello, There should be a check for an unstitched gdr branch. Ian, can you chime in with how this ought to be detected, please? git-debpush should absolutely not run `git debrebase conclude` on the user's behalf before pushing, because