Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-11-25 Thread John Paul Adrian Glaubitz
On 11/25/19 3:40 PM, Mattia Rizzolo wrote: > On Mon, Nov 25, 2019 at 02:19:42AM +0100, John Paul Adrian Glaubitz wrote: >> Could this bug get fixed soonish? We still can't build VLC on the affected >> architectures because of this particular bug. >> >> In my tests, removing the paragraph worked

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-11-25 Thread Mattia Rizzolo
On Mon, Nov 25, 2019 at 02:19:42AM +0100, John Paul Adrian Glaubitz wrote: > Could this bug get fixed soonish? We still can't build VLC on the affected > architectures because of this particular bug. > > In my tests, removing the paragraph worked perfectly fine and still made > "nocheck" work.

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-11-24 Thread John Paul Adrian Glaubitz
Hi! Could this bug get fixed soonish? We still can't build VLC on the affected architectures because of this particular bug. In my tests, removing the paragraph worked perfectly fine and still made "nocheck" work. Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer -

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-23 Thread John Paul Adrian Glaubitz
Hi Helmut! On 10/23/19 6:23 PM, Helmut Grohne wrote: > I looked back at the patch and am unsure here. I cannot imagine adding > it just for reducing build time. It must have had an effect at that > time. In general, building tests is not a problem for cross building. > Just running them is. Could

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-23 Thread Mattia Rizzolo
On Wed, Oct 23, 2019 at 06:23:10PM +0200, Helmut Grohne wrote: > > Indeed. But I have not figured out yet what the issue is. I can just say > > that building with "nocheck" currently results in a broken .pc file. > > This is easy enough to diagnose. Just build it twice once without > nocheck and

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-23 Thread John Paul Adrian Glaubitz
On 10/23/19 6:28 PM, Mattia Rizzolo wrote: >> So yeah, you should revert that part. Doing so will make it fail to >> cross build. Making nocheck work requires a different fix I fear. > > Don't worry, as I mentioned (maybe too quickly?) in my email I already > worked on a different solution,

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-23 Thread Helmut Grohne
Hi, On Wed, Oct 23, 2019 at 05:37:51PM +0200, John Paul Adrian Glaubitz wrote: > On 10/23/19 5:23 PM, Mattia Rizzolo wrote: > > This was added by Helmut to fix a FTCBFS. Are you sure removing the > > -DBUILD_TESTS=0 doesn't break cross builds? > > Yes. You can verify that removing the whole

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-23 Thread John Paul Adrian Glaubitz
On 10/23/19 5:23 PM, Mattia Rizzolo wrote: > This was added by Helmut to fix a FTCBFS. Are you sure removing the > -DBUILD_TESTS=0 doesn't break cross builds? Yes. You can verify that removing the whole paragraph still makes "nocheck" work the what you expect it, i.e.. the testsuite is still not

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-23 Thread Mattia Rizzolo
On Mon, Oct 21, 2019 at 08:39:17PM +0200, John Paul Adrian Glaubitz wrote: > ifneq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),) > CONFIGURE_FLAGS += -DBUILD_TESTS=0 -DBUILD_EXAMPLES=1 > endif > > With the paragraph removed, "nocheck" still works as expected and building > with "nocheck" no longer

Bug#942795: Acknowledgement (libsoxr: Building with "nocheck" results in a broken soxr.pc pkg-config file)

2019-10-21 Thread John Paul Adrian Glaubitz
Hi! Okay, this is actually caused by passing "-DBUILD_EXAMPLES=1" to cmake. I have not been able to find out what the problem is - it's an upstream bug - but in Debian it can easily be fixed by removing the following paragraph from debian/rules which turns out not to be necessary: ifneq