Package: libnet-proxy-perl
Version: 0.12-6
Severity: normal

Dear Maintainer,

Please consider adding a native systemd service masking the already
shipped init script (fixes lintian tag[1] in subject).

I'm attaching my own attempt at writing a service file simply from
looking at what the init script does. Note that it's completely untested
as I don't use libnet-proxy-perl (sslh) myself.
(You should be able to drop the attached file in the debian/ folder
and bump the packages debhelper compat to >= 10 and then debhelper
should do the right thing for you both with installing and handling
the service file in maintainer scripts.)

The service file does not replicate the home-brew service enable[2]
from the init script. Please consider dropping that!

Additional improvements related to eg. security hardening[3]
is possible.

Regards,
Andreas Henriksson


[1]: 
https://lintian.debian.org/tags/missing-systemd-service-for-init.d-script.html
[2]: 
https://lintian.debian.org/tags/init.d-script-should-always-start-service.html
[3]: 
https://lintian.debian.org/tags/systemd-service-file-missing-hardening-features.html
[Unit]
Description=SSH/HTTPS service multiplexer
After=network.target

[Service]
#Type=simple
EnvironmentFile=-/etc/default/sslh
ExecStart=/usr/bin/sslh $SSLH_OPTIONS
Restart=on-failure
# TODO: security hardening settings

[Install]
WantedBy=multi-user.target

Reply via email to