Control: severity -1 wishlist

Hi!

On Wed, 2020-07-01 at 11:35:14 +0200, Christian Ehrhardt wrote:
> Package: liburing
> Version: 0.6-3

> But in regard to build time and autopkgtests I found that these always
> failed.
> I've taken a look at that as I'd love to get some actual test coverage onto
> liburing in Debian&Ubuntu.

Yeah me too, and I've been fixing these upstream to try to get there. But
unfortunately these tests are highly kernel version dependent, and new
ones tend to have very recent kernel requirements.

The various architectures supported in Debian have wildly different
support and kernel versions in the buildds. So I don't find it
realistic to enforce them right now, TBH.

I still want to run them to be able to check the results from time to
time, though.

> Note, the tests at build and at autopkgtest time are mostly the same.
> Therefore I've kept "Rules-Requires-Root: no" in d/control which means it
> will
> in most cases not test at build time (unless you e.g. sudo sbuild ...). But
> since the same tests will run at autopkgtest that is ok for me, if you
> want/need build time checks please change R³ to yes and they will work.

Yeah, I'd rather not require root for building.

> I have eventually done a cross-arch build [3] and test [4] on Ubuntu to see
> how !x86 behaves now that the tests work on x86. Depending on the outcome
> of this we might disable a few more tests maybe, but they are still
> running? Since CI so far considers these always-failed we can go on as-is,
> since in the worst case non-x86 will stay that way until we further improve.

See above, this does not seem realistic in Debian. :/

> P.S. unfortunately the packaging repo doesn't contain the actual liburing
> source. Due to that I had to always ex/import from this repo onto a
> directory actually having the liburing source - is there any reason not to
> package it "as usual" with the source as in orig tarball present as well?

I find the workflow of keeping the upstream sources in the packaging
repos to be wrong-headed, and very confusing for people that are not
into Debian packaging. I've written about this elsewhere but probably
need to create a wiki page or similar to point to people that might be
curious why. :)


> From a08a5f39885e965994bf84e537956a559ac7ca46 Mon Sep 17 00:00:00 2001
> From: Christian Ehrhardt <christian.ehrha...@canonical.com>
> Date: Tue, 30 Jun 2020 14:54:44 +0200
> Subject: [PATCH 3/6] d/t/test-build: io_uring-link no more exists as example,
>  but link-cp does

Thanks, in 0.7-1, I reworked the autopkgtest to use a loop and fixed
this by renaming the example name.

So thanks for all the patches, although as it is now, I think I'm
unlikely to pull in the rest of the patches, given that this is currently
going to be a major burden until uring support stabilizes in the kernel
for all arches. Perhaps I'll add one autopkgtest running as root though,
but that's probably it.

Thanks,
Guillem

Reply via email to