Control: tag -1 - confirmed + moreinfo
Hi Gianfranco,
now that Bullseye is released and I'm preparing the upload of a new
upstream release, I've revisited this bug report.
Gianfranco Costamagna wrote:
> > Yeah, and the version.sh call itself can be removed, too. Will do.
Planned to do that(*),
Hello,
On Tue, 11 Aug 2020 21:06:02 +0200 Gianfranco Costamagna
wrote:
> Hello Axel,
>
> > Yeah, and the version.sh call itself can be removed, too. Will do.
> >
> > Thanks for bringing this up despite the initially differing opinions.
> > :-)
> >
>
> thanks to you!
>
> And forgive me if I
Hello Axel,
> Yeah, and the version.sh call itself can be removed, too. Will do.
>
> Thanks for bringing this up despite the initially differing opinions.
> :-)
>
thanks to you!
And forgive me if I wasn't clear enough, I wrote the email after a somewhat
deep analysis of the issue, and my
Dear Gianfranco,
Gianfranco Costamagna wrote:
> > > specially because in Debian we don't even use version.sh script to
> > > fill the dkms.conf file.
> >
> > I don't understand what you refer to with "in Debian". Do you mean the
> > fact that I didn't ship the package's upstream's version.sh? Do
Hello!
> Not "external" stuff but stuff from its own source.
>
oops, you are right...
> > I don't think this is a sane idea,
>
> I disagree. Using pushd/popd (or "cd -") in scripts is a valid way to
> avoid a helper variable to save the previous directory.
>
> But what I dislike in the
Control: severity -1 normal
Control: tag -1 - patch
Dear Gianfranco,
first thanks for making me aware of suboptimal upstream code.
Gianfranco Costamagna wrote:
> Hello, looks like your dkms ship file is sourcing external stuff
> with pushd/popd and so on.
Not "external" stuff but stuff from
Source: iptables-netflow
Version: 2.5-2
Severity: serious
tags: patch
Hello, looks like your dkms ship file is sourcing external stuff with
pushd/popd and so on.
I don't think this is a sane idea, specially because in Debian we don't even
use version.sh script to fill the dkms.conf file.
Can
7 matches
Mail list logo
