Hi!

I'm crossposting this to another bug because maybe the previous bug fix is
the one that is making the new bug fail.

Alexander, I hope you are still around so we can talk about this bug you had
sent.

I just came over to this bug but with the reverse feeling, after your patch
now the code doesn't wait at all.

You can go to https://bugs.debian.org/779348 in order to see what you had
sent, with your change the code goes...

    unset BREADY
    unset TRANSITIONED
    COUNT=0

    # Use 0.1 delay if available
    sleep 0.1 2>/dev/null && MAXWAIT=$((MAXWAIT * 10))

    while [ -n "$BREADY" -a $COUNT -lt $MAXWAIT ]
    do
        WAIT AND OTHER STUFF
    done

So, as we've unset BREADY, then BREADY is empty, so -n "$BREADY" will be
false and thus we wont go in the wait loop and thus it will exit without the
bridge being ready.

So... for me the code was Ok, now... what I'm asking myself is how have we
gone this far with this bug we introduced without anybody complaining.

I just came to it after setting STP and IPv6, then DAD failed and I went
looking for the bug.

So... I'm about to reverse this patch you sent me but... I'd like to know
what was wrong in the first place, that is, when you sent me the patch.

Regards...
-- 
Manty/BestiaTester -> http://manty.net

Reply via email to