Package: smokeping Version: 2.7.3-2 Severity: important Tags: upstream patch
Dear Maintainer, The UI of smokeping automatically refreshes the page when zoomed in on some graphs (every 10s here) making it completely unusable (or actually higly annoying) using it. The bug report upstream is from 2012 https://github.com/oetiker/SmokePing/issues/5 and there is finally a fix for it that's also merged upstream. https://github.com/oetiker/SmokePing/pull/170 Please consider applying it in debian. I've tested the patch in a vanilla smokeping installation and also in our infrastructure and it indeed fixes the problem. Patch reference: commit ef1a7eac0a2f0baaf2cf1dc47703a73cdd936752 Author: n0rc <c...@cypherpunks.cc> Date: Wed Mar 13 15:35:48 2019 +0100 disabled page refresh while zooming (#5) diff --git a/htdocs/js/smokeping.js b/htdocs/js/smokeping.js index 59410cc..eb34e5e 100644 --- a/htdocs/js/smokeping.js +++ b/htdocs/js/smokeping.js @@ -26,12 +26,20 @@ var EndEpoch = 0; function changeRRDImage(coords,dimensions){ + // disable reloading the RRD image while zoomed in + try { + window.stop(); + } catch (exception) { + // fallback for IE + document.execCommand('Stop'); + } + var SelectLeft = Math.min(coords.x1,coords.x2); var SelectRight = Math.max(coords.x1,coords.x2); if (SelectLeft == SelectRight) - return; // abort if nothing is selected. + return; // abort if nothing is selected. var RRDLeft = 67; // difference between left border of RRD image and content var RRDRight = 26; // difference between right border of RRD image and content I've removed all included information as it is from another system and is not related to this bug report. ps.: trying to include secrets into a public bugreport is not nice... best regards, gebi
