Bug#988029: apache2: Non-unique IDs being generated by mod_unique_id - Fix available

2021-06-07 Thread Амон аз ZH
On Tue, 4 May 2021 01:04:51 +0200 Atle Solbakken wrote: > On Mon, 03 May 2021 23:29:23 +0200 Atle Solbakken > wrote: > > > I've tried to compile the patch on top of the current stable version > 2.0.38 which seems > > to work. Upstream, the patch is only available from 2.0.47 and it's >

Bug#988029: apache2: Non-unique IDs being generated by mod_unique_id - Fix available

2021-05-05 Thread Atle Solbakken
On Tue, 4 May 2021 06:31:12 +0200 Ondřej Surý wrote: > The patch is wrong. It only adds thread local data and does absolutely nothing to prevent id collisions. > Hi You're kind of right even though the patch solved the immediate problem in some situations. I've submitted a rewrite of this

Bug#988029: apache2: Non-unique IDs being generated by mod_unique_id - Fix available

2021-05-03 Thread Ondřej Surý
The patch is wrong. It only adds thread local data and does absolutely nothing to prevent id collisions. It should not be merged here and also should not be merged upstream, but it’s beyond my capacity to send the feedback there. You need something like: - generate random nonce for each

Bug#988029: apache2: Non-unique IDs being generated by mod_unique_id - Fix available

2021-05-03 Thread Yadd
Le 03/05/2021 à 23:29, Atle Solbakken a écrit : > Package: apache2 > Version: 2.4.38-3+deb10u4 > Severity: normal > Tags: patch > > Hi > > The current version has a race condition in mod_unique_id causing non-unique > IDs to be > generated (multiple threads are using a counter without any

Bug#988029: apache2: Non-unique IDs being generated by mod_unique_id - Fix available

2021-05-03 Thread Atle Solbakken
On Mon, 03 May 2021 23:29:23 +0200 Atle Solbakken wrote: > I've tried to compile the patch on top of the current stable version 2.0.38 which seems > to work. Upstream, the patch is only available from 2.0.47 and it's currently in experimental. > > Maybe it can be applied to 2.0.38 aswell.

Bug#988029: apache2: Non-unique IDs being generated by mod_unique_id - Fix available

2021-05-03 Thread Atle Solbakken
Package: apache2 Version: 2.4.38-3+deb10u4 Severity: normal Tags: patch Hi The current version has a race condition in mod_unique_id causing non-unique IDs to be generated (multiple threads are using a counter without any mutex). I've encountered the issue in a production situation myself.