Package: ansible
Version: 2.10.7+merged+base+2.10.8+dfsg-1
Severity: minor
X-Debbugs-Cc: zoreda...@gmail.com

Dear Maintainer,

The patch 0005_use_py3.patch changes code-smell/shebang.py in a way that
breaks it.

This should probably be python3, not python33

    @@ -1,4 +1,4 @@
    -#!/usr/bin/env python
    +#!/usr/bin/env python33
     from __future__ import (absolute_import, division, print_function)
     __metaclass__ = type

The `@@ -16,14 +16,14 @@` section also probably isn't correct. The
ansible-test is sometimes used by 3rd party code and module development.
Code that might have the python shebang.  Adding the `#!/usr/bin/env
python3` as an additional shebang to check should be fine, but I can't
imagine there is a good reason to remove the check for code that has
`#!/usr/bin/env python`. Third party code that has that as a shebang, and
should get a warning.

@@ -16,14 +16,14 @@
         b'#!/usr/bin/env bash',
         b'#!/usr/bin/env fish',
         b'#!/usr/bin/env pwsh',
         b'#!/usr/bin/env python',
+        b'#!/usr/bin/env python3',
         b'#!/usr/bin/make -f',
     ])

     integration_shebangs = set([
         b'#!/bin/sh',
         b'#!/usr/bin/env bash',
         b'#!/usr/bin/env python',
+        b'#!/usr/bin/env python3',
     ])

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing-security
  APT policy: (500, 'testing-security'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 5.10.16.3-microsoft-standard-WSL2 (SMP w/8 CPU threads)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages ansible depends on:
ii  openssh-client        1:8.4p1-5
ii  python3               3.9.2-3
ii  python3-cryptography  3.3.2-1
ii  python3-distutils     3.9.2-1
ii  python3-dnspython     2.0.0-1
ii  python3-httplib2      0.18.1-3
ii  python3-jinja2        2.11.3-1
ii  python3-netaddr       0.7.19-5
ii  python3-packaging     20.9-2
ii  python3-pycryptodome  3.9.7+dfsg1-1+b2
ii  python3-yaml          5.3.1-5

Versions of packages ansible recommends:
ii  python3-argcomplete  1.8.1-1.5
ii  python3-jmespath     0.10.0-1
ii  python3-kerberos     1.1.14-3.1+b3
ii  python3-libcloud     3.2.0-2
ii  python3-selinux      3.1-3
ii  python3-winrm        0.3.0-2
ii  python3-xmltodict    0.12.0-2

Versions of packages ansible suggests:
pn  cowsay   <none>
pn  sshpass  <none>

-- no debconf information

Reply via email to