Package: sponsorship-requests Followup-For: Bug #994750 Control: tags -1 moreinfo
Hi Pablo, I've just saw that moreinfo has been removed from this RFS, so let's take another round of review: - There have been an NMU of the package, the changes of the NMU are not in your package. Please rebase your package to include this NMU. NMU version was: 0.62.dfsg2-4.1. (It could be that you just need to merge d/changelog, I did not check that.) - You should fix as well: - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=421648 - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=455401 - Wording suggestion for the first changelog entry would be: * New upstream release (Closes #…, #…, #…) (your sentence is fine but nonstandard; no need to fix, but it would be nice) - d/README.Debian does not contain useful information, it should be deleted. - d/changelog: There are undocumented changes to the packaging. Please make sure to document everything you change … e.g - that you are adopting the package (and you need to close the ITA bug) - Standard version updated - d/compat removed by B-D on debhelper_compat; also changing compat level with that change. - all the changes to the patches are undocumented. - and many more undocumented changes. - d/control - Extended description for the data package should also include the description of the game, so that the desciption is descriptive if only looking at the data package's one. I'd copy the complete extended description of the main package and add -- as a new paragraph -- the current data package description. - (optional) Please consider adding a VCS for the packaging; you can use salsa.debian.org to host it. - (optional) Please consider to put the game under the games-team umbrella. - if possible, add dep-3 headers to the patches to document them. if you are using quilt, quilt --header -e --dep3 will give you a start. - the file d/dirs and d/mazeofgalious.dirs should not be required. - lintian stuff that needs fixing: - W: mazeofgalious: description-synopsis-starts-with-article (will be fixed when you fix above mentioned bugs) - W: mazeofgalious: package-contains-upstream-installation-documentation [usr/share/doc/mazeofgalious/INSTALL] this file should not be installed - I: mazeofgalious source: anticipated-repack-count 0.63+dfsg1-1 it should be just "dfsg" without the "1". - I: mazeofgalious: extra-license-file [usr/share/doc/mazeofgalious/LICENSE.gz the GPL license text should not be installed. - I: mazeofgalious: hardening-no-bindnow [usr/games/mog] - I: mazeofgalious: hardening-no-fortify-functions [usr/games/mog] The upstream Makefile hardcodes (overwrites) compiler and linker flags. You need to patch it so that those set from dpkg-builpackage are appended. This is a regression, as in the previous package there was a patch addressing this. - d/copyright should also mention, for debian/* all previous maintainers and when they maintained the package. - (optional) the package-contains-documentation-outside-usr-share-doc lintian findings should be overridden, it adds a lot of noise to the lintian report and as those seems to be level data, linitian is wrong… - changelog says: "Also modified start.pcx images, as specified in #341501", but looking at start.pcx I don't see that #641501 is addressed. -- tobi