Bug#1067957: [[maude-bugs]] [EXTERNAL] Re: Maude fails to build on armhf

2024-04-10 Thread Andreas Tille
Hi,

Am Wed, Apr 10, 2024 at 03:33:53PM -0700 schrieb Steven Eker:
> I like that solution since I believe there are 64-bit platforms where long
> is 32-bits. I've updated my development version thus:
> 
>   //
>   //    timeValue.tv_sec is 64-bit since Linux kernel 5.6 but GMP doesn't
> yet have support
>   //    for long long which is a problem on platforms where long is less
> than 8 bytes.
>   //
> #if SIZEOF_LONG < 8
>   double seconds = timeValue.tv_sec;
> #else
>   long seconds = timeValue.tv_sec;
> #endif
>   mpz_class nanoSeconds(seconds);

Sounds like some working solution.  It would help if you could tag a new
released to enable us fetching a fresh tarball incorporatinig this
change.
 
> Of course I expect to drop support for 32-bit before 2038 - certainly when
> one our dependencies drops support. But I've gotten a bug report for
> building Maude on a Raspberry Pi.

Raspian is based on Debian and if the 32bit ARM architectures fail here
Raspian people have a problem.

Kind regards
   Andreas. 

-- 
https://fam-tille.de



Bug#1065649: e17: changes for libddcutil 2.1.4

2024-04-10 Thread Ross Vandegrift
Control: tags -1 pending

Hi Sanford,

On Fri, Mar 08, 2024 at 02:10:12AM -0500, Sanford Rockowitz wrote:
> The version of ddcutil in Debian is being updated to release 2.1.4. Shared
> library package libddcutil5 replaces libddcutil4.
> 
> Source package e17 has been identified as using libddcutil.
> 
> File e_system_ddc.c should be modified to try opening libddcutil.so.5 before
> libddcutil.so.4.
> 
> In debian/control, consider adding:
> 
> Recommends: libddcutil4 (>= 1.4.1) | libddcutil5 (>= 2.1.4)
> or
> Suggests: libddcutil4 (>= 1.4.1) | libddcutil5 (>= 2.1.4)

Thanks for the heads up.  Both changes will be in the next upload.  Upstream's
also merged support in:

https://git.enlightenment.org/enlightenment/enlightenment/pulls/68

Thanks,
Ross



Bug#1068605: RFS: web-mode/17.3.13-1 [Team] -- major emacs mode for editing web templates

2024-04-10 Thread Xiyue Deng
Nicholas D Steeves  writes:

> reopen 1068605
> owner 1068605 !
> thanks
>
> Hi,
>
> Sorry I didn't ask this sooner, but would you prefer if I call you Deng,
> or Xiyue, or something else?  Conventions and understanding vary a lot
> from place to place, after all.

No worries!  My first name is Xiyue, but I acknowledge that this is
probably difficult to pronounce in non-Asian countries or even outside
of China, so feel free to call me Deng, or even my code name "manphiz"
:)

>
> Xiyue Deng  writes:
>
>> Thanks for pointing out #1019031!  Totally missed it.  I'll opt for
>> option 1 obviously.  Updated team repo and mentors accordingly.
>
> You're welcome, and thank you.  On a related note, have you read the
> definitions for source and binary packages?
>
> #1019031 was filed against src:web-mode, so was hidden from the
> bin:elpa-web-mode view.  On the BTS the src:package view will display
> bugs that affect each binary package as well as the src:package.  §4 of
> Policy has the definition, and here is another good resource:
>
>   https://wiki.debian.org/Packaging/SourcePackage
>

Actually I should have noticed it through the tracker page[1], which has
a panel showing all bugs reported against all source and binary packages.

>> Also, accordingly to this comment from Tobias[1] it looks like there are
>> opinions that prefer to reuse existing RFS bugs instead of filing new
>> ones.  Do you think it's OK to reopen this one?
>
> There are also people who maintain the opposite position, but in the
> spirit of harmony I've reopened this bug. [edit: Be careful about only
> waiting a day and then going ahead and doing something without having
> received a reply, because when you "ask" for something, but then don't
> actually wait for a reply, it can make you look disingenuous and/or
> impatient and/or pushy.]
>

I acted fast this time as this is a RFS bug so by reopening I'm not
overriding any other people's work and it gives me a higher chance to
find a potential sponsor faster.  But I acknowledge the concern you
pointed out and will be cautious in future.

(And I get you as a reviewer which is better than I expected and I'd say
it "worked" in my favor :P)

> Onto the review:
>
>* New upstream release
>
> Push the upstream tag to salsa, and find a way to mitigate this issue in
> the future.
>

Thanks for pointing this out, and this is something that confuses me.
According to the dgit-maint-merge(7) workflow, one should have a
upstream branch tracking upstream git repo directly, so that when you
merge a tagged release "git deborig" can directly use upstream tags to
create the tarball.  On the other hand, if we have salsa CI set up there
is no upstream tag on salsa so it probably will fail at "git deborig"
stage.  Still, if I read the dgit-maint-merge workflow correctly (I
could be wrong), it only requires a "upstream/%(version)s" tag when the
upstream only releases tarballs or when we want to package a snapshot.
So I'm not sure whether we always want to have "upstream/%(version)s"
tags.

Would like to hear your opinion on this.

>* Set upstream metadata fields: Bug-Database, Bug-Submit,
>  Repository-Browse
>* Update standards version to 4.6.2; no changes needed
>
> Update this, since a new Policy version was recently released.  Did you
> already work through the upgrade checklist stepwise, starting from
> 4.3.0?
>

Yes, I reviewed the policy upgrading checklist[2] and there should not
be any changes required (actually from 4.5.0 when Thomas last worked on
it).  The same applies to 4.7.0 which I've updated to in [3].

> "debian-devel-announce" is a low traffic list that will keep you
> appraised of stuff like this.
>

Ack, and glad I've already subscribed.  Just that I worked on web-mode a
bit earlier than the announcement.

>* Use https link of homepage in d/control
>* Modernize d/watch using special substitute strings to be more
>robust
>
> I'm happy to see this clear, concise, and useful phrasing.  If you have
> any pending not-yet-uploaded work that doesn't use this, please update
> it.  If you're interested in a nitpick, the key term is "substitution
> strings" and not "[special] substitute strings" (see the manpages for
> uscan and deb-substvars as well as codesearch.debian.net).
>

Ack.  Dropping the "special" part in changelog[4].

>* Fix issues in d/copyright
>  - Clarify license to be GPL-3+ to be consistent with upstream
>
> This is unclear.  Which licence was it before, and whose license are you
> talking about?  Web-mode is a non-native package and debian/* is
> separate from the upstream source.  Also, what does it mean to clarify a
> license?
>

It used to be GPL-2, and I'm talking about the upstream license.  The
upstream updated it to GPL-3 in 2022, which was actually after Thomas
last worked on the package.  I think maybe I should change the wording
to "Update license to GPL-3+ following upstream changes"[5]

>  - 

Bug#1068791: iraf-fitsutil: fgread and fgwrite utilities crash with segmentatin fault

2024-04-10 Thread Vladimir Petko
Package: iraf-fitsutil
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch

Dear Maintainer,

 The package autopkgtests fail on armhf[1] due to 'long' passed to functions
taking 'time_t' as an argument.

fgwrite crashes with the following stacktrace:
---
Program received signal SIGSEGV, Segmentation fault.
0x0040284e in sprintf (__fmt=0x405160 "%d-%2.2d-%2.2dT%2.2d:%2.2d:%2.2d",
__s=0xfffef18c "2024-04-10T23:34:55")
at /usr/include/arm-linux-gnueabihf/bits/stdio2.h:30
warning: Source file is more recent than executable.
30 return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
(gdb) where
#0 0x0040284e in sprintf (__fmt=0x405160 "%d-%2.2d-%2.2dT%2.2d:%2.2d:%2.2d",
__s=0xfffef18c "2024-04-10T23:34:55")
at /usr/include/arm-linux-gnueabihf/bits/stdio2.h:30
#1 fgfileout (fname=fname@entry=0xfffef77d "pix.fits", out=1, ftype=6,
path=path@entry=0x405318 "", level=level@entry=1)
at fgwrite.c:695
#2 0x00400f7e in main (argc=, argv=) at
fgwrite.c:360
(gdb) down
Bottom (innermost) frame selected; you cannot go down.
(gdb) up
#1 fgfileout (fname=fname@entry=0xfffef77d "pix.fits", out=1, ftype=6,
path=path@entry=0x405318 "", level=level@entry=1)
at fgwrite.c:695
warning: 695 fgwrite.c: No such file or directory
(gdb) print tm
$1 = (struct tm *) 0x0
---
Structure fheader uses long to represent timestamps causing a failure to obtain
the proper timestamp.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/use-time-t.patch: use time_t instead of long for
timestamps (LP: #2058985).


Thanks for considering the patch.

[1]
https://objectstorage.prodstack5.canonical.com/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842/autopkgtest-
noble/noble/armhf/i/iraf-fitsutil/20240408_131637_f974b@/log.gz


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru iraf-fitsutil-2018.07.06/debian/patches/series 
iraf-fitsutil-2018.07.06/debian/patches/series
--- iraf-fitsutil-2018.07.06/debian/patches/series  2024-03-26 
10:57:36.0 +1300
+++ iraf-fitsutil-2018.07.06/debian/patches/series  2024-04-11 
11:54:47.0 +1200
@@ -5,3 +5,4 @@
 Add-missing-tm_isdst-initialization.patch
 Don-t-try-to-install-cfitsio.patch
 ANSI-C-clean-Wall.patch
+Use-time-t.patch
diff -Nru iraf-fitsutil-2018.07.06/debian/patches/Use-time-t.patch 
iraf-fitsutil-2018.07.06/debian/patches/Use-time-t.patch
--- iraf-fitsutil-2018.07.06/debian/patches/Use-time-t.patch1970-01-01 
12:00:00.0 +1200
+++ iraf-fitsutil-2018.07.06/debian/patches/Use-time-t.patch2024-04-11 
11:54:47.0 +1200
@@ -0,0 +1,35 @@
+Description: use time_t to represent timestamps
+ Due to time_t migration, sizeof(time_t) != sizeof(long) on armhf.
+ Use time_t type to represent timestamps in fgwrite/fgread.
+ This is safe to do, because the timestamps are stored in the string
+ format in the input/output file.
+Author: Vladimir Petko 
+Origin: https://github.com/iraf-community/iraf-fitsutil/pull/17
+Bug: https://github.com/iraf-community/iraf-fitsutil/issues/16
+Bug-Ubuntu: 
https://bugs.launchpad.net/ubuntu/+source/iraf-fitsutil/+bug/2058985
+Last-Update: 2024-04-11
+
+--- a/src/fgwrite.c
 b/src/fgwrite.c
+@@ -71,8 +71,8 @@
+   int gid;
+   int isdir;
+   longsize;
+-  longmtime;
+-  longctime;
++  time_t  mtime;
++  time_t  ctime;
+   longchksum;
+   int linkflag;
+   charlinkname[NAMSIZ];
+--- a/src/fgread.c
 b/src/fgread.c
+@@ -85,7 +85,7 @@
+   int dirlevel;
+   longsize;
+   longhsize;
+-  longmtime;
++  time_t  mtime;
+   longchksum;
+   int linkflag;
+   charlinkname[NAMSIZ];


Bug#1066285: nvi: FTBFS: ../dist/../common/options_f.c:324:16: error: implicit declaration of function 'conv_enc' [-Werror=implicit-function-declaration]

2024-04-10 Thread Michael Hudson-Doyle
Package: nvi
Followup-For: Bug #1066285
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hud...@ubuntu.com
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * d/patches/add-prototypes.h: add includes and prototypes for some functions
(including prototypes for some standard functions that are only accessible
if _XOPEN_SOURCE is defined, but lots of other stuff breaks if that is
defined :/).

Thanks for considering the patch.

Cheers,
mwh

-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru nvi-1.81.6/debian/control nvi-1.81.6/debian/control
--- nvi-1.81.6/debian/control   2024-03-03 09:35:03.0 +1300
+++ nvi-1.81.6/debian/control   2024-04-11 14:45:28.0 +1200
@@ -1,8 +1,7 @@
 Source: nvi
 Section: editors
 Priority: optional
-Maintainer: Ubuntu Developers 
-XSBC-Original-Maintainer: Tobias Heider 
+Maintainer: Tobias Heider 
 Standards-Version: 4.6.2
 Build-Depends:
  debhelper-compat (= 13),
diff -Nru nvi-1.81.6/debian/patches/add-prototypes.patch 
nvi-1.81.6/debian/patches/add-prototypes.patch
--- nvi-1.81.6/debian/patches/add-prototypes.patch  1970-01-01 
12:00:00.0 +1200
+++ nvi-1.81.6/debian/patches/add-prototypes.patch  2024-04-11 
14:45:28.0 +1200
@@ -0,0 +1,53 @@
+--- a/common/conv.h
 b/common/conv.h
+@@ -21,3 +21,6 @@
+   char2wchar_tinput2int;
+   wchar2char_tint2disp;
+ };
++
++extern int conv_enc (SCR *sp, int option, char *enc);
++extern void conv_init (SCR *orig, SCR *sp);
+--- a/cl/cl.h
 b/cl/cl.h
+@@ -26,6 +26,11 @@
+ #endif
+ #endif
+ 
++/*
++ * for setupterm()
++ */
++#include 
++
+ typedef struct _cl_private {
+   char ibuf[256]; /* Input keys. */
+ 
+--- a/common/multibyte.h
 b/common/multibyte.h
+@@ -5,6 +5,12 @@
+ #include 
+ #include 
+ 
++/*
++ * This is declared by wchar.h, but only if _XOPEN_SOURCE is set and lots of
++ * other things break if we define that.
++ */
++extern int wcwidth (wchar_t c);
++
+ typedef   wchar_t RCHAR_T;
+ #define RCHAR_T_MAX   ((1 << 24)-1)
+ typedef   wchar_t CHAR_T;
+--- a/cl/cl_funcs.c
 b/cl/cl_funcs.c
+@@ -31,6 +31,12 @@
+ #include "../vi/vi.h"
+ #include "cl.h"
+ 
++/*
++ * This is declared by ncurses.h, but only if _XOPEN_SOURCE is set and lots of
++ * other things break if we define that.
++ */
++extern int waddnwstr (WINDOW *,const wchar_t *,int);
++
+ static void cl_rdiv __P((SCR *));
+ 
+ static int 
diff -Nru nvi-1.81.6/debian/patches/series nvi-1.81.6/debian/patches/series
--- nvi-1.81.6/debian/patches/series2024-02-14 02:52:27.0 +1300
+++ nvi-1.81.6/debian/patches/series2024-04-11 14:44:02.0 +1200
@@ -36,3 +36,4 @@
 upstream/0036-Fix-how-keywords-are-picked-up.patch
 upstream/0037-New-macro-MEMPCPY.patch
 upstream/0038-Fix-A-word-search-for-keywords-starting-with-a-non-w.patch
+add-prototypes.patch


Bug#1066694: netdiag: FTBFS: getservent.c:121:38: error: implicit declaration of function ‘atoi’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Zixing Liu
Package: netdiag
Followup-For: Bug #1066694
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/gcc13.patch: Add multiple missing headers and
function prototypes.  Closes LP: #2060901.


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), 
(100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-26-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -u netdiag-1.2/debian/patches/series netdiag-1.2/debian/patches/series
--- netdiag-1.2/debian/patches/series
+++ netdiag-1.2/debian/patches/series
@@ -9,3 +9,4 @@
 gcc-10.diff
 pcap_init.diff
 gcc12.patch
+gcc13.patch
only in patch2:
unchanged:
--- netdiag-1.2.orig/debian/patches/gcc13.patch
+++ netdiag-1.2/debian/patches/gcc13.patch
@@ -0,0 +1,106 @@
+Description: Add multiple missing headers and function prototypes
+Author: Zixing Liu 
+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066694
+Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/netdiag/+bug/2060901
+Forwarded: no
+Last-Update: 2024-04-10
+Index: netdiag/netwatch-1.3.1-2/netwatch.h
+===
+--- netdiag.orig/netwatch-1.3.1-2/netwatch.h
 netdiag/netwatch-1.3.1-2/netwatch.h
+@@ -38,6 +38,10 @@
+ #define SN_PROT_LOOP  164 /* Pseudo protocol for Loopback */
+ 
+ #include 
++#include 
++#include 
++#include 
++#include 
+ #include "config.h"
+ /*
+ #ifdef NETINET_SUPP_socket
+@@ -84,6 +88,11 @@ typedef unsigned short  sa_family_t;
+ 
+ 
+ #include "core.h"
++int dokeyin(int force);
++int doeth();
++int gh (int opt);
++void setuphelp();
++void uthread_wait(long usec);
+ void dispdata(int errnum);
+ void services();
+ void usage(char *arg);
+Index: netdiag/statnet-3.8/statnet.c
+===
+--- netdiag.orig/statnet-3.8/statnet.c
 netdiag/statnet-3.8/statnet.c
+@@ -7,7 +7,6 @@
+ #define MAIN_LINE 1
+ 
+ #include 
+-#include "stat.h"
+ 
+ #include "curs.h"
+ #include 
+@@ -33,6 +32,8 @@
+ #endif
+ 
+ #include 
++#include 
++#include "stat.h"
+ 
+ #define Stringify(X)  #X
+ #define Quoteify(X)   Stringify(X)
+Index: netdiag/statnet-3.8/getservent.c
+===
+--- netdiag.orig/statnet-3.8/getservent.c
 netdiag/statnet-3.8/getservent.c
+@@ -43,7 +43,7 @@ static char sccsid[] = "@(#)getservent.c
+ #endif /* LIBC_SCCS and not lint */
+ 
+ #include "inetprivate.h"
+-
++#include 
+ #define   MAXALIASES  35
+ 
+ static char SERVDB[] = _PATH_SERVICES;
+Index: netdiag/statnet-3.8/itstime.c
+===
+--- netdiag.orig/statnet-3.8/itstime.c
 netdiag/statnet-3.8/itstime.c
+@@ -8,7 +8,7 @@
+ #include "stat.h"
+ #include 
+ #include 
+-
++#include 
+ extern struct StatMemStruct *StatMem; /* pointer to shared memory segment */
+ 
+ void itstime (int errnum)
+Index: netdiag/statnet-3.8/stat.h
+===
+--- netdiag.orig/statnet-3.8/stat.h
 netdiag/statnet-3.8/stat.h
+@@ -197,7 +197,7 @@ void set_null ( struct StatMemStruct *St
+ void services ();
+ void stat_delta ( struct StatMemStruct *New, struct StatMemStruct *Prev, 
struct StatMemStruct *Delta );
+ void usage (char *arg);
+-#ifdef WINDOW
++#if CURSES_H
+ void win_show_stat( WINDOW *win, int X, int Y, int noframes, struct Tally 
*Now_ts, struct Tally *Prev_ts, struct Tally *Delta_ts, short rewrite_labels, 
short *update_labels, void *show_labels );
+ #endif
+ 
+@@ -226,10 +226,10 @@ void tally_ntoh ( int bytecode,
+ struct Tally *New_t, 
+ struct Tally *Prev_t );
+ 
+-#ifdef WINDOW
++#if CURSES_H
+ void tally_label ( struct Tally *Now_ts, WINDOW *win, int width, int height );
+ #endif
+-
++int tally (int type_wanted, struct Tally *tally);
+ 
+ /* Now some redefinitions of  stuff.  With the Berkeley notice... */
+ 


Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Fay Stegerman
* Fay Stegerman  [2024-04-11 04:28]:
> * Holger Levsen  [2024-04-11 02:14]:
> > > unzip does seem to extract all the files, though it errors out.  Not sure 
> > > what
> > > diffoscope should do here.  This is definitely a broken ZIP file.  That 
> > > bug
> > > should probably be reported against libscout or whatever tooling it used 
> > > to
> > > create that JAR.
> > 
> > I agree it's more complicated, but fundamentally, diffoscope should *not* 
> > crash
> > here! (but rather report the broken zip file.)
> 
> I think we all agree it shouldn't crash :)
> 
> What I meant is that I'm not sure it should simply catch the error, report the
> file as broken, and not attempt extraction, or if it makes sense to attempt to
> work around this issue, at least in cases like this specific one where the
> entries are exact duplicates and the files can presumably be safely extracted.
> I think my workaround (which could be implemented slightly differently as 
> well,
> without modifying the ZipFile, but processing it differently in diffoscope)
> would accomplish that for this JAR at least.  I could make an MR for that.
> Though as I said I will also report this upstream to cpython, probably 
> tomorrow.
> 
> - Fay

The attached patch avoids the crash in this case, FWIW.  I would still recommend
catching the error for other cases.

- Fay
diff --git a/diffoscope/comparators/zip.py b/diffoscope/comparators/zip.py
index 2a27042a..4bfb1527 100644
--- a/diffoscope/comparators/zip.py
+++ b/diffoscope/comparators/zip.py
@@ -182,7 +182,12 @@ class ZipDirectory(Directory, ArchiveMember):
 
 class ZipContainer(Archive):
 def open_archive(self):
-return zipfile.ZipFile(self.source.path, "r")
+zf = zipfile.ZipFile(self.source.path, "r")
+self.name_to_info = {}
+for info in zf.infolist():
+if info.filename not in self.name_to_info:
+self.name_to_info[info.filename] = info
+return zf
 
 def close_archive(self):
 self.archive.close()
@@ -199,7 +204,8 @@ class ZipContainer(Archive):
 ).encode(sys.getfilesystemencoding(), errors="replace")
 
 try:
-with self.archive.open(member_name) as source, open(
+info = self.name_to_info[member_name]
+with self.archive.open(info) as source, open(
 targetpath, "wb"
 ) as target:
 shutil.copyfileobj(source, target)


Bug#1068790: please remove yforth

2024-04-10 Thread Bdale Garbee
Package: yforth

I am the one who originally packaged yforth for Debian in 1997, and am
still the sole maintainer of the package.  I haven't personally used
yforth in a number of years, and the last package update was in 2012.

As per bug #1068474, the yforth source code is crufty in ways that make
it unlikely to ever work on anything but a 32 bit machine.  Upstream has
disappeared, and nobody particularly wants to work on modernizing this
code.  

Given the existence of better-maintained Forth interpreters gforth and
pforth in Debian, I see no reason to retain yforth.  Please remove
yforth from the archive. 

Bdale


signature.asc
Description: PGP signature


Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Fay Stegerman
* Holger Levsen  [2024-04-11 02:14]:
> > unzip does seem to extract all the files, though it errors out.  Not sure 
> > what
> > diffoscope should do here.  This is definitely a broken ZIP file.  That bug
> > should probably be reported against libscout or whatever tooling it used to
> > create that JAR.
> 
> I agree it's more complicated, but fundamentally, diffoscope should *not* 
> crash
> here! (but rather report the broken zip file.)

I think we all agree it shouldn't crash :)

What I meant is that I'm not sure it should simply catch the error, report the
file as broken, and not attempt extraction, or if it makes sense to attempt to
work around this issue, at least in cases like this specific one where the
entries are exact duplicates and the files can presumably be safely extracted.
I think my workaround (which could be implemented slightly differently as well,
without modifying the ZipFile, but processing it differently in diffoscope)
would accomplish that for this JAR at least.  I could make an MR for that.
Though as I said I will also report this upstream to cpython, probably tomorrow.

- Fay



Bug#1068789: nsis: build fails if version number has buildX or ubuntuX suffix

2024-04-10 Thread Michael Hudson-Doyle
Package: nsis
Version: build fails if version number has buildX or ubuntuX suffix
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hud...@ubuntu.com

Dear Maintainer,

In Ubuntu we don't do binNMUs, we build sourceful changes with buildX
appended to the version number. This breaks with the current code in
d/rules which passes the whole version number to scons.

The attached patch is not very clean but it does fix the build for me:

  * d/rules: strip off ubuntuX, buildX from package version before feeding it
to scons as VERSION.

Thanks for considering it!

Cheers,
mwh

-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru nsis-3.09/debian/control nsis-3.09/debian/control
--- nsis-3.09/debian/control2024-04-01 20:02:28.0 +1300
+++ nsis-3.09/debian/control2024-04-11 14:22:37.0 +1200
@@ -1,6 +1,5 @@
 Source: nsis
-Maintainer: Ubuntu Developers 
-XSBC-Original-Maintainer: Thomas Gaugler 
+Maintainer: Thomas Gaugler 
 Section: devel
 Priority: optional
 Build-Depends: docbook-xsl-ns,
diff -Nru nsis-3.09/debian/rules nsis-3.09/debian/rules
--- nsis-3.09/debian/rules  2024-03-02 21:11:24.0 +1300
+++ nsis-3.09/debian/rules  2024-04-11 14:22:12.0 +1200
@@ -11,7 +11,8 @@
 # Enable hardening
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
-VERSION=$(DEB_VERSION)
+VERSION=$(shell echo $(DEB_VERSION) | sed -Ee s/\(build\|ubuntu\)[0-9]+//)
+
 PREFIX=/usr
 DATADIR=$(PREFIX)/share/nsis
 DOCDIR=$(PREFIX)/share/doc/nsis


Bug#1067911: Diff for fix of FTBFS bug

2024-04-10 Thread Chris Knadle
Attached is the NMUdiff for fixing FTBFS Bug #1067911 which would keep 
zeroc-ice from migrating to Testing.


   -- Chris

--
Chris Knadle
chris.kna...@coredump.us
diff -Nru zeroc-ice-3.7.10/debian/changelog zeroc-ice-3.7.10/debian/changelog
--- zeroc-ice-3.7.10/debian/changelog	2024-02-29 19:14:45.0 -0500
+++ zeroc-ice-3.7.10/debian/changelog	2024-04-10 10:48:17.0 -0400
@@ -1,3 +1,13 @@
+zeroc-ice (3.7.10-2.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * debian/patches:
+- Add remove-Werror-build-option.patch to fix FTBFS bug due to injection
+  of "inplicit-function-declaration" flag during time_t 64bit transition
+  (Closes: #1067911)
+
+ -- Christopher Knadle   Wed, 10 Apr 2024 10:48:17 -0400
+
 zeroc-ice (3.7.10-2.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru zeroc-ice-3.7.10/debian/patches/remove-Werror-build-option.patch zeroc-ice-3.7.10/debian/patches/remove-Werror-build-option.patch
--- zeroc-ice-3.7.10/debian/patches/remove-Werror-build-option.patch	1969-12-31 19:00:00.0 -0500
+++ zeroc-ice-3.7.10/debian/patches/remove-Werror-build-option.patch	2024-04-10 10:32:22.0 -0400
@@ -0,0 +1,18 @@
+Description: remove -Werror build option to fix FSBFS issue
+ During the time_t 64bit transition the "implicit-function-declaration" build
+ flag is injected and this breaks the build when -Werror is set
+Author: Christopher Knadle 
+Bug: https://bugs.debian.org/1067911
+Last-Update: 2024-04-10
+
+--- a/config/Make.rules.Linux
 b/config/Make.rules.Linux
+@@ -137,7 +137,7 @@
+ -pie $(if $(filter yes,$(new_dtags)),-Wl$(comma)--enable-new-dtags,-Wl$(comma)--disable-new-dtags) \
+ $$(call unique,$$(foreach d,$($4_dependencies),$$(call make-rpath-link-ldflags,$$d,$($4_dependencies)
+ 
+-cppflags= -Wall -Wextra -Wredundant-decls -Wshadow -Wdeprecated -Werror -pthread $(if $(filter yes,$(OPTIMIZE)),-DNDEBUG,-g)
++cppflags= -Wall -Wextra -Wredundant-decls -Wshadow -Wdeprecated -pthread $(if $(filter yes,$(OPTIMIZE)),-DNDEBUG,-g)
+ ldflags = -pthread
+ 
+ # -Wshadow is too strict with gcc 4
diff -Nru zeroc-ice-3.7.10/debian/patches/series zeroc-ice-3.7.10/debian/patches/series
--- zeroc-ice-3.7.10/debian/patches/series	2023-11-07 04:45:43.0 -0500
+++ zeroc-ice-3.7.10/debian/patches/series	2024-04-10 10:27:07.0 -0400
@@ -1 +1,2 @@
 java-build.patch
+remove-Werror-build-option.patch


Bug#1068787: dmeventd: inconsistent /etc/systemd/system/sockets.target.wants/dm-event.socket symlinks

2024-04-10 Thread Vincent Lefevre
Package: dmeventd
Version: 2:1.02.196-1+b1
Severity: normal

On this machine, I have

lrwxrwxrwx 1 root root 35 2023-10-07 13:43:24 
/etc/systemd/system/sockets.target.wants/dm-event.socket -> 
/lib/systemd/system/dm-event.socket

while on another machine (installed more recently):

lrwxrwxrwx 1 root root 39 2024-01-05 16:54:09 
/etc/systemd/system/sockets.target.wants/dm-event.socket -> 
/usr/lib/systemd/system/dm-event.socket

I suppose that the second one is the correct canonical path.

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 
'stable-security'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), 
(500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.15-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dmeventd depends on:
ii  libc6 2.37-15.1
ii  libdevmapper-event1.02.1  2:1.02.196-1+b1
ii  libdevmapper1.02.12:1.02.196-1+b1
ii  liblvm2cmd2.032.03.22-1+b1

dmeventd recommends no packages.

dmeventd suggests no packages.

-- no debconf information

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)



Bug#1065024: rclone: storj backend missing

2024-04-10 Thread Celejar
On Sat, 30 Mar 2024 13:58:31 +0800 Maytham  wrote:
> Hi,
> 
> > Debian's rclone package is missing the storj backend. I assume that is
> > due to this patch:
> > 
> >
> https://sources.debian.org/src/rclone/1.60.1+dfsg-3/debian/patches/ignore_tardigrade_backend.patch/
> > 
> > What is the reason for this? Does it have to do with unpackaged
> > dependencies? 
> 
> This is because the storj.io/uplink dependency is not available in Debian, as 
> well as its
> dependencies:

...

> > Is this documented somewhere? 
> 
> Usually the patch should be enough. (IMO this should warrant a NEWS entry.)
> 
> > I assume that this is related to this bug:
> > 
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=983445
> 
> Several backends have been disabled in rclone due to their dependencies not 
> being available in
> Debian.
> 
> FYI, unless someone backports rclone (or somehow gets it into a Bookworm 
> point release), then you'll
> have to wait until the next release of Debian for any backends to be 
> reenabled.

This is pretty much what I assumed. I do think that this needs to be
properly documented in a file included in the package itself.

> Kind regards,
> Maytham
> 
> 
> 



-- 
Celejar



Bug#1068786: ITS: latencytop

2024-04-10 Thread Boyuan Yang
Source: latencytop
Version: 0.5.0-0.1
Severity: important
X-Debbugs-CC: c...@debian.org

Dear package latencytop maintainer in Debian,

After looking into the package you maintain (latencytop, 
https://tracker.debian.org/pkg/latencytop), I found that this package
received no maintainer updates in the past 14 years and is not in good
shape. As a result, I am filing an ITS (Intent to Salvage) request
against your package according to section 5.12 in Debian's Developers'
Reference [1].

My current plan is to refresh packaging and fix all RC bugs.

Please let me know whether you are still willing to maintain this
package. According to the criteria listed at [2], I will upload a Non-
maintainer Upload (NMU) of this package onto DELAYED/7 after 21 days
(May 01, 2024) to continue with the package salvaging. If you find it
necessary to pause the ITS process, please let me know immediately by
replying this bug report.


[1] 
https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging
[2] https://wiki.debian.org/PackageSalvaging

-- 
Best Regards,
Boyuan Yang


signature.asc
Description: This is a digitally signed message part


Bug#1066654: mlpcap: FTBFS: utils.c:184:3: error: implicit declaration of function ‘camlidl_ml2c_pcap_pcap_handle’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Steve Langasek
Package: mlpcap
Followup-For: Bug #1066654
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue that has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru mlpcap-0.9/debian/patches/no-implicit-declarations.patch 
mlpcap-0.9/debian/patches/no-implicit-declarations.patch
--- mlpcap-0.9/debian/patches/no-implicit-declarations.patch1969-12-31 
16:00:00.0 -0800
+++ mlpcap-0.9/debian/patches/no-implicit-declarations.patch2024-04-10 
16:59:47.0 -0700
@@ -0,0 +1,22 @@
+Description: add missing prototype
+ This function is code generated by camlidl from the .idl input file;
+ unfortunately it does not emit a header including the prototype.
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066654
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: mlpcap-0.9/utils.c
+===
+--- mlpcap-0.9.orig/utils.c
 mlpcap-0.9/utils.c
+@@ -33,6 +33,9 @@
+ #include 
+ #include "utils.h"
+ 
++extern void camlidl_ml2c_pcap_pcap_handle(value _v1, pcap_handle * _c2,
++  camlidl_ctx _ctx);
++
+ void
+ _pcap_callback (void *cback, va_alist alist)
+ {
diff -Nru mlpcap-0.9/debian/patches/series mlpcap-0.9/debian/patches/series
--- mlpcap-0.9/debian/patches/series2023-09-11 22:50:01.0 -0700
+++ mlpcap-0.9/debian/patches/series2024-04-10 16:57:47.0 -0700
@@ -5,3 +5,4 @@
 03_correct_META.diff
 07_dll_with_camlidl.diff
 08_ffcall.diff
+no-implicit-declarations.patch


Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Chris Lamb
Fay Stegerman wrote:

> Salsa is probably better for figuring out what to do next, but I get
> these mails too :)

Oh, hey! o/

> unzip does seem to extract all the files, though it errors out.  Not sure what
> diffoscope should do here.  This is definitely a broken ZIP file.

First; great debugging there, thank you. :)

Okay, separate from your suggestion that a bug should be filed against
libscout with its broken zip file, I think that diffoscope should not
traceback and crash on this particular input. We do this elsewhere with
(most) invalid inputs and it makes a lot of sense here as well.

I'll modify diffoscope tomorrow morning to catch the specific
exception being thrown by Python's builtin zipfile module and add a
suitable message as a user-visible 'comment' — again, something we have
plenty of prior art for elsewhere in the codebase. Thanks again.


Best wishes,

-- 
  o
⬋   ⬊  Chris Lamb
   o o reproducible-builds.org 
⬊   ⬋
  o



Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Holger Levsen
On Thu, Apr 11, 2024 at 01:48:18AM +0200, Fay Stegerman wrote:
> Salsa is probably better for figuring out what to do next, but I get these 
> mails
> too :)

:)
 
> The libscout.jar has duplicate ZIP entries in the central directory, pointing 
> to
> the same actual entry in the ZIP.  So the "overlapped entries" error is 
> entirely
> correct, even if it's not a zip bomb.

ah!

> unzip does seem to extract all the files, though it errors out.  Not sure what
> diffoscope should do here.  This is definitely a broken ZIP file.  That bug
> should probably be reported against libscout or whatever tooling it used to
> create that JAR.

I agree it's more complicated, but fundamentally, diffoscope should *not* crash
here! (but rather report the broken zip file.)

thanks!


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

I’ve said it once, and I’ll say it a thousand times: If the penalty for
breaking a law is a fine, then that law only exists for the poor.


signature.asc
Description: PGP signature


Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Fay Stegerman
* Fay Stegerman  [2024-04-11 01:48]:
> * Holger Levsen  [2024-04-10 19:43]:
> > On Wed, Apr 10, 2024 at 06:12:21PM +0100, Chris Lamb wrote:
> > > Holger Levsen wrote:
> > > 
> > > > when building libscout 2.3.2-3 on current unstable, the result is also 
> > > > unreproducible, but diffoscope crashes when analysing the diff.
> > > I think this is somewhat related to:
> > >   https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/362
> > > … which was said to be fixed by Fay in 
> > > cc3b077f6ef97b4e20036e9823926fe633c7d4d0
> > > that released as diffoscope version 263 on 2024-04-05.
> > > However, I can see that the current output of libscout/amd64 on
> > > tests.reproducible-builds.org is failing with this very version:
> > 
> > yes, indeed.
> > 
> > also, this happened before too, I'm sure about at least with diffoscope 260 
> > already.
> >  
> > > Will loop Fay in via Salsa presently.
> > 
> > thank you!
> 
> Salsa is probably better for figuring out what to do next, but I get these 
> mails
> too :)
> 
> The libscout.jar has duplicate ZIP entries in the central directory, pointing 
> to
> the same actual entry in the ZIP.  So the "overlapped entries" error is 
> entirely
> correct, even if it's not a zip bomb.
> 
>   >>> import zipfile
>   >>> zf = zipfile.ZipFile("libscout.jar")
>   >>> fh = zf.open("javax/annotation/CheckForNull.class")
>   zipfile.BadZipFile: Overlapped entries: 
> 'javax/annotation/CheckForNull.class' (possible zip bomb)
[...]

I do have a workaround of sorts for this specific case of duplicate entries.
I'll open a cpython issue to report it to upstream.  Though they may not
consider this a bug, possibly even the correct behaviour.  Not sure myself tbh 
:)

  >>> for info in reversed(zf.infolist()):
  ...   zf.NameToInfo[info.filename] = info
  >>> fh = zf.open("javax/annotation/CheckForNull.class") # works now

- Fay



Bug#1068785: Sometimes the keyboard is turned off when waking from standby after upgrading to Debian12

2024-04-10 Thread mYnDstrEAm
Package: sddm
Version: 0.19.0-5

This could also be an issue of the Sleep function. I'm using a laptop that 
suspends to swap partition. After upgrading to Debian12 with KDE, sometimes the 
keyboard of a laptop is turned off while the touchpad still works.

It doesn't work again after putting it back into standby and then waking it 
from standby. It really is in standby as one could hear if it wasn't.

After waking from Hibernate or when just locking the screen the keyboard does 
work.

Moreover, often if not always under some conditions (which I'll try to find out 
and then add) the laptop shows the prior screen for 0.2-4.0 seconds before it 
shows the lockscreen. This obviously is a privacy issue and could be linked to 
the prior problem. It hasn't occurred the last two days.

When I just Log Out the keyboard works fine at the lockscreen. It only doesn't 
work when resuming from sleep (opening the lid after it was closed or pressing 
the power button after clicking Sleep).

Once I started testing and asking about this the problem the keyboard didn't 
just stop working sometimes but never worked after resuming from Sleep for at 
least 10 different kinds tries. Now first clicking Sleep in the bottom left 
caused a shutdown (instead of sleep) again (I think it did some disk check when 
waking), and afterwards the keyboard now works again when resuming from sleep 
in two tries but I think it's only back to sometimes rather than always being 
dysfunctional.


Please go here for further details: 
https://unix.stackexchange.com/questions/773987/sometimes-the-keyboard-is-turned-off-when-waking-from-standby-after-upgrading-to

Also it may be useful to test or develop tests whether it's fully and without 
problems going to Sleep, see: https://unix.stackexchange.com/q/774151/233262



Bug#1068784: When configuring Wayland to be the default at the login screen this doesn't change the session the user is automatically logged into

2024-04-10 Thread mYnDstrEAm
Package: sddm
Version: 0.19.0-5

When configuring Wayland to be the default at the login screen (dropdown in the 
upper left) as recommended at places where people asked about how to switch 
from X11 to Wayland, this doesn't change the session the user is automatically 
logged into.

I think it should be changed or the user be asked if they'd like to change the 
default after auto-login if they changed it at the lockscreen.

Here I got this reply https://github.com/sddm/sddm/issues/1912 :

>If you set
>
>[Autologin]
>Session=
>
>it'll use the last used session for autologin. kcm_sddm does not support that, 
>so you'll have to put that into /etc/sddm.conf.d/y_autologin.conf to override 
>the value from kde_settings.conf.



Bug#1068783: After upgrading to Debian12 the session SDDM automatically logs in to is changed

2024-04-10 Thread mYnDstrEAm
Package: sddm
Version: 0.19.0-5

On one of the machines upgraded from Debian11 to Debian12 I had configured that 
it automatically logs in. But it seems like in the dropdown next to "with 
session" after the upgrade this was changed to "Kodi" instead of "Plasma (X11)" 
(there was no noticeable difference to the standard X11 session and Kodi didn't 
autostart). It's probably because "Kodi" is the first value in the dropdown 
which seems to be sorted alphabetically.

Please either make it so that the value before the upgrade is set there or that 
it's Wayland in specific.



Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Fay Stegerman
* Holger Levsen  [2024-04-10 19:43]:
> On Wed, Apr 10, 2024 at 06:12:21PM +0100, Chris Lamb wrote:
> > Holger Levsen wrote:
> > 
> > > when building libscout 2.3.2-3 on current unstable, the result is also 
> > > unreproducible, but diffoscope crashes when analysing the diff.
> > I think this is somewhat related to:
> >   https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/362
> > … which was said to be fixed by Fay in 
> > cc3b077f6ef97b4e20036e9823926fe633c7d4d0
> > that released as diffoscope version 263 on 2024-04-05.
> > However, I can see that the current output of libscout/amd64 on
> > tests.reproducible-builds.org is failing with this very version:
> 
> yes, indeed.
> 
> also, this happened before too, I'm sure about at least with diffoscope 260 
> already.
>  
> > Will loop Fay in via Salsa presently.
> 
> thank you!

Salsa is probably better for figuring out what to do next, but I get these mails
too :)

The libscout.jar has duplicate ZIP entries in the central directory, pointing to
the same actual entry in the ZIP.  So the "overlapped entries" error is entirely
correct, even if it's not a zip bomb.

  >>> import zipfile
  >>> zf = zipfile.ZipFile("libscout.jar")
  >>> fh = zf.open("javax/annotation/CheckForNull.class")
  zipfile.BadZipFile: Overlapped entries: 'javax/annotation/CheckForNull.class' 
(possible zip bomb)
  >>> len([i for i in zf.infolist() if i.filename == 
"javax/annotation/CheckForNull.class"])
  2
  >>> len(zf.namelist()) - len(set(zf.namelist()))
  35
  >>> x, y = [i for i in zf.infolist() if i.filename == 
"javax/annotation/CheckForNull.class"]
  >>> x.header_offset
  23065534
  >>> y.header_offset
  23065534
  >>> x._end_offset
  23065890
  >>> y._end_offset
  23065534
  >>> zf.open(x)
  
  >>> zf.open(y)
  Traceback (most recent call last):
  zipfile.BadZipFile: Overlapped entries: 'javax/annotation/CheckForNull.class' 
(possible zip bomb)

$ unzip -q -d foo libscout.jar
error: invalid zip file with overlapped components (possible zip bomb)

unzip does seem to extract all the files, though it errors out.  Not sure what
diffoscope should do here.  This is definitely a broken ZIP file.  That bug
should probably be reported against libscout or whatever tooling it used to
create that JAR.

FWIW, it seems the libscout.jar files in both .deb files are identical apart
from timestamps and the ordering of entries in the ZIP.

- Fay



Bug#1068782: libesmtp: fixes for t64 and new glibc

2024-04-10 Thread Michael Hudson-Doyle
Package: libesmtp
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hud...@ubuntu.com

Dear Maintainer,

Apologies for submitting this as only one report. libesmtp was failing
on Ubuntu on armhf only because although strlcpy is now in glibc, the
declaration is only found if _DEFAULT_SOURCE or _BSD_SOURCE is defined.

While looking at this I saw some scary warnings about the date handling
in headers.c which I fixed the easy bits of.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/patches/time64: cast time_t values to long long before passing to
*printf functions (code storing time_t values in void* variables will
still break in 2038).
  * d/patches/default-source: define _DEFAULT_SOURCE to get access to
prototype of strlcpy.


Thanks for considering the patch.

Cheers,
mwh


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru libesmtp-1.1.0/debian/patches/default-source 
libesmtp-1.1.0/debian/patches/default-source
--- libesmtp-1.1.0/debian/patches/default-source1970-01-01 
12:00:00.0 +1200
+++ libesmtp-1.1.0/debian/patches/default-source2024-04-11 
11:37:59.0 +1200
@@ -0,0 +1,10 @@
+--- a/meson.build
 b/meson.build
+@@ -30,6 +30,7 @@
+ 

+ cflags = [
+   '-D_POSIX_C_SOURCE=200809L',
++  '-D_DEFAULT_SOURCE',
+ ]
+ 
+ cflags_warnings = [
diff -Nru libesmtp-1.1.0/debian/patches/series 
libesmtp-1.1.0/debian/patches/series
--- libesmtp-1.1.0/debian/patches/series2023-08-19 22:04:32.0 
+1200
+++ libesmtp-1.1.0/debian/patches/series2024-04-11 11:37:24.0 
+1200
@@ -1 +1,3 @@
 meson-build-soname
+time64
+default-source
diff -Nru libesmtp-1.1.0/debian/patches/time64 
libesmtp-1.1.0/debian/patches/time64
--- libesmtp-1.1.0/debian/patches/time641970-01-01 12:00:00.0 
+1200
+++ libesmtp-1.1.0/debian/patches/time642024-04-11 11:37:18.0 
+1200
@@ -0,0 +1,16 @@
+--- a/headers.c
 b/headers.c
+@@ -170,11 +170,11 @@
+ {
+ #ifdef HAVE_GETTIMEOFDAY
+   if (gettimeofday (, NULL) != -1) /* This shouldn't fail ... */
+-  snprintf (buf, sizeof buf, "%ld.%ld.%d@%s", tv.tv_sec, tv.tv_usec,
++snprintf (buf, sizeof buf, "%lld.%lld.%d@%s", (long 
long)tv.tv_sec, (long long)tv.tv_usec,
+ getpid (), message->session->localhost);
+   else /* ... but if it does fall back to using time() */
+ #endif
+-  snprintf (buf, sizeof buf, "%ld.%d@%s", time (NULL),
++  snprintf (buf, sizeof buf, "%lld.%d@%s", (long long)time (NULL),
+   getpid (), message->session->localhost);
+   message_id = buf;
+ }


Bug#1068781: newsboat: Some feeds fail to load with libcurl 8.7

2024-04-10 Thread Pilot
Package: newsboat
Version: 2.32-3
Severity: important
X-Debbugs-Cc: r...@rob.com

Dear Maintainer,

Upgrading to either of the 8.7 versions of the libcurl3t64-gnutls package stops 
some
feeds from loading with the error "Failed writing received data to 
disk/application".

Downgrading to libcurl3t64-gnutls_8.6.0-4_amd64.deb fixes the problem.

Upstream bugs: https://github.com/newsboat/newsboat/issues/2728, 
https://github.com/curl/curl/pull/13219

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.7.9-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages newsboat depends on:
ii  libc6 2.37-16
ii  libcurl3t64-gnutls [libcurl3-gnutls]  8.6.0-4
ii  libgcc-s1 14-20240330-1
ii  libjson-c50.17-1+b1
ii  libncursesw6  6.4+20240113-1
ii  libsqlite3-0  3.45.2-1
ii  libstdc++614-20240330-1
ii  libstfl0  0.22-3+b8
ii  libtinfo6 6.4+20240113-1
ii  libxml2   2.9.14+dfsg-1.3+b2

Versions of packages newsboat recommends:
ii  sensible-utils  0.0.22

newsboat suggests no packages.

-- debconf-show failed



Bug#993047: (No Subject)

2024-04-10 Thread mYnDstrEAm
This problem still exists in Debian12!

Shouldn't the user be hidden there because the UID is larger than the Maximum 
user UID set for the login screen in SDDM?



Bug#1002458: "version in VCS newer than in repository" might be a bit overzealous

2024-04-10 Thread Holger Levsen
On Fri, Dec 24, 2021 at 01:36:35PM +0100, Marc Haber wrote:
> On Fri, Dec 24, 2021 at 01:15:08PM +0100, Christoph Berg wrote:
> > Re: Marc Haber
> > > To fill my idea, vcswatch would need to classify commits into "real"
> > > commits and "housekeeping" commits, so that the tracker can handle them
> > > differently.
> > The idea makes sense, but I doubt that is possible without entering a
> > very deep rathole :(
> For starters, an early release could classify changelog-only commits as
> "housekeeping".

*that*!

additionally you could also only classify d/changelog changing commits
with "Gbp-Dch: ignore" in them as such, but I'd guess Marc's suggestion
really is good enough.

Please reconsider, IOW, Myon: my I reassign this back to qa.debian.org
for vcswatch?


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Only change is constant.


signature.asc
Description: PGP signature


Bug#1068780: Two login screens with the same name and with no preview/image

2024-04-10 Thread mYnDstrEAm
Package: sddm
Version: 0.19.0-5

In Debian12 with KDE5 (SDDM v0.19.0-5) after an Upgrade from Debian11 under 
System Settings -> Startup and Shutdown -> Login Screen (SDDM) there are two 
Login screens with the same name and no preview. Screenshot in the link below 
(this issue tracking system is outdated by decades). When hovering on the 
second login screen the trashbin button is also greyed out.

Screenshot and some info that could be relevant: 
https://github.com/sddm/sddm/issues/1912

If I start systemsettings from the console when opening up this page to view 
the login screens this is the new output:

QQmlEngine::setContextForObject(): Object already has a QQmlContext
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/templates/InlineMessage.qml:257:13:
 QML SelectableLabel: Binding loop detected for property "implicitWidth"
file:///usr/share/kpackage/kcms/kcm_sddm/contents/ui/main.qml:54:20: QML Image: 
Cannot open: file:///usr/share/sddm/themes/debian-maui/maui.jpg
file:///usr/share/kpackage/kcms/kcm_sddm/contents/ui/main.qml:54:20: QML Image: 
Cannot open: file:///usr/share/sddm/themes/debian-maui/maui.jpg
file:///usr/share/kpackage/kcms/kcm_sddm/contents/ui/main.qml:54:20: QML Image: 
Cannot open: file:///usr/share/sddm/themes/debian-maui/maui.jpg
file:///usr/share/kpackage/kcms/kcm_sddm/contents/ui/main.qml:54:20: QML Image: 
Cannot open: file:///usr/share/sddm/themes/debian-theme/maui.jpg
file:///usr/share/kpackage/kcms/kcm_sddm/contents/ui/main.qml:54:20: QML Image: 
Cannot open: file:///usr/share/sddm/themes/debian-maui/maui.jpg
file:///usr/share/kpackage/kcms/kcm_sddm/contents/ui/main.qml:54:20: QML Image: 
Cannot open: file:///usr/share/sddm/themes/debian-theme/maui.jpg
qml: The item SubCategoryPage_QMLTYPE_74(0x55b0a5ab7d50) is already in the 
PageRow

Maybe this is because two display monitors are configured? I previously had a 
problem of a second smaller login screen above a larger one (mirrored content 
where I could login in either) before I disabled the other powered-off display 
monitor under "Display Configuration". Bug report in need of more info if 
anybody can provide it here: https://bugs.kde.org/show_bug.cgi?id=485199

I would expect that there only is one login screen and that it has a preview 
image.



Bug#1067141: kcemu: FTBFS with -Werror=implicit-function-declaration

2024-04-10 Thread Zixing Liu
Package: kcemu
Followup-For: Bug #1067141
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/add-missing-includes.patch: Add missing includes.
Closes LP: #2060887.


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), 
(100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-26-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru kcemu-0.5.2+dfsg/debian/control kcemu-0.5.2+dfsg/debian/control
--- kcemu-0.5.2+dfsg/debian/control 2024-03-07 22:13:42.0 -0700
+++ kcemu-0.5.2+dfsg/debian/control 2024-04-10 17:17:16.0 -0600
@@ -1,8 +1,7 @@
 Source: kcemu
 Section: contrib/otherosfs
 Priority: optional
-Maintainer: Ubuntu Developers 
-XSBC-Original-Maintainer: John Paul Adrian Glaubitz 

+Maintainer: John Paul Adrian Glaubitz 
 Build-Depends: debhelper-compat (= 13), libz80ex-dev, libsdl1.2-dev, 
libsndfile-dev, libvncserver-dev, libtheora-dev,
libgtk2.0-dev, automake, autoconf, libxmu-dev, libncurses5-dev, 
netpbm, imagemagick, dh-autoreconf
 Standards-Version: 4.6.1
diff -Nru kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch 
kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch
--- kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch  1969-12-31 
17:00:00.0 -0700
+++ kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch  2024-04-10 
17:17:01.0 -0600
@@ -0,0 +1,18 @@
+Description: Add missing includes
+Author: Zixing Liu 
+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067141
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/kcemu/+bug/2060887
+Forwarded: no
+Last-Update: 2024-04-10
+Index: kcemu/src/sys/unix/sys_socket_create.c
+===
+--- kcemu.orig/src/sys/unix/sys_socket_create.c
 kcemu/src/sys/unix/sys_socket_create.c
+@@ -23,6 +23,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ 
+ #include "kc/config.h"
+ #include "sys/sysdep.h"
diff -Nru kcemu-0.5.2+dfsg/debian/patches/series 
kcemu-0.5.2+dfsg/debian/patches/series
--- kcemu-0.5.2+dfsg/debian/patches/series  1969-12-31 17:00:00.0 
-0700
+++ kcemu-0.5.2+dfsg/debian/patches/series  2024-04-10 17:06:09.0 
-0600
@@ -0,0 +1 @@
+add-missing-includes.patch


Bug#1067621: FTBFS on 32-bit time64 architectures: error: implicit declaration of function ‘gzopen64’

2024-04-10 Thread Zixing Liu
Package: berkeley-abc
Followup-For: Bug #1067621
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * Fix the build failure caused by missing function prototypes.

  * debian/patches/add-missing-include.patch: Add missing headers to
Glucose components.  Closes LP: #2060873.


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), 
(100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-26-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/control 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/control
--- berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/control2024-03-31 
23:33:27.0 -0600
+++ berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/control2024-04-10 
14:45:54.0 -0600
@@ -1,8 +1,7 @@
 Source: berkeley-abc
 Section: electronics
 Priority: optional
-Maintainer: Ubuntu Developers 
-XSBC-Original-Maintainer: Debian Science Maintainers 

+Maintainer: Debian Science Maintainers 

 Uploaders: Ruben Undheim ,
Daniel Gröber 
 Build-Depends: debhelper-compat (= 13),
diff -Nru 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/add-missing-include.patch
 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/add-missing-include.patch
--- 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/add-missing-include.patch
  1969-12-31 17:00:00.0 -0700
+++ 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/add-missing-include.patch
  2024-04-10 14:45:54.0 -0600
@@ -0,0 +1,30 @@
+Description: Add missing headers to Glucose components
+Author: Zixing Liu 
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/berkeley-abc/+bug/2060873
+Forwarded: no
+Last-Update: 2024-04-10
+Index: berkeley-abc/src/sat/glucose/Glucose.cpp
+===
+--- berkeley-abc.orig/src/sat/glucose/Glucose.cpp
 berkeley-abc/src/sat/glucose/Glucose.cpp
+@@ -34,6 +34,7 @@ OF OR IN CONNECTION WITH THE SOFTWARE OR
+ #include "sat/glucose/Constants.h"
+ #include "sat/glucose/System.h"
+ 
++#include "misc/util/abc_global.h"
+ ABC_NAMESPACE_IMPL_START
+ 
+ using namespace Gluco;
+Index: berkeley-abc/src/sat/glucose2/Glucose2.cpp
+===
+--- berkeley-abc.orig/src/sat/glucose2/Glucose2.cpp
 berkeley-abc/src/sat/glucose2/Glucose2.cpp
+@@ -34,7 +34,7 @@ OF OR IN CONNECTION WITH THE SOFTWARE OR
+ #include "sat/glucose2/Solver.h"
+ 
+ #include "sat/glucose2/CGlucose.h"
+-
++#include "misc/util/abc_global.h"
+ ABC_NAMESPACE_IMPL_START
+ 
+ using namespace Gluco2;
diff -Nru 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/remove_bzlib_convenience.patch
 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/remove_bzlib_convenience.patch
--- 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/remove_bzlib_convenience.patch
 2024-03-31 23:33:27.0 -0600
+++ 
berkeley-abc-1.01+20230625git01b1bd1+dfsg/debian/patches/remove_bzlib_convenience.patch
 2024-04-10 14:45:54.0 -0600
@@ -12,10 +12,10 @@
  src/base/io/ioWriteAiger.c | 2 +-
  3 files changed, 5 insertions(+), 3 deletions(-)
 
-diff --git a/Makefile b/Makefile
-index 3976cf7..bb3fbc2 100644
 a/Makefile
-+++ b/Makefile
+Index: berkeley-abc/Makefile
+===
+--- berkeley-abc.orig/Makefile
 berkeley-abc/Makefile
 @@ -22,7 +22,7 @@ MODULES := \
src/map/mapper src/map/mio src/map/super src/map/if \
src/map/amap src/map/cov src/map/scl src/map/mpm \
@@ -25,7 +25,7 @@
src/misc/mem src/misc/bar src/misc/bbl src/misc/parse \
src/opt/cut src/opt/fxu src/opt/fxch src/opt/rwr src/opt/mfs 
src/opt/sim \
src/opt/ret src/opt/fret src/opt/res src/opt/lpk src/opt/nwk 
src/opt/rwt \
-@@ -145,6 +145,8 @@ ifneq ($(findstring Darwin, $(shell uname)), Darwin)
+@@ -145,6 +145,8 @@ ifneq ($(findstring Darwin, $(shell unam
 LIBS += -lrt
  endif
  
@@ -34,10 +34,10 @@
  ifdef ABC_USE_LIBSTDCXX
 LIBS += -lstdc++
 $(info $(MSG_PREFIX)Using explicit -lstdc++)
-diff --git a/src/base/io/ioReadAiger.c b/src/base/io/ioReadAiger.c
-index 9cf4141..8be6d21 100644
 a/src/base/io/ioReadAiger.c
-+++ b/src/base/io/ioReadAiger.c
+Index: berkeley-abc/src/base/io/ioReadAiger.c
+===
+--- 

Bug#1065774: libdigidoc: FTBFS on arm{el,hf}: /<>/libdigidoc/DigiDocService.c:327:19: error: implicit declaration of function ‘ddocAddSignatureFromMemory’ [-Werror=implicit-function-decla

2024-04-10 Thread Steve Langasek
Package: libdigidoc
Followup-For: Bug #1065774
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue that has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch 
libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch
--- libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch 
1969-12-31 16:00:00.0 -0800
+++ libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch 
2024-04-10 16:10:25.0 -0700
@@ -0,0 +1,30 @@
+Description: add missing define and includes required for prototypes
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1065774
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: libdigidoc-3.10.5/libdigidoc/DigiDocVerify.c
+===
+--- libdigidoc-3.10.5.orig/libdigidoc/DigiDocVerify.c
 libdigidoc-3.10.5/libdigidoc/DigiDocVerify.c
+@@ -20,6 +20,7 @@
+ //  Creation
+ //==
+ 
++#define WITH_DEPRECATED_FUNCTIONS
+ #include "DigiDocVerify.h"
+ #include "DigiDocError.h"
+ #include "DigiDocLib.h"
+Index: libdigidoc-3.10.5/libdigidoc/DigiDocService.c
+===
+--- libdigidoc-3.10.5.orig/libdigidoc/DigiDocService.c
 libdigidoc-3.10.5/libdigidoc/DigiDocService.c
+@@ -26,6 +26,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+ #include 
diff -Nru libdigidoc-3.10.5/debian/patches/series 
libdigidoc-3.10.5/debian/patches/series
--- libdigidoc-3.10.5/debian/patches/series 2022-07-10 19:12:11.0 
-0700
+++ libdigidoc-3.10.5/debian/patches/series 2024-04-10 16:08:47.0 
-0700
@@ -1,3 +1,4 @@
 versioninfo.cmake-set-build_date-using-u.patch
 build-with-openssl-v3.patch
 fix-national-encoding.patch
+no-implicit-declarations.patch


Bug#1066512: latencytop: FTBFS: fsync.c:330:17: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Steve Langasek
Package: latencytop
Followup-For: Bug #1066512
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru latencytop-0.5.0/debian/patches/no-implicit-declarations.patch 
latencytop-0.5.0/debian/patches/no-implicit-declarations.patch
--- latencytop-0.5.0/debian/patches/no-implicit-declarations.patch  
1969-12-31 16:00:00.0 -0800
+++ latencytop-0.5.0/debian/patches/no-implicit-declarations.patch  
2024-04-10 16:02:15.0 -0700
@@ -0,0 +1,18 @@
+Description: add missing include
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066512
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: latencytop-0.5.0/fsync.c
+===
+--- latencytop-0.5.0.orig/fsync.c
 latencytop-0.5.0/fsync.c
+@@ -32,6 +32,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ 
+ #include 
+ 
diff -Nru latencytop-0.5.0/debian/patches/series 
latencytop-0.5.0/debian/patches/series
--- latencytop-0.5.0/debian/patches/series  2021-08-24 10:26:05.0 
-0700
+++ latencytop-0.5.0/debian/patches/series  2024-04-10 16:01:05.0 
-0700
@@ -1,3 +1,4 @@
 0001-Convert-to-autoconf.patch
 0002-Fix-FTBFS-in-fsync.c.patch
 0003-typo-fix.patch
+no-implicit-declarations.patch


Bug#1068779: Shortcuts for systemmonitor and plasma-systemmonitor are missing after upgrade or when installing it

2024-04-10 Thread mYnDstrEAm
Package: plasma-systemmonitor
Version: 5.27.5-2

On one of the machines I upgraded to Debian12 from Deb11/KDE the Default 
shortcut Ctrl+Esc for "Show System Activity" in "KDE Daemon" under Shortcuts is 
disabled but not on the other. This meant that the process manager didn't show 
anymore when pressing ctrl+esc after upgrading which can be quite annoyance to 
users and seems like a problem that is easy to solve: just make sure that 
shortcut doesn't get disabled. Note that Ctrl+Esc is also set as a shortcut 
under File->Close. I don't know why it was disabled. It could also be enabled 
whenever plasma-systemmonitor / systemmonitor gets installed. That this is hard 
to find under "KDE Daemon" where most users wouldn't expect this entry makes it 
an even bigger problem but the shortcuts should be working by default without 
requiring any configuration in general anyway.

In addition, the shortcut Ctrl+Shift+Esc should be set for opening 
plasma-systemmonitor; currently this has to be configured under Custom 
Shortcuts. It should be there by default or right after installing 
plasma-systemmonitor which should be installed by default. 

Related issue: plasma-systemmonitor with the process manager is not installed 
anymore after upgrading to Debian12 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068777



Bug#1066689: kdrill: FTBFS: init.c:171:12: error: implicit declaration of function ‘isMapped’; did you mean ‘IsUnmapped’? [-Werror=implicit-function-declaration]

2024-04-10 Thread Steve Langasek
Package: kdrill
Followup-For: Bug #1066689
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch 
kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch
--- kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch
1969-12-31 16:00:00.0 -0800
+++ kdrill-6.5deb2/debian/patches/no-implicit-declarations.patch
2024-04-10 15:56:58.0 -0700
@@ -0,0 +1,18 @@
+Description: add missing include
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066689
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: kdrill-6.5deb2/init.c
+===
+--- kdrill-6.5deb2.orig/init.c
 kdrill-6.5deb2/init.c
+@@ -24,6 +24,7 @@
+ #include "searchwidgets.h"
+ #include "widgets.h"
+ #include "timeout.h"
++#include "utils.h"
+ 
+ #include "icon_xbm"
+ 
diff -Nru kdrill-6.5deb2/debian/patches/series 
kdrill-6.5deb2/debian/patches/series
--- kdrill-6.5deb2/debian/patches/series2021-10-20 10:11:20.0 
-0700
+++ kdrill-6.5deb2/debian/patches/series2024-04-10 15:55:23.0 
-0700
@@ -12,3 +12,4 @@
 use-env-flags.diff
 warning-fixes.diff
 rename-getline.diff
+no-implicit-declarations.patch


Bug#1068778: geoclue and gpsd are running by default (they aren't needed and could be used for location tracking)

2024-04-10 Thread mYnDstrEAm
Package: general

I wondered why Debian comes with geoclue-2.0 and gpsd running by default (which 
could be used for location tracking). Please do not install them by default or 
if you really must, please do not make them autostart.

At most it could be useful for a few users if it was installed but not enabled 
and not running by default (so just an option one could enable in the configs 
or which could be enabled by the user through a prompt). If it's running by 
default this also means that after upgrades it could be running again. This is 
a privacy issue, an undesired bloat service that requires to spend time to 
remove it, and a larger attack surface even if there was a proper and 
vulnerability-free permissions-management for GPS-location-access.



Bug#1067259: jabberd2: FTBFS: make[3]: *** [Makefile:538: libsx_la-websocket.lo] Error 1

2024-04-10 Thread Steve Langasek
Package: jabberd2
Followup-For: Bug #1067259
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue that has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch 
jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch
--- jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch
1969-12-31 16:00:00.0 -0800
+++ jabberd2-2.7.0/debian/patches/no-implicit-declarations.patch
2024-04-10 15:03:46.0 -0700
@@ -0,0 +1,81 @@
+Description: add missing includes and disable conflicting crypt_r()
+ Nothing uses crypt_r() externally, it should use the glibc one; so disable
+ the conflicting prototype in the internal header.
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1067259
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: jabberd2-2.7.0/storage/authreg_sqlite.c
+===
+--- jabberd2-2.7.0.orig/storage/authreg_sqlite.c
 jabberd2-2.7.0/storage/authreg_sqlite.c
+@@ -32,6 +32,7 @@
+ #define _XOPEN_SOURCE 500
+ #include "c2s.h"
+ #include 
++#include 
+ 
+ /* Windows does not have the crypt() function, let's take DES_crypt from 
OpenSSL instead */
+ #if defined(HAVE_OPENSSL_CRYPTO_H) && defined(_WIN32)
+Index: jabberd2-2.7.0/storage/authreg_pgsql.c
+===
+--- jabberd2-2.7.0.orig/storage/authreg_pgsql.c
 jabberd2-2.7.0/storage/authreg_pgsql.c
+@@ -32,6 +32,7 @@
+ #else
+ #ifdef HAVE_CRYPT
+ #include 
++#include 
+ #endif
+ #endif
+ 
+Index: jabberd2-2.7.0/storage/authreg_ldapfull.c
+===
+--- jabberd2-2.7.0.orig/storage/authreg_ldapfull.c
 jabberd2-2.7.0/storage/authreg_ldapfull.c
+@@ -35,6 +35,7 @@
+ #ifdef STORAGE_LDAP
+ #ifdef HAVE_CRYPT
+ #include 
++#include 
+ #endif
+ 
+ #ifdef HAVE_SSL
+Index: jabberd2-2.7.0/util/crypt_blowfish.c
+===
+--- jabberd2-2.7.0.orig/util/crypt_blowfish.c
 jabberd2-2.7.0/util/crypt_blowfish.c
+@@ -54,6 +54,8 @@
+ /* Just to make sure the prototypes match the actual definitions */
+ #include "crypt_blowfish.h"
+ 
++char *crypt_r(__const char *key, __const char *setting, void *data);
++
+ #if defined(__i386__) || defined(__x86_64__) || defined(__alpha__) || 
defined(__hppa__)
+ #define BF_SCALE  1
+ #else
+Index: jabberd2-2.7.0/util/crypt_blowfish.h
+===
+--- jabberd2-2.7.0.orig/util/crypt_blowfish.h
 jabberd2-2.7.0/util/crypt_blowfish.h
+@@ -23,7 +23,6 @@
+ #endif
+ 
+ extern char *bcrypt(__const char *key, __const char *setting);
+-extern char *crypt_r(__const char *key, __const char *setting, void *data);
+ 
+ #ifndef __SKIP_OW
+ extern char *crypt_rn(__const char *key, __const char *setting,
+Index: jabberd2-2.7.0/storage/authreg_mysql.c
+===
+--- jabberd2-2.7.0.orig/storage/authreg_mysql.c
 jabberd2-2.7.0/storage/authreg_mysql.c
+@@ -35,6 +35,7 @@
+ #else
+ #ifdef HAVE_CRYPT
+ #include 
++#include 
+ #endif
+ #endif
+ 
diff -Nru jabberd2-2.7.0/debian/patches/series 
jabberd2-2.7.0/debian/patches/series
--- jabberd2-2.7.0/debian/patches/series2023-09-05 14:07:00.0 
-0700
+++ jabberd2-2.7.0/debian/patches/series2024-04-10 15:00:33.0 
-0700
@@ -7,3 +7,4 @@
 systemd-alias.diff
 m4-ax_check_compile_flag.diff
 mysql8_my_bool.patch
+no-implicit-declarations.patch


Bug#1068777: plasma-systemmonitor with the process manager is not installed anymore after upgrading to Debian12

2024-04-10 Thread mYnDstrEAm
Package: kde-plasma-desktop
Version: 5:142

After upgrading from Debian11/KDE to Debian12, plasma-systemmonitor was not 
installed. This should definitely be an installed package and I think it is 
configured to be.

On Debian11, KSysGuard was used. Now there only is KSysguard in "Background 
Services" which "Launches KSysguard on Ctrl + Escape" and launches 
systemd->systemmonitor. While this shortcut was kept, ctrl+shift+esc wasn't set 
anymore so one has to configure it again under "Custom Shortcuts" with command 
"plasma-systemmonitor".

I checked /var/log/apt/history.log and there it says 
"plasma-systemmonitor:amd64 (5.27.5-2, automatic)" underneath apt-get 
full-upgrade in the packages next to "Install: ". However that process exited 
with "Error: Sub-process /usr/bin/dpkg returned an error code (1)" because of 
"FATAL ERROR: Both /lib/udev/mtp-probe and /usr/lib/udev/mtp-probe exist." 
after which I ran "apt --fix-broken install" before running "apt-get 
full-upgrade" again.
Right after all this (that is upgrading to Debian12) I noticed this package was 
not installed and installed this specific package.

plasma-systemmonitor, which includes the process manager, should always be 
installed by default on a new KDE setup as well as when upgrading from the 
prior Debian version which had KSysguard installed. In addition, the widely 
known and much used shortcut ctrl+shift+esc should also be there by default and 
launch plasma-systemmonitor (or alternatively systemmonitor).



Bug#1067957: [[maude-bugs]] [EXTERNAL] Re: Maude fails to build on armhf

2024-04-10 Thread Steven Eker
I like that solution since I believe there are 64-bit platforms where 
long is 32-bits. I've updated my development version thus:


  //
  //    timeValue.tv_sec is 64-bit since Linux kernel 5.6 but GMP 
doesn't yet have support
  //    for long long which is a problem on platforms where long is 
less than 8 bytes.

  //
#if SIZEOF_LONG < 8
  double seconds = timeValue.tv_sec;
#else
  long seconds = timeValue.tv_sec;
#endif
  mpz_class nanoSeconds(seconds);

Of course I expect to drop support for 32-bit before 2038 - certainly 
when one our dependencies drops support. But I've gotten a bug report 
for building Maude on a Raspberry Pi.


Steven

On 4/10/24 14:59, Aaron M. Ucko wrote:


Steven Eker  writes:


This is harmless on 64-bit architectures since Index will be a signed
64-bit integer and if it works on 32-bit architectures, it's a work
around until GMP is fixed (hopefully before 2038).

I know this suggestion is unorthodox, and quite possibly moot at this
point in the context of official Debian packages -- but you might want
to consider formally going through double here, at least on the relevant
platforms.  Precision loss shouldn't be a concern for another 140
million years or so by my reckoning, and I expect the additional
conversion overhead would be negligible in practice.

Thanks!





Bug#1058646: ITP: qbe -- Small embeddable C compiler backend

2024-04-10 Thread Miguel Landaeta
On Wed, Apr 10, 2024 at 2:51 PM Guilherme Puida Moreira
 wrote:
>
> Hi Miguel,
>
> [...]
>
> I have written a very simple man page for qbe (see attached patch). I
> have never actually used qbe directly, so I'm not sure what else should
> be documented there. I figured that the cli options were a good starting
> point, though.
>

Hi Guilherme,

Thanks for the patch!

As you mentioned, this package is almost ready to be uploaded so I'll
try to prioritize it and upload it during the weekend.

Cheers,
Miguel.

-- 
Miguel Landaeta, miguel at miguel.cc
secure email with PGP 0x6E608B637D8967E9 available at http://keyserver.pgp.com/
"Faith means not wanting to know what is true." -- Nietzsche



Bug#1068483: Bug#882511: dpkg-buildpackage: should allow caller to force inclusion of source in buildinfo

2024-04-10 Thread Vagrant Cascadian
On 2024-04-09, Guillem Jover wrote:
> I've now finished the change I had in that branch, which implements
> support so that dpkg-buildpackage can be passed a .dsc or a source-dir,
> and in the former will first extract it, and for both then it will
> change directory to the source tree. If it got passed a .dsc then it
> will instruct dpkg-genbuildinfo to include a ref to it.
>
> Which I think accomplishes the requested behavior in a safe way? I've
> attached what I've got, which I'm planning on merging for 1.22.7. I'll
> probably split that into two commits though before merging.

Had a chance to take this for a test run, and it appears to work, though
with a few surprises...

  dpkg-buildpackage -- hello_2.10-3.dsc

Ends up regenerating the .dsc, as --build=any,all,source by default
... which may end up with a different .dsc checksum in the .buildinfo
than .dsc that was passed on the commandline. Which makes some sense,
but maybe would be better to error out? I would not expect to regenerate
the .dsc if you're passing dpkg-buildpackage a .dsc!


  dpkg-buildpackage --build=any,all -- /path/to/hello_2.10-3.dsc

Fails to find the .dsc file, as it appears to extract the sources to
hello-2.10 and then expects to find ../hello_2.10-3.dsc


All that said ... this seemed to work for me:

  dpkg-buildpackage --build=any,all -- hello_2.10-3.dsc

So yay, progress! Thanks!


All of the above cases do not clean up the hello-2.10 extracted from the
.dsc file, so re-running any of the above need to manually clean that or
run from a clean directory or experience various failure modes with the
existing hellp-2.10 directory.


So a few little glitches, but overall this seems close to something we
have really wanted for reproducible builds! And just for good measure,
thanks!


live well,
  vagrant


signature.asc
Description: PGP signature


Bug#1068776: Apper and Discover ask to install "orphan-sysvinit-scripts" but not apt-get

2024-04-10 Thread mYnDstrEAm
Package: apper
Version: 1.0.0

Why is that and is this a bug? If this is not the correct place to file it, 
please move this or tell me where to report it. sudo apt upgrade and sudo 
apt-get upgrade don't ask for this to be installed so I don't know why Apper 
and Discover ask for it to be installed since I thought they were using 
apt-get. This issue tracker is outdated by decades.

See 
https://unix.stackexchange.com/questions/774015/why-does-kdes-discover-and-apper-show-orphan-sysvinit-scripts-should-be-updat



Bug#1068775: sbuild-qemu: fails to work, if piuparts is requested, but not installed on the host

2024-04-10 Thread Francesco Poli (wintermute)
Package: sbuild-qemu
Version: 0.85.6
Severity: normal
X-Debbugs-Cc: invernom...@paranoici.org

Hi!

I am trying to set up sbuild-qemu to build (and test) Debian packages.

After creating the virtual machine image:

  $ mkdir -p ~/.cache/sbuild/build
  $ cd /dev/shm
  $ TMPDIR=/dev/shm mmdebstrap-autopkgtest-build-qemu \
--size=25G --boot=efi sid unstable-autopkgtest-amd64.img
  $ mv -i unstable-autopkgtest-amd64.img ~/.cache/sbuild/

I prepared the following configuration file:

  $ cat ~/.sbuildrc 
  $source_only_changes = 1;
  $autopkgtest_require_success = 1;
  $lintian_require_success = 0;
  $piuparts_require_success = 1;
  $run_autopkgtest = 1;
  $run_lintian = 1;
  $run_piuparts = 1;
  $build_dir = "$HOME/.cache/sbuild/build";
  
  # don't remove this, Perl needs it:
  1;

I can update the virtual machine (if I create a symlink, see bug [#1061816]):

  $ sbuild-qemu-update --boot=efi unstable-autopkgtest-amd64.img

[#1061816]: 

But, when I try to build a package from withing the unpacked source
tree:

  $ sbuild-qemu --boot=efi --overlay-dir=/dev/shm
  sbuild --dist unstable --purge-build=never --purge-deps=never 
--chroot-mode=autopkgtest --autopkgtest-virt-server=qemu 
--autopkgtest-virt-server-opt --overlay-dir=/dev/shm 
--autopkgtest-virt-server-opt --qemu-architecture=x86_64 
--autopkgtest-virt-server-opt --ram-size=2048 --autopkgtest-virt-server-opt 
--cpus=2 --autopkgtest-virt-server-opt --boot=efi --autopkgtest-virt-server-opt 
/home/$USER/.cache/sbuild/unstable-autopkgtest-amd64.img 
--bd-uninstallable-explainer apt
Error reading configuration: PIUPARTS binary 'piuparts' does not exist or is 
not executable at /usr/share/perl5/Sbuild/Conf.pm line 76.

Now, piuparts is indeed not installed on the host:

  $ apt policy piuparts
  piuparts:
Installed: (none)
Candidate: 1.4.1
Version table:
   1.4.1 800
  800 http://deb.debian.org/debian testing/main amd64 Packages
  500 http://deb.debian.org/debian unstable/main amd64 Packages

However, I thought that setting $run_piuparts = 1 in ~/.sbuildrc caused
piuparts to be run inside the virtual machine guest system, not on the
host system!
Hence, I thought that piuparts was going to be automatically installed
and executed on the guest system (actually on the throw-away overlay).
And I thought that the same was going to happen for $run_autopkgtest = 1
and for $run_lintian = 1 ...

Am I completely off-track?
What did I fail to understand?

Why does sbuild-qemu insist that piuparts be installed on the *host*
system?

Please clarify and/or fix this issue.
Thanks for your kind assistance!


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.15-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages sbuild-qemu depends on:
ii  autopkgtest  5.34
ii  python3  3.11.6-1
ii  python3-pexpect  4.9-2
ii  python3-psutil   5.9.8-2
ii  qemu-system-x86  1:8.2.1+ds-2
ii  qemu-utils   1:8.2.1+ds-2
ii  sbuild   0.85.6
ii  vmdb20.28-2

Versions of packages sbuild-qemu recommends:
ii  qemu-system-arm [qemu-system-arm]  1:8.2.1+ds-2
ii  qemu-system-ppc [qemu-system-ppc]  1:8.2.1+ds-2

sbuild-qemu suggests no packages.

-- no debconf information



Bug#1042467: (No Subject)

2024-04-10 Thread mYnDstrEAm
Same here on multiple Debian/KDE machines after upgrading to Debian12. I think 
the title should be clearer or should this package actually be installed? I 
doubt it. For me it wants to remove way more than 30 packages, many of them 
being essential packages.

See 
https://unix.stackexchange.com/questions/748950/after-upgrading-to-debian12-and-upgrading-packages-apt-shows-the-following-pack
 Also this issue tracker is totally outdated. By decades. And nearly unusable, 
which is a problem if the project is interested in getting more devs involved.



Bug#956330: (No Subject)

2024-04-10 Thread mYnDstrEAm
I think this would good. Created a similar issue here: 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068774 However, I don't 
think it's common that one manually installs a package that one already had 
installed as a dependency and doesn't want to mark it as manually installed, or 
is it? I think example scenarios would be useful.



Bug#1067957: [[maude-bugs]] [EXTERNAL] Re: Maude fails to build on armhf

2024-04-10 Thread Aaron M. Ucko
Steven Eker  writes:

> This is harmless on 64-bit architectures since Index will be a signed
> 64-bit integer and if it works on 32-bit architectures, it's a work 
> around until GMP is fixed (hopefully before 2038).

I know this suggestion is unorthodox, and quite possibly moot at this
point in the context of official Debian packages -- but you might want
to consider formally going through double here, at least on the relevant
platforms.  Precision loss shouldn't be a concern for another 140
million years or so by my reckoning, and I expect the additional
conversion overhead would be negligible in practice.

Thanks!

-- 
Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu



Bug#1066505: epic5: FTBFS: functions.c:7547:15: error: implicit declaration of function ‘strptime’; did you mean ‘strftime’? [-Werror=implicit-function-declaration]

2024-04-10 Thread Michael Hudson-Doyle
Package: epic5
Followup-For: Bug #1066505
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hud...@ubuntu.com
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * d/patches/define-xopen-bsd-source.patch: #define _XOPEN_SOURCE and
_BSD_SOURCE to get access to the declaration of strptime, strlcat and some
other symbols.

Thanks for considering the patch.

Cheers,
mwh

-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch 
epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch
--- epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch1970-01-01 
12:00:00.0 +1200
+++ epic5-2.1.6/debian/patches/define-xopen-bsd-source.patch2024-04-10 
14:07:56.0 +1200
@@ -0,0 +1,17 @@
+--- a/include/irc_std.h
 b/include/irc_std.h
+@@ -12,6 +12,14 @@
+ #include "defs.h"
+ 
+ /*
++ * Define _XOPEN_SOURCE to get access to prototype of strptime() and
++ * _BSD_SOURCE to get access to prototype of strl{cat,cpy} and declaration of
++ * h_errno.
++ */
++#define _XOPEN_SOURCE 700
++#define _BSD_SOURCE
++
++/*
+  * Try to turn back the IPv6 monster at the gate
+  */
+ #ifdef DO_NOT_USE_IPV6
diff -Nru epic5-2.1.6/debian/patches/series epic5-2.1.6/debian/patches/series
--- epic5-2.1.6/debian/patches/series   2021-10-10 00:04:08.0 +1300
+++ epic5-2.1.6/debian/patches/series   2024-04-10 14:07:56.0 +1200
@@ -2,3 +2,4 @@
 manual.patch
 path.patch
 reproducible-build.patch
+define-xopen-bsd-source.patch


Bug#1068774: When installing a package that is kept back with apt-get install do not mark it as manually installed or ask the user whether the mark should be added

2024-04-10 Thread mYnDstrEAm
Package: apt
Version: 2.6.1

Could you please make apt not mark packages as manually installed when 
installing packages that have been kept back in specific?

Alternatively, the user could be asked whether they want to have it marked if 
the mark would be added but I think most users would not want that. It makes 
little sense and only causes problems, partly because they then won't uninstall 
when removing packages that depend on them.

The packages could also be marked differently such as "kept-back manually 
installed" and there could be a parameter for marking it as manually installed 
like it is now.

This is a common problem and it's recommended or best practice to not mark them 
as manually installed, see: 
https://askubuntu.com/questions/601/the-following-packages-have-been-kept-back-why-and-how-do-i-solve-it

Also see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=956330



Bug#1065969: ike-scan: FTBFS on arm{el,hf}: configure: error: cannot determine snprintf format string for long long int

2024-04-10 Thread Steve Langasek
Package: ike-scan
Followup-For: Bug #1065969
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue that has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru ike-scan-1.9.5/debian/patches/no-implicit-declarations.patch 
ike-scan-1.9.5/debian/patches/no-implicit-declarations.patch
--- ike-scan-1.9.5/debian/patches/no-implicit-declarations.patch
1969-12-31 16:00:00.0 -0800
+++ ike-scan-1.9.5/debian/patches/no-implicit-declarations.patch
2024-04-10 14:34:34.0 -0700
@@ -0,0 +1,18 @@
+Description: add missing include
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1065969
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: ike-scan-1.9.5/acinclude.m4
+===
+--- ike-scan-1.9.5.orig/acinclude.m4
 ike-scan-1.9.5/acinclude.m4
+@@ -180,6 +180,7 @@
+ AC_CACHE_VAL(pgac_cv_snprintf_long_long_int_format,
+ [for pgac_format in '%lld' '%qd' '%I64d'; do
+ AC_TRY_RUN([#include 
++#include 
+ typedef long long int int64;
+ #define INT64_FORMAT "$pgac_format"
+ 
diff -Nru ike-scan-1.9.5/debian/patches/series 
ike-scan-1.9.5/debian/patches/series
--- ike-scan-1.9.5/debian/patches/series2021-10-18 02:12:52.0 
-0700
+++ ike-scan-1.9.5/debian/patches/series2024-04-10 14:03:18.0 
-0700
@@ -1,2 +1,3 @@
 disable_aggressive_in_v2.patch
 skip-malformed-comp.patch
+no-implicit-declarations.patch


Bug#1068655: lomiri-telephony-service FTBFS with abseil 20230802.1

2024-04-10 Thread Adrian Bunk
On Wed, Apr 10, 2024 at 09:02:50PM +, Mike Gabriel wrote:
> Hi Adrian,

Hi Mike,

>...
> I'd appreciate if you could take a look and shed some light on this.
>...

I would have mentioned if I had a clue about this, but I don't.

In places like #debian-devel there might be people who understand at 
first sight what the problem might be.

> Thanks!
> Mike

cu
Adrian



Bug#961434: baresip-core: stack smashing detected with evdev module

2024-04-10 Thread Bastian Germann

I am uploading a NMU to experimental in order to fix this.
Please consider confirming the transition #1055755 so that it can move to 
unstable.diff -Nru baresip-1.1.0/debian/changelog baresip-1.1.0/debian/changelog
--- baresip-1.1.0/debian/changelog  2023-10-14 16:59:36.0 +
+++ baresip-1.1.0/debian/changelog  2024-04-10 20:52:08.0 +
@@ -1,3 +1,11 @@
+baresip (1.1.0-0.2) experimental; urgency=medium
+
+  * Non-maintainer upload
+  * Remove OMX support (see #1065623)
+  * Fix stack smashing (Closes: #961434)
+
+ -- Bastian Germann   Wed, 10 Apr 2024 20:52:08 +
+
 baresip (1.1.0-0.1) experimental; urgency=medium
 
   * Non-maintainer upload
diff -Nru baresip-1.1.0/debian/control baresip-1.1.0/debian/control
--- baresip-1.1.0/debian/control2023-10-14 16:59:36.0 +
+++ baresip-1.1.0/debian/control2024-04-10 20:52:03.0 +
@@ -22,7 +22,6 @@
  libmosquitto-dev,
  libmp3lame-dev,
  libmpg123-dev,
- libomxil-bellagio-dev,
  libopenaptx-dev,
  libopencore-amrnb-dev,
  libopencore-amrwb-dev,
diff -Nru baresip-1.1.0/debian/patches/0002_70a7f45.patch 
baresip-1.1.0/debian/patches/0002_70a7f45.patch
--- baresip-1.1.0/debian/patches/0002_70a7f45.patch 1970-01-01 
00:00:00.0 +
+++ baresip-1.1.0/debian/patches/0002_70a7f45.patch 2024-04-10 
20:52:08.0 +
@@ -0,0 +1,39 @@
+Origin: upstream, 70a7f456668426a2b59911a04bf42f93a3b2bec6
+From: Sebastian Reimers 
+Date: Mon, 16 May 2022 08:19:14 +0200
+Subject: evdev: fix wrong ioctl size (#1843)
+
+found and fixed by debian:
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961434
+---
+ modules/evdev/print.c | 8 
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/modules/evdev/print.c b/modules/evdev/print.c
+index f04f4af4e..6571c1f8f 100644
+--- a/modules/evdev/print.c
 b/modules/evdev/print.c
+@@ -42,11 +42,11 @@ void print_name(int fd)
+  */
+ void print_events(int fd)
+ {
+-  uint8_t evtype_bitmask[EV_MAX/8 + 1];
++  uint8_t evbitmask[EV_MAX/8 + 1];
+   int i;
+ 
+-  memset(evtype_bitmask, 0, sizeof(evtype_bitmask));
+-  if (ioctl(fd, EVIOCGBIT(0, EV_MAX), evtype_bitmask) < 0) {
++  memset(evbitmask, 0, sizeof(evbitmask));
++  if (ioctl(fd, EVIOCGBIT(0, sizeof(evbitmask)), evbitmask) < 0) {
+   warning("evdev: ioctl EVIOCGBIT (%m)\n", errno);
+   return;
+   }
+@@ -54,7 +54,7 @@ void print_events(int fd)
+   printf("Supported event types:\n");
+ 
+   for (i = 0; i < EV_MAX; i++) {
+-  if (!test_bit(i, evtype_bitmask))
++  if (!test_bit(i, evbitmask))
+   continue;
+ 
+   printf("  Event type 0x%02x ", i);
diff -Nru baresip-1.1.0/debian/patches/series 
baresip-1.1.0/debian/patches/series
--- baresip-1.1.0/debian/patches/series 2023-10-14 16:59:36.0 +
+++ baresip-1.1.0/debian/patches/series 2024-04-10 20:52:08.0 +
@@ -1,3 +1,4 @@
+0002_70a7f45.patch
 1002_system_header_locations.patch
 2001_drop_libre_so_check.patch
 2002_test_verbose.patch
diff -Nru baresip-1.1.0/debian/rules baresip-1.1.0/debian/rules
--- baresip-1.1.0/debian/rules  2023-10-14 16:59:36.0 +
+++ baresip-1.1.0/debian/rules  2024-04-10 20:52:08.0 +
@@ -26,7 +26,7 @@
 ffmpeg-mods = avcodec avfilter avformat swscale
 gstreamer-mods = gst gst_video
 gtk-mods = gtk
-x11-mods = cairo omx pulse rst sdl vidinfo x11 x11grab
+x11-mods = cairo pulse rst sdl vidinfo x11 x11grab
 
 DEB_MAKE_EXTRA_ARGS = V=1 PREFIX=/usr RELEASE=1 \
EXTRA_MODULES="$(core-mods-extra) avfilter swscale" \


Bug#872944: #872944 www.debian.org: Remove JavaScript from Policy Manual published on web mirrors

2024-04-10 Thread Holger Wansing
Hi,

Bill Allombert  wrote (Wed, 10 Apr 2024 
22:24:20 +0200):
> On Wed, Apr 10, 2024 at 09:33:50PM +0200, Holger Wansing wrote:
> > Hello www team and debian-policy editor team,
> > 
> > Note: apparently we have no alternative beside js, if we want full-text 
> > search for html output (single-page html could be a possible way, but 
> > that output format has been disabled due to various other issues).
> 
> Sorry, but why is this so hard to generate a single-page html ?
> debiandoc could do it. Using the browser intra-page search is always much
> easier/faster that using a search box.

I did not go deeper into this scenario, I just found 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877337
which includes a forward-backword-forward dance switching multiple
times between multi-page and single-page html variant requests.


Holger


-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076



Bug#1068773: Subject: blhc: Stack clash and branch protection flag issues in Debian Bookworm and older releases

2024-04-10 Thread aquilamacedo
Package: blhc
X-Debbugs-Cc: car...@debian.org, aquilamac...@riseup.net
Version: 0.13-5
Severity: normal

Dear Maintainer,

I am writing to report an issue that has been observed during the Salsa
CI process for Debian Bookworm and older releases. The problem arises
when checking for stack clash protection (-fstack-clash-protection) and
branch protection (amd64: -fcf-protection, arm64:
-mbranch-protection=standard). These checks were requested by Emanuele
Rocca (Debian Bug #1050909 and #1050912).

The issue manifests as a compilation error. For instance, you can see
the error in this job:
https://salsa.debian.org/kernel-team/linux/-/jobs/5496461.

The issue was first noticed by @carnil during a routine check. The error
message indicates that the CFLAGS are missing (-fstack-clash-protection
-fcf-protection).

The ${RELEASE} variable in the context of this issue refers to the
specific Debian release being used during the Salsa CI process. One
potential solution that has been considered is to ensure that
blhc:${RELEASE} correctly handles the flags for each release. This
approach could alleviate the compilation errors and ensure consistency
across different Debian releases.

For more details, you can check the issue in the Salsa CI repository at
https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/340

Before proceeding with any changes, I would appreciate your input on
this matter. Specifically, do you think it would be sensible to use blhc
from each release? Your insights would be greatly appreciated.

Cheers,



Bug#1068655: lomiri-telephony-service FTBFS with abseil 20230802.1

2024-04-10 Thread Mike Gabriel

Hi Adrian,

On  Mo 08 Apr 2024 20:36:54 CEST, Adrian Bunk wrote:


Source: lomiri-telephony-service
Version: 0.5.3-1
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/fetch.php?pkg=lomiri-telephony-service=amd64=0.5.3-1%2Bb3=1712518065=0

...
/<>/libtelephonyservice/contactwatcher.cpp: In member  
function ‘void ContactWatcher::updateAlias()’:
/<>/libtelephonyservice/contactwatcher.cpp:157:21:  
error: ‘dgettext’ is not a member of ‘C’; did you mean ‘dgettext’?

  157 | setAlias(C::dgettext("telephony-service", "Private Number"));
  | ^~~~
In file included from  
/usr/include/x86_64-linux-gnu/c++/13/bits/messages_members.h:36,

 from /usr/include/c++/13/bits/locale_facets_nonio.h:2064,
 from /usr/include/c++/13/locale:43,
 from /usr/include/c++/13/iomanip:45,
 from /usr/include/absl/strings/internal/str_format/arg.h:23,
 from /usr/include/absl/strings/str_format.h:78,
 from /usr/include/absl/crc/crc32c.h:32,
 from /usr/include/absl/crc/internal/crc_cord_state.h:23,
 from /usr/include/absl/strings/cord.h:79,
 from  
/usr/include/absl/container/internal/hash_function_defaults.h:56,

 from /usr/include/absl/container/node_hash_set.h:42,
 from /usr/include/phonenumbers/phonenumberutil.h:33,
 from /<>/libtelephonyservice/phoneutils.h:27,
 from  
/<>/libtelephonyservice/contactwatcher.cpp:25:

/usr/include/libintl.h:44:14: note: ‘dgettext’ declared here
   44 | extern char *dgettext (const char *__domainname, const char *__msgid)
  |  ^~~~
/<>/libtelephonyservice/contactwatcher.cpp:159:21:  
error: ‘dgettext’ is not a member of ‘C’; did you mean ‘dgettext’?

  159 | setAlias(C::dgettext("telephony-service", "Unknown Number"));
  | ^~~~
/usr/include/libintl.h:44:14: note: ‘dgettext’ declared here
   44 | extern char *dgettext (const char *__domainname, const char *__msgid)
  |  ^~~~
...



I might need a hand with this. I have been staring at the code and see  
a construct like this:


```
namespace C {
#include 
}


... C::dgettext(...) ...
```

This works in many of the files of lomiri-telephony-service, but not  
in libtelephonyservice/contactwatcher.cpp. Neither in  
indicator/messagingmenu.cpp.


I can omit the "C::" namespace prefix in those files and then the  
build works. (But it used to work the way it is before the recent  
binNMU if lomiri-telephony-service).


I'd appreciate if you could take a look and shed some light on this.

Thanks in advance!!!

As a side note: shouldn't the libintl.h include in an 'extern "C" {  
#include <...> }' environment?


Thanks!
Mike


--

mike gabriel aka sunweaver (Debian Developer)
mobile: +49 (1520) 1976 148
landline: +49 (4351) 486 14 27

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22  0782 9AF4 6B30 2577 1B31
mail: sunwea...@debian.org, http://sunweavers.net



pgp3cQXH_kgZ2.pgp
Description: Digitale PGP-Signatur


Bug#1066672: httest: FTBFS: socks_module.c:115:21: error: implicit declaration of function ‘atoi’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Steve Langasek
Package: httest
Followup-For: Bug #1066672
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru httest-2.4.23/debian/patches/no-implicit-declarations.patch 
httest-2.4.23/debian/patches/no-implicit-declarations.patch
--- httest-2.4.23/debian/patches/no-implicit-declarations.patch 1969-12-31 
16:00:00.0 -0800
+++ httest-2.4.23/debian/patches/no-implicit-declarations.patch 2024-04-10 
13:45:54.0 -0700
@@ -0,0 +1,43 @@
+Description: add missing includes
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066672
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: httest-2.4.23/src/socks_module.c
+===
+--- httest-2.4.23.orig/src/socks_module.c
 httest-2.4.23/src/socks_module.c
+@@ -25,6 +25,8 @@
+ /
+  * Includes
+  ***/
++#include 
++
+ #include "module.h"
+ #ifndef HAVE_NO_NETINET
+   #include 
+Index: httest-2.4.23/src/annotation_module.c
+===
+--- httest-2.4.23.orig/src/annotation_module.c
 httest-2.4.23/src/annotation_module.c
+@@ -25,6 +25,7 @@
+ /
+  * Includes
+  ***/
++#include 
+ #include "module.h"
+ 
+ /
+Index: httest-2.4.23/src/dbg_module.c
+===
+--- httest-2.4.23.orig/src/dbg_module.c
 httest-2.4.23/src/dbg_module.c
+@@ -24,6 +24,7 @@
+ /
+  * Includes
+  ***/
++#include 
+ #include "store.h"
+ #include "module.h"
+ 
diff -Nru httest-2.4.23/debian/patches/series 
httest-2.4.23/debian/patches/series
--- httest-2.4.23/debian/patches/series 2023-12-18 04:21:33.0 -0800
+++ httest-2.4.23/debian/patches/series 2024-04-10 13:45:05.0 -0700
@@ -4,3 +4,4 @@
 fix-gcc-10.patch
 autoconf-2.70.patch
 pcre2.patch
+no-implicit-declarations.patch


Bug#1064975: RFS: k3conf/0.3-1 [ITP] -- Powerful Diagnostic Tool for Texas Instruments K3 based Processors

2024-04-10 Thread Andrey Rakhmatullin
On Wed, Apr 10, 2024 at 03:05:04PM -0500, Andrew Davis wrote:
> is that not right? Maybe my lintian version is old, I'm on v2.114, I'll
> see if updating that helps.
2.114 is older than stable, and for packages aimed at unstable you need
to use tools from unstable.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#1065777: clblas: FTBFS on arm{el,hf}: /<>/src/library/blas/gens/symv.c:955:29: error: implicit declaration of function ‘abs’; did you mean ‘fabs’? [-Werror=implicit-function-declarati

2024-04-10 Thread Steve Langasek
Package: clblas
Followup-For: Bug #1065777
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Apologies, the patch I attached fixed a real missing include, but not the
one mentioned in this bug and the package still failed to build.  Attached
is a patch that has passed build testing locally with
DEB_CFLAGS_APPEND=-Werror=implicit-function-declaration in Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru clblas-2.12/debian/patches/no-implicit-declarations.patch 
clblas-2.12/debian/patches/no-implicit-declarations.patch
--- clblas-2.12/debian/patches/no-implicit-declarations.patch   1969-12-31 
16:00:00.0 -0800
+++ clblas-2.12/debian/patches/no-implicit-declarations.patch   2024-04-09 
14:42:11.0 -0700
@@ -0,0 +1,30 @@
+Description: Add missing stdlib.h includes
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1065777
+Last-Update: 2024-04-09
+Forwarded: no
+
+Index: clblas-2.12/src/library/blas/gens/gemv.c
+===
+--- clblas-2.12.orig/src/library/blas/gens/gemv.c
 clblas-2.12/src/library/blas/gens/gemv.c
+@@ -21,6 +21,7 @@
+ 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+ #include 
+Index: clblas-2.12/src/library/blas/gens/symv.c
+===
+--- clblas-2.12.orig/src/library/blas/gens/symv.c
 clblas-2.12/src/library/blas/gens/symv.c
+@@ -21,6 +21,7 @@
+ 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+ #include 
diff -Nru clblas-2.12/debian/patches/series clblas-2.12/debian/patches/series
--- clblas-2.12/debian/patches/series   2023-09-28 16:21:54.0 -0700
+++ clblas-2.12/debian/patches/series   2024-04-09 14:40:35.0 -0700
@@ -9,3 +9,4 @@
 Fix-double-literals.patch
 Fix-null-pointer-crash.patch
 Fix-local-variables-not-declared-in-outermost-scope.patch
+no-implicit-declarations.patch


Bug#872944: #872944 www.debian.org: Remove JavaScript from Policy Manual published on web mirrors

2024-04-10 Thread Bill Allombert
On Wed, Apr 10, 2024 at 09:33:50PM +0200, Holger Wansing wrote:
> Hello www team and debian-policy editor team,
> 
> Note: apparently we have no alternative beside js, if we want full-text 
> search for html output (single-page html could be a possible way, but 
> that output format has been disabled due to various other issues).

Sorry, but why is this so hard to generate a single-page html ?
debiandoc could do it. Using the browser intra-page search is always much
easier/faster that using a search box.

Cheers,
Bill.



Bug#1067309: xerces-c: FTBFS: Exception in thread "main" java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-17-openjdk-amd64/lib/libfontmanager.so: libharfbuzz.so.0: cannot open shared object file: No

2024-04-10 Thread Bastian Germann

I am uploading a NMU to fix this.
The debdiff is attached.diff -Nru xerces-c-3.2.4+debian/debian/changelog 
xerces-c-3.2.4+debian/debian/changelog
--- xerces-c-3.2.4+debian/debian/changelog  2024-02-29 07:28:56.0 
+
+++ xerces-c-3.2.4+debian/debian/changelog  2024-04-10 20:08:55.0 
+
@@ -1,3 +1,10 @@
+xerces-c (3.2.4+debian-1.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove default-jre-headless B-D alternative. Closes: #1067309
+
+ -- Bastian Germann   Wed, 10 Apr 2024 20:08:55 +
+
 xerces-c (3.2.4+debian-1.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru xerces-c-3.2.4+debian/debian/control 
xerces-c-3.2.4+debian/debian/control
--- xerces-c-3.2.4+debian/debian/control2024-02-29 07:28:56.0 
+
+++ xerces-c-3.2.4+debian/debian/control2024-04-10 20:08:42.0 
+
@@ -5,7 +5,7 @@
libcurl4-gnutls-dev,
libicu-dev
 Build-Depends-Indep: doxygen,
- default-jre-headless | default-jre,
+ default-jre,
  libatk-wrapper-java,
  libstylebook-java,
  libxalan2-java,


Bug#1068562: Upstream proposed fix for unit test failure

2024-04-10 Thread Athos Ribeiro

Hi,

I submitted a salsa MR at
https://salsa.debian.org/ha-team/crmsh/-/merge_requests/7 with a fix
for this one.

--
Athos Ribeiro



Bug#1068772: uhd-host: usrpctl fails to run

2024-04-10 Thread Sudip Mukherjee
Package: uhd-host
Version: 4.6.0.0+ds1-5.1+b1
Severity: normal

Dear Maintainer,

usrpctl fails to run with the error:

$ usrpctl
Traceback (most recent call last):
  File "/usr/bin/usrpctl", line 15, in 
import uhd
ModuleNotFoundError: No module named 'uhd'

It should have a runtime dependency on python3-uhd.

-- 
Regards
Sudip

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.13-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages uhd-host depends on:
ii  libboost-filesystem1.83.0   1.83.0-2.1+b1
ii  libboost-program-options1.83.0  1.83.0-2.1+b1
ii  libboost-test1.83.0 1.83.0-2.1+b1
ii  libboost-thread1.83.0   1.83.0-2.1+b1
ii  libc6   2.37-15
ii  libgcc-s1   14-20240201-3
ii  libncurses6 6.4+20240113-1
ii  libstdc++6  14-20240201-3
ii  libtinfo6   6.4+20240113-1
ii  libuhd4.6.0t64  4.6.0.0+ds1-5.1+b1
ii  python3 3.11.6-1
ii  python3-numpy [python3-numpy-abi9]  1:1.26.4+ds-6
ii  python3-requests2.31.0+dfsg-1

Versions of packages uhd-host recommends:
ii  curl8.7.1-2
ii  procps  2:4.0.4-4

Versions of packages uhd-host suggests:
ii  fdisk 2.39.3-6
pn  gnuradio  



Bug#872944: #872944 www.debian.org: Remove JavaScript from Policy Manual published on web mirrors

2024-04-10 Thread Thomas Lange


> On Wed, 10 Apr 2024 21:33:50 +0200, Holger Wansing  
> said:


> The second javascript functionality is the full-text search.

> Please note, that I made use of javascript by intend, despite of this bug 
> requesting to remove all js functionality.
Hi holger,

in the past we tried to avoid javascript, but that's long time ago
(like 7 years) and nowadays I see no reason to do web pages without it
if we loose functionality.

So please go ahead and use js. I think the search function is very important.

I think it's important not to load js code on our pages from an
external URL, but to provide it from our web servers (selfhosted).

> Please note, that this decision is not only for debian-policy, but for
> all sphinx-based manuals on Debian website.
> (I hope we don't make different decisions on this question for the 
> various manuals we have. That would make the implentation once again
> more difficult.)
All sphinx-based manuals can use js from my point of view. There's no
reason to handle some manuals differently.


> What should be done now?
Close the bug that request to remove all js functionality (#876241).

-- 
regards Thomas



Bug#1064975: RFS: k3conf/0.3-1 [ITP] -- Powerful Diagnostic Tool for Texas Instruments K3 based Processors

2024-04-10 Thread Andrew Davis

On 4/10/24 2:12 PM, Andrey Rakhmatullin wrote:

On Wed, Apr 10, 2024 at 12:39:47PM -0500, Andrew Davis wrote:

- debian/k3conf.1 has a *roff warning, lintian also catches it.



I don't see this warning,

W: k3conf: groff-message error: automatically ending diversion 
'an*link-text-div' on exit [usr/share/man/man1/k3conf.1.gz:3]
Are you running lintian on the binary .changes?


I've run it on several of the files, including the binary .changes,

# lintian -i -I --show-overrides k3conf_0.3-1_amd64.changes

is that not right? Maybe my lintian version is old, I'm on v2.114, I'll
see if updating that helps.




it just shows "maintainer-manual-page" item. Which I know nothing about

You should use lintian-explain-tags(1) to read tag descriptions.



That works, thanks for hint. Also just found lintian -i flag, seems
that could be a good default now given the help site for the short
version is gone.

Andrew



Bug#1060787: i2pd: FTBFS on armel: Host compiler appears to require libatomic for 64-bit operations, but cannot find it.

2024-04-10 Thread Bastian Germann

Control: forwarded -1 
https://github.com/PurpleI2P/i2pd/commit/6b33250c599f138d8834fb00bfe9f936bc9d8894

This is fixed with upstream v2.50. See forwarded URL.



Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Cyril Brulebois
Control: forwarded -1 
https://lore.kernel.org/stable/20240410193207.qnb75osxuk4ov...@mraw.org/

Salvatore Bonaccorso  (2024-04-10):
> Yes, if you prefer to not do the forwarding upstream (stable list, CC
> to involved people + regression list), then I can try to take care of
> it. Obviously the former would be great, as you are the finder and
> have done all the work.

Thanks for nudging me into walking those extra few meters. Let's see how
that goes…


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Bug#1068771: xbtop: xbtop fails to run

2024-04-10 Thread Sudip Mukherjee
Package: libxrt-utils
Version: 202210.2.13.466+dfsg-8
Severity: normal

Dear Maintainer,

xbtop fails to run with the error:

$ xbtop 
python3: can't open file '/usr/bin/../python/xbtop.py': [Errno 2] No such file 
or directory


-- 
Regards
Sudip


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.13-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libxrt-utils depends on:
ii  libboost-filesystem1.74.0  1.74.0+ds1-23.1+b1
ii  libc6  2.37-15
ii  libgcc-s1  14-20240201-3
ii  libstdc++6 14-20240201-3
ii  libudev1   255.3-2
ii  libxrt1202210.2.13.466+dfsg-8
ii  python33.11.6-1

libxrt-utils recommends no packages.

libxrt-utils suggests no packages.



Bug#872944: #872944 www.debian.org: Remove JavaScript from Policy Manual published on web mirrors

2024-04-10 Thread Holger Wansing
Hello www team and debian-policy editor team,


in-line with activating the new html theme on our website I also
worked on the javascript front:

to make the html theme work on small screens (smartphones) the readthedocs.org
theme relies on javascript functionality, to display a sidebar with the table
of content only, when the device is in landscape direction resp. when the 
burger button is pressed.

The second javascript functionality is the full-text search.

I made all needed changings, to get the above functions work and they are doing 
fine now. See 

Please note, that I made use of javascript by intend, despite of this bug 
requesting to remove all js functionality.
This is because I wanted to find out,  what we need (aka which javascript 
packages) to make all the above mentioned functions work. 
Since I lack the skills to value this simply by studying source code and 
reading documentation, I had to test this in live to be sure.

The outcome of this is:
we need content of the javascript packages "libjs-sphinxdoc" and "libjs-jquery" 
existing in the manuals' path, to accomplish the above goals.

We need to decide now, if we want these functionality, when they require 
those javascript packages. 
Or if we skip such functionality.

Note: apparently we have no alternative beside js, if we want full-text 
search for html output (single-page html could be a possible way, but 
that output format has been disabled due to various other issues).

And being able to show/hide the sidebar on smartphones is a great benefit
when screen size is limited.


There are requests to not use js, but it has also been mentioned, that it
may be worth it enabling js, because of the relatively reduced amount of js 
use in sphinxdoc / jquery.
Note: I'm lacking skills to inspect source code, which other functions are
integrated in the doctools.js / jquery.js / searchtools.js / sphinx-highlight.js
scripts resp. what the functions I find there are doing exactly! 
Maybe someone can make a statement here?

I would like to mention another point:
it's a Browser functionality for decades to have the possibility to disable
use of JavaScript. So people who want to avoid any risk due to js, can or
will most probably have JavaScript disabled in the Browser settings anyway.


Please note, that this decision is not only for debian-policy, but for
all sphinx-based manuals on Debian website.
(I hope we don't make different decisions on this question for the 
various manuals we have. That would make the implentation once again
more difficult.)



What should be done now?


Holger



Bug#1068770: linux-image-6.1.0-18-amd64: Local privilege escalation vulnerability in kernel n_gsm driver

2024-04-10 Thread Salvatore Bonaccorso
Control: tags -1 + confirmed pending
Control: found -1 6.1.82-1

Hi,

On Wed, Apr 10, 2024 at 12:16:21PM -0700, LW wrote:
> Package: src:linux
> Version: 6.1.76-1
> Severity: critical
> Tags: upstream security
> Justification: root security hole
> X-Debbugs-Cc: lw-deb-...@greyskydesigns.com, Debian Security Team 
> 
> 
> Dear Maintainer,
> 
> A Reddit thread[1] linked to a Github page[2] with a local root
> escalation exploit.  This exploit works on the current "bookworm"
> stable kernel, 6.1.0-18-amd64.
> 
> It can be worked around by blocking the n_gsm driver:
> 
> echo 'blacklist n_gsm' | sudo tee -a /etc/modprobe.d/blacklist-gsm.conf
> sudo rmmod n_gsm
> 
> 
> [1] 
> https://old.reddit.com/r/linux/comments/1c0i7tx/someone_found_a_kernel_0day/
> [2] https://github.com/YuriiCrimson/ExploitGSM/

Thanks we are already aware of the issue.

Upstream is going to apply a mitigation for the issue:
https://lore.kernel.org/stable/2024041054-asleep-replace-96e8@gregkh/T/#m3a8ce43359ad57e447faa4db6ecf4f4c1b60c498

Regards,
Salvatore



Bug#1057407: texworks: Intent to drop poppler-qt6 on i386

2024-04-10 Thread Preuße

On 08.04.2024 00:08, Preuße...@buxtehude.debian.org, Hilmar wrote:

On 20.12.2023 15:25, Jeremy Bícha wrote:

On Sat, Dec 16, 2023 at 6:02 PM Hilmar Preuße  wrote:


Hi Jeremy,


As no package depend on texworks, I'll drop i386 as requested. If you
have a patch for me I'll be glad.


My plan is to first get a newer poppler from Experimental into
Unstable. After that poppler transition completes, then I can stop
building poppler qt6 on i386 and ask the ftpmasters to remove poppler
qt6 on i386 and texworks on i386. I don't think there is anything we
need to do to the texworks packaging; texworks will just be in depwait
status on i386.



OK, fine. So I guess there is nothing to do from my side regarding 
packaging, we have just to remove the texworks packages for i386 from 
the archive, else you won't be able to remove your packages, right?


I've filed #1068672 to remove i386 for texworks from the archive and it 
was processed today. I guess you can proceed soon.


Hilmar


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1068770: linux-image-6.1.0-18-amd64: Local privilege escalation vulnerability in kernel n_gsm driver

2024-04-10 Thread LW
Package: src:linux
Version: 6.1.76-1
Severity: critical
Tags: upstream security
Justification: root security hole
X-Debbugs-Cc: lw-deb-...@greyskydesigns.com, Debian Security Team 


Dear Maintainer,

A Reddit thread[1] linked to a Github page[2] with a local root escalation 
exploit.  This exploit works on the current "bookworm" stable kernel, 
6.1.0-18-amd64.

It can be worked around by blocking the n_gsm driver:

echo 'blacklist n_gsm' | sudo tee -a /etc/modprobe.d/blacklist-gsm.conf
sudo rmmod n_gsm


[1] https://old.reddit.com/r/linux/comments/1c0i7tx/someone_found_a_kernel_0day/
[2] https://github.com/YuriiCrimson/ExploitGSM/


-- Package-specific info:
** Version:
Linux version 6.1.0-18-amd64 (debian-ker...@lists.debian.org) (gcc-12 (Debian 
12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40) #1 SMP 
PREEMPT_DYNAMIC Debian 6.1.76-1 (2024-02-01)

** Command line:
BOOT_IMAGE=/@rootfs/boot/vmlinuz-6.1.0-18-amd64 root=UUID=403bad0f-[snip] ro 
rootflags=subvol=@rootfs panic=5

** Not tainted

** Kernel log:
[2.783100] at24 0-0051: supply vcc not found, using dummy regulator
[2.784137] at24 0-0051: 256 byte spd EEPROM, read-only
[2.789726] usb 2-1.3: FTDI USB Serial Device converter now attached to 
ttyUSB1
[2.806774] ipmi_si: IPMI System Interface driver
[2.810971] usbcore: registered new interface driver usbhid
[2.811095] usbhid: USB HID core driver
[2.811363] ipmi_si dmi-ipmi-si.0: ipmi_platform: probing via SMBIOS
[2.811489] ipmi_platform: ipmi_si: SMBIOS: io 0xca8 regsize 1 spacing 1 irq 0
[2.811630] ipmi_si: Adding SMBIOS-specified kcs state machine
[2.811813] ipmi_si IPI0001:00: ipmi_platform: probing via ACPI
[2.812069] ipmi_si IPI0001:00: ipmi_platform: [io  0x0ca8] regsize 1 
spacing 4 irq 0
[2.818248] ipmi_si dmi-ipmi-si.0: Removing SMBIOS-specified kcs state 
machine in favor of ACPI
[2.818400] ipmi_si: Adding ACPI-specified kcs state machine
[2.818581] ipmi_si: Trying ACPI-specified kcs state machine at i/o address 
0xca8, slave address 0x20, irq 0
[2.825415] input: American Megatrends Inc. Virtual Keyboard and Mouse as 
/devices/pci:00/:00:1a.0/usb1/1-1/1-1.5/1-1.5.1/1-1.5.1:1.0/0003:046B:FF10.0001/input/input3
[2.832623] hid-generic 0003:046B:FF10.0001: input,hidraw0: USB HID v1.10 
Keyboard [American Megatrends Inc. Virtual Keyboard and Mouse] on 
usb-:00:1a.0-1.5.1/input0
[2.832950] input: American Megatrends Inc. Virtual Keyboard and Mouse as 
/devices/pci:00/:00:1a.0/usb1/1-1/1-1.5/1-1.5.1/1-1.5.1:1.1/0003:046B:FF10.0002/input/input4
[2.834908] hid-generic 0003:046B:FF10.0002: input,hidraw1: USB HID v1.10 
Mouse [American Megatrends Inc. Virtual Keyboard and Mouse] on 
usb-:00:1a.0-1.5.1/input1
[2.842988] ast :0a:00.0: vgaarb: deactivate vga console
[2.844608] Console: switching to colour dummy device 80x25
[2.846274] ast :0a:00.0: [drm] Using P2A bridge for configuration
[2.846281] ast :0a:00.0: [drm] AST 1100 detected
[2.846293] ast :0a:00.0: [drm] Using analog VGA
[2.846303] ast :0a:00.0: [drm] dram MCLK=204 Mhz type=0 bus_width=16
[2.850155] [drm] Initialized ast 0.1.0 20120228 for :0a:00.0 on minor 0
[2.855445] fbcon: astdrmfb (fb0) is primary device
[2.896398] ipmi_si IPI0001:00: IPMI message handler: Found new BMC (man_id: 
0x0019fd, prod_id: 0x1588, dev_id: 0x20)
[2.956975] RAPL PMU: API unit is 2^-32 Joules, 2 fixed counters, 163840 ms 
ovfl timer
[2.956979] RAPL PMU: hw unit of domain pp0-core 2^-16 Joules
[2.956980] RAPL PMU: hw unit of domain package 2^-16 Joules
[2.962273] cfg80211: Loading compiled-in X.509 certificates for regulatory 
database
[2.962515] cfg80211: Loaded X.509 cert 'b...@debian.org: 
577e021cb980e0e820821ba7b54b4961b8b4fadf'
[2.962782] cfg80211: Loaded X.509 cert 'romain.per...@gmail.com: 
3abbc6ec146e09d1b6016ab9d6cf71dd233f0328'
[2.963083] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7'
[2.963382] cfg80211: Loaded X.509 cert 'wens: 
61c038651aabdcf94bd0ac7ff06c7248db18c600'
[2.964803] platform regulatory.0: firmware: direct-loading firmware 
regulatory.db
[2.964836] platform regulatory.0: firmware: direct-loading firmware 
regulatory.db.p7s
[2.965857] cryptd: max_cpu_qlen set to 1000
[2.968485] Console: switching to colour frame buffer device 128x48
[2.970095] ast :0a:00.0: [drm] fb0: astdrmfb frame buffer device
[2.985684] AVX version of gcm_enc/dec engaged.
[2.985759] AES CTR mode by8 optimization enabled
[3.09] ipmi_si IPI0001:00: IPMI kcs interface initialized
[3.015582] ipmi_ssif: IPMI SSIF Interface driver
[3.171484] bond1: (slave enp6s0): Enslaving as a backup interface with a 
down link
[3.190106] random: crng init done
[3.315374] bond1: (slave enp5s0): Enslaving as a backup interface with a 
down link
[3.377310] intel_rapl_common: Found RAPL domain package
[3.377890] 

Bug#1064975: RFS: k3conf/0.3-1 [ITP] -- Powerful Diagnostic Tool for Texas Instruments K3 based Processors

2024-04-10 Thread Andrey Rakhmatullin
On Wed, Apr 10, 2024 at 12:39:47PM -0500, Andrew Davis wrote:
> > - debian/k3conf.1 has a *roff warning, lintian also catches it.
> > 
> 
> I don't see this warning, 
W: k3conf: groff-message error: automatically ending diversion 
'an*link-text-div' on exit [usr/share/man/man1/k3conf.1.gz:3]
Are you running lintian on the binary .changes?

> it just shows "maintainer-manual-page" item. Which I know nothing about
You should use lintian-explain-tags(1) to read tag descriptions.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Salvatore Bonaccorso
Control: tags -1 + upstream

Hi,

On Wed, Apr 10, 2024 at 07:00:14PM +0200, Cyril Brulebois wrote:
> Cyril Brulebois  (2024-04-10):
> > Intermediate results based on upstream stable releases: v6.1.80 is good,
> > v6.1.81 is bad. Still ~200 commits to bisect.
> 
> Final results:
> 
> kibi@genova:~/hack/linux.git ((cf33e6ca12d81...)|BISECTING)$ git bisect 
> bad
> cf33e6ca12d814e1be2263cb76960d0019d7fb94 is the first bad commit
> commit cf33e6ca12d814e1be2263cb76960d0019d7fb94
> Author: Mike Christie 
> Date:   Thu Dec 29 13:01:40 2022 -0600
> 
> scsi: core: Add struct for args to execution functions
> 
> [ Upstream commit d0949565811f0896c1c7e781ab2ad99d34273fdf ]
> 
> Move the SCSI execution functions to use a struct for passing in 
> optional
> args. This commit adds the new struct, temporarily converts 
> scsi_execute()
> and scsi_execute_req() ands a new helper, scsi_execute_cmd(), which 
> takes
> the scsi_exec_args struct.
> 
> There should be no change in behavior. We no longer allow users to 
> pass in
> any request->rq_flags value, but they were only passing in RQF_PM 
> which we
> do support by allowing users to pass in the BLK_MQ_REQ flags used by
> blk_mq_alloc_request().
> 
> Subsequent commits will convert scsi_execute() and scsi_execute_req() 
> users
> to the new helpers then remove scsi_execute() and scsi_execute_req().
> 
> Signed-off-by: Mike Christie 
> Reviewed-by: Bart Van Assche 
> Reviewed-by: Christoph Hellwig 
> Reviewed-by: John Garry 
> Signed-off-by: Martin K. Petersen 
> Stable-dep-of: 321da3dc1f3c ("scsi: sd: usb_storage: uas: Access 
> media prior to querying device properties")
> Signed-off-by: Sasha Levin 
> 
>  drivers/scsi/scsi_lib.c| 52 
> ++
>  include/scsi/scsi_device.h | 51 
> -
>  2 files changed, 62 insertions(+), 41 deletions(-)
> 
> 
> That's one of the 3 commits suggested by Diederik, good hunch.
> 
> I know hindsight is always 100% but “There should be no change in
> behavior.”… :D
> 
> Of course, since there are companion changes afterwards, it cannot be
> simply reverted on top of either v6.1.82 (Debian) or v6.1.84 (upstream).
> 
> 
> I'd appreciate if someone could carry the ball through the appropriate
> channels upstream.

Great, thanks a lot for your bisecting work!

Yes, if you prefer to not do the forwarding upstream (stable list, CC
to involved people + regression list), then I can try to take care of
it. Obviously the former would be great, as you are the finder and
have done all the work.

Regards,
Salvatore



Bug#1068769: When removing a package with an entry in /etc/xdg/autostart/ ask the user whether the autostart file should be removed or remove it by default

2024-04-10 Thread mYnDstrEAm
Package: apt
Version: 2.6.1

See 
https://unix.stackexchange.com/questions/774058/shouldnt-files-in-etc-xdg-autostart-be-removed-when-removing-a-package/774068

Please make apt-get remove autostart entries from the /etc/xdg/autostart/ 
folder also if the --purge option is not used. Alternatively, prompt the user 
whether that autostart entry should also be removed.

Many or most users do not know about the --purge option and those who do 
probably don't always know which of all of their packages have an autostart 
entry. There is no command like apt-get clean to remove all dysfunctional 
autostart entries.

Files that cause things to autostart are different from any /etc/ config file 
which just provides some configs if the application is running. Cleaning up 
autostart entries if a software is removed is good practice, improves security, 
and is generally what the user would like to do. If the package is installed 
again, a new autostart entry would or could be created anyway and keeping it 
after removing a package is more likely to cause problems than anything else in 
that case such as the app autostarting twice. It does not make sense to keep 
autostart entries when packages get removed.



Bug#1068768: librdf-query-perl: rqsh fails to run

2024-04-10 Thread Sudip Mukherjee
Package: librdf-query-perl
Version: 2.918-4
Severity: normal

Dear Maintainer,

rqsh fails to run with the error:

$ rqsh 
Can't locate Term/ReadKey.pm in @INC (you may need to install the Term::ReadKey 
module) (@INC entries checked: /etc/perl 
/usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 
/usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 
/usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 
/usr/share/perl/5.38 /usr/local/lib/site_perl) at /usr/bin/rqsh line 14.
BEGIN failed--compilation aborted at /usr/bin/rqsh line 14.


-- 
Regards
Sudip

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.13-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages librdf-query-perl depends on:
ii  libcgi-pm-perl  4.64-1
ii  libdatetime-format-w3cdtf-perl  0.08-1
ii  liberror-perl   0.17029-2
ii  libjson-perl4.1-1
ii  libmodule-pluggable-perl5.2-5
ii  libossp-uuid-perl   1.6.2-1.5+b13
ii  libparse-recdescent-perl1.967015+dfsg-4
ii  librdf-trine-perl   1.019-4
ii  libset-scalar-perl  1.29-3
ii  liburi-perl 5.26-1
ii  perl [libfile-spec-perl]5.38.2-3.2+b2

Versions of packages librdf-query-perl recommends:
ii  libgeo-distance-perl   0.25-3
ii  libgetopt-simple-perl  1.52-7
ii  libwww-perl6.76-1

librdf-query-perl suggests no packages.



Bug#1066359: aview: FTBFS: main.c:30:86: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Gianfranco Costamagna

control: tags -1 patch

diff -Nru aview-1.3.0rc1/debian/changelog aview-1.3.0rc1/debian/changelog
--- aview-1.3.0rc1/debian/changelog 2024-04-01 05:32:50.0 +
+++ aview-1.3.0rc1/debian/changelog 2024-04-10 18:19:03.0 +
@@ -1,3 +1,10 @@
+aview (1.3.0rc1-9.2ubuntu1) noble; urgency=medium
+
+  * debian/patches/no-implicit-declarations.patch: add missing includes.
+Closes: #1066359.
+
+ -- Steve Langasek   Wed, 10 Apr 2024 18:19:03 +
+
 aview (1.3.0rc1-9.2build1) noble; urgency=medium
 
   * No-change rebuild for CVE-2024-3094

diff -Nru aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch 
aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
--- aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
1970-01-01 00:00:00.0 +
+++ aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
2024-04-10 18:18:59.0 +
@@ -0,0 +1,15 @@
+Description: add missing includes
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066359
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: aview-1.3.0rc1/main.c
+===
+--- aview-1.3.0rc1.orig/main.c
 aview-1.3.0rc1/main.c
+@@ -1,3 +1,4 @@
++#include 
+ #include 
+ #include 
+ #include "image.h"
diff -Nru aview-1.3.0rc1/debian/patches/series 
aview-1.3.0rc1/debian/patches/series
--- aview-1.3.0rc1/debian/patches/series2024-02-17 23:14:52.0 
+
+++ aview-1.3.0rc1/debian/patches/series2024-04-10 18:18:13.0 
+
@@ -2,3 +2,4 @@
 01_manpages.patch
 02_tmp_creation.patch
 03_missing_library.patch
+no-implicit-declarations.patch

G.
On Wed, 13 Mar 2024 12:48:02 +0100 Lucas Nussbaum  wrote:

Source: aview
Version: 1.3.0rc1-9.2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I. -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security 
-fcf-protection -I/usr/include -c main.c
> main.c: In function ‘parse_cmdline’:
> main.c:30:86: error: implicit declaration of function ‘exit’ 
[-Werror=implicit-function-declaration]
>30 |   if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) { 
showhelp(argv[0]); exit(0); }
>   |   
   ^~~~
> main.c:6:1: note: include ‘’ or provide a declaration of ‘exit’
> 5 | #include "config.h"
>   +++ |+#include 
> 6 | 
> main.c:30:86: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]

>30 |   if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) { 
showhelp(argv[0]); exit(0); }
>   |   
   ^~~~
> main.c:30:86: note: include ‘’ or provide a declaration of ‘exit’
> main.c:31:66: warning: incompatible implicit declaration of built-in function 
‘exit’ [-Wbuiltin-declaration-mismatch]
>31 |   if (!strcmp(argv[i], "--version")) { showversion(argv[0]); 
exit(0); }
>   |  ^~~~
> main.c:31:66: note: include ‘’ or provide a declaration of ‘exit’
> main.c:33:7: warning: incompatible implicit declaration of built-in function 
‘exit’ [-Wbuiltin-declaration-mismatch]
>33 |   exit(-1);
>   |   ^~~~
> main.c:33:7: note: include ‘’ or provide a declaration of ‘exit’
> main.c: In function ‘main’:
> main.c:49:9: warning: incompatible implicit declaration of built-in function 
‘exit’ [-Wbuiltin-declaration-mismatch]
>49 | exit(-1);
>   | ^~~~
> main.c:49:9: note: include ‘’ or provide a declaration of ‘exit’
> main.c:52:9: warning: incompatible implicit declaration of built-in function 
‘exit’ [-Wbuiltin-declaration-mismatch]
>52 | exit(-1);
>   | ^~~~
> main.c:52:9: note: include ‘’ or provide a declaration of ‘exit’
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:187: main.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/aview_1.3.0rc1-9.2_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results



OpenPGP_signature.asc
Description: 

Bug#1066359: aview: FTBFS: main.c:30:86: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Steve Langasek
Package: aview
Followup-For: Bug #1066359
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developer   https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch 
aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
--- aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
1969-12-31 16:00:00.0 -0800
+++ aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
2024-04-10 11:18:59.0 -0700
@@ -0,0 +1,15 @@
+Description: add missing includes
+Author: Steve Langasek 
+Bug-Debian: https://bugs.debian.org/1066359
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: aview-1.3.0rc1/main.c
+===
+--- aview-1.3.0rc1.orig/main.c
 aview-1.3.0rc1/main.c
+@@ -1,3 +1,4 @@
++#include 
+ #include 
+ #include 
+ #include "image.h"
diff -Nru aview-1.3.0rc1/debian/patches/series 
aview-1.3.0rc1/debian/patches/series
--- aview-1.3.0rc1/debian/patches/series2024-02-17 15:14:52.0 
-0800
+++ aview-1.3.0rc1/debian/patches/series2024-04-10 11:18:13.0 
-0700
@@ -2,3 +2,4 @@
 01_manpages.patch
 02_tmp_creation.patch
 03_missing_library.patch
+no-implicit-declarations.patch


Bug#1068767: php-matthiasmullie-minify: minifycss fails to run

2024-04-10 Thread Sudip Mukherjee
On Wed, Apr 10, 2024 at 06:38:36PM +0100, Sudip Mukherjee wrote:
> Package: php-matthiasmullie-minify
> Version: 1.3.68-6
> Severity: normal
> 
> Dear Maintainer,
> 
> minifycss fails to run with the error:
> 
> $ minifycss 
> PHP Warning:  require_once(/usr/bin/../src/Minify.php): Failed to open 
> stream: No such file or directory in /usr/bin/minifycss on line 10
> PHP Fatal error:  Uncaught Error: Failed opening required 
> '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in 
> /usr/bin/minifycss:10
> Stack trace:
> #0 {main}
>   thrown in /usr/bin/minifycss on line 10

The attached patch should fix the problem.

-- 
Regards
Sudip
diff -Nru matthiasmullie-minify-1.3.68/debian/changelog 
matthiasmullie-minify-1.3.68/debian/changelog
--- matthiasmullie-minify-1.3.68/debian/changelog   2023-07-28 
17:05:19.0 +0100
+++ matthiasmullie-minify-1.3.68/debian/changelog   2024-04-10 
19:00:59.0 +0100
@@ -1,3 +1,10 @@
+matthiasmullie-minify (1.3.68-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix paths of the required files. (Closes: #1068767)
+
+ -- Sudip Mukherjee   Wed, 10 Apr 2024 19:00:59 
+0100
+
 matthiasmullie-minify (1.3.68-4) unstable; urgency=medium
 
   * Team upload.
diff -Nru matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch 
matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch
--- matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch  1970-01-01 
01:00:00.0 +0100
+++ matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch  2024-04-10 
19:00:43.0 +0100
@@ -0,0 +1,36 @@
+Description: Fix paths of the files minify required
+Author: Sudip Mukherjee 
+Forwarded: not-needed
+Last-Update: 2024-04-10
+---
+
+--- matthiasmullie-minify-1.3.68.orig/bin/minifycss
 matthiasmullie-minify-1.3.68/bin/minifycss
+@@ -7,9 +7,9 @@ if (file_exists(__DIR__ . '/../../../aut
+ // if composer install
+ require_once __DIR__ . '/../../../autoload.php';
+ } else {
+-require_once __DIR__ . '/../src/Minify.php';
+-require_once __DIR__ . '/../src/CSS.php';
+-require_once __DIR__ . '/../src/Exception.php';
++require_once __DIR__ . '/../share/php/MatthiasMullie/Minify/Minify.php';
++require_once __DIR__ . '/../share/php/MatthiasMullie/Minify/CSS.php';
++require_once __DIR__ . 
'/../share/php/MatthiasMullie/Minify/Exception.php';
+ }
+ 
+ error_reporting(E_ALL);
+--- matthiasmullie-minify-1.3.68.orig/bin/minifyjs
 matthiasmullie-minify-1.3.68/bin/minifyjs
+@@ -7,9 +7,9 @@ if (file_exists(__DIR__ . '/../../../aut
+ // if composer install
+ require_once __DIR__ . '/../../../autoload.php';
+ } else {
+-require_once __DIR__ . '/../src/Minify.php';
+-require_once __DIR__ . '/../src/JS.php';
+-require_once __DIR__ . '/../src/Exception.php';
++require_once __DIR__ . '/../share/php/MatthiasMullie/Minify/Minify.php';
++require_once __DIR__ . '/../share/php/MatthiasMullie/Minify/CSS.php';
++require_once __DIR__ . 
'/../share/php/MatthiasMullie/Minify/Exception.php';
+ }
+ 
+ error_reporting(E_ALL);
diff -Nru matthiasmullie-minify-1.3.68/debian/patches/series 
matthiasmullie-minify-1.3.68/debian/patches/series
--- matthiasmullie-minify-1.3.68/debian/patches/series  2023-07-28 
17:05:19.0 +0100
+++ matthiasmullie-minify-1.3.68/debian/patches/series  2024-04-10 
18:44:19.0 +0100
@@ -1,3 +1,4 @@
 update_dataDir_to_live_in_proper_dir.patch
 skip_scrapbook_test_if_not_installed.patch
 support_phpunit10.patch
+fix-path.patch


Bug#1065761: m4api: FTBFS on arm{el,hf}: /<>/m4api.c:413:10: error: implicit declaration of function ‘m4SetBinary’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Nick Rosbrook
Package: m4api
Followup-For: Bug #1065761
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to fix the implicit
declarations.

  * debian/patches: fix several implicit declarations (LP: #2060847)


Thanks for considering the patch.

-Nick
diff -Nru 
m4api-0.3~0.9646fd/debian/patches/fix-several-implicit-declarations.patch 
m4api-0.3~0.9646fd/debian/patches/fix-several-implicit-declarations.patch
--- m4api-0.3~0.9646fd/debian/patches/fix-several-implicit-declarations.patch   
1969-12-31 19:00:00.0 -0500
+++ m4api-0.3~0.9646fd/debian/patches/fix-several-implicit-declarations.patch   
2024-04-10 13:41:11.0 -0400
@@ -0,0 +1,27 @@
+Description: Fix several implicit declarations
+Author: Nick Rosbrook 
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2060847
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066290
+Last-Update: 2024-04-10
+--- a/m4api.c
 b/m4api.c
+@@ -391,6 +391,8 @@
+   return 0;
+ }
+ 
++int m4SetBinary(m4Handle *dev, struct m4ConfigField *field, char const *val);
++
+ int m4SetFloat(m4Handle *dev, enum m4FieldID fid, float val) {
+   char binary[2];
+   int ival;
+--- a/m4ctl.c
 b/m4ctl.c
+@@ -17,6 +17,8 @@
+  */
+ 
+ #include 
++#include 
++#include 
+ #include 
+ 
+ #include "m4api.h"
diff -Nru m4api-0.3~0.9646fd/debian/patches/series 
m4api-0.3~0.9646fd/debian/patches/series
--- m4api-0.3~0.9646fd/debian/patches/series1969-12-31 19:00:00.0 
-0500
+++ m4api-0.3~0.9646fd/debian/patches/series2024-04-10 13:40:41.0 
-0400
@@ -0,0 +1 @@
+fix-several-implicit-declarations.patch


Bug#1064975: RFS: k3conf/0.3-1 [ITP] -- Powerful Diagnostic Tool for Texas Instruments K3 based Processors

2024-04-10 Thread Andrew Davis

On 4/5/24 2:13 PM, Andrey Rakhmatullin wrote:

I have several suggestions for this:
- Can you provide debian/watch? It should be possible.


Okay, I'll add a watch file.


- debian/k3conf.1 has a *roff warning, lintian also catches it.



I don't see this warning, it just shows "maintainer-manual-page"
item. Which I know nothing about, the help link it generates points
to a site[0] that has down for about 6 months now[1][2]..

Andrew

[0] https://lintian.debian.org/tags/maintainer-manual-page
[1] https://lists.debian.org/debian-devel/2023/11/msg00171.html
[2] https://salsa.debian.org/mentors.debian.net-team/debexpo/-/issues/160



Bug#872381: dpkg-dev: optimize Makefile snippets for debian/rules

2024-04-10 Thread Nicolas Boulenguez
The attached version
fixes the spacing issue in tests with a more readable trick,
splits the changes inside tests into small chunks,
replaces - with _ in Make variable names,
avoids non portable -r -E sed options.

Without -r, sed in {buildflags,pkg-info}.mk should cause no
regression.  It has been present in pkg-info.mk since 2011.
>From 5b3d75fb604dae497406f19073d03ea094da8d07 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Wed, 10 Apr 2024 00:41:42 +0200
Subject: [PATCH 01/10] scripts/t/mk/buildflags.mk: fix test of _MAINT_APPEND
 when TEST_ is empty

When TEST_CPPFLAGS is empty, the right hand side of the comparison
starts with a space character.
---
 scripts/t/mk/buildflags.mk | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/scripts/t/mk/buildflags.mk b/scripts/t/mk/buildflags.mk
index 94d85a7e0..7cf798f73 100644
--- a/scripts/t/mk/buildflags.mk
+++ b/scripts/t/mk/buildflags.mk
@@ -1,5 +1,8 @@
 DEB_CPPFLAGS_MAINT_APPEND = -DTEST_MK=test-host
+TEST_CPPFLAGS+= -DTEST_MK=test-host
+
 DEB_CPPFLAGS_FOR_BUILD_MAINT_APPEND = -DTEST_MK=test-build
+TEST_CPPFLAGS_FOR_BUILD+= -DTEST_MK=test-build
 
 include $(srcdir)/mk/buildflags.mk
 
@@ -8,8 +11,8 @@ test:
 	test "$(ASFLAGS_FOR_BUILD)" = "$(TEST_ASFLAGS_FOR_BUILD)"
 	test "$(CFLAGS)" = "$(TEST_CFLAGS)"
 	test "$(CFLAGS_FOR_BUILD)" = "$(TEST_CFLAGS_FOR_BUILD)"
-	test "$(CPPFLAGS)" = "$(TEST_CPPFLAGS) -DTEST_MK=test-host"
-	test "$(CPPFLAGS_FOR_BUILD)" = "$(TEST_CPPFLAGS_FOR_BUILD)-DTEST_MK=test-build"
+	test "$(CPPFLAGS)" = "$(TEST_CPPFLAGS)"
+	test "$(CPPFLAGS_FOR_BUILD)" = "$(TEST_CXXFLAGS_FOR_BUILD)"
 	test "$(CXXFLAGS)" = "$(TEST_CXXFLAGS)"
 	test "$(CXXFLAGS_FOR_BUILD)" = "$(TEST_CXXFLAGS_FOR_BUILD)"
 	test "$(DFLAGS)" = "$(TEST_DFLAGS)"
-- 
2.39.2

>From 53aeebafeb2af84369df3b7d81ff1cbcc1e13a9d Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez 
Date: Wed, 10 Apr 2024 00:09:43 +0200
Subject: [PATCH 02/10] scripts/t/mk: use loops instead of repetitions

---
 scripts/t/mk/architecture.mk | 54 +---
 scripts/t/mk/buildflags.mk   | 39 --
 scripts/t/mk/buildtools.mk   | 54 +++-
 3 files changed, 61 insertions(+), 86 deletions(-)

diff --git a/scripts/t/mk/architecture.mk b/scripts/t/mk/architecture.mk
index 2ac0222ca..b146f34b7 100644
--- a/scripts/t/mk/architecture.mk
+++ b/scripts/t/mk/architecture.mk
@@ -1,36 +1,22 @@
 include $(srcdir)/mk/architecture.mk
 
-test:
-	test "$(DEB_BUILD_ARCH)" = "$(TEST_DEB_BUILD_ARCH)"
-	test "$(DEB_BUILD_ARCH_ABI)" = "$(TEST_DEB_BUILD_ARCH_ABI)"
-	test "$(DEB_BUILD_ARCH_BITS)" = "$(TEST_DEB_BUILD_ARCH_BITS)"
-	test "$(DEB_BUILD_ARCH_CPU)" = "$(TEST_DEB_BUILD_ARCH_CPU)"
-	test "$(DEB_BUILD_ARCH_ENDIAN)" = "$(TEST_DEB_BUILD_ARCH_ENDIAN)"
-	test "$(DEB_BUILD_ARCH_LIBC)" = "$(TEST_DEB_BUILD_ARCH_LIBC)"
-	test "$(DEB_BUILD_ARCH_OS)" = "$(TEST_DEB_BUILD_ARCH_OS)"
-	test "$(DEB_BUILD_GNU_CPU)" = "$(TEST_DEB_BUILD_GNU_CPU)"
-	test "$(DEB_BUILD_GNU_SYSTEM)" = "$(TEST_DEB_BUILD_GNU_SYSTEM)"
-	test "$(DEB_BUILD_GNU_TYPE)" = "$(TEST_DEB_BUILD_GNU_TYPE)"
-	test "$(DEB_BUILD_MULTIARCH)" = "$(TEST_DEB_BUILD_MULTIARCH)"
-	test "$(DEB_HOST_ARCH)" = "$(TEST_DEB_HOST_ARCH)"
-	test "$(DEB_HOST_ARCH_ABI)" = "$(TEST_DEB_HOST_ARCH_ABI)"
-	test "$(DEB_HOST_ARCH_BITS)" = "$(TEST_DEB_HOST_ARCH_BITS)"
-	test "$(DEB_HOST_ARCH_CPU)" = "$(TEST_DEB_HOST_ARCH_CPU)"
-	test "$(DEB_HOST_ARCH_ENDIAN)" = "$(TEST_DEB_HOST_ARCH_ENDIAN)"
-	test "$(DEB_HOST_ARCH_LIBC)" = "$(TEST_DEB_HOST_ARCH_LIBC)"
-	test "$(DEB_HOST_ARCH_OS)" = "$(TEST_DEB_HOST_ARCH_OS)"
-	test "$(DEB_HOST_GNU_CPU)" = "$(TEST_DEB_HOST_GNU_CPU)"
-	test "$(DEB_HOST_GNU_SYSTEM)" = "$(TEST_DEB_HOST_GNU_SYSTEM)"
-	test "$(DEB_HOST_GNU_TYPE)" = "$(TEST_DEB_HOST_GNU_TYPE)"
-	test "$(DEB_HOST_MULTIARCH)" = "$(TEST_DEB_HOST_MULTIARCH)"
-	test "$(DEB_TARGET_ARCH)" = "$(TEST_DEB_TARGET_ARCH)"
-	test "$(DEB_TARGET_ARCH_ABI)" = "$(TEST_DEB_TARGET_ARCH_ABI)"
-	test "$(DEB_TARGET_ARCH_BITS)" = "$(TEST_DEB_TARGET_ARCH_BITS)"
-	test "$(DEB_TARGET_ARCH_CPU)" = "$(TEST_DEB_TARGET_ARCH_CPU)"
-	test "$(DEB_TARGET_ARCH_ENDIAN)" = "$(TEST_DEB_TARGET_ARCH_ENDIAN)"
-	test "$(DEB_TARGET_ARCH_LIBC)" = "$(TEST_DEB_TARGET_ARCH_LIBC)"
-	test "$(DEB_TARGET_ARCH_OS)" = "$(TEST_DEB_TARGET_ARCH_OS)"
-	test "$(DEB_TARGET_GNU_CPU)" = "$(TEST_DEB_TARGET_GNU_CPU)"
-	test "$(DEB_TARGET_GNU_SYSTEM)" = "$(TEST_DEB_TARGET_GNU_SYSTEM)"
-	test "$(DEB_TARGET_GNU_TYPE)" = "$(TEST_DEB_TARGET_GNU_TYPE)"
-	test "$(DEB_TARGET_MULTIARCH)" = "$(TEST_DEB_TARGET_MULTIARCH)"
+vars := \
+  ARCH \
+  ARCH_ABI \
+  ARCH_BITS \
+  ARCH_CPU \
+  ARCH_ENDIAN \
+  ARCH_LIBC \
+  ARCH_OS \
+  GNU_CPU \
+  GNU_SYSTEM \
+  GNU_TYPE \
+  MULTIARCH \
+  # EOL
+loop_targets := $(foreach machine,BUILD HOST TARGET,$(foreach var,$(vars),\
+  DEB_$(machine)_$(var)))
+
+test: $(loop_targets)
+
+$(loop_targets):
+	test "$($@)" = "$(TEST_$@)"
diff --git a/scripts/t/mk/buildflags.mk b/scripts/t/mk/buildflags.mk
index 

Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Holger Levsen
On Wed, Apr 10, 2024 at 06:12:21PM +0100, Chris Lamb wrote:
> Holger Levsen wrote:
> 
> > when building libscout 2.3.2-3 on current unstable, the result is also 
> > unreproducible, but diffoscope crashes when analysing the diff.
> I think this is somewhat related to:
>   https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/362
> … which was said to be fixed by Fay in 
> cc3b077f6ef97b4e20036e9823926fe633c7d4d0
> that released as diffoscope version 263 on 2024-04-05.
> However, I can see that the current output of libscout/amd64 on
> tests.reproducible-builds.org is failing with this very version:

yes, indeed.

also, this happened before too, I'm sure about at least with diffoscope 260 
already.
 
> Will loop Fay in via Salsa presently.

thank you!


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Fischers Fritz fischt Plastik.


signature.asc
Description: PGP signature


Bug#1068767: php-matthiasmullie-minify: minifycss fails to run

2024-04-10 Thread Sudip Mukherjee
Package: php-matthiasmullie-minify
Version: 1.3.68-6
Severity: normal

Dear Maintainer,

minifycss fails to run with the error:

$ minifycss 
PHP Warning:  require_once(/usr/bin/../src/Minify.php): Failed to open stream: 
No such file or directory in /usr/bin/minifycss on line 10
PHP Fatal error:  Uncaught Error: Failed opening required 
'/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in 
/usr/bin/minifycss:10
Stack trace:
#0 {main}
  thrown in /usr/bin/minifycss on line 10


-- 
Regards
Sudip

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.13-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages php-matthiasmullie-minify depends on:
ii  php-cli2:8.2+93
ii  php-common 2:93
ii  php-matthiasmullie-path-converter  1.1.3-2
ii  php8.2-cli [php-cli]   8.2.17-1+b1

php-matthiasmullie-minify recommends no packages.

Versions of packages php-matthiasmullie-minify suggests:
pn  php-psr-cache-implementation  



Bug#1053409: qtwebengine-opensource-src: FTBFS with re2 >= 20230601 (which requires abseil)

2024-04-10 Thread Soren Stoutner
Control: tags -1 patch

I created a merge request at:

https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/merge_requests/
26[1]

-- 
Soren Stoutner
so...@debian.org


[1] https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/merge_requests/
26


signature.asc
Description: This is a digitally signed message part.


Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Cyril Brulebois
Cyril Brulebois  (2024-04-10):
> Of course, since there are companion changes afterwards, it cannot be
> simply reverted on top of either v6.1.82 (Debian) or v6.1.84 (upstream).
> 
> 
> I'd appreciate if someone could carry the ball through the appropriate
> channels upstream.

And of course I only spotted minutes after sending the previous mail
that v6.1.85 got published while I was busy bisecting. It's also
affected by this bug.

For the sake of completeness: except for the initial report, all tests
were performed with the “SATA disk in a VM” setup described in my first
follow-up.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Bug#1053409: qtwebengine-opensource-src: FTBFS with re2 >= 20230601 (which requires abseil)

2024-04-10 Thread Soren Stoutner
As Chromium has supported the updated RE2 since around 116, that will likely be 
included 
in the Qt WebEngine 6.7.0 release.

https://wiki.qt.io/QtWebEngine/ChromiumVersions[1]

It is unlikely to ever make it back to Qt WebEngine 5.15.x.

Currently, Qt WebEngine 6 has switched to building against the embedded copy of 
RE2, 
which can be reverted once 6.7.0 is packaged.

https://salsa.debian.org/qt-kde-team/qt6/qt6-webengine/-/commit/
d4ea2d870d0db1afc9c16668bf537f8fac28f3d7[2]

I think I will make a similar adjustment to Qt WebEngine 5, but without the 
plan to ever 
switch it back as Qt WebEngine 5 is reaching end-of-life.

-- 
Soren Stoutner
so...@debian.org


[1] https://wiki.qt.io/QtWebEngine/ChromiumVersions
[2] https://salsa.debian.org/qt-kde-team/qt6/qt6-webengine/-/commit/
d4ea2d870d0db1afc9c16668bf537f8fac28f3d7


signature.asc
Description: This is a digitally signed message part.


Bug#1068705: diffoscope crashes on libscout 2.3.2-3 build on unstable but not bullseye

2024-04-10 Thread Chris Lamb
Holger Levsen wrote:

> when building libscout 2.3.2-3 on current unstable, the result is also 
> unreproducible, but diffoscope crashes when analysing the diff.

I think this is somewhat related to:

  https://salsa.debian.org/reproducible-builds/diffoscope/-/issues/362

… which was said to be fixed by Fay in cc3b077f6ef97b4e20036e9823926fe633c7d4d0
that released as diffoscope version 263 on 2024-04-05.

However, I can see that the current output of libscout/amd64 on
tests.reproducible-builds.org is failing with this very version:

  Tue Apr  9 12:14:14 UTC 2024  I: diffoscope 263 will be used to compare the 
two builds:

  From https://gist.github.com/lamby/e5db96d4d61612485a469b826590192e/raw
  (saved output for posterity)

Will loop Fay in via Salsa presently.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-



Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Cyril Brulebois
Cyril Brulebois  (2024-04-10):
> Intermediate results based on upstream stable releases: v6.1.80 is good,
> v6.1.81 is bad. Still ~200 commits to bisect.

Final results:

kibi@genova:~/hack/linux.git ((cf33e6ca12d81...)|BISECTING)$ git bisect bad
cf33e6ca12d814e1be2263cb76960d0019d7fb94 is the first bad commit
commit cf33e6ca12d814e1be2263cb76960d0019d7fb94
Author: Mike Christie 
Date:   Thu Dec 29 13:01:40 2022 -0600

scsi: core: Add struct for args to execution functions

[ Upstream commit d0949565811f0896c1c7e781ab2ad99d34273fdf ]

Move the SCSI execution functions to use a struct for passing in 
optional
args. This commit adds the new struct, temporarily converts 
scsi_execute()
and scsi_execute_req() ands a new helper, scsi_execute_cmd(), which 
takes
the scsi_exec_args struct.

There should be no change in behavior. We no longer allow users to pass 
in
any request->rq_flags value, but they were only passing in RQF_PM which 
we
do support by allowing users to pass in the BLK_MQ_REQ flags used by
blk_mq_alloc_request().

Subsequent commits will convert scsi_execute() and scsi_execute_req() 
users
to the new helpers then remove scsi_execute() and scsi_execute_req().

Signed-off-by: Mike Christie 
Reviewed-by: Bart Van Assche 
Reviewed-by: Christoph Hellwig 
Reviewed-by: John Garry 
Signed-off-by: Martin K. Petersen 
Stable-dep-of: 321da3dc1f3c ("scsi: sd: usb_storage: uas: Access media 
prior to querying device properties")
Signed-off-by: Sasha Levin 

 drivers/scsi/scsi_lib.c| 52 
++
 include/scsi/scsi_device.h | 51 
-
 2 files changed, 62 insertions(+), 41 deletions(-)


That's one of the 3 commits suggested by Diederik, good hunch.

I know hindsight is always 100% but “There should be no change in
behavior.”… :D

Of course, since there are companion changes afterwards, it cannot be
simply reverted on top of either v6.1.82 (Debian) or v6.1.84 (upstream).


I'd appreciate if someone could carry the ball through the appropriate
channels upstream.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Bug#1068578: RFH: singularity-container -- container platform focused on supporting "Mobility of Compute"

2024-04-10 Thread Nilesh Patra
On Mon, Apr 08, 2024 at 08:59:26AM +0300, Andrius Merkys wrote:
> On 2024-04-07 15:28, Nilesh Patra wrote:
> > Assistance required with maintaining the singularity-container package.
> 
> I am not offering help with singularity-container, but do you by any chance
> know why apptainer is not packaged for Debian? I cannot find a wnpp bug.

I am lazy to find references right now, but you should be able to find it in
debian-hpc and debian-devel archives. If I don't miss anything this was the
sequence of events:

1) While updating singularity-container, Andreas created a repo for apptainer on
salsa.
2) The goal at that time was to get a mobility compute (either apptainer or
singularity) up and running
3) singularity and apptainer codebases are in sync so as per my understanding
there's no real point in having *both* - here's a brief discussion about it[1]

My opinion: It does not make a lot of sense to package apptainer as well.
Although the latter is "community" maintained, the codebases for
sylabs/singularity and apptainer are in close sync at most times which also
means they keep inheriting CVEs from each other too.

As a result one may not be able to maintain apptainer well in stable release
either unless they have:
a) Good/Great go programming skills
b) ability to deal with CVEs and backports

I'd like to just link to a similar discussion thread about the same rather than
repeating the points[2] and here's what upstream says[3].

What do you think?

[1]: https://lists.debian.org/debian-hpc/2022/08/msg00021.html
[2]: https://lists.debian.org/debian-devel/2023/01/msg00078.html
[3]: https://lists.debian.org/debian-devel/2023/01/msg00080.html

Best,
Nilesh


signature.asc
Description: PGP signature


Bug#1066379: loqui: FTBFS: loqui-core-gtk.gob:256:25: error: implicit declaration of function ‘account_list_dialog_open_for_connect’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Nick Rosbrook
Package: loqui
Followup-For: Bug #1066379
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

This FTBFS is due to a missing include of account_list_dialog.h. In
Ubuntu we applied this patch to fix it.

  * debian/patches: fix implicit declaration of
account_list_dialog_open_for_connect


Thanks for considering the patch.

-Nick
diff -Nru 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch
--- 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch 
1969-12-31 19:00:00.0 -0500
+++ 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch 
2024-04-10 11:51:39.0 -0400
@@ -0,0 +1,16 @@
+Description: Fix implicit declaration of account_list_dialog_open_for_connect
+ The account_list_dialog.h header needs to be included for this.
+Author: Nick Rosbrook 
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/loqui/+bug/2060834
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066379
+Last-Update: 2024-04-10
+--- a/src/loqui-core-gtk.gob
 b/src/loqui-core-gtk.gob
+@@ -63,6 +63,7 @@
+ #include "loqui_stock.h"
+ #include "prefs_general_upgrader.h"
+ #include "loqui-notifier-gtk.h"
++#include "account_list_dialog.h"
+ 
+ %}
+ 
diff -Nru loqui-0.7.0/debian/patches/series loqui-0.7.0/debian/patches/series
--- loqui-0.7.0/debian/patches/series   2021-08-14 23:24:56.0 -0400
+++ loqui-0.7.0/debian/patches/series   2024-04-10 11:47:31.0 -0400
@@ -1 +1,2 @@
 0001-Add-missing-Makefile.in.patch
+0002-add-missing-include-account_list_dialog.h.patch


Bug#1068766: RM: maude [i386 armhf armel] -- ROM; Unsuitable for release on 32-bit archs

2024-04-10 Thread Nilesh Patra
Package: ftp.debian.org
Severity: normal
X-Debbugs-Cc: ma...@packages.debian.org, ti...@debian.org, 
sramac...@debian.org, debian-...@lists.debian.org
Control: affects -1 + src:maude
User: ftp.debian@packages.debian.org
Usertags: remove

Hi,

maude FTBFS on 32-bit archs and the temporary fix will explode at some point
due to Y2038. This is due to gmp not having proper support for 32-bits.

As was a concensus on -med, there's some agreement to remove 32-bit support for
end-user applications since no-one uses med packages on these archs[1].

The maintainer/uploader of maude also agreed to the removal on 32-bit archs for 
this
package in[2]

[1]: https://lists.debian.org/debian-med/2024/03/msg00032.html
[2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067957#46



Bug#1066507: closed by Debian FTP Masters (reply to Guillem Jover ) (Bug#1066507: fixed in kannel 1.4.5-14)

2024-04-10 Thread Guillem Jover
Hi!

On Sat, 2024-03-16 at 01:12:07 +, Debian Bug Tracking System wrote:
> This is an automatic notification regarding your Bug report
> which was filed against the src:kannel package:
> 
> #1066507: kannel: FTBFS: configure: error: Either get a multithread-enabled 
> SSL or configure with --disable-ssl
> 
> It has been closed by Debian FTP Masters  
> (reply to Guillem Jover ).

Just sending keep-alive mail to avoid the auto-removal, as the bug is
already fixed in sid, but not migrating due to the time64 transition.

Thanks,
Guillem



Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Cyril Brulebois
Cyril Brulebois  (2024-04-10):
> v6.1.84 with stable's .config & bindeb-pkg still does; next up for me:
> confirming good/bad and bisecting.

Intermediate results based on upstream stable releases: v6.1.80 is good,
v6.1.81 is bad. Still ~200 commits to bisect.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Bug#1067911: FTBFS: error: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ [-Werror]

2024-04-10 Thread Chris Knadle



On 4/10/24 10:02, Andrey Rakhmatullin wrote:

On Wed, Apr 10, 2024 at 09:52:44AM -0400, Chris Knadle wrote:

Removing -Werror looks like it would be a simple patch, it seems to be set
here:

config/Make.rules.Linux:cppflags    = -Wall -Wextra -Wredundant-decls
-Wshadow -Wdeprecated -Werror -pthread $(if $(filter
yes,$(OPTIMIZE)),-DNDEBUG,-g)

... but this also doesn't sound like the right answer.

Yes, it just turns the error into a warning, it's still better to remove
the problem that causes this warning, but it's *also* better to not use
-Werror when building Debian packages.


That's probably true.

I've made a patch to do this, I'll do a test build and then upload an NMU.

   -- Chris

--
Chris Knadle
chris.kna...@coredump.us



Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Diederik de Haas
On Wednesday, 10 April 2024 15:32:02 CEST Cyril Brulebois wrote:
> Cyril Brulebois  (2024-04-10):
> > Salvatore Bonaccorso  (2024-04-10):
> > > On Tue, Apr 09, 2024 at 03:33:09PM +0200, Diederik de Haas wrote:
> > > > Does the problem go away if you revert the following commits on top of
> > > > -19?
> > > > 
> > > > db6338f45971b4285ea368432a84033690eaf53c
> > > > scsi: core: Move scsi_host_busy() out of host lock for waking up EH
> > > > handler
> > > > 
> > > > 1ebd75cefaac6fd74729a7d3157f6eaa59960ae2
> > > > scsi: core: Move scsi_host_busy() out of host lock if it is for
> > > > per-command
> > > > 
> > > > cf33e6ca12d814e1be2263cb76960d0019d7fb94
> > > > scsi: core: Add struct for args to execution functions
> > 
> > Preparing that test right now, thanks Diederik.
> 
> This doesn't build, but I didn't try very hard:
> 
> /home/kibi/debian-kernel/linux.git/drivers/scsi/sd.c: In function
> ‘sd_read_block_zero’:
> /home/kibi/debian-kernel/linux.git/drivers/scsi/sd.c:3300:9: error:
> implicit declaration of function ‘scsi_execute_cmd’; did you mean
> ‘scsi_execute_req’? [-Werror=implicit-function-declaration]

Then it got troublesome even earlier then I expected ;-)
If you do `gitk -- drivers/scsi/` on 'master', then you'll see a huge list of 
recent commits ... which probably didn't get backported all ...
A lot of them landed in 6.8.

That Salvatore could confirm the issue should help.

Good luck,
  Diederik

signature.asc
Description: This is a digitally signed message part.


Bug#1067957: [[maude-bugs]] [EXTERNAL] Re: Maude fails to build on armhf

2024-04-10 Thread Andreas Tille
Hi,

I'd suggest to set

  Build-Depends: architecture-is-64-bit, architecture-is-little-endian

and remove 32bit architectures of maude.

Kind regards
   Andreas.

-- 
https://fam-tille.de



Bug#1068765: calibre: dependency on node-mathjax-full required?

2024-04-10 Thread gregor herrmann
Package: calibre
Version: 7.8.0+ds1-1
Severity: minor

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512


calibre 7.8.0+ds1-1 has acquired a hard dependency on node-mathjax-full
(and indirectly on nodejs and 8 other node packages), installing some
100MB.

In my understanding, mathjax is used for typesetting mathetical
formulars in ebooks, and I guess that's not what most calibre users
do regularly.

Would a be a possibility to move node-mathjax-full from Depends to
Recommends, so that user have the option to not install a whole new
ecosystem on their machines?

Thanks for considering,
gregor

-BEGIN PGP SIGNATURE-

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmYWpyVfFIAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgZSZBAAtcOIgD79UWvY0Vwnd6dOOmAGHYazc8JoMntYCWM9u+dskXiFjW+ZKGOU
YrKONVdfTN3Py5N63g2pYqEloVuF8AVXZUMNAhlv7CjGx6bhFrK0Ma+Od3+98N9+
UoiOeSNl5FsWe8rijeBzfoi+SrN9JYI7L4C+tSRobaFgcLyAug7t80YW0hEdIbag
qxtz+l8XH0iwRB5MOMbsbtZAw+GFTr5DoKAG6UX+ltRzoVVwj/fm+Co9zsoHvAs5
15xpMV05VZmleoVButhyD0Iy0UrkIuhohet360o454kIzRkI9ttsKAZuBBAqL8b7
dWFRA+VJU57hDe93AaQnc9JcV7A8zuxLloxx34aUOKZJRR5AoHTFPCTGS0qGti5m
+9905pvj/INuugVgW2SF7uEf0VvShTcEiI613aHGtz/+gMqtq7ObiXuAaVokNtFl
Hed8myZBnSl2be3zQcVo38BKpKYOhYBESc/jOeChBBN3b/FKU1EfBCL/DLVlTxZ6
Glbg1+73L/lIz/cLC+eEcWsMT/xu+x+m9lbK9WcHmpGO2CdiW87Ki+1YyKcpQNP7
7JwJmFcBnTtrrmapJ7nV9d+4lRxGMvVaqfGsc0sxBgeX/Oh1de/h6TOoN9RZshrX
ralQZSPUlhIRV7DGlUf/c1uyu4RRqFd1L2E92qOyRADmyWfAu38=
=TMFU
-END PGP SIGNATURE-



Bug#1068764: RFP: nginx-module-vts -- Nginx virtual host traffic status module

2024-04-10 Thread Antoine Beaupre
Package: wnpp
Severity: wishlist
X-Debbugs-Cc: pkg-nginx-maintain...@alioth-lists.debian.net

* Package name: nginx-module-vts
  Version : 0.2.2
  Upstream Contact: YoungJoo.Kim 
* URL : https://github.com/vozlt/nginx-module-vts
* License : BSD-2
  Programming Lang: C
  Description : Nginx virtual host traffic status module

This is an Nginx module that provides access to virtual host status
information. It contains the current status such as servers,
upstreams, caches. This is similar to the live activity monitoring of
nginx plus. The built-in html is also taken from the demo page of old
version.



This module provides more in-depth stats than the ones provided by the
built-in statistics module, crippled by its opencore/non-free
counterpart only available in nginx plus.

There's already another nginx exporter in Debian, but it proxies (and
rewrites) the requests to the builtin stats module, with limited
effect. It cannot, for example, count bytes or examine hit ratios, nor
per-vhost usage stats.

I'm not sure I'm going to package this myself, and I don't know if it
should be shipped alongside nginx-full: it seems to me it would be
better as its own standalone module, would love to hear thoughts from
the nginx maintainers as well..

I would definitely need this at torproject.org. We're using nginx more
and more, and the stats we're able to extract from the components
available in debian pale in comparison with what we have in the apache
exporter, for example.



Bug#1068763: [Pkg-utopia-maintainers] Bug#1068763: upower: Please update to 1.90.4

2024-04-10 Thread Jeremy Bícha
Control: tags -1 -moreinfo

On Wed, Apr 10, 2024 at 9:57 AM Michael Biebl  wrote:
>
> Control: tags -1 + moreinfo
>
> Am 10.04.2024 um 15:38 schrieb Jeremy Bícha:
> > Source: upower
> > Version: 1.90.3-1
> > Severity: wishlist
> > X-Debbugs-CC: bi...@debian.org
> >
> > Please update upower to 1.90.4. It was released yesterday with a fix
> > for a significant disk write/ CPU use issue.
> >
> > https://gitlab.freedesktop.org/upower/upower/-/releases/v1.90.4
>
> I might be mistaken, but 1.90.4 is just 1.90.3 with NEWS updated?
> https://gitlab.freedesktop.org/upower/upower/-/compare/v1.90.3...v1.90.4?from_project_id=139=false

Yeah that looks correct. Thank you for checking.

Jeremy Bícha



Bug#1068675: linux-image-6.1.0-19-amd64: loss of SMART information: Device is in SLEEP mode, exit(2)

2024-04-10 Thread Cyril Brulebois
Salvatore Bonaccorso  (2024-04-10):
> 6.7.9-2 in unstable does not exibit the issue.

v6.1.84 with stable's .config & bindeb-pkg still does; next up for me:
confirming good/bad and bisecting.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Bug#1067911: FTBFS: error: ‘-Werror=’ argument ‘-Werror=implicit-function-declaration’ is not valid for C++ [-Werror]

2024-04-10 Thread Andrey Rakhmatullin
On Wed, Apr 10, 2024 at 09:52:44AM -0400, Chris Knadle wrote:
> > > Apparently this new bug got introduced with the time_t 64bit transition:
> > Yes, but it's a valid bug in the package, not a bad thing accidentally
> > introduced by the transition.
> That doesn't sound right.
> The zeroc-ice source code does not set the
> '-Werror=implicit-function-declaration' build option.
Yes, Debian sets that.

> I think these two lines in debian/rules in the package are where CFLAGS get
> set:
> 
> 
>    DPKG_EXPORT_BUILDFLAGS = 1
>    include /usr/share/dpkg/default.mk
> 
> In other words, whatever bug this is seems to be due to a change in
> reasonable default configs from Debian, not in the source.
The change that led to this FTBFS is of course a change in Debian, not in
the package, but the FTBFS happens because flags from CFLAGS set by Debian
are used to compile C++ code.
Compare `dpkg-buildflags --get CFLAGS` and
`dpkg-buildflags --get CXXFLAGS`.

> From examining the source, zeroc-ice doesn't set CFLAGS when building with
> Linux.The source of CFLAGS being set seems to be set by dpkg-buildflags
Of course.

> Removing -Werror looks like it would be a simple patch, it seems to be set
> here:
> 
> config/Make.rules.Linux:cppflags    = -Wall -Wextra -Wredundant-decls
> -Wshadow -Wdeprecated -Werror -pthread $(if $(filter
> yes,$(OPTIMIZE)),-DNDEBUG,-g)
> 
> ... but this also doesn't sound like the right answer.
Yes, it just turns the error into a warning, it's still better to remove
the problem that causes this warning, but it's *also* better to not use
-Werror when building Debian packages.

> But clearing CFLAGS seems like it would be reasonable.
I cannot call that reasonable.

-- 
WBR, wRAR


signature.asc
Description: PGP signature


Bug#1068708: Building with EPICS fails because the compiler cannot find `compilerSpecific.h`.

2024-04-10 Thread Andrius Merkys

Hi Florian,

On 2024-04-10 16:40, Florian Forster wrote:
pkg-config references paths (/build/reproducible-path/…) that likely 
exist on the build system, but are not provided by the package:


```
# pkg-config epics-base --cflags | sed -e 's/  */\n/g'
-I/build/reproducible-path/epics-base-7.0.8+dfsg1/include
-I/build/reproducible-path/epics-base-7.0.8+dfsg1/include/os/Linux
-I/build/reproducible-path/epics-base-7.0.8+dfsg1/include/compiler/gcc
-D_GNU_SOURCE
-D_DEFAULT_SOURCE
-D_X86_64_
-DUNIX
-Dlinux
-ffile-prefix-map=/build/reproducible-path/epics-base-7.0.8+dfsg1=.
-D_FORTIFY_SOURCE=2
-ffile-prefix-map=/build/reproducible-path/epics-base-7.0.8+dfsg1=.
-fstack-protector-strong
-fstack-clash-protection
-fcf-protection
-D_FORTIFY_SOURCE=2
-mtune=generic
-m64
# dpkg -L epics-dev | grep /build; echo $?
1
```


You are right - this has been reported as bug #1059706 and marked as 
fixed since, although incorrect paths apparently were left in 
epics-base.pc. I have reopened #1059706 to deal with that.


Unrelated to this bug: my recommendation would be to keep the CPP flags 
(`-I`, `-D`) and remove the C flags (`-f`, `-m`).


It seems that EPICS straightforwardly puts its build flags to 
epics-base.pc. Many of these flags are specific to EPICS build and 
should not be used for reverse-dependencies.



What compiler do you use?


We test our project with GCC and clang.


OK, thanks.


Does this patch work for you?


Kind of. It fixes the compiler specific include described in the initial 
report, but fails to find an OS specific include:


```
In file included from /usr/include/epics/cadef.h:35,
                  from src/epics.c:26:
/usr/include/epics/epicsThread.h:468:10: fatal error: osdThread.h: No 
such file or directory

   468 | #include "osdThread.h"
       |          ^
```


Can you as well try to add /usr/include/compiler/gcc to your compiler's include 
path?


That path alone is not enough, but this works:

```
make CPPFLAGS="-I/usr/include/epics -I/usr/include/epics/compiler/gcc 
-I/usr/include/epics/os/Linux"

```


I guess that both /usr/include/epics/os/Linux/ and 
/usr/include/epics/compiler/gcc/ should be in the include path. Thus the 
following should work on GCC without patching EPICS code:


make CPPFLAGS="-I/usr/include/epics -I/usr/include/epics/compiler/gcc 
-I/usr/include/epics/os/Linux"


I wonder why clang cannot work with compilerSpecific.h. Most likely it 
contains GCC-specific instructions.


I think a viable solution for clang would be to create an empty file in 
/usr/include/epics/compiler/clang/compilerSpecific.h (no compiler 
specific settings for clang) and use include paths to indicate the used 
compiler, for clang:


make CPPFLAGS="-I/usr/include/epics -I/usr/include/epics/compiler/clang 
-I/usr/include/epics/os/Linux"


However, this should better be discussed with the upstream. They may 
want to automatically identify the compiler using __GNUC__ and similar 
checks.



Thanks for your time and effort maintaining this package, I appreciate it!


Thank you for the report!

Best wishes,
Andrius



Bug#1068763: [Pkg-utopia-maintainers] Bug#1068763: upower: Please update to 1.90.4

2024-04-10 Thread Michael Biebl

Control: tags -1 + moreinfo

Am 10.04.2024 um 15:38 schrieb Jeremy Bícha:

Source: upower
Version: 1.90.3-1
Severity: wishlist
X-Debbugs-CC: bi...@debian.org

Please update upower to 1.90.4. It was released yesterday with a fix
for a significant disk write/ CPU use issue.

https://gitlab.freedesktop.org/upower/upower/-/releases/v1.90.4


I might be mistaken, but 1.90.4 is just 1.90.3 with NEWS updated?
https://gitlab.freedesktop.org/upower/upower/-/compare/v1.90.3...v1.90.4?from_project_id=139=false





OpenPGP_signature.asc
Description: OpenPGP digital signature


  1   2   >