Bug#956112: RFS: eggdrop/1.8.4-3 -- Advanced IRC Robot
Hi Adam, Thank you very much for your feedback! I have fixed all the issues you listed and uploaded an updated package to mentors: - https://mentors.debian.net/package/eggdrop - https://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.8.4-1.dsc > The package is marked as UNRELEASED, and uploading that would cause an > autoreject. Distribution changed to "unstable". > The changelog entry from 11 Aug 2014 is overwritten with a bunch of > UNRELEASED entries. This shows some confusion. Past changelog entries are > supposed to be immutable other than for corrections. These were all the not uploaded releases (lived only in mentors), there has been quite a few. I have reimported the published changelog and added a single 1.8.4-1 entry with all changes since 2014. > dh-missing complains about a lot of files installed into staging dirs but > not put anywhere into actual packages. dh_missing warnings fixed, they were due to documentation files taken from source directory instead of installed package. Regards -- Cédric
Bug#928786: eggdrop FTCBFS: multiple minor issues
tags 928786 + pending stop Hi Helmut, First of all sorry it took me so long to answer. Both issues have been fixed upstream and are packaged for a long time, but I don't have upload rights and could not find a sponsor since the release of eggdrop 1.8.0 (packaged in Feb 2017), despite a few contacts with debian developers and one RFS (closed without notification because the package had been removed from mentors). The up-to-date package is available on mentors.debian.net : https://mentors.debian.net/package/eggdrop https://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.8.4-3.dsc Regards -- Cédric May 11, 2019 7:42 AM, "Helmut Grohne" wrote: > Source: eggdrop > Version: 1.6.21-4 > Tags: patch upstream > User: helm...@debian.org > Usertags: rebootstrap > > eggdrop fails to cross build from source for two reasons: > > * It uses AC_RUN_IFELSE with a wrong cross guess to check whether > socklen_t exists. > > A better solution is using AC_CHECK_TYPE here. > > * It insists on running eggdrop -v during build. > > It simply should not do that as it does not contribute to the build > in any way. > > The attached patch fixes both. Please consider applying it. > > Helmut
Bug#956112: RFS: eggdrop/1.8.4-3 -- Advanced IRC Robot
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "eggdrop" * Package name : eggdrop Version : 1.8.4-3 Upstream Author : EggHeads Development Team * URL : http://www.eggheads.org * License : GPL-2+ * Vcs : https://github.com/yastupin/eggdrop-debian Section : net It builds those binary packages: eggdrop - Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: https://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.8.4-3.dsc Changes since the last upload: * New upstream version 1.8.4 * patches - remove 03openssl_checks (fixed upstream) - refresh patches * fix some lintian warnings - use debhelper 12 - enable hardening flags (+all) - remove autotools-dev and dh-autoreconf dependencies - update to standards version 4.3.0 - add override for compress.so hardening * debian/watch - use https - ignore rc releases in debian/watch * rename NEWS and UPGRADING files * add Vcs-Git and Vcs-Browser to control * use dh_autoreconf Regards -- Cédric
Bug#919916: RFS: eggdrop/1.8.4-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "eggdrop" * Package name : eggdrop Version : 1.8.4-1 Upstream Author : Eggheads Development Team * URL : https://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop - Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: https://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.8.4-1.dsc More information about eggdrop can be obtained from https://www.eggheads.org/ Changes since the last upload: * New upstream version 1.8.4 * patches - remove 03openssl_checks (fixed upstream) - refresh patches * fix some lintian warnings - use debhelper 10 - enable hardening flags - remove autotools-dev and dh-autoreconf dependencies * debian/watch - use https - ignore rc releases in debian/watch * rename NEWS and UPGRADING files * add Vcs-Git and Vcs-Browser to control Build log on travis : https://travis-ci.org/yastupin/eggdrop-debian/builds/482084985 Regards, -- Cédric Barboiron
Bug#908235: O: wnpp - Work-Needing and Prospective Packages
Hi, September 7, 2018 6:42 PM, "Sebastian Tobie" wrote: > Package: eggdrop > Severity: normal > > since 2011 the package eggdrop was not updated and bugs were not fixed. 2016 > the upstream developer > released a new minor Version where many issues which where reported to Debian > were fixed. The package has been updated and reworked in 2014, with the latest and final 1.6.x release: 1.6.21 (included in jessie). The 1.8.x series was still in beta for etch's freeze, but an updated version (1.8.3 currently) has been available here: https://mentors.debian.net/package/eggdrop . I will definitely seek a mentor to upload it when the buster's freeze will approach. If anyone with upload rights wants to adopt this package for faster updates, I'm totally open to the idea. Regards -- Cédric
Bug#374568: fixed upstream
tag 374568 + upstream quit Fixed by upstream in the 1.8 series. Currently available at https://mentors.debian.net/package/eggdrop, will be uploaded when sponsored.
Bug#782494: puppet: Non-ASCII user realnames cause encoding errors when running with a UTF-8 locale
Hi, Here is the updated patch that has been merged upstream: https://github.com/puppetlabs/puppet/pull/3977 Regards -- Cédric 0001-PUP-4633-fix-non-ASCII-user-comment-with-ruby-2.1.patch Description: Binary data
Bug#782494: puppet: Non-ASCII user realnames cause encoding errors when running with a UTF-8 locale
There is an upstream bug : https://tickets.puppetlabs.com/browse/PUP-4633 0001-fix-again-22703-for-ruby-2.1.0.patch Description: Binary data
Bug#782494: puppet: Non-ASCII user realnames cause encoding errors when running with a UTF-8 locale
tags 782494 + patch thanks Hi, This is indeed related to upstream bug #22703. The fix to this bug is no longer needed, since ruby Etc module now handles encoding correctly (from ruby 2.1.0) commit 4c009414119347e87d9bb2402617a4585dd3f341 Author: nobu nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e Date: Sat Aug 3 00:46:10 2013 + etc.c: encodings * ext/etc/etc.c (setup_passwd, setup_group): set proper encodings to string members. Test with the following user : useradd -c 'éèéù' test Just before this commit (at 042e5013a3bc42a3637aa1646e9fc002436b852f) : ruby -retc -e 'p Etc.getpwnam(test).gecos.encoding' #Encoding:ASCII-8BIT At commit 4c009414119347e87d9bb2402617a4585dd3f341 : ruby -retc -e 'p Etc.getpwnam(test).gecos.encoding' #Encoding:UTF-8 The following patch has been tested successfully on wheezy and jessie. Regards -- Cédric From f13f102622725283264fb80fc0d4679692edacda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Barboiron?= c...@winkie.fr Date: Thu, 28 May 2015 14:30:05 +0200 Subject: [PATCH] fix again #22703 for ruby = 2.1.0 --- lib/puppet/type/user.rb | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/puppet/type/user.rb b/lib/puppet/type/user.rb index 12c4250..9e18f98 100644 --- a/lib/puppet/type/user.rb +++ b/lib/puppet/type/user.rb @@ -170,8 +170,10 @@ module Puppet newproperty(:comment) do desc A description of the user. Generally the user's full name. - munge do |v| -v.respond_to?(:force_encoding) ? v.force_encoding(Encoding::ASCII_8BIT) : v + if RUBY_VERSION 2.1.0 +munge do |v| + v.respond_to?(:force_encoding) ? v.force_encoding(Encoding::ASCII_8BIT) : v +end end end -- 2.1.0
Bug#774748: patch
Hi,
I've tried to write a patch for the very specific issue in this CVE.
The regex used is derived from the one used in redmine
(https://github.com/redmine/redmine/blob/master/lib/redcloth3.rb#L818).
Package built with this patch (in pbuilder) and succesfully tested against the
PoC in http://co3k.org/blog/redcloth-unfixed-xss-en
As a side note, I would not be able to patch redcloth for a more complex issue
or anything in the ragel layer.
Regards
Description: fix for CVE-2012-6684
Author: Cédric Barboiron c...@winkie.fr
--- a/lib/redcloth/formatters/html.rb
+++ b/lib/redcloth/formatters/html.rb
@@ -111,14 +111,17 @@
end
def link(opts)
-a href=\#{escape_attribute
opts[:href]}\#{pba(opts)}#{opts[:name]}/a
+href = escape_uri(escape_attribute(opts[:href]))
+a href=\#{href}\#{pba(opts)}#{opts[:name]}/a
end
def image(opts)
opts.delete(:align)
opts[:alt] = opts[:title]
-img = img src=\#{escape_attribute opts[:src]}\#{pba(opts)}
alt=\#{escape_attribute opts[:alt].to_s}\ /
-img = a href=\#{escape_attribute opts[:href]}\#{img}/a if
opts[:href]
+src = escape_uri(escape_attribute(opts[:src]))
+href = escape_uri(escape_attribute(opts[:href])) if opts[:href]
+img = img src=\#{src}\#{pba(opts)} alt=\#{escape_attribute
opts[:alt].to_s}\ /
+img = a href=\#{href}\#{img}/a if href
img
end
@@ -267,6 +270,22 @@
def escape_attribute(text)
html_esc(text, :html_escape_attributes)
end
+
+ # fix for CVE-2012-6684
+ def escape_uri(uri)
+# escape only if filter_html is enabled
+return uri unless filter_html
+
+# accept every scheme://*
+# allow only mailto:*
+# accept all other uri
+m = %r{^([a-zA-Z]+):(?!//)}.match uri
+return uri unless m m[1] != 'mailto'
+
+# unwanted uri (e.g. javascript:*)
+# prefix by '#'
+'#' uri
+ end
def after_transform(text)
text.chomp!
--- a/spec/fixtures/filter_html.yml
+++ b/spec/fixtures/filter_html.yml
@@ -175,3 +175,18 @@
---
in: /me 3 beer
filtered_html: p/me lt;3 beer/p
+---
+name: CVE-2012-6684
+in: |-
+ [clickme:javascript:alert(%27XSS%27)]
+filtered_html: pa href=#javascript:alert(%27XSS%27)clickme/a/p
+---
+name: legit http link
+in: |-
+ [clickme:http://example.com]
+filtered_html: pa href=http://example.com;clickme/a/p
+---
+name: legit mailto link
+in: |-
+ [clickme:mailto:u...@example.com]
+filtered_html: pa href=mailto:u...@example.com;clickme/a/p
Bug#762573: initramfs: refuses to boot if a device in conf.d/cryptroot is missing
Package: cryptsetup
Version: 2:1.6.6-1
Tags: patch
Hi,
I'm booting on 4 encrypted devices, opened as LVM PVs, and use the LVM
mirroring feature for the LVs (including rootfs).
Trying to boot with a missing drive triggers the 'panic -r ALERT!
${cryptsource} does not exist. Dropping to a shell!' error, although it is
possible to boot without this device. (Especially in my case where the missing
device had no LV segment at all anymore.)
I propose the attached patch to skip the device if we exit the shell without
fixing the problem, instead of looping in the panic shell.
Regards
--
Cédric
diff --git a/cryptroot-script b/cryptroot-script
index 414f882..6aea503 100644
--- a/cryptroot-script
+++ b/cryptroot-script
@@ -222,11 +222,16 @@ setup_mapping()
udev_settle
# We've given up, but we'll let the user fix matters if they can
- while [ ! -e ${cryptsource} ]; do
+ if [ ! -e ${cryptsource} ]; then
+ echo ALERT! ${cryptsource} does not exist.
echo Check cryptopts=source= bootarg: cat /proc/cmdline
echo or missing modules, devices: cat /proc/modules; ls /dev
- panic -r ALERT! ${cryptsource} does not exist. Dropping to a shell!
- done
+ panic -r Dropping to a shell. Will skip ${cryptsource} if you can't fix.
+ fi
+
+ if [ ! -e ${cryptsource} ]; then
+ return 1
+ fi
# Prepare commands
cryptopen=/sbin/cryptsetup -T 1
Bug#757881: RFS: eggdrop/1.6.21-4
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-4 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-4.dsc Changes since the last upload: * clang-ftbfs.diff: - Fix FTBFS with clang-3.5 (Closes: #757400) - Apply patch from Arthur Marble, thank you! Regards, Cédric Barboiron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757881: RFS: eggdrop/1.6.21-4
Oops, forgot to add following info to the RFS template : - uploaded package built with up-to-date pbuilder - successfully compiled with clang (by hand, `CC=clang debuild` is not compiling with clang) - separately built for wheezy (with tcl-8.5) and now running fine a real eggdrop bot -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757400: eggdrop: FTBFS with clang instead of gcc
tag -1 + pending stop Hello Arthur, Thanks for the bug report and your proposed patch. It builds ok here with both gcc and clang. I'll fix the open_listen header (src/proto.h) as well and check all inline functions before updating the package to ensure this bug is properly fixed. Should be done this week. Regards -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#753531: apt-get clean executes 'rm /*' if Dir::Cache is set to
On Thu, 3 Jul 2014 08:59:57 +0200
Michael Vogt m...@debian.org wrote:
Thanks for your bugreport.
(warning: attached patch is not a solution, it is just intended to
show the problem)
Setting Dir::Cache::archives and Dir::Cache to the empty string (as
instructed by man 5 apt.conf) do NOT disable cache but set it to
'/'.
Consequence: apt-get clean then effectively cleans '/' and removes
all files here.
Not true anymore but even worse, on squeeze it also removes the
'/lib64' symlink, breaking the loader and preventing any new
dynamically linked binary to be launched.
This sounds like we want to improve the description of the apt.conf
manpage. I assume your use-case was to disable the binary cache? Maybe
you can suggest a way to make the description clearer to avoid the
issue for others?
As for protecting against this, I attached a patch that makes clean a
bit more careful and fix the example where Dir::Cache::archives= is
empty. But there is only so much we can do, e.g. if someone sets
Dir::Cache=/vmlinuz its hard to have a programmatic way to detect that
this is a bad idea. But I'm happy to protect against obvious ones
(like Clean(/)).
Hi Michael, and thanks for your answer.
The use-case was indeed to disable the bin cache. Your patch is a good
protection against misreading the manual. Btw, I tried with '/dev/null'
only because it is handled differently in configuration.cc, I don't
think it's useful to protect against this.
For the manpage, I believe changing their names and empty string
to the actual values would be clear enough (attached patch).
Regards
--
Cédric
diff --git a/doc/apt.conf.5.xml b/doc/apt.conf.5.xml
index fcbf20d..ffecc6c 100644
--- a/doc/apt.conf.5.xml
+++ b/doc/apt.conf.5.xml
@@ -608,10 +608,11 @@ DPkg::Pre-Install-Pkgs {/usr/sbin/dpkg-preconfigure --apt;};
information, such as the two package caches literalsrcpkgcache/literal and
literalpkgcache/literal as well as the location to place downloaded archives,
literalDir::Cache::archives/literal. Generation of caches can be turned off
- by setting their names to the empty string. This will slow down startup but
- save disk space. It is probably preferable to turn off the pkgcache rather
- than the srcpkgcache. Like literalDir::State/literal the default
- directory is contained in literalDir::Cache/literal/para
+ by setting literalpkgcache/literal or literalsrcpkgcache/literal to
+ literal/literal. This will slow down startup but save disk space. It
+ is probably preferable to turn off the pkgcache rather than the srcpkgcache.
+ Like literalDir::State/literal the default directory is contained in
+ literalDir::Cache/literal/para
paraliteralDir::Etc/literal contains the location of configuration files,
literalsourcelist/literal gives the location of the sourcelist and
Bug#753531: apt-get clean executes 'rm /*' if Dir::Cache is set to
Package: apt
Version: 1.0.5
Severity: important
(warning: attached patch is not a solution, it is just intended to show
the problem)
Setting Dir::Cache::archives and Dir::Cache to the empty string (as
instructed by man 5 apt.conf) do NOT disable cache but set it to '/'.
Consequence: apt-get clean then effectively cleans '/' and removes all
files here.
Not true anymore but even worse, on squeeze it also removes the '/lib64'
symlink, breaking the loader and preventing any new dynamically linked
binary to be launched.
- - -
all following tests done on debian testing, up to date on 2014-07-02
current result:
debdev# cat apt.conf
Dir::Cache ;
Dir::Cache::archives ;
debdev# touch /VERY_SECRET
debdev# ls /
bin boot dev etc home initrd.img initrd.img.old lib lib64 lost+found
media mnt opt proc root run sbin srv sys tmp usr var VERY_SECRET
vmlinuz vmlinuz.old
debdev# apt-get clean
debdev# ls /
bin boot dev etc home lib lib64 lock lost+found media mnt opt proc
root run sbin srv sys tmp usr var
reading source code (contrib/configuration.cc) instead of the man page of
apt.conf:
debdev# cat apt.conf
Dir::Cache /dev/null;
Dir::Cache::archives /dev/null;
debdev# touch /VERY_SECRET
debdev# ls /
bin boot dev etc home lib lib64 lock lost+found media mnt opt proc
root run sbin srv sys tmp usr var VERY_SECRET
debdev# apt-get clean
debdev# ls /
bin boot dev etc home lib lib64 lock lost+found media mnt opt proc
root run sbin srv sys tmp usr var VERY_SECRET
expected result, BUT BUT BUT its not a good idea at all :
debdev# cat /etc/apt/apt.conf
Dir::Cache /dev/null;
Dir::Cache::archives /dev/null;
debdev# ls -l /dev/null
crw-rw-rw- 1 root root 1, 3 Jul 2 20:11 /dev/null
debdev# apt-get install libcaca
Reading package lists... Error!
E: Write error - write (28: No space left on device)
E: Can't mmap an empty file
E: Failed to truncate file - ftruncate (9: Bad file descriptor)
E: The package lists or status file could not be parsed or opened.
debdev# ls -l /dev/null
-rw-r--r-- 1 root root 0 Jul 2 20:17 /dev/null
debdev# df -h
Filesystem Size Used Avail Use% Mounted on
/dev/mapper/debdev-root 95G 5.0G 85G 6% /
udev 10M 10M 0 100% /dev
tmpfs202M 200K 201M 1% /run
tmpfs5.0M 0 5.0M 0% /run/lock
tmpfs403M 0 403M 0% /run/shm
/dev/sda1228M 80M 137M 37% /boot
none 4.0K 0 4.0K 0% /sys/fs/cgroup
and finally with attached patch (built without make test because it has other
side-effects):
debdev# cat /etc/apt/apt.conf
Dir::Cache ;
Dir::Cache::archives ;
debdev# touch /MYTRALALA
debdev# ls /
bin dev home lib64 lost+found mntopt root sbin sys usr
boot etc lib lock media MYTRALALA proc run srv tmp var
debdev# apt-get clean
E: Ignored empty string directory configuration (would have been expanded to
'/' otherwise)
debdev# ls /
bin dev home lib64 lost+found mntopt root sbin sys usr
boot etc lib lock media MYTRALALA proc run srv tmp var
diff --git a/apt-pkg/contrib/configuration.cc b/apt-pkg/contrib/configuration.cc
index 00f6ad0..3dd63aa 100644
--- a/apt-pkg/contrib/configuration.cc
+++ b/apt-pkg/contrib/configuration.cc
@@ -240,6 +240,11 @@ string Configuration::FindFile(const char *Name,const char *Default) const
string Configuration::FindDir(const char *Name,const char *Default) const
{
string Res = FindFile(Name,Default);
+ if (Res == )
+ {
+ _error-Error(_(Ignored empty string directory configuration (would have been expanded to '/' otherwise)));
+ return Res;
+ }
if (Res.end()[-1] != '/')
{
size_t const found = Res.rfind(/dev/null);
diff --git a/doc/apt.conf.5.xml b/doc/apt.conf.5.xml
index fcbf20d..e30898c 100644
--- a/doc/apt.conf.5.xml
+++ b/doc/apt.conf.5.xml
@@ -607,8 +607,8 @@ DPkg::Pre-Install-Pkgs {/usr/sbin/dpkg-preconfigure --apt;};
paraliteralDir::Cache/literal contains locations pertaining to local cache
information, such as the two package caches literalsrcpkgcache/literal and
literalpkgcache/literal as well as the location to place downloaded archives,
- literalDir::Cache::archives/literal. Generation of caches can be turned off
- by setting their names to the empty string. This will slow down startup but
+ literalDir::Cache::archives/literal. Generation of caches CANNOT BE TURNED OFF.
+ This would slow down startup but could
save disk space. It is probably preferable to turn off the pkgcache rather
than the srcpkgcache. Like literalDir::State/literal the default
directory is contained in literalDir::Cache/literal/para
Bug#750618: eggdrop FTBFS on arm64 outdated config.sub/guess
On Thu, Jun 05, 2014 at 03:50:55AM +0100, peter green wrote: infinity plugwash: Changing to this seems to work for me: infinity dh $@ --with autotools_dev,autoreconf Thanks for both reporting the bug and providing a solution! I've uploaded an updated package to the mentors archive : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-3.dsc Do you have some time to upload it to unstable or should I create a new request for sponsorship? -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
On Sun, 18 May 2014 20:03:41 -0700 Vincent Cheng vch...@debian.org wrote: Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and tried to use dh-autoreconf properly. You can find the updated package at the same place : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc - Why does debian/control now have Build-Conflicts: autoconf2.13, automake1.4? - debian/source/options should be unnecessary (dh-autoreconf takes care of removing/restoring autotools cruft before/after build) For these two points I only applied autotools-dev/README (after learning its existence at https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-autotools ): The autoconf2.13 package diverts autoconf, autoheader and autoreconf from the autoconf package to autoconf2.50, autoheader2.50 and autoreconf2.50. You must make sure you are not depending on the existence of the diverted scripts. The automake packages provide alternatives for the automake command, with increased priority for newer versions. There is one exception: the automake1.4 package provides a higher priority alternative for the automake command than the newer automake packages. and Reducing the annoyance factor with diffs: By adding a suitable extend-diff-ignore option to debian/source/options, one can instruct dpkg-source to ignore config.sub, config.guess, and any other autogenerated files (such as Makefile when autoconf is used, Makefile and Makefile.in when automake is used, etc). For example, you could use: extend-diff-ignore=(^|/)(config\.sub|config\.guess|Makefile)$ I'm not able to say if these tips should be followed in this particular case. Would you like me do any more changes? Regards -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
On Sat, 17 May 2014 16:02:29 -0700 Vincent Cheng vch...@debian.org wrote: * debian/patches/03fix_freebsd_build: - use $CC in SHLIB_LD (instead of hardcoded ld) Why are you patching automatically generated files (configure, in this case)? I'm certainly not an autotools expert, but can't you patch aclocal.m4 instead and then run autoreconf (or rather, use dh-autoreconf) afterwards? Hi Vincent, Thanks for your feedback. You're right, and indeed my first local patch was against aclocal.m4. But it did introduce automake + autoconf as build dependencies (we were using upstream configure before), and was getting more complicated than a one-line fix to build on kfreebsd. I agree that it is not a good excuse. Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and tried to use dh-autoreconf properly. You can find the updated package at the same place : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc I successfully built it on amd64 with pbuilder and on a fresh kfreebsd-amd64 install. Regards -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#748476: RFS: eggdrop/1.6.21-2
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-2 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * debian/patches/03fix_freebsd_build: - use $CC in SHLIB_LD (instead of hardcoded ld) Regards, Cédric Barboiron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Hi Vincent, Thanks for your comments again. On Sun, 20 Apr 2014 01:33:17 -0700 Vincent Cheng vch...@debian.org wrote: - Your package FTBFS with pbuilder (full build log attached): checking for Tcl library... not found Fixed. According to http://eggwiki.org/Bugs/Tcl8.6 , eggdrop versions =1.6.20 have no particular bugs with tcl8.6, so I use it instead of 8.5. - According to debian/changelog, eggdrop was split into two separate binary packages (an additional -data package) as of 1.6.16-3, so as per Policy 7.6.1 [1], consider adding Breaks: eggdrop ( 1.6.16-3) and Replaces: eggdrop ( 1.6.16-3) relationships to your eggdrop-data binary package, otherwise dpkg will error out on updates from eggdrop 1.6.16-3 to the current eggdrop package. This would usually qualify as a RC bug, but since 1.6.16-3 was released about 10 years ago, you could possibly get away with not doing this (I don't think piuparts.debian.org tests package upgrades from 10 years back...) True, same comment and drop solution was suggested here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698599#12 So to avoid any further confusion I add the Breaks+Replaces 1.6.16-3. - debian/copyright: please give src/rfc1459.c some kind of license name on line 40. Also, the current header in that file isn't really a license...if at all possible, I'd suggest adding the license of the corresponding source file from ircd-hybrid into debian/copyright. I listed rfc1459.c as the original ircd-hybrid 5.3 match.c license (GPL-1+) with the current rfc1459.c header as a comment. I believe (and hope) that the package is now correct and incremented the version to 1.6.21-2 so that there is no confusion with the different -1 attempts. You can find it here : http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc PS: Lintian reports error debian-watch-file-pubkey-file-is-missing but it's a lintian bug now fixed (#736711) Regards, -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Hi Vincent and Markus, Thanks for your comments on the package. I've updated the package with copyright information for - src/compat/gnu_strftime.c (LGPL-2+) - src/compat/inet_aton.c (GPL-2+ and BSD-4-clause and BSD-3-clause, with comment for the University of California BSD-4-clause portion) As well as the following files (different authors): - src/match.c (public domain) - src/compat/snprintf.c (GPL-2+) - src/md5/md5c.c (public domain) - scripts/dccwhois.tcl (GPL-2+) Finally, I've excluded the only two files with no license information from the package : scripts/autobotchk and scripts/sentinel.tcl You can find the updated package at the same place http://mentors.debian.net/package/eggdrop http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-1.dsc A quick note on the remaining open bugs: - #282437 wasn't able to reproduce (but since it is almost 10 years old...) - #596641 the UTF-8 patch indeed is simple, but it is labeled as I want Eggdrop to speak and understand UTF-8. I want it so badly that I'm willing to take the ugliest hack available! on http://eggwiki.org/Main_Page . It comes from http://forum.egghelp.org/viewtopic.php?p=82111#82111 , with the following comment : BE AWARE: This patch FORCES UTF-8 support, so only apply it if your system supports it :) [This patch overrides eggdrops own mechanism to detect the encoding system it should use based on variables (LC_ALL,...). So this is totally a HACK and nothing to put into production code for compatibility reasons] - #374568 for the same reasons as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=374568#17 Regards, -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#698272: eggdrop: ITA
retitle 698272 ITA: eggdrop -- Advanced IRC RobotControl owner 698272 ! thanks Hi, I've been working on the eggdrop package and have uploaded an updated package in the mentors archive (https://mentors.debian.net/package/eggdrop). Here is a summary of the changes : - new upstream release 1.6.21 - build with dh9 - fix almost all lintian warnings - closes bugs #650718 #724986 #668091 #661572 -- Cédric -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: RFS: eggdrop/1.6.21-1 [ITA #698272]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package eggdrop * Package name: eggdrop Version : 1.6.21-1 Upstream Author : EggHeads Development Team egghe...@eggheads.org * URL : http://www.eggheads.org/ * License : GPL-2+ Section : net It builds those binary packages: eggdrop- Advanced IRC Robot eggdrop-data - Architecture independent files for eggdrop To access further information about this package, please visit the following URL: http://mentors.debian.net/package/eggdrop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-1.dsc Changes since the last upload: * New upstream release: - debian/patches/00conf_paths.patch: updated - debian/patches/gcc-format-string-warnings: updated - debian/patches/01tcl8.5.10.patch: fixed upstream - debian/eggdrop.install: don't use hardcoded version anymore - Closes: #650718 * debian/compat: update to level 9 * debian/control: - set maintainer to Cédric Barboiron - use latest Standards-Version - add debhelper9 and autotools-dev dependencies - remove cdbs dependency * debian/rules: - switch to debhelper 9 format - Closes: #724986 as a side effect * debian/copyright: use copyright-format 1.0 * debian/watch: version 3, plus check pgp signature * debian/patches/01use_ldflags.patch: propagate LDFLAGS for eggdrop and modules (Closes: #668091) * debian/patches/02language_dir.patch: set default language directory (Closes: #661572) Regards, -- Cédric Barboiron -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#740543: minor update
Hi, I've uploaded an updated version with two minor changes : * debian/control: drop the Replaces field for eggdrop-data (according to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698599#12 ) * debian/changelog: Closes ITA #698272 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
