Bug#1052011: iscsitarget-dkms: Module fails to compile

2023-09-15 Thread TimW
Package: iscsitarget-dkms
Version: 1.4.20.3+svn502-2
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: t...@tee-jay.org.uk

Dear Maintainer,

Trying to install this package dkms fails to compile the module


make.log is as follows:
DKMS make.log for iscsitarget-1.4.20.3+svn502 for kernel 6.1.21+ (armv7l)
Fri 15 Sep 23:04:56 BST 2023
make: Entering directory '/usr/src/linux-headers-6.1.21+'
  CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/tio.o
  CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/iscsi.o
  CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/nthread.o
  CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/wthread.o
In file included from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/nthread.c:16:
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/iscsi.h:274:19: error: 
field ‘rx_hash’ has incomplete type
  274 |  struct hash_desc rx_hash;
  |   ^~~
In file included from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/tio.c:7:
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/iscsi.h:274:19: error: 
field ‘rx_hash’ has incomplete type
  274 |  struct hash_desc rx_hash;
  |   ^~~
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/iscsi.h:275:19: error: 
field ‘tx_hash’ has incomplete type
  275 |  struct hash_desc tx_hash;
  |   ^~~
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/iscsi.h:275:19: error: 
field ‘tx_hash’ has incomplete type
  275 |  struct hash_desc tx_hash;
  |   ^~~
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/nthread.c: In function 
‘iscsi_conn_init_read’:
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/nthread.c:45:17: error: 
‘struct msghdr’ has no member named ‘msg_iov’; did you mean ‘msg_inq’?
   45 |  conn->read_msg.msg_iov = conn->read_iov;
  | ^~~
  | msg_inq
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/nthread.c:46:16: error: 
‘struct msghdr’ has no member named ‘msg_iovlen’
   46 |  conn->read_msg.msg_iovlen = 1;
  |^
In file included from ./include/linux/kernel.h:26,
 from ./include/linux/cpumask.h:10,
 from ./include/linux/smp.h:13,
 from ./include/linux/lockdep.h:14,
 from ./include/linux/spinlock.h:63,
 from ./include/linux/wait.h:9,
 from ./include/linux/wait_bit.h:8,
 from ./include/linux/fs.h:6,
 from ./include/linux/highmem.h:5,
 from ./include/linux/bvec.h:10,
 from ./include/linux/blk_types.h:10,
 from ./include/linux/blkdev.h:9,
 from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/iscsi.h:11,
 from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/tio.c:7:
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/tio.c: In function 
‘tio_add_data’:
./include/linux/minmax.h:20:28: warning: comparison of distinct pointer types 
lacks a cast
   20 |  (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
  |^~
./include/linux/minmax.h:26:4: note: in expansion of macro ‘__typecheck’
   26 |   (__typecheck(x, y) && __no_side_effects(x, y))
  |^~~
./include/linux/minmax.h:36:24: note: in expansion of macro ‘__safe_cmp’
   36 |  __builtin_choose_expr(__safe_cmp(x, y), \
  |^~
./include/linux/minmax.h:45:19: note: in expansion of macro ‘__careful_cmp’
   45 | #define min(x, y) __careful_cmp(x, y, <)
  |   ^
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/tio.c:75:25: note: in 
expansion of macro ‘min’
   75 |  const size_t to_copy = min(tio->pg_cnt * PAGE_SIZE - iter->size, len);
  | ^~~
./include/linux/minmax.h:20:28: warning: comparison of distinct pointer types 
lacks a cast
   20 |  (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
  |^~
./include/linux/minmax.h:26:4: note: in expansion of macro ‘__typecheck’
   26 |   (__typecheck(x, y) && __no_side_effects(x, y))
  |^~~
./include/linux/minmax.h:36:24: note: in expansion of macro ‘__safe_cmp’
   36 |  __builtin_choose_expr(__safe_cmp(x, y), \
  |^~
./include/linux/minmax.h:45:19: note: in expansion of macro ‘__careful_cmp’
   45 | #define min(x, y) __careful_cmp(x, y, <)
  |   ^
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/tio.c:82:18: note: in 
expansion of macro ‘min’
   82 |   size_t chunk = min(PAGE_SIZE - iter->pg_off, residual);
  |  ^~~
In file included from 
/var/lib/dkms/iscsitarget/1.4.20.3+svn502/build/kernel/wthread.c:9:

Bug#1006789: iptables-restore fails unless -v ior -n flag is specified

2022-03-04 Thread timw
Package: iptables
Version: 1.8.7-1
Severity: normal
Tags: ipv6
X-Debbugs-Cc: t...@tee-jay.org.uk

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
As root attempting to restore a trivial tables config from a file written by 
iptables-save over a completely flushed table

   * What exactly did you do (or not do) that was effective (or
 ineffective)?
Ran the following command:
iptables-restore /etc/iptables/rules.v4

   * What was the outcome of this action?
The following messages were seen on stdout/stderr:
iptables-restore v1.8.7 (nf_tables): 
line 10: CHAIN_ADD failed (Device or resource busy): chain INPUT
line 10: CHAIN_UPDATE failed (Device or resource busy): chain INPUT
line 10: CHAIN_ADD failed (Device or resource busy): chain FORWARD
line 10: CHAIN_UPDATE failed (Device or resource busy): chain FORWARD
line 10: CHAIN_ADD failed (Device or resource busy): chain OUTPUT
line 10: CHAIN_UPDATE failed (Device or resource busy): chain OUTPUT
line 10: RULE_APPEND failed (No such file or directory): rule in chain INPUT
line 10: RULE_APPEND failed (No such file or directory): rule in chain INPUT
line 10: RULE_APPEND failed (No such file or directory): rule in chain INPUT
line 10: RULE_APPEND failed (No such file or directory): rule in chain INPUT
Tables were not populated with any of the contents of the file.

   * What outcome did you expect instead?
Tables to be populated with the contents of the file.


Workaround found while troubleshooting is that when running the same command 
but with the --verbose flag set the tables are correctly populated with the
contents of the file and the following output on stdout/stderr:
# Generated by iptables-save v1.8.7 on Fri Mar  4 00:51:20 2022
Flushing chain `INPUT'
Flushing chain `FORWARD'
Flushing chain `OUTPUT'
# Completed on Fri Mar  4 00:51:20 2022

ip6tables-restore behaves in the same way. 

Using --noflush instead of --verbose also works but with tables not flushed
first (this is to be expected).


iptables-restore is linked as follows on this system:

/usr/sbin/iptables-restore
  v
/etc/alternatives/iptables-restore
  v
/usr/sbin/iptables-nft-restore
  v
xtables-nft-multi
  

*** End of the template - remove these template lines ***


-- System Information:
Debian Release: 11.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0 (SMP w/1 CPU thread)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages iptables depends on:
ii  libc62.31-13+deb11u2
ii  libip4tc21.8.7-1
ii  libip6tc21.8.7-1
ii  libmnl0  1.0.4-3
ii  libnetfilter-conntrack3  1.0.8-3
ii  libnfnetlink01.0.1-3+b1
ii  libnftnl11   1.1.9-1
ii  libxtables12 1.8.7-1
ii  netbase  6.3

Versions of packages iptables recommends:
pn  nftables  

Versions of packages iptables suggests:
pn  firewalld  
ii  kmod   28-1

-- no debconf information