Bug#1065944: squeak-plugins-scratch: FTBFS on arm{el,hf}: WeDoLinux.c:175:9: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]

2024-04-15 Thread Zixing Liu 
Package: squeak-plugins-scratch
Followup-For: Bug #1065944
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/add-missing-include.patch: Add a missing header to
fix build on armhf.  (Closes #1065944, LP: #2061587).
  * debian/control: Add quilt to B-D as this is previously missing.


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), 
(100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru squeak-plugins-scratch-1.4.0.2~svn.r83/debian/control 
squeak-plugins-scratch-1.4.0.2~svn.r83/debian/control
--- squeak-plugins-scratch-1.4.0.2~svn.r83/debian/control   2024-03-08 
00:00:18.0 -0700
+++ squeak-plugins-scratch-1.4.0.2~svn.r83/debian/control   2024-04-15 
10:23:53.0 -0600
@@ -1,8 +1,8 @@
 Source: squeak-plugins-scratch
 Section: devel
 Priority: optional
 Maintainer: Miriam Ruiz 
-Build-Depends: debhelper, dh-buildinfo,
+Build-Depends: debhelper, dh-buildinfo, quilt,
  libcairo2-dev (>= 1.8.6), libpango1.0-dev (>= 1.24.1),
  libglib2.0-dev (>= 2.20.1), libv4l-dev (>= 0.5.8)
 Standards-Version: 4.2.1.4
diff -Nru 
squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/add-missing-include.patch 
squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/add-missing-include.patch
--- 
squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/add-missing-include.patch 
1969-12-31 17:00:00.0 -0700
+++ 
squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/add-missing-include.patch 
2024-04-15 10:23:10.0 -0600
@@ -0,0 +1,19 @@
+Description: Add a missing header to fix build on armhf
+Author: Zixing Liu 
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065944
+Bug-Ubuntu: 
https://bugs.launchpad.net/ubuntu/+source/squeak-plugins-scratch/+bug/2061587
+Forwarded: no
+Last-Update: 2024-04-15
+---
+Index: squeak-plugins-scratch/wedo/WeDoLinux.c
+===
+--- squeak-plugins-scratch.orig/wedo/WeDoLinux.c
 squeak-plugins-scratch/wedo/WeDoLinux.c
+@@ -37,6 +37,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ #include 
+ 
+ 
diff -Nru squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/series 
squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/series
--- squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/series
1969-12-31 17:00:00.0 -0700
+++ squeak-plugins-scratch-1.4.0.2~svn.r83/debian/patches/series
2024-04-15 10:17:28.0 -0600
@@ -0,0 +1 @@
+add-missing-include.patch

Bug#1065944: squeak-plugins-scratch: FTBFS on arm{el,hf}: WeDoLinux.c:175:9: error: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Werror=implicit-function-declaration]

2024-03-10 Thread Sebastian Ramacher 
Source: squeak-plugins-scratch
Version: 1.4.0.2~svn.r83-3.1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past)
X-Debbugs-Cc: sramac...@debian.org

https://buildd.debian.org/status/fetch.php?pkg=squeak-plugins-scratch=armel=1.4.0.2%7Esvn.r83-3.1%2Bb1=1710056636=0

cd wedo/ && \
arm-linux-gnueabi-gcc -std=gnu89 -g -O2 
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat 
-Werror=format-security -g -fPIC -c *.c
WeDoLinux.c: In function ‘WeDoClosePort’:
WeDoLinux.c:175:9: error: implicit declaration of function ‘close’; did you 
mean ‘pclose’? [-Werror=implicit-function-declaration]
  175 | close(fdWeDo);
  | ^
  | pclose
cc1: some warnings being treated as errors
make: *** [debian/rules:31: build-stamp] Error 1

Cheers
-- 
Sebastian Ramacher