Bug#309129: ripperx does not support titles longer than 30 chars

2005-05-16 Thread tony mancill
Hello Tobias,

Thank you for reporting this problem.  Can you give me an example of what
you're seeing?  Are you saying that a song title longer than 30 characters
creates a tag that looks like this:

   012345678901234567890123456789
songname:  This is a very long song titlexxx
artist:xxxRemainder of Artist Name

Until ripperX has support ID3v2 tags, there will be problems with truncation
of song titles, album, and artist names longer than 30 characters.  I want
to make sure this isn't the problem you're seeing.

MfG,
tony


Tobias Pfeiffer wrote:
 Package: ripperx
 Version: 2.6.4-2
 
 Hi!
 
 I have recently ripped a CD and then encoded into Ogg with ripperx. The
 title names of the songs are quite long, at least longer than 30
 charactes. The filenames of the output files are correct, but in the ID3
 tags of the ogg files, after 30 characters, the full name of the artist
 is appendend instead of the remaining characters. I suppose the error
 has its origin in the file id3.h that can be found at
 http://cvs.sf.net/viewcvs.py/ripperx/ripperX/src/id3.h?rev=1.2view=markup
 There the ID3 tag is defined:
 
 typedef struct id3tag_s {
 charmagic[ 3 ];
 charsongname[ 30 ];
 charartist[ 30 ];
 charalbum[ 30 ];
 charyear[ 4 ];
 charnote[ 28 ];
 unsigned charnull;
 unsigned chartrack;
 unsigned charstyle;
 } id3tag_t;
 
 
 I don't know about C++ and neither about the rest of the source, but I
 believe that at some point, the artist information overwrites all of the
 things stored in the memory that should actually belong to the title
 information. Somebody able to fix this?


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#309129: ripperx does not support titles longer than 30 chars

2005-05-14 Thread Tobias Pfeiffer
Package: ripperx
Version: 2.6.4-2
Hi!
I have recently ripped a CD and then encoded into Ogg with ripperx. The
title names of the songs are quite long, at least longer than 30
charactes. The filenames of the output files are correct, but in the ID3
tags of the ogg files, after 30 characters, the full name of the artist
is appendend instead of the remaining characters. I suppose the error
has its origin in the file id3.h that can be found at
http://cvs.sf.net/viewcvs.py/ripperx/ripperX/src/id3.h?rev=1.2view=markup
There the ID3 tag is defined:
typedef struct id3tag_s {
charmagic[ 3 ];
charsongname[ 30 ];
charartist[ 30 ];
charalbum[ 30 ];
charyear[ 4 ];
charnote[ 28 ];
unsigned char   null;
unsigned char   track;
unsigned char   style;
} id3tag_t;
I don't know about C++ and neither about the rest of the source, but I
believe that at some point, the artist information overwrites all of the
things stored in the memory that should actually belong to the title
information. Somebody able to fix this?
Bye
Tobias
--
Ashes to ashes and clay to clay,
if the enemy doesn't get you, your own folks may.


signature.asc
Description: OpenPGP digital signature