Bug#322208: seahorse: DEBUILD_PRESERVE_ENVVARS must indeed preserve DISPLAY it seems

2006-10-29 Thread Julian Gilbey
On Thu, Dec 22, 2005 at 01:58:49PM +0200, Martin-Éric Racine wrote:
 As others suggested, I tried the DEBUILD_PRESERVE_ENVVARS trick and,
 sure enough, it fixes it. Personally, I would just reassign this bug 
 to devscripts and ask the maintainers to fix this in their defaults, 
 rather than argue about why seahorse-agent needs it and whether it's 
 an acceptable programming choice.

debuild deliberately cleans as many environment variables as possible,
so that maintainers' environment variables don't accidentally slip
into and affect package builds.  I have no idea whether some package
would build incorrectly if DISPLAY is set.

I would prefer one of the following solutions:

- seahorse-agent should not rely on DISPLAY being correctly set
- set DEBUILD_PRESERVE_ENV=DISPLAY in the .devscripts file
- have Debian's version of seahorse-agent do something to handle this
  situation, for example by setting DEBUILD_PRESERVE_ENV
  appropriately, or by wrapping debuild

But if there is agreement that preserving DISPLAY is the correct way
to go, and that it is unlikely to have any effect on other package
builds, then we can go with that.

   Julian


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#322208: seahorse: DEBUILD_PRESERVE_ENVVARS must indeed preserve DISPLAY it seems

2005-12-22 Thread Martin-Éric Racine
Package: seahorse
Version: 0.8.0-1
Followup-For: Bug #322208

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

As others suggested, I tried the DEBUILD_PRESERVE_ENVVARS trick and,
sure enough, it fixes it. Personally, I would just reassign this bug 
to devscripts and ask the maintainers to fix this in their defaults, 
rather than argue about why seahorse-agent needs it and whether it's 
an acceptable programming choice.

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDqpT5eXr56x4Muc0RAieAAJ9B3dApYpQICpmKLqL6+wiJbTCO8wCgp+Dx
VdNZcXk1W1qHn6kf7c+zRts=
=Ubz7
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]