Bug#346040: backupninja: [PATCH] duplicity local backup support
tags 346040 + fixed-upstream thanks Hello, I’ve implemented support for all duplicity-supported transports other than SSH, the way Joey Hess suggested in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=483712 ; this is in upstream SVN trunk r568 [1]. All interested parties, please test this patch with the transports you need before we release backupninja 0.9.6 for inclusion in Debian Lenny. If this is not an option for you, just wait for the release :) [1] https://code.autistici.org/trac/backupninja/changeset/568 Bye, -- intrigeri [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#346040: backupninja: [PATCH] duplicity local backup support
intrigeri wrote (18 Jan 2007 23:21:28 GMT) : The Anarcat wrote (10 Jan 2007 17:53:13 GMT) : I did some work to get there. I have attached a patch that adds a protocol option, that, if unset defaults to scp. Thanks for this patch, which I'd like to apply upstream once it's documented, added to example.dup, and dealt with by ninjahelper ; I won't do this myself, but I can offer help to : - take care of the remote setup tests ; - review your patch next versions, as I'm doing for this one. It's not quite clean yet, because it lacks documentation and it's really just a flag right now. Not sure what would happen if you'd enter, say, ssh or (!) ftp as a protocol. :) Maybe backupninja should check for this... Yes, I think it's necessary to test if the protocol option has a valid value, and exit with an error if this is not the case : this would at least unveil some typos in configuration files... e.g. if I wrote protocol = fole, I would like to be informed of it in clear terms, and not simply by seeing that a scp connection I did not expect to happen failed. I also haven't tested what happens if you *don't* enter a protocol (or put scp). I guess it will behave fine, but I don't have a remote setup to do formal testing. The test I recommend above would also cover this case, IMHO. Any news from this, Anarcat ? Ciao, -- intrigeri [EMAIL PROTECTED] | gnupg key @ http://intrigeri.boum.org/intrigeri.asc | We're dreaming of something else. | Something more clandestine, something happier. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#346040: backupninja: [PATCH] duplicity local backup support
On Tue, May 15, 2007 at 11:41:54AM +0200, intrigeri wrote: Any news from this, Anarcat ? We're not using duplicity within backupninja anymore, so I could find time to work on this again, and I do not think I will have any in a forseeable future. Sorry... A. signature.asc Description: Digital signature
Bug#346040: backupninja: [PATCH] duplicity local backup support
Hello, The Anarcat wrote (10 Jan 2007 17:53:13 GMT) : I did some work to get there. I have attached a patch that adds a protocol option, that, if unset defaults to scp. Thanks for this patch, which I'd like to apply upstream once it's documented, added to example.dup, and dealt with by ninjahelper ; I won't do this myself, but I can offer help to : - take care of the remote setup tests ; - review your patch next versions, as I'm doing for this one. It's not quite clean yet, because it lacks documentation and it's really just a flag right now. Not sure what would happen if you'd enter, say, ssh or (!) ftp as a protocol. :) Maybe backupninja should check for this... Yes, I think it's necessary to test if the protocol option has a valid value, and exit with an error if this is not the case : this would at least unveil some typos in configuration files... e.g. if I wrote protocol = fole, I would like to be informed of it in clear terms, and not simply by seeing that a scp connection I did not expect to happen failed. I also haven't tested what happens if you *don't* enter a protocol (or put scp). I guess it will behave fine, but I don't have a remote setup to do formal testing. The test I recommend above would also cover this case, IMHO. Thanks, again :) Ciao, -- intrigeri [EMAIL PROTECTED] | gnupg key @ http://intrigeri.boum.org/intrigeri.asc | That there, it's not me. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#346040: backupninja: [PATCH] duplicity local backup support
Package: backupninja
Followup-For: Bug #346040
Hi.
I did some work to get there. I have attached a patch that adds a
protocol option, that, if unset defaults to scp.
It's not quite clean yet, because it lacks documentation and it's
really just a flag right now. Not sure what would happen if you'd
enter, say, ssh or (!) ftp as a protocol. :) Maybe backupninja
should check for this...
I also haven't tested what happens if you *don't* enter a protocol (or
put scp). I guess it will behave fine, but I don't have a remote
setup to do formal testing.
-- System Information:
Debian Release: 4.0
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-686
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
--- dup.orig2006-04-08 22:12:35.0 +
+++ dup 2007-01-10 17:23:27.0 +
@@ -7,6 +7,7 @@
getconf options
getconf testconnect yes
getconf nicelevel 0
+getconf protocol scp
setsection gpg
getconf password
@@ -69,10 +70,16 @@
### COMMAND-LINE MANGLING ###
-scpoptions=$sshoptions
-[ $bandwidthlimit == 0 ] || scpoptions=$scpoptions -l $bandwidthlimit
+if [ $protocol != file ]; then
+ scpoptions=$sshoptions
+ [ $bandwidthlimit == 0 ] || scpoptions=$scpoptions -l $bandwidthlimit
+fi
+
+execstr=$options --no-print-statistics
-execstr=$options --no-print-statistics --scp-command 'scp $scpoptions'
--ssh-command 'ssh $sshoptions'
+if [ $protocol != file ]; then
+ execstr=${execstr}--scp-command 'scp $scpoptions' --ssh-command 'ssh
$sshoptions'
+fi
# deal with symmetric or asymmetric (public/private key pair) encryption
if [ -n $encryptkey ]; then
@@ -108,7 +115,11 @@
execstr=${execstr}--full
fi
-execstr_serverpart=scp://[EMAIL PROTECTED]/$destdir
+if [ $protocol == file ]; then
+execstr_serverpart=$protocol:///$destdir
+else
+execstr_serverpart=$protocol://[EMAIL PROTECTED]/$destdir
+fi
execstr_clientpart=/
### SOURCE ###
