Bug#695873: memtest86+: Serial console does not work
Hi, Feel free do NMU - thanks much for this :) - Mail original - > De: "Louis-Philippe Véronneau" > À: 695...@bugs.debian.org > Envoyé: Mardi 13 Août 2019 21:44:38 > Objet: Bug#695873: memtest86+: Serial console does not work > > Hello! > > I'd be happy to make an NMU to fix this, since: > > * there is a patch > * the patch was tested by 4 people and it seems to work > * the patch looks trivial > * the patch has been merged in Fedora [1] > > I've emailed the maintainer directly to ask him if it would be OK > with > him for me to NMU this. > > If I don't get an answer I'll look into fixing this by an NMU :) > > Cheers, > > [1] > https://src.fedoraproject.org/rpms/memtest86+/blob/master/f/memtest86+-5.01-serial-console-fix.patch > > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau > ⢿⡄⠘⠷⠚⠋ po...@debian.org / veronneau.org > ⠈⠳⣄ > >
Bug#695873: memtest86+: Serial console does not work
Hello! I'd be happy to make an NMU to fix this, since: * there is a patch * the patch was tested by 4 people and it seems to work * the patch looks trivial * the patch has been merged in Fedora [1] I've emailed the maintainer directly to ask him if it would be OK with him for me to NMU this. If I don't get an answer I'll look into fixing this by an NMU :) Cheers, [1] https://src.fedoraproject.org/rpms/memtest86+/blob/master/f/memtest86+-5.01-serial-console-fix.patch -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Louis-Philippe Véronneau ⢿⡄⠘⠷⠚⠋ po...@debian.org / veronneau.org ⠈⠳⣄ signature.asc Description: OpenPGP digital signature
Bug#695873: memtest86+: Serial console does not work
I have also confirmed the patch to fix serial console that was sent to #695873 works. I was applying it to 5.01-3, building on buster, installed and booted fine. Please apply. Thanks, -- Matt Taggart tagg...@debian.org
Bug#695873: memtest86+: Serial console does not work
Attached patch should fix it. tag 695873 patch diff --git a/lib.c b/lib.c index a2b829d..6a7e210 100644 --- a/lib.c +++ b/lib.c @@ -1141,7 +1141,7 @@ void serial_console_setup(char *param) end++; - if (*end != '\0' || *end != ' ') + if (*end != '\0' && *end != ' ') return; /* garbage at the end */ serial_bits = bits;
Bug#695873: memtest86+: Serial console does not work
Control: found -1 5.01-2 > When recompiled with SERIAL_CONSOLE_DEFAULT=1 and other settings in > config.h the serial console works fine. However setting the > parameters from the boot prompt with lilo (or pxelinux) does not. I'm in the same situation with Syslinux: passing serial options on the command line has no effect, but recompilation helps. -- Feri
Bug#695873: memtest86+: Serial console does not work
Package: memtest86+ Version: 4.20-1.1 Severity: normal Dear Maintainer, When recompiled with SERIAL_CONSOLE_DEFAULT=1 and other settings in config.h the serial console works fine. However setting the parameters from the boot prompt with lilo (or pxelinux) does not. In particular these settings do not work (lilo version): append="console=ttyS1,115200n8" and similarly console=ttyS1 console=ttyS0 etc. From a brief poke at the code I suspect that the commandline is not successfully being passed from the bootloader to memtest. -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (900, 'testing'), (800, 'unstable'), (700, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages memtest86+ depends on: ii debconf [debconf-2.0] 1.5.46 memtest86+ recommends no packages. Versions of packages memtest86+ suggests: ii grub-pc 1.99-23 pn hwtools pn kernel-patch-badram pn memtest86 pn memtester ii mtools 4.0.17-1 -- debconf information excluded -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org