Bug#708551: Fwd: Bug#708551: Updated TODO list
On 2013-07-17 11:31, Mathieu Parent wrote: [...] I merged the 15 patches in [1], though with some rebasing and some whitespace fixes (e.g. 4-space instead 2-space indentation). Okay. Where there any patch(es) beyond those 15? No. But now there are new ones. See attached pacthes. Note that the latest add a lintian build-dep, needed for the tests. Regards -- Mathieu Parent Ah, missed those - they have been merged now. ~Niels -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#708551: Fwd: Bug#708551: Updated TODO list
2013/7/10 Niels Thykier ni...@thykier.net: On 2013-07-10 14:29, Mathieu Parent wrote: 2013/7/10 Niels Thykier ni...@thykier.net: [...] In other news, the patches have been merged into master branch and will be part of the 2.5.15 release. :) Great, but it seems that you didn't merge the latest patches. Regards -- Mathieu I merged the 15 patches in [1], though with some rebasing and some whitespace fixes (e.g. 4-space instead 2-space indentation). Okay. Where there any patch(es) beyond those 15? No. But now there are new ones. See attached pacthes. Note that the latest add a lintian build-dep, needed for the tests. Regards -- Mathieu Parent 0001-Check-for-missing-bdeps-on-PECL-packages.patch Description: Binary data 0002-Check-for-phppear-description-and-phppear-summary.patch Description: Binary data 0003-Only-check-package2.xml-and-PECL-if-pkg-php-tools-is.patch Description: Binary data 0004-Check-for-debian-rules-for-PHP-packages.patch Description: Binary data
Bug#708551: Fwd: Bug#708551: Updated TODO list
On 2013-07-10 10:52, Mathieu Parent wrote: (re-sending,as it is not on b.d.o) [...] Actually, it is on bugs.d.o - but it never reached the maintainer list (possibly the mail size is over the limit for what lists.d.o will accept). In other news, the patches have been merged into master branch and will be part of the 2.5.15 release. :) ~Niels -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#708551: Fwd: Bug#708551: Updated TODO list
2013/7/10 Niels Thykier ni...@thykier.net: On 2013-07-10 10:52, Mathieu Parent wrote: (re-sending,as it is not on b.d.o) [...] Actually, it is on bugs.d.o - but it never reached the maintainer list (possibly the mail size is over the limit for what lists.d.o will accept). Seen after sending it. In other news, the patches have been merged into master branch and will be part of the 2.5.15 release. :) Great, but it seems that you didn't merge the latest patches. Regards -- Mathieu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#708551: Fwd: Bug#708551: Updated TODO list
On 2013-07-10 14:29, Mathieu Parent wrote: 2013/7/10 Niels Thykier ni...@thykier.net: [...] In other news, the patches have been merged into master branch and will be part of the 2.5.15 release. :) Great, but it seems that you didn't merge the latest patches. Regards -- Mathieu I merged the 15 patches in [1], though with some rebasing and some whitespace fixes (e.g. 4-space instead 2-space indentation). Where there any patch(es) beyond those 15? ~Niels [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=708551#30 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#708551: Updated TODO list
On 2013-05-27 12:59, Mathieu Parent wrote:
Hi,
Attached are the updated patches.
Remaining todo:
- check for --buildsystem=phppear and --with phppear usage
- check for php5-dev builddep when using PECL
- check for ${phppear:summary} and ${phppear:description} in Description
low priority:
- check for builddep when using roles (currently, only php-horde-role
is shipping a role)
Regards
--
Mathieu
Hi,
Thanks for the patches and the interest. A couple of comments:
* 0003 adds a tag that isn't used in that patch. It is used in a later
patch, so (for me) the question is whether it was supposed to have
been in 0004 or if there is a bug in 0003.
* 0007 opens a file without open succeeds (missing use autodie;) and
does not close the handle when it is done with it.
Beyond that, it looks like it is just mising some tests.
~Niels
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#708551: Updated TODO list
Hi,
Attached are the updated patches.
Remaining todo:
- check for --buildsystem=phppear and --with phppear usage
- check for php5-dev builddep when using PECL
- check for ${phppear:summary} and ${phppear:description} in Description
low priority:
- check for builddep when using roles (currently, only php-horde-role
is shipping a role)
Regards
--
Mathieu
0001-Initial-phppear-check.patch
Description: Binary data
0002-phppear-Check-for-channel.xml.patch
Description: Binary data
0003-phppear-Check-for-binary-dependencies.patch
Description: Binary data
0004-pkg-php-tools-overrides-requires-1.patch
Description: Binary data
0005-PEAR-channels-support-requires-pkg-php-tools-1.3.patch
Description: Binary data
0006-package2.xml-requires-pkg-php-tools-1.4.patch
Description: Binary data
0007-PECL-support-requires-pkg-php-tools-1.5.patch
Description: Binary data
Bug#708551: Updated TODO list
- check for --buildsystem=phppear and --with phppear usage
- check for php5-dev builddep when using PECL
- package2.xml requires a newer pkg-php-tools version (also TODO on this side)
- check for ${phppear:summary} and ${phppear:description} in Description
low priority:
- check for builddep when using roles (currently, only php-horde-role
is shipping a role)
Patches welcome
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
