Bug#781248: RFS: golang-go-colorable/0.0~git20140924-1 [ITP#781244]
I'll be waiting for someone from pkg-go then :) Thanks! On 26/03/15 09:50 AM, Paul Tagliamonte wrote: On Thu, Mar 26, 2015 at 09:42:38AM -0400, Alexandre Viau wrote: (https://github.com/ReAzem/golang-go-colorable). I had plans to push it on alioth as soon as I am added to the scm_pkg-go group (I'm waiting on whatever cronjob does it). As this will live in pkg-go; please do not upload without a run-through from pkg-go hackers (at the moment, myself and tianon) -- but a package review is very very welcome! I'm sorry, I'm a bit limited on time or this would contain a review of the package; thanks for your contribution so far, Alexandre! Paul -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
Bug#781248: RFS: golang-go-colorable/0.0~git20140924-1 [ITP#781244]
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package golang-go-colorable * Package name: golang-go-colorable Version : 0.0~git20140924 Upstream Author : Yasuhiro Matsumoto * URL : https://github.com/mattn/go-colorable * License : MIT Section : devel It builds those binary packages: golang-go-colorable-dev - Cross-platform colorable writer To access further information about this package, please visit the following URL: http://mentors.debian.net/package/golang-go-colorable Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/g/golang-go-colorable/golang-go-colorable_0.0~git20140924-1.dsc My packaging is on Github for now (https://github.com/ReAzem/golang-go-colorable). I had plans to push it on alioth as soon as I am added to the scm_pkg-go group (I'm waiting on whatever cronjob does it). Regards, Alexandre Viau signature.asc Description: OpenPGP digital signature
Bug#781248: RFS: golang-go-colorable/0.0~git20140924-1 [ITP#781244]
On Thu, Mar 26, 2015 at 09:42:38AM -0400, Alexandre Viau wrote: (https://github.com/ReAzem/golang-go-colorable). I had plans to push it on alioth as soon as I am added to the scm_pkg-go group (I'm waiting on whatever cronjob does it). As this will live in pkg-go; please do not upload without a run-through from pkg-go hackers (at the moment, myself and tianon) -- but a package review is very very welcome! I'm sorry, I'm a bit limited on time or this would contain a review of the package; thanks for your contribution so far, Alexandre! Paul -- .''`. Paul Tagliamonte paul...@debian.org | Proud Debian Developer : :' : 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87 `. `'` http://people.debian.org/~paultag `- http://people.debian.org/~paultag/conduct-statement.txt signature.asc Description: Digital signature
Bug#781248: RFS: golang-go-colorable/0.0~git20140924-1 [ITP#781244]
Alexandre Viau alexan...@alexandreviau.net writes: I'll be waiting for someone from pkg-go then :) Hi Alexandre! I am not with pkg-go -- sorry! But I do have a quick review for you that contains some things which you can work on while you wait. Because there are so many variants of the MIT license, the Debian copyright-format policy wants the license specified as the more specific version - Expat is usually compatible with MIT, but it depends what the upstream author wants. The file _example/main.go doesn't comply with gofmt. A quick run-through of gofmt and sending the patch upstream is an easy fix for that. Other than that, there's an extra newline in d/copyright. The RFS bug for this package should /probably/ block on the RFS bug for golang-go-isatty, since this package depends on that one. Not a big deal, though. Hope that helps, and thank you for your contributions to Debian! -- Harlan Lieberman-Berg ~hlieberman -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#781248: RFS: golang-go-colorable/0.0~git20140924-1 [ITP#781244]
On 26/03/15 06:01 PM, Harlan Lieberman-Berg wrote: Hi Alexandre! Hii :) I am not with pkg-go -- sorry! But I do have a quick review for you Thanks! Because there are so many variants of the MIT license, the Debian copyright-format policy wants the license specified as the more specific version - Expat is usually compatible with MIT, but it depends what the upstream author wants. Done! The file _example/main.go doesn't comply with gofmt. A quick run-through of gofmt and sending the patch upstream is an easy fix for that. I opened a PR upstream and it was merged. I have repackaged, pushed to github, and to mentors.debian.net Other than that, there's an extra newline in d/copyright. I had done this mistake in all 3 packages. Fixed. The RFS bug for this package should /probably/ block on the RFS bug for golang-go-isatty, since this package depends on that one. Not a big deal, though. Done! Hope that helps, and thank you for your contributions to Debian! thanks to you :) -- Alexandre Viau alexan...@alexandreviau.net signature.asc Description: OpenPGP digital signature
