Bug#806027: fwknop: FTBFS when built with dpkg-buildpackage -A (No such file or directory)

[Santiago Vila]

Greetings.

I have the ok from the Release Managers to consider this issue as RC
for stretch. I'm going to wait at least one week before raising
this to "serious".

There is a patch available for this bug. If you need someone to make
an upload, please ask for a sponsor in debian-mentors.

Thanks.

Bug#806027: fwknop: FTBFS when built with dpkg-buildpackage -A (No such file or directory)

[Santiago Vila]

tags 806027 + patch
thanks

>debian/rules override_dh_fixperms
> make[1]: Entering directory '/<>'
> chmod 600 /<>/debian/fwknop-server/etc/fwknop/access.conf
> chmod: cannot access 
> '/<>/debian/fwknop-server/etc/fwknop/access.conf': No such file 
> or directory

Explanation: We are creating arch-independent packages only, so
debian/fwknop-server/[...] does not exist because fwknop-server is
arch-dependent.

The trivial fix is to override dh_fixperms only when creating
arch-dependent packages.

While we are at it, we can even avoid using --exclude by putting
dh_fixperms first and chmod later.

Patch attached.

Thanks.--- a/debian/rules
+++ b/debian/rules
@@ -57,10 +57,10 @@ override_dh_link:
dh_link -plibfko2-dev $(LIB_LIBFKODEV)/libfko.so.2.0.0 
$(LIB_LIBFKODEV)/libfko.so
dh_link --remaining-packages
 
-override_dh_fixperms:
+override_dh_fixperms-arch:
+   dh_fixperms
chmod 600 $(CURDIR)/debian/fwknop-server/etc/fwknop/access.conf
chmod 600 $(CURDIR)/debian/fwknop-server/etc/fwknop/fwknopd.conf
-   dh_fixperms --exclude access.conf --exclude fwknopd.conf
 
 override_dh_strip:
dh_strip --dbg-package=libfko2-dbg

Bug#806027: fwknop: FTBFS when built with dpkg-buildpackage -A (No such file or directory)

[Santiago Vila]

Package: src:fwknop
Version: 2.6.0-2.1
User: sanv...@debian.org
Usertags: binary-indep
Severity: important

Dear maintainer:

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:


[...]
 fakeroot debian/rules binary-indep
dh binary-indep --with=python2
   dh_testroot -i
   dh_prep -i
rm -f debian/libfko-doc.substvars
rm -f debian/libfko-doc.*.debhelper
rm -rf debian/libfko-doc/
rm -f debian/fwknop-apparmor-profile.substvars
rm -f debian/fwknop-apparmor-profile.*.debhelper
rm -rf debian/fwknop-apparmor-profile/
   dh_installdirs -i
install -d debian/libfko-doc
install -d debian/fwknop-apparmor-profile
install -d debian/fwknop-apparmor-profile/etc/apparmor.d
   debian/rules override_dh_auto_install
make[1]: Entering directory '/<>'
dh_auto_install
make -j1 install DESTDIR=/<>/debian/tmp 
AM_UPDATE_INFO_DIR=no
make[2]: Entering directory '/<>'
Making install in lib
make[3]: Entering directory '/<>/lib'
make[4]: Entering directory '/<>/lib'

[... snipped ...]

chmod a-x usr/share/doc/fwknop-apparmor-profile/NEWS.Debian 
usr/share/doc/fwknop-apparmor-profile/changelog 
usr/share/doc/fwknop-apparmor-profile/changelog.Debian
gzip -9nf usr/share/doc/fwknop-apparmor-profile/NEWS.Debian 
usr/share/doc/fwknop-apparmor-profile/changelog 
usr/share/doc/fwknop-apparmor-profile/changelog.Debian
cd '/<>'
   debian/rules override_dh_fixperms
make[1]: Entering directory '/<>'
chmod 600 /<>/debian/fwknop-server/etc/fwknop/access.conf
chmod: cannot access 
'/<>/debian/fwknop-server/etc/fwknop/access.conf': No such file or 
directory
debian/rules:61: recipe for target 'override_dh_fixperms' failed
make[1]: *** [override_dh_fixperms] Error 1
make[1]: Leaving directory '/<>'
debian/rules:27: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit 
status 2


Sorry not to have a fix, as I am reporting many bugs similar to
this one, but I can give some general hints:

* If all the arch-independent packages are dummy transitional packages
released with jessie, the easy fix is to drop them now.
 
* If not, debian/rules should be modified so that the binary-indep
target works in all cases, even when binary-arch is not used (this is
what the "Architecture: all" autobuilder does). For that:

* If you are using debhelper, you might want to use options -a and -i
for dh_* commands so that they do not act on packages they do not
have to act.

* Also, if you are using dh, the (independently) optional targets
override_dh_foo-arch and override_dh_foo-indep (for several values
of "foo") may be useful to write a debian/rules which behaves exactly
as desired.


After checking that both "dpkg-buildpackage -A" and "dpkg-buildpackage -B"
work properly, this package will be suitable to be uploaded in
source-only form if you wish (you might want to try it).

Thanks.