Bug#811980: libusbtc08: FTBFS with GCC 6: symbol changes

2020-05-28 Thread Moritz Mühlenhoff 
On Sat, Feb 11, 2017 at 11:16:19AM +0100, Maximiliano Curia wrote:
> ¡Hola Nobuhiro!
> 
> El 2017-02-11 a las 15:48 +0900, Nobuhiro Iwamatsu escribió:
> > Control: tags 811980 + patch
> 
> > > This package fails to build with GCC 6.  GCC 6 has not been released
> > > yet, but it's expected that GCC 6 will become the default compiler
> > > for stretch.
> 
> > > Note that only the first error is reported; there might be more.
> > > You can find a snapshot of GCC 6 in experimental.  To build with GCC
> > > 6, you can set CC=gcc-6 CXX=g++-6 explicitly.
> 
> > > You may be able to find out more about this issue at
> > > https://gcc.gnu.org/gcc-6/changes.html
> 
> > I create a patch which update symboles file. Could you check this patch?
> 
> I've considered requesting the removal of libusbtc08 as I'm no longer using
> it, it seems that there aren't any users for it, and upstream stopped
> distributing their source code for the newer versions
> (https://www.picotech.com/downloads/linux).

I've filed an RM bug now.

Cheers,
Moritz

Bug#811980: libusbtc08: FTBFS with GCC 6: symbol changes

2017-03-15 Thread Mattia Rizzolo 
On Sun, Feb 12, 2017 at 08:25:54AM +0900, Nobuhiro Iwamatsu wrote:
> I see.
> I will NMU.

How is the NMU coming?

Although, TBH, if the library is not used by anything anymore I'd
personally like to see it removed instead.

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature

Bug#811980: libusbtc08: FTBFS with GCC 6: symbol changes

2017-02-11 Thread Nobuhiro Iwamatsu 
Hi, Maximiliano!

Thnaks for your comment.

2017-02-11 19:16 GMT+09:00 Maximiliano Curia :
> ¡Hola Nobuhiro!
>
> El 2017-02-11 a las 15:48 +0900, Nobuhiro Iwamatsu escribió:
>>
>> Control: tags 811980 + patch
>
>
>>> This package fails to build with GCC 6.  GCC 6 has not been released yet,
>>> but it's expected that GCC 6 will become the default compiler for stretch.
>
>
>>> Note that only the first error is reported; there might be more.  You can
>>> find a snapshot of GCC 6 in experimental.  To build with GCC 6, you can set
>>> CC=gcc-6 CXX=g++-6 explicitly.
>
>
>>> You may be able to find out more about this issue at
>>> https://gcc.gnu.org/gcc-6/changes.html
>
>
>> I create a patch which update symboles file. Could you check this patch?
>
>
> I've considered requesting the removal of libusbtc08 as I'm no longer using
> it, it seems that there aren't any users for it, and upstream stopped
> distributing their source code for the newer versions
> (https://www.picotech.com/downloads/linux).
>
> If you want to take care of libusbtc08 as is and/or work with upstream
> please consider taking over this package.
>
> In any case, I'm listed in the https://wiki.debian.org/LowThresholdNmu, feel
> free to upload the fix without asking for permission.
>
> Happy hacking,

I see.
I will NMU.

>
>> --- libusbtc08-1.7.2/debian/libusbtc08-1.symbols  2015-08-27
>> 05:37:20.0 +0900
>> +++ libusbtc08-1.7.2/debian/libusbtc08-1.symbols  2017-02-11
>> 15:30:30.0 +0900
>> @@ -67,9 +67,6 @@
>>  _ZN13PicoUsbDevice4InitEv@Base 1.7.2
>>  _ZN13PicoUsbDevice5CountEt@Base 1.7.2
>>  _ZN13PicoUsbDevice9EnumerateEPPS_jt@Base 1.7.2
>> - (optional=gccinternal)_ZN13PicoUsbDeviceD0Ev@Base 1.7.2
>> - (optional=gccinternal)_ZN13PicoUsbDeviceD1Ev@Base 1.7.2
>> - (optional=gccinternal)_ZN13PicoUsbDeviceD2Ev@Base 1.7.2
>
> No need to drop optional fields (these are the default destructors, and
> might show up again in a future version of gcc).
>

Indeed.

> ...
>
>> - (optional=gccinternal)_ZTV13PicoUsbDevice@Base 1.7.2
>
> Mmh, this one should probably stay, as the class is still present and
> contains virtual methods
>
> Most likely you would need a second upload after processing all the buildds
> logs, it might make sense to use the pkg-kde-tools symbolshelper for this.
>

OK, I will check with pkg-kde-tools symbolshelper too.

> Happy hacking,

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

Bug#811980: libusbtc08: FTBFS with GCC 6: symbol changes

2017-02-11 Thread Maximiliano Curia 

¡Hola Nobuhiro!

El 2017-02-11 a las 15:48 +0900, Nobuhiro Iwamatsu escribió:

Control: tags 811980 + patch


This package fails to build with GCC 6.  GCC 6 has not been released 
yet, but it's expected that GCC 6 will become the default compiler for 
stretch.


Note that only the first error is reported; there might be more.  You 
can find a snapshot of GCC 6 in experimental.  To build with GCC 6, 
you can set CC=gcc-6 CXX=g++-6 explicitly.


You may be able to find out more about this issue at 
https://gcc.gnu.org/gcc-6/changes.html


I create a patch which update symboles file. 
Could you check this patch?


I've considered requesting the removal of libusbtc08 as I'm no longer using 
it, it seems that there aren't any users for it, and upstream stopped 
distributing their source code for the newer versions 
(https://www.picotech.com/downloads/linux).


If you want to take care of libusbtc08 as is and/or work with upstream please 
consider taking over this package.


In any case, I'm listed in the https://wiki.debian.org/LowThresholdNmu, feel 
free to upload the fix without asking for permission.


Happy hacking,

> --- libusbtc08-1.7.2/debian/libusbtc08-1.symbols   2015-08-27 
05:37:20.0 +0900
> +++ libusbtc08-1.7.2/debian/libusbtc08-1.symbols   2017-02-11 
15:30:30.0 +0900
> @@ -67,9 +67,6 @@
>  _ZN13PicoUsbDevice4InitEv@Base 1.7.2
>  _ZN13PicoUsbDevice5CountEt@Base 1.7.2
>  _ZN13PicoUsbDevice9EnumerateEPPS_jt@Base 1.7.2
> - (optional=gccinternal)_ZN13PicoUsbDeviceD0Ev@Base 1.7.2
> - (optional=gccinternal)_ZN13PicoUsbDeviceD1Ev@Base 1.7.2
> - (optional=gccinternal)_ZN13PicoUsbDeviceD2Ev@Base 1.7.2

No need to drop optional fields (these are the default destructors, and might 
show up again in a future version of gcc).


...

> - (optional=gccinternal)_ZTV13PicoUsbDevice@Base 1.7.2

Mmh, this one should probably stay, as the class is still present and 
contains virtual methods


Most likely you would need a second upload after processing all the buildds 
logs, it might make sense to use the pkg-kde-tools symbolshelper for this.


Happy hacking,
--
"There are two major products that come out of Berkeley: LSD and BSD.
We don't believe this to be a coincidence."
-- Jeremy S. Anderson
Saludos /\/\ /\ >< `/


signature.asc
Description: PGP signature

Bug#811980: libusbtc08: FTBFS with GCC 6: symbol changes

2017-02-10 Thread Nobuhiro Iwamatsu 
Control: tags 811980 + patch

Hi,

> This package fails to build with GCC 6.  GCC 6 has not been released
> yet, but it's expected that GCC 6 will become the default compiler for
> stretch.
> 
> Note that only the first error is reported; there might be more.  You
> can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
> you can set CC=gcc-6 CXX=g++-6 explicitly.
> 
> You may be able to find out more about this issue at
> https://gcc.gnu.org/gcc-6/changes.html
> 
> 

I create a patch which update symboles file.
Could you check this patch?

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
diff -Nru libusbtc08-1.7.2/debian/changelog libusbtc08-1.7.2/debian/changelog
--- libusbtc08-1.7.2/debian/changelog   2015-08-27 05:37:20.0 +0900
+++ libusbtc08-1.7.2/debian/changelog   2017-02-11 15:30:30.0 +0900
@@ -1,3 +1,10 @@
+libusbtc08 (1.7.2-5.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Update debian/libusbtc08-1.symbols (Closes: #811980).
+
+ -- Nobuhiro Iwamatsu   Sat, 11 Feb 2017 15:30:30 +0900
+
 libusbtc08 (1.7.2-5) unstable; urgency=medium
 
   * Bump Standards-Version to 3.9.6, no changes needed.
diff -Nru libusbtc08-1.7.2/debian/libusbtc08-1.symbols 
libusbtc08-1.7.2/debian/libusbtc08-1.symbols
--- libusbtc08-1.7.2/debian/libusbtc08-1.symbols2015-08-27 
05:37:20.0 +0900
+++ libusbtc08-1.7.2/debian/libusbtc08-1.symbols2017-02-11 
15:30:30.0 +0900
@@ -67,9 +67,6 @@
  _ZN13PicoUsbDevice4InitEv@Base 1.7.2
  _ZN13PicoUsbDevice5CountEt@Base 1.7.2
  _ZN13PicoUsbDevice9EnumerateEPPS_jt@Base 1.7.2
- (optional=gccinternal)_ZN13PicoUsbDeviceD0Ev@Base 1.7.2
- (optional=gccinternal)_ZN13PicoUsbDeviceD1Ev@Base 1.7.2
- (optional=gccinternal)_ZN13PicoUsbDeviceD2Ev@Base 1.7.2
  _ZN13ReadingBuffer10AddReadingEf@Base 1.7.2
  _ZN13ReadingBuffer10AddReadingEfb@Base 1.7.2
  _ZN13ReadingBuffer12BufferIsFullEv@Base 1.7.2
@@ -154,14 +151,16 @@
  _ZN22TC08DeviceInternalDataC2Ev@Base 1.7.2
  _ZN26TC08EnumeratorInternalDataD1Ev@Base 1.7.2
  _ZN26TC08EnumeratorInternalDataD2Ev@Base 1.7.2
- 
_ZNSt6vectorIP12tTCDataTableSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
 1.7.2
- 
(optional=templinst)_ZNSt6vectorIP15linux_usbfs_urbSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
 1.7.2
- 
_ZNSt6vectorIP16TC08DeviceHandleSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
 1.7.2
+ 
_ZNSt6vectorIP12tTCDataTableSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base 
1.7.2
+ 
_ZNSt6vectorIP15linux_usbfs_urbSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
 1.7.2
+ 
_ZNSt6vectorIP16TC08DeviceHandleSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
 1.7.2
  _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EED1Ev@Base 1.7.2
  _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EED2Ev@Base 1.7.2
- 
_ZNSt6vectorIP18EndpointDescriptorSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
 1.7.2
- 
_ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS2_S4_EERKS2_@Base
 1.7.2
- 
(optional=templinst)_ZNSt6vectorIPcSaIS0_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS0_S2_EERKS0_@Base
 1.7.2
+ 
_ZNSt6vectorIP18EndpointDescriptorSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
 1.7.2
+ 
_ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE12emplace_backIJS2_EEEvDpOT_@Base
 1.7.2
+ 
_ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE19_M_emplace_back_auxIJRKS2_EEEvDpOT_@Base
 1.7.2
+ 
_ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE19_M_emplace_back_auxIJS2_EEEvDpOT_@Base
 1.7.2
+ _ZNSt6vectorIPcSaIS0_EE19_M_emplace_back_auxIJRKS0_EEEvDpOT_@Base 1.7.2
  _ZTI13PicoUsbDevice@Base 1.7.2
  _ZTI14PicoDownloader@Base 1.7.2
  _ZTI18PicoLinuxUsbDevice@Base 1.7.2
@@ -170,7 +169,6 @@
  _ZTS14PicoDownloader@Base 1.7.2
  _ZTS18PicoLinuxUsbDevice@Base 1.7.2
  _ZTS20PicoDownloader_Linux@Base 1.7.2
- (optional=gccinternal)_ZTV13PicoUsbDevice@Base 1.7.2
  _ZTV14PicoDownloader@Base 1.7.2
  _ZTV18PicoLinuxUsbDevice@Base 1.7.2
  _ZTV20PicoDownloader_Linux@Base 1.7.2


signature.asc
Description: PGP signature

Bug#811980: libusbtc08: FTBFS with GCC 6: symbol changes

2016-01-19 Thread Martin Michlmayr 
Package: libusbtc08
Version: 1.7.2-5
Severity: important
User: debian-...@lists.debian.org
Usertags: ftbfs-gcc-6 gcc-6-symbols

This package fails to build with GCC 6.  GCC 6 has not been released
yet, but it's expected that GCC 6 will become the default compiler for
stretch.

Note that only the first error is reported; there might be more.  You
can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
you can set CC=gcc-6 CXX=g++-6 explicitly.

You may be able to find out more about this issue at
https://gcc.gnu.org/gcc-6/changes.html

> sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
...
> dpkg-gensymbols: warning: some symbols or patterns disappeared in the symbols 
> file: see diff output below
> dpkg-gensymbols: warning: debian/libusbtc08-1/DEBIAN/symbols doesn't match 
> completely debian/libusbtc08-1.symbols
> --- debian/libusbtc08-1.symbols (libusbtc08-1_1.7.2-5_amd64)
> +++ dpkg-gensymbolsJW_lF0 2016-01-19 19:17:50.888068045 +
> @@ -67,9 +67,9 @@
>   _ZN13PicoUsbDevice4InitEv@Base 1.7.2
>   _ZN13PicoUsbDevice5CountEt@Base 1.7.2
>   _ZN13PicoUsbDevice9EnumerateEPPS_jt@Base 1.7.2
> - (optional=gccinternal)_ZN13PicoUsbDeviceD0Ev@Base 1.7.2
> - (optional=gccinternal)_ZN13PicoUsbDeviceD1Ev@Base 1.7.2
> - (optional=gccinternal)_ZN13PicoUsbDeviceD2Ev@Base 1.7.2
> +#MISSING: 1.7.2-5# (optional=gccinternal)_ZN13PicoUsbDeviceD0Ev@Base 1.7.2
> +#MISSING: 1.7.2-5# (optional=gccinternal)_ZN13PicoUsbDeviceD1Ev@Base 1.7.2
> +#MISSING: 1.7.2-5# (optional=gccinternal)_ZN13PicoUsbDeviceD2Ev@Base 1.7.2
>   _ZN13ReadingBuffer10AddReadingEf@Base 1.7.2
>   _ZN13ReadingBuffer10AddReadingEfb@Base 1.7.2
>   _ZN13ReadingBuffer12BufferIsFullEv@Base 1.7.2
> @@ -154,14 +154,22 @@
>   _ZN22TC08DeviceInternalDataC2Ev@Base 1.7.2
>   _ZN26TC08EnumeratorInternalDataD1Ev@Base 1.7.2
>   _ZN26TC08EnumeratorInternalDataD2Ev@Base 1.7.2
> - 
> _ZNSt6vectorIP12tTCDataTableSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> - 
> (optional=templinst)_ZNSt6vectorIP15linux_usbfs_urbSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> - 
> _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> +#MISSING: 1.7.2-5# 
> _ZNSt6vectorIP12tTCDataTableSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> + 
> _ZNSt6vectorIP12tTCDataTableSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
>  1.7.2-5
> +#MISSING: 1.7.2-5# 
> (optional=templinst)_ZNSt6vectorIP15linux_usbfs_urbSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> + 
> _ZNSt6vectorIP15linux_usbfs_urbSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
>  1.7.2-5
> +#MISSING: 1.7.2-5# 
> _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> + 
> _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
>  1.7.2-5
>   _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EED1Ev@Base 1.7.2
>   _ZNSt6vectorIP16TC08DeviceHandleSaIS1_EED2Ev@Base 1.7.2
> - 
> _ZNSt6vectorIP18EndpointDescriptorSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> - 
> _ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS2_S4_EERKS2_@Base
>  1.7.2
> - 
> (optional=templinst)_ZNSt6vectorIPcSaIS0_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS0_S2_EERKS0_@Base
>  1.7.2
> +#MISSING: 1.7.2-5# 
> _ZNSt6vectorIP18EndpointDescriptorSaIS1_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS1_S3_EERKS1_@Base
>  1.7.2
> + 
> _ZNSt6vectorIP18EndpointDescriptorSaIS1_EE19_M_emplace_back_auxIJRKS1_EEEvDpOT_@Base
>  1.7.2-5
> + 
> _ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE12emplace_backIJS2_EEEvDpOT_@Base
>  1.7.2-5
> +#MISSING: 1.7.2-5# 
> _ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS2_S4_EERKS2_@Base
>  1.7.2
> + 
> _ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE19_M_emplace_back_auxIJRKS2_EEEvDpOT_@Base
>  1.7.2-5
> + 
> _ZNSt6vectorIPN14PicoDownloader10DeviceSpecESaIS2_EE19_M_emplace_back_auxIJS2_EEEvDpOT_@Base
>  1.7.2-5
> +#MISSING: 1.7.2-5# 
> (optional=templinst)_ZNSt6vectorIPcSaIS0_EE13_M_insert_auxEN9__gnu_cxx17__normal_iteratorIPS0_S2_EERKS0_@Base
>  1.7.2
> + _ZNSt6vectorIPcSaIS0_EE19_M_emplace_back_auxIJRKS0_EEEvDpOT_@Base 1.7.2-5
>   _ZTI13PicoUsbDevice@Base 1.7.2
>   _ZTI14PicoDownloader@Base 1.7.2
>   _ZTI18PicoLinuxUsbDevice@Base 1.7.2
> @@ -170,7 +178,7 @@
>   _ZTS14PicoDownloader@Base 1.7.2
>   _ZTS18PicoLinuxUsbDevice@Base 1.7.2
>   _ZTS20PicoDownloader_Linux@Base 1.7.2
> - (optional=gccinternal)_ZTV13PicoUsbDevice@Base 1.7.2
> +#MISSING: 1.7.2-5# (optional=gccinternal)_ZTV13PicoUsbDevice@Base 1.7.2
>   _ZTV14PicoDownloader@Base 1.7.2
>   _ZTV18PicoLinuxUsbDevice@Base 1.7.2
>   _ZTV20PicoDownloader_Linux@Base 1.7.2
> dh_makeshlibs: failing due to earlier errors