Bug#836609: nostalgy: please make the build reproducible

[Chris Lamb]

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#836609: nostalgy: please make the build reproducible

[Chris Lamb]

reopen 836609
found 836609 0.2.36-1.2
tags 836609 + patch
thanks

Hi Pollo,

Thanks for applying my reproducibility patch in your nostalgy
0.2.36-1.2 upload. However, it seems like it was incomplete:

│ │ │ ├── ./usr/share/xul-ext/nostalgy/chrome/nostalgy.jar
│ │ │ │ ├── bsdtar -tvf {}
│ │ │ │ │ @@ -1,20 +1,20 @@
│ │ │ │ │ --rw-r--r--  0    11787 Jan 20 17:40 content/about.xhtml
│ │ │ │ │ --rw-r--r--  0      518 Jan 20 17:40 content/about.xul
│ │ │ │ │ --rw-r--r--  0     1611 Jan 20 17:40 content/composer.js
│ │ │ │ │ +-rw-r--r--  0    11787 Jan 20 17:40 content/about.xhtml
│ │ │ │ │ +-rw-r--r--  0      518 Jan 20 17:40 content/about.xul
│ │ │ │ │ +-rw-r--r--  0     1611 Jan 20 17:40 content/composer.js

I think we need:

--- a/debian/patches/0003-Reproducible-build.patch
+++ b/debian/patches/0003-Reproducible-build.patch
 @@ -72,7 +72,10 @@ find content -path '*.svn*' -prune -o -t
  find locale -path '*.svn*' -prune -o -type f -print | grep -v \~ >> files

-+LC_ALL=C sort files | zip -0 $JAR_FILE -@
++LC_ALL=C sort files | zip --no-extra -0 $JAR_FILE -@
  # The following statement should be used instead if you don't wish to use the 
JAR file


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#836609: [Pkg-mozext-maintainers] Bug#836609: nostalgy: please make the build reproducible

[Louis-Philippe Véronneau]

Hi!

I touched that package recently to fix an RC bug and saw this one. Had
to scratch that itch.

I can't upload to the archive as I'm not an uploading DD, but I did
merge that patch on Salsa [1].

I built and tested the resulting package on the latest version of
Thunderbird in testing and everything seemed to work just fine.

I pinged the Web extensions packaging team on IRC to see if someone
wanted to upload the new version.

If someone wants to upload it but needs me to change something before,
please ping me!

[1]:
https://salsa.debian.org/webext-team/nostalgy/compare/86162e07...01a130b1

-- 
  ,''`.
 : :'  : Louis-Philippe Véronneau
 `. `'`  po...@debian.org / veronneau.org
   `-



signature.asc
Description: OpenPGP digital signature

Bug#836609: [Pkg-mozext-maintainers] Bug#836609: nostalgy: please make the build reproducible

[Sean Whitton]

Hello Chris,

On Sun, Feb 19, 2017 at 11:05:34AM +1300, Chris Lamb wrote:
> > Would you consider applying this patch and uploading?
> 
> Friendly ping on this :)

It would surely be inadvisable to upload this to unstable during the freeze.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#836609: nostalgy: please make the build reproducible

[Chris Lamb]

> Would you consider applying this patch and uploading?

Friendly ping on this :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#836609: nostalgy: please make the build reproducible

[Chris Lamb]

Dear Maintainer,

> Source: nostalgy
> Version: 0.2.34-1
> Tags: patch

There hasn't seem to be any update on this bug in 63 days, in which
time the Reproducible Builds effort has come on a long way. :)

Would you consider applying this patch and uploading?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#836609: nostalgy: please make the build reproducible

[Chris Lamb]

Source: nostalgy
Version: 0.2.34-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that nostalgy could not be built reproducibly.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/patches/0003-Reproducible-build.patch  1970-01-01 
01:00:00.0 +0100
--- b/debian/patches/0003-Reproducible-build.patch  2016-09-04 
13:56:42.262802348 +0100
@@ -0,0 +1,18 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2016-09-04
+
+--- nostalgy-0.2.34.orig/build.sh
 nostalgy-0.2.34/build.sh
+@@ -72,7 +72,10 @@ find content -path '*.svn*' -prune -o -t
+ find locale -path '*.svn*' -prune -o -type f -print | grep -v \~ >> files
+ 
+ 
+-cat files | zip -0 $JAR_FILE -@
++if [ -n "$SOURCE_DATE_EPOCH" ]; then
++  cat files | xargs -r touch --no-dereference --date="@${SOURCE_DATE_EPOCH}"
++fi
++LC_ALL=C sort files | zip -0 $JAR_FILE -@
+ # The following statement should be used instead if you don't wish to use the 
JAR file
+ #cp --verbose --parents `cat files` $TMP_DIR/chrome
+ 
--- a/debian/patches/series 2016-09-04 13:52:14.384034333 +0100
--- b/debian/patches/series 2016-09-04 13:56:41.182791060 +0100
@@ -1,2 +1,3 @@
 0001-Remove-cleanup-from-the-build.patch
 0002-Fix-RDF-syntax.patch
+0003-Reproducible-build.patch