Bug#839486: lhasa: FTBFS: Tests failures

[Jonathan Dowland]

On Tue, Oct 11, 2016 at 12:46:46PM +0100, James Cowgill wrote:
> Control: tags -1 patch

Thanks for looking at this!

-- 
Jonathan Dowland


signature.asc
Description: Digital signature

Bug#839486: lhasa: FTBFS: Tests failures

[James Cowgill]

Control: tags -1 patch

Hi,

On Sat, 1 Oct 2016 16:16:05 +0200 Lucas Nussbaum  wrote:
> Source: lhasa
> Version: 0.3.1-1
> Severity: serious
> Tags: stretch sid
> User: debian...@lists.debian.org
> Usertags: qa-ftbfs-20161001 qa-ftbfs
> Justification: FTBFS on amd64
> 
> Hi,
> 
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
[...]
> FAIL: test-file-headers
> ===
> 
> --- output/larc333/lz4.lzs-hdr.txt2016-03-30 02:24:28.0 +
> +++ /tmp/lhasa-test.bbrkwr/hdr.txt2016-10-01 11:46:04.06800 +
> @@ -5,5 +5,5 @@
>  header_level: 0
>  os_type: 0
>  crc: b6d5
> -timestamp: 1273184274
> +timestamp: 1273187874
>  --
> Output not as expected for larc333/lz4.lzs
> rmdir: failed to remove '/tmp/lhasa-test.bbrkwr': Directory not empty
> FAIL test-file-headers (exit status: 1)

This appears to be due to timezone differences on the build machine.
test/test_common.sh handles this using:

TZ=Europe/London
export TZ

But this doesn't work if tzdata isn't installed!

Applying the attached patch to add tzdata to the build dependencies
fixes this bug for me.

Thanks,
James
diff -ur a/debian/control b/debian/control
--- a/debian/control	2016-03-31 20:08:13.0 +
+++ b/debian/control	2016-10-11 11:42:20.257704348 +
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Jonathan Dowland 
 Build-Depends: debhelper (>= 9.20120115), automake (>= 1:1.11.3),
-   autoconf (>= 2.68), libtool (>= 2.4.2)
+   autoconf (>= 2.68), libtool (>= 2.4.2), tzdata
 Standards-Version: 3.9.6
 Homepage: http://fragglet.github.com/lhasa/
 Vcs-Browser: http://anonscm.debian.org/cgit/collab-maint/lhasa.git


signature.asc
Description: OpenPGP digital signature

Bug#839486: lhasa: FTBFS: Tests failures

[Lucas Nussbaum]

Source: lhasa
Version: 0.3.1-1
Severity: serious
Tags: stretch sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20161001 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> Please report to frag...@gmail.com
> 
> Makefile:783: recipe for target 'test-suite.log' failed
> make[5]: *** [test-suite.log] Error 1
> make[5]: Leaving directory '/<>/test'
> Makefile:889: recipe for target 'check-TESTS' failed
> make[4]: *** [check-TESTS] Error 2
> make[4]: Leaving directory '/<>/test'
> Makefile:1025: recipe for target 'check-am' failed
> make[3]: *** [check-am] Error 2
> make[3]: Leaving directory '/<>/test'
> Makefile:468: recipe for target 'check-recursive' failed
> make[2]: *** [check-recursive] Error 1
> make[2]: Leaving directory '/<>'
> dh_auto_test: make -j1 check VERBOSE=1 VERBOSE=true returned exit code 2
> debian/rules:9: recipe for target 'override_dh_auto_test' failed

If the failure looks somehow time/timezone related:
Note that this rebuild was performed without the 'tzdata' package
installed in the chroot. tzdata used be (transitively) part of
build-essential, but it no longer is. If this package requires it to
build, it should be added to build-depends. For the release team's
opinion on this, see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836940#185

If the failure looks LSB-related:
similarly to tzdata, lsb-base is not installed in the build chroot.

The full build log is available from:
   http://aws-logs.debian.net/2016/10/01/lhasa_0.3.1-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.