Bug#840940: src:rsyslog: Please disable DNS resolution in the test suite
Control: tags -1 + moreinfo On Sun, 16 Oct 2016 13:13:04 +0200 Christoph Biedl wrote: > Package: src:rsyslog > Version: 8.22.0-1 > Severity: normal > Tags: patch > > Dear Maintainer, > > for reasons I rebuild the rsyslog package. Quite some time ago, must be > at least a year, rebuild started failing due to errors in the test > suite. This left me somewhat in confusion since this happens on > different hosts and different archs while the Debian buildds > appearently never have a problem with it. > > After a long debugging session I finally realized the reason for > imptcp_conndrop.sh failing here is an incoming connection rate limit hit > on the DNS server my build hosts access. No big surprise then since > stress testing is part of the test suite and there actually are DNS > requests triggered by the rsyslogd started as part of a test. > > While I will certainly review the rate limiting settings, can you > please disable that kind of name server resolution during tests? Above > all, this should speed up the test suite execution a little bit, > something nobody would object. The patch below defines RES_OPTIONS > as recently suggested in debian-devel and works for me. > > This might also raise the question whether src:rsyslog violates the > "must not attempt network access" policy but I'll happily leave this to > other to decide. > > The remaining failures still require investigation. Some are AFAICT > related to my build system (wild guess: As the list is more or less > identical to the second section you listed in #785101[*], this might be > a bug in the inotify handling of the overlay filesystem). > > Christoph > > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -1,6 +1,10 @@ > if ENABLE_TESTBENCH > CLEANFILES = \ > IN_AUTO_DEBUG > + > +# disable network access through DNS > +export RES_OPTIONS=attempts:0 I have no idea how this affects the test suite, so I'm not sure if it's safe to add this. In any case, looping in Rainer here as this touches the upstream build system. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature
Bug#840940: src:rsyslog: Please disable DNS resolution in the test suite
Christoph Biedl wrote... > The remaining failures still require investigation. Some are AFAICT > related to my build system (wild guess: As the list is more or less > identical to the second section you listed in #785101[*], this might be > a bug in the inotify handling of the overlay filesystem). Dangling footnote: [*] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=785101#20 signature.asc Description: Digital signature
Bug#840940: src:rsyslog: Please disable DNS resolution in the test suite
Package: src:rsyslog Version: 8.22.0-1 Severity: normal Tags: patch Dear Maintainer, for reasons I rebuild the rsyslog package. Quite some time ago, must be at least a year, rebuild started failing due to errors in the test suite. This left me somewhat in confusion since this happens on different hosts and different archs while the Debian buildds appearently never have a problem with it. After a long debugging session I finally realized the reason for imptcp_conndrop.sh failing here is an incoming connection rate limit hit on the DNS server my build hosts access. No big surprise then since stress testing is part of the test suite and there actually are DNS requests triggered by the rsyslogd started as part of a test. While I will certainly review the rate limiting settings, can you please disable that kind of name server resolution during tests? Above all, this should speed up the test suite execution a little bit, something nobody would object. The patch below defines RES_OPTIONS as recently suggested in debian-devel and works for me. This might also raise the question whether src:rsyslog violates the "must not attempt network access" policy but I'll happily leave this to other to decide. The remaining failures still require investigation. Some are AFAICT related to my build system (wild guess: As the list is more or less identical to the second section you listed in #785101[*], this might be a bug in the inotify handling of the overlay filesystem). Christoph --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,6 +1,10 @@ if ENABLE_TESTBENCH CLEANFILES = \ IN_AUTO_DEBUG + +# disable network access through DNS +export RES_OPTIONS=attempts:0 + # IN_AUTO_DEBUG should be deleted each time make check is run, but # there exists no such hook. Se we at least delete it on make clean. -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 4.4.24 (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Init: unable to detect signature.asc Description: Digital signature
