Bug#862195: sendip: please make the build reproducible

[Jonathan McDowell]

Control: tags -1 + pending

On Tue, Sep 01, 2020 at 10:58:10PM -, Chris Lamb wrote:
> Dear Maintainer,
> 
> > Source: sendip
> > Version: 2.5-7
> > Tags: patch
> 
> There hasn't seem to be any update on this bug in 1210 days, in which
> time the Reproducible Builds effort has come on a long way.
> 
> Would you consider applying this patch and uploading?

That's, er, a perfectly reasonable request after such a long time. The
package needs some other cleanup, but I've applied your patch to the
current work:

https://salsa.debian.org/noodles/sendip/-/commit/c0757c237448e8d16d90084a73fd11b84bbead87

J.

-- 
Revd Jonathan McDowell, ULC | Shopping is hard. Let's do Math!

Bug#862195: sendip: please make the build reproducible

[Chris Lamb]

Dear Maintainer,

> Source: sendip
> Version: 2.5-7
> Tags: patch

There hasn't seem to be any update on this bug in 1210 days, in which
time the Reproducible Builds effort has come on a long way.

Would you consider applying this patch and uploading?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#862195: sendip: please make the build reproducible

[Chris Lamb]

Source: sendip
Version: 2.5-7
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that sendip could not be built reproducibly.

This is because it uses an embedded copy of help2man which does
not support SOURCE_DATE_EPOCH.

Patch attached to use the Debian-supplied one (which it should be
doing anyway, I suppose...)


 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/control2017-05-09 17:34:12.813413625 +0100
--- b/debian/control2017-05-09 17:34:58.141642157 +0100
@@ -3,7 +3,7 @@
 Priority: optional
 Section: net
 Standards-Version: 3.9.3
-Build-Depends: debhelper (>= 8)
+Build-Depends: debhelper (>= 8), help2man
 Homepage: http://www.earth.li/projectpurple/progs/sendip.html
 
 Package: sendip
--- a/debian/patches/08-reproducible-build.diff 1970-01-01 01:00:00.0 
+0100
--- b/debian/patches/08-reproducible-build.diff 2017-05-09 17:35:34.197825457 
+0100
@@ -0,0 +1,17 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2017-05-09
+
+--- sendip-2.5.orig/Makefile
 sendip-2.5/Makefile
+@@ -42,8 +42,8 @@ else \
+ $(CC) -o $@ $(LDFLAGS) $(CFLAGS) $+ ; \
+ fi"
+ 
+-sendip.1: ./help2man $(PROGS) $(PROTOS) VERSION
+-  ./help2man -n "Send arbitrary IP packets" -N >sendip.1
++sendip.1:
++  help2man -n "Send arbitrary IP packets" -N ./sendip >sendip.1
+ 
+ sendip.spec:  sendip.spec.in VERSION
+   echo -n '%define ver ' >sendip.spec
--- a/debian/patches/series 2017-05-09 17:34:12.813413625 +0100
--- b/debian/patches/series 2017-05-09 17:35:10.957707162 +0100
@@ -5,3 +5,4 @@
 05-as-needed.diff
 06-clang-fix.diff
 07-gcc-5-fix.diff
+08-reproducible-build.diff