Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2018-01-11 Thread Pino Toscano
On giovedì 11 gennaio 2018 10:03:14 CET Simon McVittie wrote:
> Version: 1.36+u20180108~dfsg-1
> 
> On Sat, 30 Dec 2017 at 11:16:55 +0100, Pino Toscano wrote:
> > your package depends or recommends a package which used to provide the
> > kdialog utility.  Now kdialog is shipped in an own source and binary,
> > so the package relation can be adjusted to use it directly.
> 
> This is now fixed, although I forgot to add the bug number to the
> changelog.

Thanks!  Feel free to close this bug, then.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.


Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2018-01-11 Thread Simon McVittie
Version: 1.36+u20180108~dfsg-1

On Sat, 30 Dec 2017 at 11:16:55 +0100, Pino Toscano wrote:
> your package depends or recommends a package which used to provide the
> kdialog utility.  Now kdialog is shipped in an own source and binary,
> so the package relation can be adjusted to use it directly.

This is now fixed, although I forgot to add the bug number to the
changelog. Equivalent changes in game-data-packager, iortcw, opentyrian
and rott are still pending.

smcv



Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2017-12-30 Thread Simon McVittie
On Sat, 30 Dec 2017 at 17:29:12 +0100, Pino Toscano wrote:
> On sabato 30 dicembre 2017 16:17:04 CET Simon McVittie wrote:
> > - quake3 (src:game-data-packager)
> > - opentyrian
> > - rott
> > - rtcw (src:iortcw)
>
> Yes, all of them use kdialog, so switching from kde-baseapps-bin &
> kdebase-bin to kdialog is indeed the right change here.

Thanks, all fixed in their respective git repositories. quake3 and rtcw
are on my radar anyway; the other two I don't really maintain, but I'm
in the team that does, and I'll upload them eventually if nobody gets
there first.

smcv



Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2017-12-30 Thread Pino Toscano
On sabato 30 dicembre 2017 16:17:04 CET Simon McVittie wrote:
> On Sat, 30 Dec 2017 at 12:43:16 +0100, Pino Toscano wrote:
> > My medium-term goal is to get rid of them, at least for
> > Buster, and there are other 6 bugs like this one.
> 
> Should dependencies on kde-baseapps-bin for kdialog also be updated to
> point to the new kdialog package?

Yes, I filed bugs for those too... but forgot to check contrib and
non-free, it seems :-/

> Affected game packages, which I'm happy to deal with myself (no need for bugs 
> or
> patches for these):
> 
> - quake3 (src:game-data-packager)
> - opentyrian
> - rott
> - rtcw (src:iortcw)
> 
> I'm reasonably sure all of those are only using kdialog and not other
> KDE binaries. At some point I might patch ioquake3 and iortcw to use
> SDL_ShowMessageBox() so that they never need xmessage/zenity/kdialog,
> but until then, shrinking the dependency seems good.

Yes, all of them use kdialog, so switching from kde-baseapps-bin &
kdebase-bin to kdialog is indeed the right change here.  (The other
binary that is still currently provided by kde-baseapps-bin is
keditbookmarks, but it is not used directly usually.)

Thanks,
-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.


Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2017-12-30 Thread Simon McVittie
On Sat, 30 Dec 2017 at 12:43:16 +0100, Pino Toscano wrote:
> My medium-term goal is to get rid of them, at least for
> Buster, and there are other 6 bugs like this one.

Should dependencies on kde-baseapps-bin for kdialog also be updated to
point to the new kdialog package?

Affected game packages, which I'm happy to deal with myself (no need for bugs or
patches for these):

- quake3 (src:game-data-packager)
- opentyrian
- rott
- rtcw (src:iortcw)

I'm reasonably sure all of those are only using kdialog and not other
KDE binaries. At some point I might patch ioquake3 and iortcw to use
SDL_ShowMessageBox() so that they never need xmessage/zenity/kdialog,
but until then, shrinking the dependency seems good.

Thanks,
smcv



Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2017-12-30 Thread Pino Toscano
On sabato 30 dicembre 2017 11:39:31 CET Simon McVittie wrote:
> On Sat, 30 Dec 2017 at 11:16:55 +0100, Pino Toscano wrote:
> > your package depends or recommends a package which used to provide the
> > kdialog utility.  Now kdialog is shipped in an own source and binary,
> > so the package relation can be adjusted to use it directly.
> 
> Thanks, I've applied your patch for the next upload. It's the third in a
> set of alternative dependencies, so I'm not going to rush to upload this.

No hurry, queueing it for the next upload, whenever it will be, sounds
great to me.  My medium-term goal is to get rid of them, at least for
Buster, and there are other 6 bugs like this one.

Thanks!
-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.


Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2017-12-30 Thread Simon McVittie
Control: tags -1 + pending

On Sat, 30 Dec 2017 at 11:16:55 +0100, Pino Toscano wrote:
> your package depends or recommends a package which used to provide the
> kdialog utility.  Now kdialog is shipped in an own source and binary,
> so the package relation can be adjusted to use it directly.

Thanks, I've applied your patch for the next upload. It's the third in a
set of alternative dependencies, so I'm not going to rush to upload this.

smcv



Bug#885839: ioquake3: please migrate kdebase-bin relationship to kdialog

2017-12-30 Thread Pino Toscano
Package: ioquake3
Version: 1.36+u20171216~dfsg-1
Severity: wishlist
Tags: patch

Dear Maintainer,

your package depends or recommends a package which used to provide the
kdialog utility.  Now kdialog is shipped in an own source and binary,
so the package relation can be adjusted to use it directly.

Attached there is a patch for this.

Thanks,
-- 
Pino
--- a/debian/control
+++ b/debian/control
@@ -30,7 +30,7 @@ Depends:
  ${misc:Depends},
  ${shlibs:Depends},
 Recommends:
- x11-utils | zenity | kdebase-bin,
+ x11-utils | zenity | kdialog,
 Breaks:
  openarena (<< 0.8.8-9~),
 Description: Game engine for 3D first person shooter games