Bug#901771: Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Simon McVittie]

On Thu, 28 Jun 2018 at 13:01:37 +0100, Simon McVittie wrote:
> I'm escalating #901771 to RC, because d-shlibs is clearly
> not helping here, and the solution is trivial; see attached
> 0001-Add-quirk-for-libfribidi-dev.patch, which I have confirmed fixes the
> build of src:libgtkdatabox

Sorry, here's that patch. Also available from
https://salsa.debian.org/debian/d-shlibs/merge_requests/2

smcv
>From 52a1ecd72ba4205764e9c1441f464881c2608e6d Mon Sep 17 00:00:00 2001
From: Simon McVittie 
Date: Thu, 28 Jun 2018 12:00:26 +0100
Subject: [PATCH 1/4] Add quirk for libfribidi-dev

Closes: #901771
---
 d-devlibdeps | 1 +
 1 file changed, 1 insertion(+)

diff --git a/d-devlibdeps b/d-devlibdeps
index 71fffa1..e805491 100755
--- a/d-devlibdeps
+++ b/d-devlibdeps
@@ -82,6 +82,7 @@ overridedevlibdeps() {
 		-e 's/libeXosip2-[0-9]\+-dev/libexosip2-dev/' \
 		-e 's/libf2clibf2c.so-dev/libf2c2-dev/' \
 		-e 's/libffado2-dev/libffado-dev/' \
+		-e 's/libfribidi0-dev/libfribidi-dev/' \
 		-e 's/libGenome-\([.0-9]\+\)-[0-9]\+-dev/libgenome-\1-dev/' \
 		-e 's/libGL1-dev/xlibmesa-gl-dev/' \
 		-e 's/libGLU1-dev/xlibmesa-glu-dev/' \
-- 
2.18.0

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Simon McVittie]

Control: affects 901771 src:gtkdataboxmm src:libgtkdatabox src:osm-gps-map 
src:sugar-toolkit-gtk3 src:fontforge
Control: severity 901771 serious
Control: tags 901771 + patch

On Thu, 19 Apr 2018 at 23:56:18 -0400, Jeremy Bicha wrote:
> The build itself completes fine. If pango were broken, I'd expect a
> lot more bug reports.
> 
> But it's the d-shlibmove command that fails. Note this line in the build log:
> 
> > devlibs error: There is no package matching [libfribidi0-dev] and noone
> > provides it, please report bug to d-shlibs maintainer

On Fri, 20 Apr 2018 at 09:09:12 +0300, Adrian Bunk wrote:
> d-devlibdeps basically contains a manual mapping to the -dev packages 
> in such cases, this is horribly fragile.

I was about to clone this bug to d-shlibs, because that's clearly a bug
in d-shlibs, orthogonal to whether anything is wrong with pango1.0; but
 was reported
in the meantime, so let's use that one instead.

I'm escalating #901771 to RC, because d-shlibs is clearly
not helping here, and the solution is trivial; see attached
0001-Add-quirk-for-libfribidi-dev.patch, which I have confirmed fixes the
build of src:libgtkdatabox (patches also on the way for the existing RC
bug #897539). I've also opened a bug suggesting that d-devlibdeps should
be deprecated.

> In this specific case the root problem is that using pango results in 
> needlessly linking with libfribidi, which can also become annoying for
> transitions.
> 
> This would otherwise not be a FTBFS-causing RC bug, but it is an easily 
> fixable bug that should be fixed.

Normally, I'd say fribidi should be moved from Requires
to Requires.private (or the Requires.internal proposed on
, but that doesn't
exist yet) to resolve this while not breaking static linking; and I'd
also say we should augment debian/tests/build to exercise static linking,
to prove that that can still work.

However, libfribidi in Debian doesn't provide a static library
any more, so static linking can't actually work anyway. I've asked
fribidi upstream whether they intend to be only supporting shared
linking, or whether their change of defaults was misinterpreted by
the Debian maintainer of fribidi as having been a policy change:
https://github.com/fribidi/fribidi/issues/83

Either moving this dependency from Requires to Requires.private or
removing it altogether is clearly an improvement, so I think we should
do one or the other, and I'm very tempted to pick one arbitrarily and
JFDI, with the intention of swapping to the other if the result of
fribidi#83 indicates that the opposite would be better.

smcv

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Jeremy Bicha]

On Fri, Apr 20, 2018 at 3:02 AM, Adrian Bunk  wrote:
> Moving fribidi from Requires to Requires.private would fix this
> unnecessary linking.

I suggested that upstream, but the upstream developer was a bit
confused by the situation and just removed fribidi from the .pc file
completely unless someone can better explain what needs to be done.

Could someone interested in this issue follow up at
https://bugzilla.gnome.org/794570

Thanks,
Jeremy Bicha

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Adrian Bunk]

On Fri, Apr 20, 2018 at 02:25:15AM -0400, Jeremy Bicha wrote:
> On Fri, Apr 20, 2018 at 2:09 AM, Adrian Bunk  wrote:
> > Control: reassign -1 libpango1.0-dev 1.42.1-1
> > Control: retitle -1 "pkg-config --libs pango" incorrectly contains -lfribidi
> >
> > On Thu, Apr 19, 2018 at 11:56:18PM -0400, Jeremy Bicha wrote:
> >> Control: reassign -1 d-shlibs 0.82
> >>
> >> The build itself completes fine. If pango were broken, I'd expect a
> >> lot more bug reports.
> >>
> >> But it's the d-shlibmove command that fails. Note this line in the build 
> >> log:
> >>
> >> > devlibs error: There is no package matching [libfribidi0-dev] and noone
> >> > provides it, please report bug to d-shlibs maintainer
> >>
> >> Therefore I am reassigning.
> >
> > d-devlibdeps basically contains a manual mapping to the -dev packages
> > in such cases, this is horribly fragile.
> >
> > In this specific case the root problem is that using pango results in
> > needlessly linking with libfribidi, which can also become annoying for
> > transitions.
> 
> My understanding is that pango's recent linking with libfribidi is
> definitely intentional and there is nothing to fix in pango.
>...

pango linking with libfribidi is intentional and correct.

But making everything that links with pango also link directly with
libfribidi is not required, this is an implementation detail of pango
that could change at any point.

Moving fribidi from Requires to Requires.private would fix this 
unnecessary linking.

> Thanks,
> Jeremy Bicha

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Jeremy Bicha]

On Fri, Apr 20, 2018 at 2:09 AM, Adrian Bunk  wrote:
> Control: reassign -1 libpango1.0-dev 1.42.1-1
> Control: retitle -1 "pkg-config --libs pango" incorrectly contains -lfribidi
>
> On Thu, Apr 19, 2018 at 11:56:18PM -0400, Jeremy Bicha wrote:
>> Control: reassign -1 d-shlibs 0.82
>>
>> The build itself completes fine. If pango were broken, I'd expect a
>> lot more bug reports.
>>
>> But it's the d-shlibmove command that fails. Note this line in the build log:
>>
>> > devlibs error: There is no package matching [libfribidi0-dev] and noone
>> > provides it, please report bug to d-shlibs maintainer
>>
>> Therefore I am reassigning.
>
> d-devlibdeps basically contains a manual mapping to the -dev packages
> in such cases, this is horribly fragile.
>
> In this specific case the root problem is that using pango results in
> needlessly linking with libfribidi, which can also become annoying for
> transitions.

My understanding is that pango's recent linking with libfribidi is
definitely intentional and there is nothing to fix in pango.

I think those packages that use d-shlibs just need to add an override
for the correct name of libfribidi-dev. Or d-shlibs can do it itself.

Thanks,
Jeremy Bicha

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Adrian Bunk]

Control: reassign -1 libpango1.0-dev 1.42.1-1
Control: retitle -1 "pkg-config --libs pango" incorrectly contains -lfribidi

On Thu, Apr 19, 2018 at 11:56:18PM -0400, Jeremy Bicha wrote:
> Control: reassign -1 d-shlibs 0.82
> 
> The build itself completes fine. If pango were broken, I'd expect a
> lot more bug reports.
> 
> But it's the d-shlibmove command that fails. Note this line in the build log:
> 
> > devlibs error: There is no package matching [libfribidi0-dev] and noone
> > provides it, please report bug to d-shlibs maintainer
> 
> Therefore I am reassigning.

d-devlibdeps basically contains a manual mapping to the -dev packages 
in such cases, this is horribly fragile.

In this specific case the root problem is that using pango results in 
needlessly linking with libfribidi, which can also become annoying for
transitions.

This would otherwise not be a FTBFS-causing RC bug, but it is an easily 
fixable bug that should be fixed.

> Thanks,
> Jeremy Bicha

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Jeremy Bicha]

Control: reassign -1 d-shlibs 0.82

The build itself completes fine. If pango were broken, I'd expect a
lot more bug reports.

But it's the d-shlibmove command that fails. Note this line in the build log:

> devlibs error: There is no package matching [libfribidi0-dev] and noone
> provides it, please report bug to d-shlibs maintainer

Therefore I am reassigning.

Thanks,
Jeremy Bicha

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Adrian Bunk]

Control: reassign -1 libpango1.0-dev 1.42.1-1
Control: retitle -1 "pkg-config --libs pango" incorrectly contains -lfribidi
Control: affects -1 src:sugar-toolkit-gtk3 src:osm-gps-map src:gtkdataboxmm 
src:fontforge

On Sun, Apr 08, 2018 at 08:12:42PM +0300, Adrian Bunk wrote:
> Source: sugar-toolkit-gtk3
> Version: 0.112-1
> Severity: serious
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/sugar-toolkit-gtk3.html
> 
> ...
> d-shlibmove --commit \
>   --multiarch \
>   --exclude-la --exclude-a \
>   --devunversioned --ignorelibdep \
>   --movedev debian/tmp/usr/share/gir-1.0 usr/share/ \
>   --extralib 
> debian/tmp/usr/lib/x86_64-linux-gnu/libsugar-eventcontroller.so \
>   debian/tmp/usr/lib/x86_64-linux-gnu/libsugarext.so
> Library package automatic movement utility
>  --> libasound2-dev package exists.
>  --> libatk1.0-dev package exists.
>  --> libcairo-dev is provided by a package.
>  --> libcairo2-dev package exists.
> devlibs error: There is no package matching [libfribidi0-dev] and noone 
> provides it, please report bug to d-shlibs maintainer
>  --> libglib2.0-dev package exists.
>  --> libgtk-3-dev package exists.
>  --> libgtk2.0-dev package exists.
>  --> libice-dev package exists.
>  --> libpango1.0-dev package exists.
>  --> librsvg2-dev package exists.
>  --> libsm-dev package exists.
>  --> libx11-dev package exists.
>  --> libxfixes-dev package exists.
>  --> libxi-dev package exists.
> make: *** [debian/rules:118: debian/stamp-local-shlibs-libsugarext] Error 1

The root cause is:

$ pkg-config --libs pango
-lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfribidi 
$

See also
  https://bugzilla.gnome.org/show_bug.cgi?id=794570#c2

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#895235: sugar-toolkit-gtk3 FTBFS: devlibs error: There is no package matching [libfribidi0-dev] and noone provides it

[Adrian Bunk]

Source: sugar-toolkit-gtk3
Version: 0.112-1
Severity: serious

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/sugar-toolkit-gtk3.html

...
d-shlibmove --commit \
--multiarch \
--exclude-la --exclude-a \
--devunversioned --ignorelibdep \
--movedev debian/tmp/usr/share/gir-1.0 usr/share/ \
--extralib 
debian/tmp/usr/lib/x86_64-linux-gnu/libsugar-eventcontroller.so \
debian/tmp/usr/lib/x86_64-linux-gnu/libsugarext.so
Library package automatic movement utility
 --> libasound2-dev package exists.
 --> libatk1.0-dev package exists.
 --> libcairo-dev is provided by a package.
 --> libcairo2-dev package exists.
devlibs error: There is no package matching [libfribidi0-dev] and noone 
provides it, please report bug to d-shlibs maintainer
 --> libglib2.0-dev package exists.
 --> libgtk-3-dev package exists.
 --> libgtk2.0-dev package exists.
 --> libice-dev package exists.
 --> libpango1.0-dev package exists.
 --> librsvg2-dev package exists.
 --> libsm-dev package exists.
 --> libx11-dev package exists.
 --> libxfixes-dev package exists.
 --> libxi-dev package exists.
make: *** [debian/rules:118: debian/stamp-local-shlibs-libsugarext] Error 1