Bug#909843: libfiu: frequent parallel FTBFS

2018-10-01 Thread Chris Lamb
tags 909843 + pending
thanks

Hi Alberto,


> >> https://blitiri.com.ar/git/r/libfiu/c/b4c21a6b2a714c1ad9cdfe96358f843688c3a77e/
> >
> >Still no way of getting a patch from the web interface, out of
> >interest?
> 
> Just implemented it :)

Applied & uploaded... Many thanks.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#909843: libfiu: frequent parallel FTBFS

2018-10-01 Thread Alberto Bertogli

On Mon, Oct 01, 2018 at 10:34:51AM +0100, Chris Lamb wrote:

Hi Alberto,


I think this newly written patch fixes the problem:
https://blitiri.com.ar/git/r/libfiu/c/b4c21a6b2a714c1ad9cdfe96358f843688c3a77e/


Still no way of getting a patch from the web interface, out of
interest?


Just implemented it :)

Append ".patch" to the commit base path, like this:
https://blitiri.com.ar/git/r/libfiu/c/0d4f662733045f0e3f6e2936e94518cd4186129e.patch

Let me know if something doesn't work, I did this 5s ago so there could 
be bugs or issues.




I'm having a problem even getting this from the git
repository itself:

 $ git clone https://blitiri.com.ar/repos/libfiu
 $ cd libfiu
 $ git show b4c21a6b2a714c1ad9cdfe96358f843688c3a77e
 fatal: bad object b4c21a6b2a714c1ad9cdfe96358f843688c3a77e


Sorry, my bad. I rebased the branch afterwards (for unrelated reasons).

Try commit: 0d4f662733045f0e3f6e2936e94518cd4186129e

https://blitiri.com.ar/git/r/libfiu/c/0d4f662733045f0e3f6e2936e94518cd4186129e/
https://blitiri.com.ar/git/r/libfiu/c/0d4f662733045f0e3f6e2936e94518cd4186129e.patch

Thanks,
Alberto



Bug#909843: libfiu: frequent parallel FTBFS

2018-10-01 Thread Chris Lamb
Hi Alberto,

> I think this newly written patch fixes the problem:
> https://blitiri.com.ar/git/r/libfiu/c/b4c21a6b2a714c1ad9cdfe96358f843688c3a77e/

Still no way of getting a patch from the web interface, out of
interest? I'm having a problem even getting this from the git
repository itself:

  $ git clone https://blitiri.com.ar/repos/libfiu
  $ cd libfiu
  $ git show b4c21a6b2a714c1ad9cdfe96358f843688c3a77e
  fatal: bad object b4c21a6b2a714c1ad9cdfe96358f843688c3a77e
  $ echo $?
  128


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#909843: libfiu: frequent parallel FTBFS

2018-09-29 Thread Alberto Bertogli

On Sat, Sep 29, 2018 at 06:45:53PM +0100, Alberto Bertogli wrote:

On Sat, Sep 29, 2018 at 03:36:51PM +0300, Adrian Bunk wrote:

./wrap-python 2 ./test-fiu_ctrl.py
./wrap-python 2 ./test-basic.py
cc -I../../libfiu/ -L../../libfiu/ -D_XOPEN_SOURCE=600 -D_GNU_SOURCE -fPIC 
-DFIU_ENABLE=1 -g -O2 -fdebug-prefix-map=/build/libfiu-0.96=. 
-fstack-protector-strong -Wformat -Werror=format-security -std=c99 -pedantic 
-Wall -std=c99 -pedantic -Wall tests/open.c -lfiu -o tests/open.bin
Traceback (most recent call last):
File "./test-fiu_ctrl.py", line 21, in 
  cmd = run_cat()
File "./test-fiu_ctrl.py", line 16, in run_cat
  return fiu_ctrl.Subprocess(["./small-cat"],
AttributeError: 'module' object has no attribute 'Subprocess'


This is weird.

fiu_ctrl.py definitely defines a class Subprocess, so if the file is 
there and with the proper contents, this should work.


I think this might be caused by building python2 and python3 in 
parallel, because both builds could attempt to generate fiu_ctrl.py 
and they might be stepping onto each other, to the point where one 
copies a partial (or empty) file as the module.


But that's just a wild theory at this point, I will look into it a bit 
more and post again once I have any news.


I think that's what happened.

I can't reproduce it despite multiple runs, probably because of the race 
being too small in my laptop; however, everything I've seen points to 
this being the cause.


I think this newly written patch fixes the problem:
https://blitiri.com.ar/git/r/libfiu/c/b4c21a6b2a714c1ad9cdfe96358f843688c3a77e/


Chris, if you want to give the above patch a try, please go ahead.

That said, I'm going to cut a release soon (I'm waiting on someone's 
confirmation of other unrelated patches), so you might want to consider 
waiting instead :)


Thanks!
Alberto



Bug#909843: libfiu: frequent parallel FTBFS

2018-09-29 Thread Alberto Bertogli

On Sat, Sep 29, 2018 at 03:36:51PM +0300, Adrian Bunk wrote:

./wrap-python 2 ./test-fiu_ctrl.py
./wrap-python 2 ./test-basic.py
cc -I../../libfiu/ -L../../libfiu/ -D_XOPEN_SOURCE=600 -D_GNU_SOURCE -fPIC 
-DFIU_ENABLE=1 -g -O2 -fdebug-prefix-map=/build/libfiu-0.96=. 
-fstack-protector-strong -Wformat -Werror=format-security -std=c99 -pedantic 
-Wall -std=c99 -pedantic -Wall tests/open.c -lfiu -o tests/open.bin
Traceback (most recent call last):
 File "./test-fiu_ctrl.py", line 21, in 
   cmd = run_cat()
 File "./test-fiu_ctrl.py", line 16, in run_cat
   return fiu_ctrl.Subprocess(["./small-cat"],
AttributeError: 'module' object has no attribute 'Subprocess'


This is weird.

fiu_ctrl.py definitely defines a class Subprocess, so if the file is 
there and with the proper contents, this should work.


I think this might be caused by building python2 and python3 in 
parallel, because both builds could attempt to generate fiu_ctrl.py and 
they might be stepping onto each other, to the point where one copies a 
partial (or empty) file as the module.


But that's just a wild theory at this point, I will look into it a bit 
more and post again once I have any news.


Thanks,
Alberto



Bug#909843: libfiu: frequent parallel FTBFS

2018-09-29 Thread Adrian Bunk
Source: libfiu
Version: 0.96-4
Severity: important
Tags: ftbfs

https://tests.reproducible-builds.org/debian/history/libfiu.html
https://tests.reproducible-builds.org/debian/rb-pkg/buster/armhf/libfiu.html

...
ln -f ../preload/posix/fiu_posix_preload.so libs/
ln -f ../preload/run/fiu_run_preload.so libs/
LD_LIBRARY_PATH=../libfiu/ ./test-parallel-wildcard
cc -I../../libfiu/ -L../../libfiu/ -D_XOPEN_SOURCE=600 -D_GNU_SOURCE -fPIC 
-DFIU_ENABLE=1 -g -O2 -fdebug-prefix-map=/build/libfiu-0.96=. 
-fstack-protector-strong -Wformat -Werror=format-security -std=c99 -pedantic 
-Wall -std=c99 -pedantic -Wall tests/kill.c -lfiu -o tests/kill.bin
LD_LIBRARY_PATH=../libfiu/ ./test-enable_stack
NOTE: fiu_enable_stack() failed, skipping test
LD_LIBRARY_PATH=../libfiu/ ./test-enable_stack_by_name
NOTE: fiu_enable_stack_by_name() failed, skipping test
./wrap-python 2 ./test-manyfps.py
./wrap-python 2 ./test-failinfo_refcount.py
./wrap-python 2 ./test-wildcards.py
./wrap-python 2 ./test-fiu_ctrl.py
./wrap-python 2 ./test-basic.py
cc -I../../libfiu/ -L../../libfiu/ -D_XOPEN_SOURCE=600 -D_GNU_SOURCE -fPIC 
-DFIU_ENABLE=1 -g -O2 -fdebug-prefix-map=/build/libfiu-0.96=. 
-fstack-protector-strong -Wformat -Werror=format-security -std=c99 -pedantic 
-Wall -std=c99 -pedantic -Wall tests/open.c -lfiu -o tests/open.bin
Traceback (most recent call last):
  File "./test-fiu_ctrl.py", line 21, in 
cmd = run_cat()
  File "./test-fiu_ctrl.py", line 16, in run_cat
return fiu_ctrl.Subprocess(["./small-cat"],
AttributeError: 'module' object has no attribute 'Subprocess'
make[3]: *** [Makefile:93: py-run-test-fiu_ctrl] Error 1