Bug#910966: RFS: 4pane/5.0-2

2018-10-16 Thread David Hart
Hi Herbert,

>My final comments so I can upload the package:
>The history of debian/changelog is been changed. Please,
>keep the history.

>+4pane (5.0-1) testing; urgency=medium
> 
>   * New upstream version.
> All the previous patches are now redundant and a dfsg tarball is
> no longer needed.
>-  * Bump std-version to 4.0.0, no changes needed
>-  * Update copyright file.
>-  * Add dependency on gettext, msgfmt is used by upstream build system
>-  * Update watch file

Ah. The 5.0-1 sponsor expanded my changelog entry, and I'd not updated that
here. Now fixed. Thank you for noticing it.

> - debian/rules does not need these two lines:
>-DPKG_EXPORT_BUILDFLAGS = 1
>-include /usr/share/dpkg/buildflags.mk

Also fixed.

Many thanks in advance for sponsoring!

Regards,

David Hart



Bug#910966: RFS: 4pane/5.0-2

2018-10-15 Thread Herbert Fortes

Hi,

My final comments so I can upload the package:

The history of debian/changelog is been changed. Please,
keep the history.

https://tracker.debian.org/media/packages/4/4pane/changelog-5.0-1

diff -Nru 4pane-5.0/debian/changelog 4pane-5.0/debian/changelog
--- 4pane-5.0/debian/changelog  2017-07-20 11:18:45.0 -0300
+++ 4pane-5.0/debian/changelog  2018-10-08 13:15:58.0 -0300
@@ -1,12 +1,19 @@
-4pane (5.0-1) unstable; urgency=medium
+4pane (5.0-2) unstable; urgency=medium
+
+  * Depend on the gtk+3 version of wxWidgets: see #894663
+  * Override testsuite-autopkgtest-missing
+  * Add an upstream/metadata file
+  * Move the appdata.xml file from appdata/ to metadata/
+  * Change some links from http: to https:
+  * Update to the latest debhelper and policy versions
+
+ -- David Hart   Mon, 08 Oct 2018 17:15:58 +0100
+
+4pane (5.0-1) testing; urgency=medium
 
   * New upstream version.

 All the previous patches are now redundant and a dfsg tarball is
 no longer needed.
-  * Bump std-version to 4.0.0, no changes needed
-  * Update copyright file.
-  * Add dependency on gettext, msgfmt is used by upstream build system
-  * Update watch file
 
  -- David Hart   Thu, 20 Jul 2017 15:18:45 +0100




 - debian/rules does not need these two lines:

diff -Nru 4pane-5.0/debian/rules 4pane-5.0/debian/rules
--- 4pane-5.0/debian/rules  2017-07-20 11:18:45.0 -0300
+++ 4pane-5.0/debian/rules  2018-10-08 13:15:58.0 -0300
@@ -3,8 +3,6 @@
 DH_VERBOSE = 1
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all

-DPKG_EXPORT_BUILDFLAGS = 1
-include /usr/share/dpkg/buildflags.mk



Regards,
Herbert



Bug#910966: RFS: 4pane/5.0-2

2018-10-14 Thread Herbert Fortes

On 10/14/18 11:24 AM, David Hart wrote:

Hi Herbert,


debian/changelog
- is "UNRELEASED".
- a comment: I never saw a changelog going to 'testing'. Like
   version 5.0-1. It is in Sid anyway. But there are less 4 lines
   in that part of the file


I wasn't sure what was right for that field. I've now changed it to 'unstable'.


debian/copyright
-  does not have a 'Files: debian/*". I never saw that either.


I don't think it's needed. As I'm both the packager and upstream, IIUC the
contents of a 'Files: debian/*' entry would just duplicate the overriding
'Files: *'. Please correct me if I'm mistaken.




I understand. I thought the same thing in a first time. And nobody
said anything before. Can not be wrong.

But then I thought the debian dir as a separated part. Not related
to other files.

If no sponsor does the upload the package before me, I will see it.



Regards,
Herbert



Bug#910966: RFS: 4pane/5.0-2

2018-10-14 Thread David Hart
Hi Herbert,

>debian/changelog
> - is "UNRELEASED".
> - a comment: I never saw a changelog going to 'testing'. Like
>   version 5.0-1. It is in Sid anyway. But there are less 4 lines
>   in that part of the file

I wasn't sure what was right for that field. I've now changed it to 'unstable'.

>debian/copyright
> -  does not have a 'Files: debian/*". I never saw that either.

I don't think it's needed. As I'm both the packager and upstream, IIUC the
contents of a 'Files: debian/*' entry would just duplicate the overriding
'Files: *'. Please correct me if I'm mistaken.

Thank you for taking the time to comment.

Regards,

David Hart