Bug#911832: polyfill should be dropped

[David Prévot]

Hi Kunal,

Le 04/01/2019 à 16:12, Kunal Mehta a écrit :
> On 1/3/19 6:57 PM, David Prévot wrote:
>> Le 04/01/2019 à 12:50, Kunal Mehta a écrit :
>>> This patch adds overrides for all symfony/polyfill-* packages to
>>> pkg-php-tools itself, so all packages will automatically use it and no
>>> longer automatically depend upon php-symfony-polyfill-* (and will cover
>>> all current dependencies).
>>
>> Overrides can be added “locally” (for the build, in
>> debian/pkg-php-tools-overrides, see e.g. twig). Anyway, this is not the
>> only needed step, see below.
> 
> Right. Are you saying you'd rather have the overrides in the individual
> packages instead of in pkg-php-tools?

Since packages need to be rebuilt from source as binNMU are still (even
for arch-all only source packages) not allowed for binary-all, we don’t
need an archive-wide workaround (and you already pointed that there are
only a handful of packages involved).

> I'm happy to prepare patches (and
> NMUs if necessary) either way

Great. Feel free to team-upload stuff under the PHP PEAR (and Composer)
umbrella too.

> but I think we still need a pkg-php-tools
> patch to support dropping the version constraint, which is included in
> my current merge request.

No opinion about pkg-php-tools, I’ll let Mathieu follow up.

>>> And this one drops php-symfony-polyfill-*

Just for the record (since I failed to point why those polyfill were
packaged in first place), those packages may be useful in backport-style
environments where the PHP version or extension constraints are
different than the usual Debian environments.

Also, I don’t mind if php-symfony-polyfill is gracefully removed from
testing (and thus the next Buster release) unless someone feels that it
may be useful.

[…]
>> You also (rightfully) changed the autoload files. It’s not “just” a
>> matter of removing the (build-)dependencies.
> 
> Ack, I just wrote the commit message before I realized those also needed
> to be removed.

Fine by me (I just had to look at the actual MR to find out if you took
everything into account).

Regards

David



signature.asc
Description: OpenPGP digital signature

Bug#911832: polyfill should be dropped

[Kunal Mehta]

Hi,

On 1/3/19 6:57 PM, David Prévot wrote:
> Le 04/01/2019 à 12:50, Kunal Mehta a écrit :
>> This patch adds overrides for all symfony/polyfill-* packages to
>> pkg-php-tools itself, so all packages will automatically use it and no
>> longer automatically depend upon php-symfony-polyfill-* (and will cover
>> all current dependencies).
> 
> Overrides can be added “locally” (for the build, in
> debian/pkg-php-tools-overrides, see e.g. twig). Anyway, this is not the
> only needed step, see below.

Right. Are you saying you'd rather have the overrides in the individual
packages instead of in pkg-php-tools? I'm happy to prepare patches (and
NMUs if necessary) either way, but I think we still need a pkg-php-tools
patch to support dropping the version constraint, which is included in
my current merge request.

>> And this one drops php-symfony-polyfill-* build deps that I don't see
>> why they were required in the first place.
> 
> You also (rightfully) changed the autoload files. It’s not “just” a
> matter of removing the (build-)dependencies.

Ack, I just wrote the commit message before I realized those also needed
to be removed.

-- Kunal



signature.asc
Description: OpenPGP digital signature

Bug#911832: polyfill should be dropped

[David Prévot]

Hi,

Le 04/01/2019 à 12:50, Kunal Mehta a écrit :
> This patch adds overrides for all symfony/polyfill-* packages to
> pkg-php-tools itself, so all packages will automatically use it and no
> longer automatically depend upon php-symfony-polyfill-* (and will cover
> all current dependencies).

Overrides can be added “locally” (for the build, in
debian/pkg-php-tools-overrides, see e.g. twig). Anyway, this is not the
only needed step, see below.

> And this one drops php-symfony-polyfill-* build deps that I don't see
> why they were required in the first place.

You also (rightfully) changed the autoload files. It’s not “just” a
matter of removing the (build-)dependencies.

Regards

David



signature.asc
Description: OpenPGP digital signature

Bug#911832: polyfill should be dropped

[Kunal Mehta]

On 1/2/19 11:57 PM, Kunal Mehta wrote:
> I'm not sure how exactly the best way to remove the dependency is since
> it's automatically generated from composer.json. We could update
> pkg-php-tools to modify php-symfony-polyfill-* dependencies?

https://salsa.debian.org/php-team/pear/pkg-php-tools/merge_requests/1

This patch adds overrides for all symfony/polyfill-* packages to
pkg-php-tools itself, so all packages will automatically use it and no
longer automatically depend upon php-symfony-polyfill-* (and will cover
all current dependencies).

https://salsa.debian.org/php-team/pear/symfony/merge_requests/1

And this one drops php-symfony-polyfill-* build deps that I don't see
why they were required in the first place.

-- Kunal



signature.asc
Description: OpenPGP digital signature

Bug#911832: polyfill should be dropped

[Kunal Mehta]

Hi,

First, I filed  upstream
about the test failures.

However, as I looked a bit more, I'm not sure why this package exists in
Debian in the first place. The purpose of the polyfill is to have pure
PHP fallback implementations for when the PHP install is missing an
extension or on an older version. But neither of those apply to Debian
where we can just depend on the PHP extension itself.

For example, instead of depending upon php-symfony-polyfill-mbstring,
the package should depend upon php-mbstring. All of the
php-symfony-polyfill-php* packages are useless since we're already
providing PHP 7.3.

The vast majority of dependencies are in src:symfony, so it shouldn't be
too difficult to remove:

km@km-pt:~$ reverse-depends src:php-symfony-polyfill
Reverse-Depends
===
* civicrm-common(for php-symfony-polyfill-iconv)
* php-respect-validation(for php-symfony-polyfill-mbstring)
* php-symfony   (for php-symfony-polyfill-php56)
* php-symfony   (for php-symfony-polyfill-ctype)
* php-symfony   (for php-symfony-polyfill-apcu)
* php-symfony   (for php-symfony-polyfill-mbstring)
* php-symfony   (for php-symfony-polyfill-php70)
* php-symfony   (for php-symfony-polyfill-intl-icu)
* php-symfony-cache (for php-symfony-polyfill-apcu)
* php-symfony-config(for php-symfony-polyfill-ctype)
* php-symfony-console   (for php-symfony-polyfill-mbstring)
* php-symfony-doctrine-bridge   (for php-symfony-polyfill-ctype)
* php-symfony-doctrine-bridge   (for php-symfony-polyfill-mbstring)
* php-symfony-dom-crawler   (for php-symfony-polyfill-ctype)
* php-symfony-dom-crawler   (for php-symfony-polyfill-mbstring)
* php-symfony-filesystem(for php-symfony-polyfill-ctype)
* php-symfony-form  (for php-symfony-polyfill-ctype)
* php-symfony-form  (for php-symfony-polyfill-mbstring)
* php-symfony-framework-bundle  (for php-symfony-polyfill-mbstring)
* php-symfony-http-foundation   (for php-symfony-polyfill-php70)
* php-symfony-http-foundation   (for php-symfony-polyfill-mbstring)
* php-symfony-http-kernel   (for php-symfony-polyfill-ctype)
* php-symfony-inflector (for php-symfony-polyfill-ctype)
* php-symfony-intl  (for php-symfony-polyfill-intl-icu)
* php-symfony-ldap  (for php-symfony-polyfill-php56)
* php-symfony-lock  (for php-symfony-polyfill-php70)
* php-symfony-property-access   (for php-symfony-polyfill-php70)
* php-symfony-security  (for php-symfony-polyfill-php70)
* php-symfony-security  (for php-symfony-polyfill-php56)
* php-symfony-security-bundle   (for php-symfony-polyfill-php70)
* php-symfony-security-core (for php-symfony-polyfill-php56)
* php-symfony-security-csrf (for php-symfony-polyfill-php56)
* php-symfony-security-csrf (for php-symfony-polyfill-php70)
* php-symfony-security-http (for php-symfony-polyfill-php56)
* php-symfony-security-http (for php-symfony-polyfill-php70)
* php-symfony-serializer(for php-symfony-polyfill-ctype)
* php-symfony-templating(for php-symfony-polyfill-ctype)
* php-symfony-translation   (for php-symfony-polyfill-mbstring)
* php-symfony-twig-bundle   (for php-symfony-polyfill-ctype)
* php-symfony-validator (for php-symfony-polyfill-mbstring)
* php-symfony-validator (for php-symfony-polyfill-ctype)
* php-symfony-var-dumper(for php-symfony-polyfill-mbstring)
* php-symfony-web-profiler-bundle  (for php-symfony-polyfill-php70)
* php-symfony-web-server-bundle  (for php-symfony-polyfill-ctype)
* php-symfony-yaml  (for php-symfony-polyfill-ctype)
* php-webmozart-assert  (for php-symfony-polyfill-ctype)

I'm not sure how exactly the best way to remove the dependency is since
it's automatically generated from composer.json. We could update
pkg-php-tools to modify php-symfony-polyfill-* dependencies?

HTH,
-- Kunal



signature.asc
Description: OpenPGP digital signature