Bug#921781: fis-gtm: FTBFS (dh_auto_configure fails)

2019-02-10 Thread Shah, Amul
Thank you for the patch! We encountered the same problem with the deprecation 
of icu-config. I will fix the upstream source ASAP.

Best Regards,
Amul

The information contained in this message is proprietary and/or confidential. 
If you are not the intended recipient, please: (i) delete the message and all 
copies; (ii) do not disclose, distribute or use the message in any manner; and 
(iii) notify the sender immediately. In addition, please be aware that any 
message addressed to our domain is subject to archiving and review by persons 
other than the intended recipient. Thank you.


Bug#921781: fis-gtm: FTBFS (dh_auto_configure fails)

2019-02-09 Thread GCS
On Sat, Feb 9, 2019 at 9:13 AM Andreas Tille  wrote:
> The naive approach to simply remove the icu-config
> check from CMakeLists.txt ended up in
>
> ...
> -- Installing: 
> /build/fis-gtm-6.3-005/debian/fis-gtm-6.3-005-stage1/usr/lib/x86_64-linux-gnu/fis-gtm/V6.3-005_x86_64/GDETEMPL.o
> CMake Error at cmake_install.cmake:763 (file):
>   file INSTALL cannot find
>   "/build/fis-gtm-6.3-005/obj-x86_64-linux-gnu/utf8/GDEGET.o".
 This happens with and without icu-config (rebuilt the last ICU one
which had icu-config) as well.
Reason that you didn't recognize:
%GTM-E-GTMDISTUNVERIF, Environment variable $gtm_dist
([builddir]/fis-gtm-6.3-005/obj-x86_64-linux-gnu) could not be
verified against the executables path
([builddir]/fis-gtm-6.3-005/obj-x86_64-linux-gnu/mumps).
But it only happens in my dirty chroot. Normal pbuilder build with my
ICU patch can build your package. Consult the gtm_dist issue with your
upstream if you want.

Laszlo/GCS



Bug#921781: fis-gtm: FTBFS (dh_auto_configure fails)

2019-02-09 Thread GCS
Control: tags -1 +patch

On Sat, Feb 9, 2019 at 9:13 AM Andreas Tille  wrote:
> I've now read logs of #920900 and #898820.  The latter even is
> mentioning that fis-gtm depends icu-config.  I wonder if someone
> who has experience with cmake could lend a helping hand how to
> replace icu-config by pkg-config.
 Proper patch is attached.

> The naive approach to simply remove the icu-config
> check from CMakeLists.txt ended up in
>
> ...
> -- Installing: 
> /build/fis-gtm-6.3-005/debian/fis-gtm-6.3-005-stage1/usr/lib/x86_64-linux-gnu/fis-gtm/V6.3-005_x86_64/GDETEMPL.o
> CMake Error at cmake_install.cmake:763 (file):
>   file INSTALL cannot find
>   "/build/fis-gtm-6.3-005/obj-x86_64-linux-gnu/utf8/GDEGET.o".
 This might be a different issue. Going to check it as well.

Laszlo/GCS
--- fis-gtm-6.3-005.orig/CMakeLists.txt
+++ fis-gtm-6.3-005/CMakeLists.txt
@@ -737,24 +737,9 @@ install(FILES ${scripts}
   PERMISSIONS ${install_permissions_script}
   )
 
-find_program(ICUCONFIG NAMES icu-config)
-if(ICUCONFIG)
-  execute_process(
-COMMAND ${ICUCONFIG} --version
-OUTPUT_VARIABLE icu_version
-RESULT_VARIABLE icu_failed
-OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-  if(icu_failed)
-message(FATAL_ERROR "Command\n ${ICUCONFIG} --version\nfailed (${icu_failed}).")
-  elseif("x${icu_version}" MATCHES "^x([0-9]+\\.[0-9]+)")
-set(gtm_icu_version "${CMAKE_MATCH_1}")
-  else()
-message(FATAL_ERROR "Command\n ${ICUCONFIG} --version\nproduced unrecognized output:\n ${icu_version}")
-  endif()
-else()
-  message(FATAL_ERROR "Unable to find 'icu-config'.  Set ICUCONFIG in CMake cache.")
-endif()
+find_package(PkgConfig REQUIRED)
+PKG_CHECK_MODULES(ICU REQUIRED icu-io)
+set(gtm_icu_version "${ICU_VERSION}")
 
 find_program(LOCALECFG NAMES locale)
 if(LOCALECFG)
--- fis-gtm-6.3-005.orig/sr_unix/gtmprofile.gtc
+++ fis-gtm-6.3-005/sr_unix/gtmprofile.gtc
@@ -75,11 +75,11 @@ if [ $gtm_dist != "$old_gtm_dist" ] ; th
 else gtmroutines=$gtm_dist ; fi
 export gtmroutines
 # Set $gtm_icu_version if icu-config is available - should be set before checking for UTF-8 mode
-if [ -z "$gtm_icu_version" -a -n "`which icu-config`" ] ; then
-	gtm_icu_version=`icu-config --version | gtm_chset=M $gtm_dist/mumps -run %XCMD 'Read x Write $FNumber(x*$Select(+x>5:.1,1:1),"",1)'`
+if [ -z "$gtm_icu_version" -a -n "`which pkg-config`" ] ; then
+	gtm_icu_version=`pkg-config --modversion icu-io | gtm_chset=M $gtm_dist/mumps -run %XCMD 'Read x Write $FNumber(x*$Select(+x>5:.1,1:1),"",1)'`
 export gtm_icu_version
 	# Add library path to LD_LIBRARY_PATH
-	extendlibpath=`icu-config --libdir`
+	extendlibpath=`pkg-config --libs-only-L icu-io`
 	if [ "" = "$LD_LIBRARY_PATH" ]; then LD_LIBRARY_PATH="$extendlibpath"; else LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$extendlibpath";fi; export LD_LIBRARY_PATH
 	if [ "ibm" = "$arch" ]; then
 		if [ "" = "$LIBPATH" ]; then LIBPATH="$extendlibpath"; else LIBPATH="$LIBPATH:$extendlibpath";fi; export LIBPATH;


Bug#921781: fis-gtm: FTBFS (dh_auto_configure fails)

2019-02-09 Thread Andreas Tille
Control: tags -1 help

[CCing some contributors to the bugs mentioned below]

Hi,

I've now read logs of #920900 and #898820.  The latter even is
mentioning that fis-gtm depends icu-config.  I wonder if someone
who has experience with cmake could lend a helping hand how to
replace icu-config by pkg-config.

I'm afraid I will end up with some hackish patches which are
not really nice to submit upstream and I'd prefer to do it the
right.  The naive approach to simply remove the icu-config
check from CMakeLists.txt ended up in 

...
-- Installing: 
/build/fis-gtm-6.3-005/debian/fis-gtm-6.3-005-stage1/usr/lib/x86_64-linux-gnu/fis-gtm/V6.3-005_x86_64/GDETEMPL.o
CMake Error at cmake_install.cmake:763 (file):
  file INSTALL cannot find
  "/build/fis-gtm-6.3-005/obj-x86_64-linux-gnu/utf8/GDEGET.o".

I've pushed my poor attempt to


https://salsa.debian.org/med-team/fis-gtm/blob/master/debian/patches/no_icu-config.patch

but this does not help. :-(

Any hints?

Kind regards

   Andreas.


On Sat, Feb 09, 2019 at 07:15:00AM +0100, Andreas Tille wrote:
> Hi,
> 
> that's caused by missing icu-config (#920900)
> 
> 
> On Sat, Feb 09, 2019 at 12:15:16AM +, Santiago Vila wrote:
> > [... snipped ...]
> 
> -- Detecting C compiler ABI info - done
> -- Detecting C compile features
> -- Detecting C compile features - done
> --> OS = Linux / ARCH = x86_64
> -- Bootstraping from pre-generated sources.
> CMake Error at CMakeLists.txt:756 (message):
>   Unable to find 'icu-config'.  Set ICUCONFIG in CMake cache.
> 
> 
> I need to check how to work around this.  Its a bit ugly to
> drop something with "wontfix" in this release state ...
> 
> Kind regards
> 
>  Andreas.
> 
> -- 
> http://fam-tille.de
> 
> ___
> Debian-med-packaging mailing list
> debian-med-packag...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging

-- 
http://fam-tille.de



Bug#921781: fis-gtm: FTBFS (dh_auto_configure fails)

2019-02-08 Thread Andreas Tille
Hi,

that's caused by missing icu-config (#920900)


On Sat, Feb 09, 2019 at 12:15:16AM +, Santiago Vila wrote:
> -- Check for working C compiler: /usr/bin/cc
> -- Check for working C compiler: /usr/bin/cc -- works
> -- Detecting C compiler ABI info
> 
> [... snipped ...]

... the relevant part was snipped here:


-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
--> OS = Linux / ARCH = x86_64
-- Bootstraping from pre-generated sources.
CMake Error at CMakeLists.txt:756 (message):
  Unable to find 'icu-config'.  Set ICUCONFIG in CMake cache.


I need to check how to work around this.  Its a bit ugly to
drop something with "wontfix" in this release state ...

Kind regards

 Andreas.

-- 
http://fam-tille.de



Bug#921781: fis-gtm: FTBFS (dh_auto_configure fails)

2019-02-08 Thread Santiago Vila
Package: src:fis-gtm
Version: 6.3-005-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:


[...]
 debian/rules build-indep
dh build-indep
   dh_update_autotools_config -i
   dh_autoreconf -i
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<>'
dh_auto_configure -- -DCMAKE_INSTALL_PREFIX:PATH=/usr 
-DGTM_INSTALL_DIR=lib/x86_64-linux-gnu/fis-gtm/V6.3-005_x86_64 
-DCMAKE_BUILD_TYPE=Release
cd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr 
-DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc 
-DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON 
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run 
"-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu -DCMAKE_INSTALL_PREFIX:PATH=/usr 
-DGTM_INSTALL_DIR=lib/x86_64-linux-gnu/fis-gtm/V6.3-005_x86_64 
-DCMAKE_BUILD_TYPE=Release ..
-- The C compiler identification is GNU 8.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info

[... snipped ...]


Run Build Command:"/usr/bin/make" "cmTC_76390/fast"
make[2]: Entering directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'
/usr/bin/make -f CMakeFiles/cmTC_76390.dir/build.make 
CMakeFiles/cmTC_76390.dir/build
make[3]: Entering directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_76390.dir/feature_tests.c.o
/usr/bin/cc   -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2-std=c99 -o CMakeFiles/cmTC_76390.dir/feature_tests.c.o  
 -c /<>/obj-x86_64-linux-gnu/CMakeFiles/feature_tests.c
Linking C executable cmTC_76390
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_76390.dir/link.txt 
--verbose=1
/usr/bin/cc -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2   -Wl,-z,relro -Wl,-z,now  -rdynamic 
CMakeFiles/cmTC_76390.dir/feature_tests.c.o  -o cmTC_76390 
make[3]: Leaving directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'
make[2]: Leaving directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'


Feature record: C_FEATURE:1c_function_prototypes
Feature record: C_FEATURE:1c_restrict
Feature record: C_FEATURE:0c_static_assert
Feature record: C_FEATURE:1c_variadic_macros


Detecting C [-std=c90] compiler features compiled with the following output:
Change Dir: /<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp

Run Build Command:"/usr/bin/make" "cmTC_da08a/fast"
make[2]: Entering directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'
/usr/bin/make -f CMakeFiles/cmTC_da08a.dir/build.make 
CMakeFiles/cmTC_da08a.dir/build
make[3]: Entering directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_da08a.dir/feature_tests.c.o
/usr/bin/cc   -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2-std=c90 -o CMakeFiles/cmTC_da08a.dir/feature_tests.c.o  
 -c /<>/obj-x86_64-linux-gnu/CMakeFiles/feature_tests.c
Linking C executable cmTC_da08a
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_da08a.dir/link.txt 
--verbose=1
/usr/bin/cc -g -O2 -fdebug-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2   -Wl,-z,relro -Wl,-z,now  -rdynamic 
CMakeFiles/cmTC_da08a.dir/feature_tests.c.o  -o cmTC_da08a 
make[3]: Leaving directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'
make[2]: Leaving directory 
'/<>/obj-x86_64-linux-gnu/CMakeFiles/CMakeTmp'


Feature record: C_FEATURE:1c_function_prototypes
Feature record: C_FEATURE:0c_restrict
Feature record: C_FEATURE:0c_static_assert
Feature record: C_FEATURE:0c_variadic_macros
dh_auto_configure: cd obj-x86_64-linux-gnu && cmake -DCMAKE_INSTALL_PREFIX=/usr 
-DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc 
-DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON 
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run 
"-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu -DCMAKE_INSTALL_PREFIX:PATH=/usr 
-DGTM_INSTALL_DIR=lib/x86_64-linux-gnu/fis-gtm/V6.3-005_x86_64 
-DCMAKE_BUILD_TYPE=Release .. returned exit code 1
make[1]: *** [debian/rules:24: override_dh_auto_configure] Error 2
make[1]: Leaving directory '/<>'
make: *** [debian/rules:21: build-indep] Error 2
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit 
status 2


(The above is just how the build ends and not necessarily the most relevant 
part)

The