-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hi,
On Mon, Jun 17, 2019 at 04:10:03AM +0300, antisocrates wrote:
> I am looking for a sponsor for my package "i3-gaps"
Thanks for your contribution! I looked into your package and have the
following remarks:
* Did you talk to the i3-wm maintainer, Michael Stapelberg, about his
opinion on this, and also about ways how to avoid the conflict
between the packages and instead enable it to co-exist?
* Your Recommends is a bit too "fat" IMHO. I would suggest keeping
all that stuff aligned with the i3-wm package, and leave everything
else to the i3 meta package. After upload, you can then ask the i3
maintainer to include your i3-gaps package as alternative
dependency in his i3 meta-package.
* Please add a paragraph about what i3 is to your package
description, not only the differences in i3-gaps.
* Your d/copyright lists i3wm upstream as source rather than the fork,
and also lists the original author as upstream contact. It should
point to the GitHub source repo and list Ingo Bürk as upstream
contact, While at it, please also look into whether Michael
Stapelberg is the only copyright holder. At least Ingo's changes
might be big enough to be separate copyrightable work. How did you
verify the information you put into d/copyright?
* I would prefer to have your packaging repository on
salsa.debian.org.
* Hmm, two almost exact copies of the same code in Debian in two
conflicting packages? i3-gaps is a widely accepted fork I suppose,
yes. What is Michael's opinion on that?
Please go through my remarks and comment each of them with what you
think about it, and whether you implemented it, will do so or
won't.
Cheers,
Nik
-BEGIN PGP SIGNATURE-
iQJlBAEBCgBPFiEEPJ1UpHV1wCb7F/0mt5o8FqDE8pYFAl0HcsUxGmh0dHBzOi8v
d3d3LmRvbWluaWstZ2VvcmdlLmRlL2dwZy1wb2xpY3kudHh0LmFzYwAKCRC3mjwW
oMTylvB8D/0QzHlAilO3kt+nqsvRSQVxqZX1GUYcbvFRbCtxkoHuBAIOrcqPoK7v
JtRuDUbz+WkCtgf8o/qC22dytDHx9u4dTdidJu9htw5owJoFJB29ZpFPU9zRXRw+
kD+Fky3TsnvR4GxRIgrepOnQuvewvxBC37g+IteqELHHSG6YRN/JE0g1O5DZ2gV4
H8ngf1+P5jAASvEZmhfATfQdlyIQxiplTPd2P1vW/ux8nIYwpxBfIjfqeBw60PQB
Dfjmnw0woQEWq05oZCJjUDPpV6sHoJmwiu/tJgqw87T2+yoxPezPNOJARqpoc6C3
FOnVl8BTDmlpOOogsWzyAbLtzMrFREZiSet2HmbWUiapZb1drR1RrCUQzlc0oZy5
ohWhh4O/MdJtR1OYkp+654H6253jHltHULc1uWnyjrkNvsvTyQ0CPsj7Qac54Lj5
XMYtnGvDB3fiJ8zTZDoQR5CC2S+Raue+5d8Np6Dyepo3B2W3qaERKWeni8miCNxI
bBA1Hr83mN53KkUaZotFRipwjCtj8LWj4R4RvyB3KCu1p1dPdQAUvMYQepl9uXGp
xCBlWC1bLbZ40yzCBd2Oz2F5DX5vg2nxAEDxxajPWeGuY7YpS+iAmn9/C4p7Kj4/
d07OqHrwh0P8w3kqxlTkhjSIs8r+7PbN7mz/qR8LCvFhAAvLc6aLJw==
=rliv
-END PGP SIGNATURE-
