Bug#947357: Bug #947357: votebar template fails at parsing some translated files
Hi Laura, On Thu, 26 Dec 2019 22:31:36 +0100 Laura Arjona Reina wrote: > * Fixing the Perl code in /english/template/debian/votebar.wml so it > parses the title and status line wherever they are I've created a MR on the Salsa webwml repository [1]. Build tried locally and it's work fine with the 'define-tag' on other location on the file. Bests regards, Alban [1] https://salsa.debian.org/webmaster-team/webwml/merge_requests/335
Bug#947357: Bug #947357: votebar template fails at parsing some translated files
Hi Laura, On Thu, 26 Dec 2019 22:31:36 +0100 Laura Arjona Reina wrote: > I have noticed that the files not added in the Spanish index were the > ones with the translation-check header in the first line. I have moved > the translation-check header line below, so the first line is the > pagetitle and the second line the status, and then the file is parsed > correctly by the votebar template and thus, added to the index. > > So, I see 2 ways of solving the issue: > > * Fixing the Perl code in /english/template/debian/votebar.wml so it > parses the title and status line wherever they are > > * Finding a list of the translated files not having the pagetitle and > status lines as the first two lines in the file, and fixing them as I > did with the Spanish ones, and adding a note to translators in future > voting files so they move the translation-check header below (note that > copypage.pl places this line at the top of the file). All of files named 'vote_*.wml' now correctly start with: line1: ^ line2: ^ Done by commit e7846f57 [1], thanks Jean-Pierre Giraud. Votebar seem good on any languages. Now I'll see to try to fix the Perl script (but I'm not Perl expert). Best regards, Alban [1] https://salsa.debian.org/webmaster-team/webwml/commit/e7846f578d3c3e61ec164111fa0569e6e8ca0d68 signature.asc Description: OpenPGP digital signature
Bug#947357: Bug #947357: votebar template fails at parsing some translated files
user www.debian@packages.debian.org usertags 947357 scripts retitle 947357 votebar template fails at parsing some translated files thanks I have noticed that the files not added in the Spanish index were the ones with the translation-check header in the first line. I have moved the translation-check header line below, so the first line is the pagetitle and the second line the status, and then the file is parsed correctly by the votebar template and thus, added to the index. So, I see 2 ways of solving the issue: * Fixing the Perl code in /english/template/debian/votebar.wml so it parses the title and status line wherever they are * Finding a list of the translated files not having the pagetitle and status lines as the first two lines in the file, and fixing them as I did with the Spanish ones, and adding a note to translators in future voting files so they move the translation-check header below (note that copypage.pl places this line at the top of the file). Kind regards, -- Laura Arjona Reina https://wiki.debian.org/LauraArjona
