Bug#1000985: Mailman web interface shows Fedora icon on login page, which errors when clicked on

2022-06-29 Thread Olivier Berger
Hi.

Le Thu, Dec 02, 2021 at 08:34:03AM +0100, Alain Knaff a écrit :
> Hi,
> 
> Mailman3-web ships with a
> /usr/share/mailman3-web/settings_local.py.sample file that has
> django_mailman3.lib.auth.fedora included in INSTALLED_APPS
> 
> This causes appearance of a fedora logo on the mailing lists' login
> page. However, clicking on that logo results in an error message mailed
> to admin (see attach)
> 
> Removing django_mailman3.lib.auth.fedora from
> /etc/mailman3/mailman-web.py locally fixes the issue, but obviously
> packages should not ship with defaults that cause errors.
> 
> Thanks,
> 
> Alain

For what it's worth, some related discussion about this parameter's docs, in 
https://gitlab.com/mailman/mailman-suite-doc/-/issues/28

Hth,

-- 
Olivier BERGER
https://www-public.imtbs-tsp.eu/~berger_o/ - OpenPGP 2048R/0xF9EAE3A65819D7E8
Ingenieur Recherche - Dept INF
Institut Mines-Telecom, Telecom SudParis, Evry (France)



Bug#1000985: Mailman web interface shows Fedora icon on login page, which errors when clicked on

2021-12-01 Thread Alain Knaff
Package: mailman3-web
Version: 0+20200530-2

Hi,

Mailman3-web ships with a
/usr/share/mailman3-web/settings_local.py.sample file that has
django_mailman3.lib.auth.fedora included in INSTALLED_APPS

This causes appearance of a fedora logo on the mailing lists' login
page. However, clicking on that logo results in an error message mailed
to admin (see attach)

Removing django_mailman3.lib.auth.fedora from
/etc/mailman3/mailman-web.py locally fixes the issue, but obviously
packages should not ship with defaults that cause errors.

Thanks,

Alain
--- Begin Message ---
Internal Server Error: /mailman3/accounts/fedora/login/

TypeError at /accounts/fedora/login/
_openid_consumer() missing 2 required positional arguments: 'provider' and 
'endpoint'

Request Method: GET
Request URL: 
https://udpcast.linux.lu/mailman3/accounts/fedora/login/?process=login=%2Fmailman3%2Fhyperkitty%2Flist%2Fudpcast%40udpcast.linux.lu%2F2014%2F5%2F
Django Version: 2.2.24
Python Executable: /usr/bin/uwsgi-core
Python Version: 3.9.2
Python Path: ['.', '', '/usr/lib/python39.zip', '/usr/lib/python3.9', 
'/usr/lib/python3.9/lib-dynload', '/usr/local/lib/python3.9/dist-packages', 
'/usr/lib/python3/dist-packages', '/usr/lib/python3.9/dist-packages']
Server time: Mon, 1 Nov 2021 07:20:20 +
Installed Applications:
('hyperkitty',
 'postorius',
 'django_mailman3',
 'django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.sessions',
 'django.contrib.sites',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'rest_framework',
 'django_gravatar',
 'compressor',
 'haystack',
 'django_extensions',
 'django_q',
 'allauth',
 'allauth.account',
 'allauth.socialaccount',
 'django_mailman3.lib.auth.fedora')
Installed Middleware:
('django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.security.SecurityMiddleware',
 'django_mailman3.middleware.TimezoneMiddleware',
 'postorius.middleware.PostoriusMiddleware')


Traceback:

File "/usr/lib/python3/dist-packages/django/core/handlers/exception.py" in inner
  34. response = get_response(request)

File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in 
_get_response
  115. response = self.process_exception_by_middleware(e, 
request)

File "/usr/lib/python3/dist-packages/django/core/handlers/base.py" in 
_get_response
  113. response = wrapped_callback(request, *callback_args, 
**callback_kwargs)

File "/usr/lib/python3/dist-packages/django/views/generic/base.py" in view
  71. return self.dispatch(request, *args, **kwargs)

File "/usr/lib/python3/dist-packages/django/views/generic/base.py" in dispatch
  97. return handler(request, *args, **kwargs)

File "/usr/lib/python3/dist-packages/django_mailman3/lib/auth/fedora/views.py" 
in get
  56. return self.post(request, *args, **kwargs)

File "/usr/lib/python3/dist-packages/django_mailman3/lib/auth/fedora/views.py" 
in post
  67. client = _openid_consumer(request)

Exception Type: TypeError at /accounts/fedora/login/
Exception Value: _openid_consumer() missing 2 required positional arguments: 
'provider' and 'endpoint'
Request information:
USER: AnonymousUser

GET:
process = 'login'
next = '/mailman3/hyperkitty/list/udpc...@udpcast.linux.lu/2014/5/'

POST: No POST data

FILES: No FILES data

COOKIES: No cookie data

META:
CONTEXT_DOCUMENT_ROOT = '/var/www/html'
CONTEXT_PREFIX = ''
DOCUMENT_ROOT = '/var/www/html'
GATEWAY_INTERFACE = 'CGI/1.1'
HTTPS = 'on'
HTTP_ACCEPT = 
'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8,text/html,application/xhtml+xml,application/signed-exchange;v=b3,application/xml;q=0.9,*/*;q=0.8'
HTTP_ACCEPT_ENCODING = 'gzip, deflate, br'
HTTP_AMP_CACHE_TRANSFORM = 'google;v="1..8"'
HTTP_CONNECTION = 'keep-alive'
HTTP_FROM = 'googlebot(at)googlebot.com'
HTTP_HOST = 'udpcast.linux.lu'
HTTP_USER_AGENT = 'Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5X Build/MMB29P) 
AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Mobile Safari/537.36 
(compatible; Googlebot/2.1; +http://www.google.com/bot.html)'
PATH = '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
PATH_INFO = '/accounts/fedora/login/'
QUERY_STRING = 
'process=login=%2Fmailman3%2Fhyperkitty%2Flist%2Fudpcast%40udpcast.linux.lu%2F2014%2F5%2F'
REMOTE_ADDR = '66.249.64.45'
REMOTE_PORT = '37475'
REQUEST_METHOD = 'GET'
REQUEST_SCHEME = 'https'
REQUEST_URI = 
'/mailman3/accounts/fedora/login/?process=login=%2Fmailman3%2Fhyperkitty%2Flist%2Fudpcast%40udpcast.linux.lu%2F2014%2F5%2F'
SCRIPT_FILENAME = 'proxy:uwsgi://localhost/accounts/fedora/login/'
SCRIPT_NAME = '/mailman3'
SERVER_ADDR =