Bug#1004077: node-pbkdf2: autopkgtest regression on s390x

2022-01-26 Thread Yadd 

On 26/01/2022 16:20, Yadd wrote:

On 22/01/2022 10:28, Yadd wrote:

Hi,

I wrote a quick-and-dirty patch for UInt32, you just have to detect 
32/16/8 bits with thing.BYTES_PER_ELEMENT and fix the call of my new 
function.


Else I'll probably able to fix that next week.


Cheers,
Yadd


Hi,

fixed locally except ripemd160 test (probably node-ripemd160 bug). I'm 
going to fix that


False positive

I think I fixed all issues:
 * TypedArray conversions for big-endian architectures
 * test on armhf (tap+tape does something strange, I switched to
   tape only like upstream test)

Hope all is good now

Cheers,
Yadd

Bug#1004077: [Pkg-javascript-devel] Bug#1004077: Bug#1004077: node-pbkdf2: autopkgtest regression on s390x

2022-01-26 Thread Yadd 

On 22/01/2022 10:28, Yadd wrote:

Hi,

I wrote a quick-and-dirty patch for UInt32, you just have to detect 
32/16/8 bits with thing.BYTES_PER_ELEMENT and fix the call of my new 
function.


Else I'll probably able to fix that next week.


Cheers,
Yadd


Hi,

fixed locally except ripemd160 test (probably node-ripemd160 bug). I'm 
going to fix that


Cheers,
Yadd

Bug#1004077: [Pkg-javascript-devel] Bug#1004077: node-pbkdf2: autopkgtest regression on s390x

2022-01-22 Thread Yadd 
Hi,

I wrote a quick-and-dirty patch for UInt32, you just have to detect 32/16/8 
bits with thing.BYTES_PER_ELEMENT and fix the call of my new function.

Else I'll probably able to fix that next week.


Cheers,
Yadd

Le 22 janvier 2022 09:46:59 GMT+01:00, Dipak Zope1  a 
écrit :
>Sure Graham,
>Let me look into this. 
>
>Thanks,
>-Dipak
>
>
>
>From:   "Graham Inggs" 
>To: "Debian Bug Tracking System" 
>Date:   20/01/2022 05:03 PM
>Subject:    [EXTERNAL] Bug#1004077: node-pbkdf2: autopkgtest 
>regression on s390x
>
>
>
>Source: node-pbkdf2
>Version: 3.1.1-1
>X-Debbugs-CC: debian...@lists.debian.org, debian-s...@lists.debian.org
>Severity: important
>User: debian...@lists.debian.org
>Usertags: regression
>
>Hi Maintainer
>
>Since 3.1.1-1, node-pbkdf2's autopkgtests have been failing on the
>big-endian s390x architecture [1].  I 've copied what I hope is the
>relevant part of the log below.
>
>Regards
>Graham
>
>
>[1] 
>https://ci.debian.net/packages/n/node-pbkdf2/ 
>
>
>
># JavaScript pbkdf2sync w/ sha1 encodes
>"112,97,115,115,119,111,114,100" (Uint8Array) with salt "salt"
>(string) with sha1 to
>0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164
>not ok 44 should be strictly equal
>  ---
>operator: equal
>expected: |-
> '0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164'
>actual: |-
> '7ee9a9e0028eea8e908ae69a894a340e42070fa7cc78d680992119a863362487'
>at: Test.
>(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:176:11)
>stack: |-
>  Error: should be strictly equal
>  at Test.assert [as _assert]
>(/usr/share/nodejs/tape/lib/test.js:314:54)
>  at Test.bound [as _assert]
>(/usr/share/nodejs/tape/lib/test.js:99:32)
>  at Test.strictEqual 
>(/usr/share/nodejs/tape/lib/test.js:478:10)
>  at Test.bound [as equal]
>(/usr/share/nodejs/tape/lib/test.js:99:32)
>  at Test.
>(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:176:11)
>  at Test.bound [as _cb] 
>(/usr/share/nodejs/tape/lib/test.js:99:32)
>  at Test.run (/usr/share/nodejs/tape/lib/test.js:117:31)
>  at Test.bound [as run] 
>(/usr/share/nodejs/tape/lib/test.js:99:32)
>  at Immediate.next [as _onImmediate]
>(/usr/share/nodejs/tape/lib/results.js:88:19)
>  at processImmediate (internal/timers.js:461:21)
>  ...
>/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:168
>  t.equal(result.toString('hex'), expected)
> ^
>
>TypeError: Cannot read property 'toString' of undefined
>at 
>/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:168:26
>at /usr/share/nodejs/pbkdf2/lib/async.js:82:7
>at processTicksAndRejections (internal/process/task_queues.js:79:11)
># JavaScript pbkdf2 async w/ sha1 encodes "password" (string) with
>salt "115,97,108,116" (Uint8Array) with sha1 to
>0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164
>not ok 45 TypeError: salt.copy is not a function
>  ---
>operator: error
>at: 
>(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:167:13)
>stack: |-
>  TypeError: salt.copy is not a function
>  at pbkdf2 (/usr/share/nodejs/pbkdf2/lib/sync.js:28:8)
>  at /usr/share/nodejs/pbkdf2/lib/async.js:116:12
>  at processTicksAndRejections
>(internal/process/task_queues.js:97:5)
>  ...
># test count(45) != plan(null)
># failed 3 of 45 tests
>not ok 1 - test/index.js # time=349.71ms
>  ---
>  timeout: 3
>  file: test/index.js
>  command: /usr/bin/node
>  args:
>- test/index.js
>  stdio:
>- 0
>- pipe
>- 2
>  cwd: /tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE
>  failures:
>- tapError: no plan
>  exitCode: 1
>  ...
>
>1..1
># failed 1 test
># time=360.207ms
>
>
>
>
>

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma 
brièveté.

Bug#1004077: node-pbkdf2: autopkgtest regression on s390x

2022-01-22 Thread Dipak Zope1 
Sure Graham,
Let me look into this. 

Thanks,
-Dipak



From:   "Graham Inggs" 
To: "Debian Bug Tracking System" 
Date:   20/01/2022 05:03 PM
Subject:    [EXTERNAL] Bug#1004077: node-pbkdf2: autopkgtest 
regression on s390x



Source: node-pbkdf2
Version: 3.1.1-1
X-Debbugs-CC: debian...@lists.debian.org, debian-s...@lists.debian.org
Severity: important
User: debian...@lists.debian.org
Usertags: regression

Hi Maintainer

Since 3.1.1-1, node-pbkdf2's autopkgtests have been failing on the
big-endian s390x architecture [1].  I 've copied what I hope is the
relevant part of the log below.

Regards
Graham


[1] 
https://ci.debian.net/packages/n/node-pbkdf2/ 



# JavaScript pbkdf2sync w/ sha1 encodes
"112,97,115,115,119,111,114,100" (Uint8Array) with salt "salt"
(string) with sha1 to
0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164
not ok 44 should be strictly equal
  ---
operator: equal
expected: |-
 '0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164'
actual: |-
 '7ee9a9e0028eea8e908ae69a894a340e42070fa7cc78d680992119a863362487'
at: Test.
(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:176:11)
stack: |-
  Error: should be strictly equal
  at Test.assert [as _assert]
(/usr/share/nodejs/tape/lib/test.js:314:54)
  at Test.bound [as _assert]
(/usr/share/nodejs/tape/lib/test.js:99:32)
  at Test.strictEqual 
(/usr/share/nodejs/tape/lib/test.js:478:10)
  at Test.bound [as equal]
(/usr/share/nodejs/tape/lib/test.js:99:32)
  at Test.
(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:176:11)
  at Test.bound [as _cb] 
(/usr/share/nodejs/tape/lib/test.js:99:32)
  at Test.run (/usr/share/nodejs/tape/lib/test.js:117:31)
  at Test.bound [as run] 
(/usr/share/nodejs/tape/lib/test.js:99:32)
  at Immediate.next [as _onImmediate]
(/usr/share/nodejs/tape/lib/results.js:88:19)
  at processImmediate (internal/timers.js:461:21)
  ...
/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:168
  t.equal(result.toString('hex'), expected)
 ^

TypeError: Cannot read property 'toString' of undefined
at 
/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:168:26
at /usr/share/nodejs/pbkdf2/lib/async.js:82:7
at processTicksAndRejections (internal/process/task_queues.js:79:11)
# JavaScript pbkdf2 async w/ sha1 encodes "password" (string) with
salt "115,97,108,116" (Uint8Array) with sha1 to
0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164
not ok 45 TypeError: salt.copy is not a function
  ---
operator: error
at: 
(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:167:13)
stack: |-
  TypeError: salt.copy is not a function
  at pbkdf2 (/usr/share/nodejs/pbkdf2/lib/sync.js:28:8)
  at /usr/share/nodejs/pbkdf2/lib/async.js:116:12
  at processTicksAndRejections
(internal/process/task_queues.js:97:5)
  ...
# test count(45) != plan(null)
# failed 3 of 45 tests
not ok 1 - test/index.js # time=349.71ms
  ---
  timeout: 3
  file: test/index.js
  command: /usr/bin/node
  args:
- test/index.js
  stdio:
- 0
- pipe
- 2
  cwd: /tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE
  failures:
- tapError: no plan
  exitCode: 1
  ...

1..1
# failed 1 test
# time=360.207ms

Bug#1004077: node-pbkdf2: autopkgtest regression on s390x

2022-01-20 Thread Graham Inggs 
Source: node-pbkdf2
Version: 3.1.1-1
X-Debbugs-CC: debian...@lists.debian.org, debian-s...@lists.debian.org
Severity: important
User: debian...@lists.debian.org
Usertags: regression

Hi Maintainer

Since 3.1.1-1, node-pbkdf2's autopkgtests have been failing on the
big-endian s390x architecture [1].  I 've copied what I hope is the
relevant part of the log below.

Regards
Graham


[1] https://ci.debian.net/packages/n/node-pbkdf2/


# JavaScript pbkdf2sync w/ sha1 encodes
"112,97,115,115,119,111,114,100" (Uint8Array) with salt "salt"
(string) with sha1 to
0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164
not ok 44 should be strictly equal
  ---
operator: equal
expected: |-
  '0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164'
actual: |-
  '7ee9a9e0028eea8e908ae69a894a340e42070fa7cc78d680992119a863362487'
at: Test.
(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:176:11)
stack: |-
  Error: should be strictly equal
  at Test.assert [as _assert]
(/usr/share/nodejs/tape/lib/test.js:314:54)
  at Test.bound [as _assert]
(/usr/share/nodejs/tape/lib/test.js:99:32)
  at Test.strictEqual (/usr/share/nodejs/tape/lib/test.js:478:10)
  at Test.bound [as equal]
(/usr/share/nodejs/tape/lib/test.js:99:32)
  at Test.
(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:176:11)
  at Test.bound [as _cb] (/usr/share/nodejs/tape/lib/test.js:99:32)
  at Test.run (/usr/share/nodejs/tape/lib/test.js:117:31)
  at Test.bound [as run] (/usr/share/nodejs/tape/lib/test.js:99:32)
  at Immediate.next [as _onImmediate]
(/usr/share/nodejs/tape/lib/results.js:88:19)
  at processImmediate (internal/timers.js:461:21)
  ...
/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:168
  t.equal(result.toString('hex'), expected)
 ^

TypeError: Cannot read property 'toString' of undefined
at 
/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:168:26
at /usr/share/nodejs/pbkdf2/lib/async.js:82:7
at processTicksAndRejections (internal/process/task_queues.js:79:11)
# JavaScript pbkdf2 async w/ sha1 encodes "password" (string) with
salt "115,97,108,116" (Uint8Array) with sha1 to
0c60c80f961f0e71f3a9b524af6012062fe037a6e0f0eb94fe8fc46bdc637164
not ok 45 TypeError: salt.copy is not a function
  ---
operator: error
at: 
(/tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE/test/index.js:167:13)
stack: |-
  TypeError: salt.copy is not a function
  at pbkdf2 (/usr/share/nodejs/pbkdf2/lib/sync.js:28:8)
  at /usr/share/nodejs/pbkdf2/lib/async.js:116:12
  at processTicksAndRejections
(internal/process/task_queues.js:97:5)
  ...
# test count(45) != plan(null)
# failed 3 of 45 tests
not ok 1 - test/index.js # time=349.71ms
  ---
  timeout: 3
  file: test/index.js
  command: /usr/bin/node
  args:
- test/index.js
  stdio:
- 0
- pipe
- 2
  cwd: /tmp/autopkgtest-lxc.o92ywer_/downtmp/autopkgtest_tmp/smoke6sIkqE
  failures:
- tapError: no plan
  exitCode: 1
  ...

1..1
# failed 1 test
# time=360.207ms