Daniel Shahaf wrote:
> > FAILS: env PAGER=cat quilt series
> > WORKS: env -u LESS PAGER=cat quilt series
> >
> >
> > This is actually a separate but related bug in quilt.
> > If $LESS is set, quilt ignores $PAGER and forces less.
> > This is wrong.
> ⋮
> > 18:38 <REDACTED> [ -n "$LESS" -a -z "${QUILT_PAGER+x}" ] &&
> > QUILT_PAGER="less -FRX"
>
> Agreed. If Alice normally uses «export PAGER=less LESS=S» and then sets
> PAGER=foo, that's the pager quilt shoult use.
>
> Cloned as -2. The above patch does _not_ fix it.
>
> > If quilt wants to override the user's requested $LESS,
> > it should do so with "export LESS=FRX",
> > entirely independent of $QUILT_PAGER'.
>
> This particular approach would be lossy: it would overwrite the user's
> value of $LESS. Instead, quilt could _append_ to $LESS, or pass -R into
> less(1)'s argv, or only use $LESS as a hint if PAGER and GIT_PAGER are
> also unset and less(1) is installed, or document that the user should
> configure their $PAGER / $LESS / $QUILT_PAGER envvars with -R, or…
OK that sounds reasonable.
The part I care about is "don't force PAGER=less when LESS=x".
I don't really care about the EXACT way that is achieved.
All else being equal, I think quilt should mimic git's equivalent logic.
I guess that's here:
https://sources.debian.org/src/git/1:2.35.1-1/Documentation/config/core.txt/?hl=508#L496-L519
