Bug#1010050: bullseye-pu: package clementine/1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1

2022-05-30 Thread Florian Ernst
On Sat, May 28, 2022 at 08:17:47PM +0100, Adam D. Barratt wrote:
> On Sat, 2022-04-23 at 10:25 +0200, Florian Ernst wrote:
> > Clementine fails to start if the package libqt5sql5-sqlite is not
> > installed, i.e. clementine is missing a Depends. This was reported in
> > #1008312, an identical fix has already been uploaded to Unstable.
> > 
> > [ Impact ]
> > Users need to realize that a Depends is missing that they need to
> > install manually. As it is, clementine might simply fail to start.
> > Clementine's error messages indicate that something is missing, but
> > finding the relevant missing package is hard for end users.
> > 
> 
> Please go ahead.

Thanks, just uploaded.

Cheers,
Flo


signature.asc
Description: PGP signature


Bug#1010050: bullseye-pu: package clementine/1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1

2022-05-28 Thread Adam D. Barratt
Control: tags -1 + confirmed

On Sat, 2022-04-23 at 10:25 +0200, Florian Ernst wrote:
> Clementine fails to start if the package libqt5sql5-sqlite is not
> installed, i.e. clementine is missing a Depends. This was reported in
> #1008312, an identical fix has already been uploaded to Unstable.
> 
> [ Impact ]
> Users need to realize that a Depends is missing that they need to
> install manually. As it is, clementine might simply fail to start.
> Clementine's error messages indicate that something is missing, but
> finding the relevant missing package is hard for end users.
> 

Please go ahead.

Regards,

Adam



Bug#1010050: bullseye-pu: package clementine/1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1

2022-04-23 Thread Florian Ernst
Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: Thomas Pierson 

[ Reason ]
Clementine fails to start if the package libqt5sql5-sqlite is not
installed, i.e. clementine is missing a Depends. This was reported in
#1008312, an identical fix has already been uploaded to Unstable.

[ Impact ]
Users need to realize that a Depends is missing that they need to
install manually. As it is, clementine might simply fail to start.
Clementine's error messages indicate that something is missing, but
finding the relevant missing package is hard for end users.

[ Tests ]
There are no code changes at all, clementine just gains an explicit
Depends on a package that most QT users will already have installed
anyways. I'm running the updated package on my local Bullseye just fine.

[ Risks ]
No code changes at all, a trivial fix, and the newly added Depends on
libqt5sql5-sqlite can be fulfilled on all release archs. There had been
a binNMU in Stable that had me worrying whether the versioning of the
proposed upload was correct, but according to apt/dpkg it all works as
intended, cf.
| ~/debian/temp/clementine $ apt policy clementine
| clementine:
|   Installed: 1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1
|   Candidate: 1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1
|   Version table:
|  1.4.0~rc1+git347-gfc4cb6fc7+dfsg-2.1 50
|  50 http://deb.debian.org/debian unstable/main amd64 Packages
|  1.4.0~rc1+git347-gfc4cb6fc7+dfsg-2 50
|  50 http://deb.debian.org/debian testing/main amd64 Packages
|  *** 1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1 100
| 100 /var/lib/dpkg/status
|  1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+b1 990
| 990 http://deb.debian.org/debian bullseye/main amd64 Packages
|  1.3.1+git609-g623a53681+dfsg-1 990
| 990 http://deb.debian.org/debian buster/main amd64 Packages
| ~/debian/temp/clementine $ dpkg --compare-versions 
'1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1' gt 
'1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+b1' && echo true
| true

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
Add explicit Depends on libqt5sql5-sqlite.

[ Other info ]
In the past other packages were impacted similarly and also fixed this
by adding an explicit Depends, e.g.
- kaffeine 1.0~pre3-1 (updated in kaffeine 2.0.3-1)
- kstars 4:16.08.3-2, #854516
- ktouch 4:19.08.3-2, LP#1790955

I'll upload once I receive your approval.

Cheers,
Flo
diff -Nru clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/changelog 
clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/changelog
--- clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/changelog
2020-10-27 11:30:27.0 +0100
+++ clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/changelog
2022-04-23 09:29:26.0 +0200
@@ -1,3 +1,10 @@
+clementine (1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1+deb11u1) bullseye; 
urgency=medium
+
+  * Non-maintainer upload.
+  * Add explicit Depends on libqt5sql5-sqlite (Closes: #1008312)
+
+ -- Florian Ernst   Sat, 23 Apr 2022 09:29:26 +0200
+
 clementine (1.4.0~rc1+git347-gfc4cb6fc7+dfsg-1) unstable; urgency=medium
 
   * New upstream snapshot.
diff -Nru clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/control 
clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/control
--- clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/control  2020-10-27 
11:30:27.0 +0100
+++ clementine-1.4.0~rc1+git347-gfc4cb6fc7+dfsg/debian/control  2022-04-23 
09:12:37.0 +0200
@@ -38,6 +38,7 @@
 Package: clementine
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends},
+ libqt5sql5-sqlite,
  gstreamer1.0-plugins-base,
  gstreamer1.0-plugins-good,
  gstreamer1.0-plugins-ugly


signature.asc
Description: PGP signature