Bug#1010806: apt: Avoid color output on monochrome terminals

2024-01-29 Thread Axel Scheepers
Using 'ncolors' for both function and variable isn't really nice but as is the function will exit when you use it with an unknown terminal which might not be ok. Maybe using the following would be better; #include #include int ncolors(void) { int err, n = -1; if

Bug#1010806: apt: Avoid color output on monochrome terminals

2024-01-29 Thread Axel Scheepers
1010...@bugs.debian.org On Thu, 26 May 2022 11:03:25 +0200 Axel Scheepers wrote: > Or the other way around as I proposed. The entire problem of knowing what > and how to use color goes away when curses is used. Would you accept a > patch for using that instead? I've forgot about this but how

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-26 Thread Axel Scheepers
Op wo 25 mei 2022 21:36 schreef Adam Borowski : > And how, pray tell, may I know in advance what terminal will be used on the > other end of the serial link? Especially if it's a box people ssh into > from > random places, using a plethora of various terminals on their side? > That's the most

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-25 Thread Adam Borowski
On Mon, May 16, 2022 at 08:15:16PM +0200, Axel Scheepers wrote: > On Mon, May 16, 2022 at 6:30 PM Adam Borowski wrote: > > The terminfo entries stopped being maintained by late 80's. And even if > > they were, every new terminal would need to wait several years before it can > > have its

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-16 Thread Daniel Abrecht
Am 2022-05-16 18:29, schrieb Adam Borowski: On Tue, May 10, 2022 at 07:34:25PM +0200, Axel Scheepers wrote: The terminfo entries stopped being maintained by late 80's. This doesn't seam to be true. The terminfo files seam to mostly come from ncurses-term, the ncurses package seams still to be

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-16 Thread Axel Scheepers
Hi, On Mon, May 16, 2022 at 6:30 PM Adam Borowski wrote: > The terminfo entries stopped being maintained by late 80's. And even if > they were, every new terminal would need to wait several years before it can > have its definition known by operating systems (today, distributions). > The

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-16 Thread Adam Borowski
On Tue, May 10, 2022 at 07:34:25PM +0200, Axel Scheepers wrote: > Regarding terminal capabilities, > > On Tue, May 10, 2022 at 6:04 PM Julian Andres Klode wrote: > > > in programs. But there's no common characteristic of a terminal that'd > > > allow autodetecting your wishes. > > The 'proper'

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-10 Thread Axel Scheepers
Hi, Regarding terminal capabilities, On Tue, May 10, 2022 at 6:04 PM Julian Andres Klode wrote: > > in programs. But there's no common characteristic of a terminal that'd > > allow autodetecting your wishes. The 'proper' way would be to query the terminfo entry Co I think. The best way to

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-10 Thread Axel Scheepers
Hi, Thanks for your quick response and thoughtful comments, On Tue, May 10, 2022 at 6:04 PM Julian Andres Klode wrote: > On Tue, May 10, 2022 at 04:54:21PM +0200, Adam Borowski wrote: > > You mean monochrome terminals such as "xterm", "rxvt", "linux", ...? Yes, and screenreaders or other

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-10 Thread Julian Andres Klode
On Tue, May 10, 2022 at 04:54:21PM +0200, Adam Borowski wrote: > On Tue, May 10, 2022 at 02:38:40PM +0200, Axel wrote: > > The apt command shows colors on monochrome terminals (even on a dumb > > terminal), > > please avoid this. Included is a patch which i believe will solve the > > problem > >

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-10 Thread Adam Borowski
On Tue, May 10, 2022 at 02:38:40PM +0200, Axel wrote: > The apt command shows colors on monochrome terminals (even on a dumb > terminal), > please avoid this. Included is a patch which i believe will solve the problem > and only allows output on terminals which actually have 'color' in them; the

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-10 Thread Daniel Abrecht
Hi I'm not really involved with apt development, but I've strong opinions when it comes to terminal applications. The value of $TERM refers to a terminfo / termcap definition / file. If a terminal supports color, and which escape sequences they need for them, is specified inside those

Bug#1010806: apt: Avoid color output on monochrome terminals

2022-05-10 Thread Axel
Package: apt Version: 2.2.4 Severity: normal Dear Maintainer, The apt command shows colors on monochrome terminals (even on a dumb terminal), please avoid this. Included is a patch which i believe will solve the problem and only allows output on terminals which actually have 'color' in them; the