Bug#1013035: sgt-puzzles: ftbfs with GCC-12

2022-07-30 Thread Ben Hutchings 
On Fri, 2022-07-29 at 10:04 +0100, Simon Tatham wrote:
> Ben Hutchings  wrote:
> > I should patch out the use of -Werror in this package though.
> 
> FWIW, I've already done this upstream. Since commit 79a5378 I've
> completely reworked the build system (it's now a unified cmake setup
> rather than my own horrible mkfiles.pl cruft feeding into autotools),
> and removed the default -Werror. And a test build with gcc 12 worked
> fine for me just now with the current upstream code.

Thanks for the reminder to update, and I appreciate the move to CMake.
I've now uploaded version 20220613.387d323.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part

Bug#1013035: sgt-puzzles: ftbfs with GCC-12

2022-07-29 Thread Simon Tatham 
Ben Hutchings  wrote:
> I should patch out the use of -Werror in this package though.

FWIW, I've already done this upstream. Since commit 79a5378 I've
completely reworked the build system (it's now a unified cmake setup
rather than my own horrible mkfiles.pl cruft feeding into autotools),
and removed the default -Werror. And a test build with gcc 12 worked
fine for me just now with the current upstream code.

Cheers,
Simon

-- 
import hashlib; print((lambda p,q,g,y,r,s,m: (lambda w:(pow(g,int(hashlib.sha1(
m.encode('ascii')).hexdigest(),16)*w%q,p)*pow(y,r*w%q,p)%p)%q)(pow(s,q-2,q))==r
and s%q!=0 and m)(12342649995480866419, 2278082317364501, 1670428356600652640,
5398151833726432125, 645223105888478, 1916678356240619, ""))

Bug#1013035: sgt-puzzles: ftbfs with GCC-12

2022-06-19 Thread Ben Hutchings 
On Thu, 2022-06-16 at 12:13 +, Matthias Klose wrote:
[...]
> In file included from /usr/include/string.h:519,
>  from mines.c:12:
> In function ‘memset’,
> inlined from ‘new_game’ at mines.c:2257:2:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:59:10: error: 
> ‘__builtin_memset’ specified size between 18446744071562067968 and 
> 18446744073709551615 exceeds maximum object size 9223372036854775807 
> [-Werror=stringop-overflow=]
>59 |   return __builtin___memset_chk (__dest, __ch, __len,
>   |  ^~~~
>60 |  __glibc_objsize0 (__dest));
>   |  ~~
> mines.c: In function ‘new_game’:
> mines.c:2257:29: note: destination object allocated here
>  2257 | memset(state->layout->mines, 0, wh * sizeof(bool));
>   |~^~~
[...]

This warning is nonsense, isn't it?  It's claiming that memset() is the
allocation site.  And the length (wh) is the result of multiplying two
integers that have been range-checked (though not in this function).

I should patch out the use of -Werror in this package though.

Ben.

-- 
Ben Hutchings
The most exhausting thing in life is being insincere.
 - Anne Morrow Lindberg


signature.asc
Description: This is a digitally signed message part