Bug#1014797: FTBFS: test failures with new libgd3
Hi Olivier, Am Fri, Sep 30, 2022 at 10:49:38AM +0200 schrieb olivier sallou: > > I have a patch. With this patch, tests are ok, but I have no way to know if > it works as expected (don't know how to test it on real case) > Basically it removes gd2 format usage to use png, see patch below. But it > could have impacts on real display. I also can't say. Since you are Uploader I wonder whether you see any reason to wait with an upload. ;-) My guess is, nobody else here on this list can answer your question. Kind regards Andreas. -- http://fam-tille.de
Bug#1014797: FTBFS: test failures with new libgd3
Le ven. 30 sept. 2022 à 07:20, Andreas Tille a écrit :
> Am Fri, Sep 30, 2022 at 02:20:26AM +0200 schrieb olivier sallou:
> > Will try to have a look, but i have no perl knowledge and software is
> quite
> > old now...
>
I have a patch. With this patch, tests are ok, but I have no way to know if
it works as expected (don't know how to test it on real case)
Basically it removes gd2 format usage to use png, see patch below. But it
could have impacts on real display.
Patch:
--- a/lib/Bio/Graphics/Browser2/CachedTrack.pm
+++ b/lib/Bio/Graphics/Browser2/CachedTrack.pm
@@ -151,7 +151,7 @@
sub put_data {
my $self = shift;
my ($gd,$map,$titles) = @_;
-$self->{data}{gd} = $gd->can('gd2') ? $gd->gd2 : $gd;
+$self->{data}{gd} = $gd->png;
$self->{data}{map}= $map;
$self->{data}{titles} = $titles;
my $datafile = $self->datafile;
@@ -191,7 +191,7 @@
my $gd = (ref($data->{gd})
&& ref($data->{gd})=~/^GD/)
? $data->{gd}
-: GD::Image->newFromGd2Data($data->{gd});
+: GD::Image->newFromPngData($data->{gd});
return $gd;
}
--- a/lib/Bio/Graphics/Browser2/Render/Slave.pm
+++ b/lib/Bio/Graphics/Browser2/Render/Slave.pm
@@ -488,7 +488,7 @@
titles=> $titles,
width => $width,
height=> $height,
-imagedata => eval{$imagedata->gd2}};
+imagedata => eval{$imagedata->png}};
}
my $content = nfreeze \%results;
return $content;
Olivier
>
> Alternatively we might consider removal.
>
> Kind regards
>
> Andreas.
>
> --
> http://fam-tille.de
>
Bug#1014797: FTBFS: test failures with new libgd3
Am Fri, Sep 30, 2022 at 02:20:26AM +0200 schrieb olivier sallou: > Will try to have a look, but i have no perl knowledge and software is quite > old now... Alternatively we might consider removal. Kind regards Andreas. -- http://fam-tille.de
Bug#1014797: FTBFS: test failures with new libgd3
Will try to have a look, but i have no perl knowledge and software is quite old now... Le jeu. 29 sept. 2022, 19:44, Andreas Tille a écrit : > Control: tags -1 help > > Hi Aaron and Olivier, > > do you have some idea how to fix this bug? > > Kind regards > > Andreas. > > -- > http://fam-tille.de >
Bug#1014797: FTBFS: test failures with new libgd3
Andreas Tille writes: > do you have some idea how to fix this bug? Not offhand, sorry. In general, I'm not closely familiar with either this package or the underlying GD library (though I do know Perl); I just added myself to Uploaders a decade ago so I could most cleanly upload a packaging fix (for #624130) and stayed there by inertia. -- Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu
Bug#1014797: FTBFS: test failures with new libgd3
Control: tags -1 help Hi Aaron and Olivier, do you have some idea how to fix this bug? Kind regards Andreas. -- http://fam-tille.de
Bug#1014797: FTBFS: test failures with new libgd3
Control: tags -1 upstream Control: forwarded -1 https://github.com/GMOD/GBrowse/issues/64
Bug#1014797: FTBFS: test failures with new libgd3
Source: gbrowse Version: 2.56+dfsg-10 Severity: serious Tags: ftbfs Justification: fails to build from source (but built successfully in the past) -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 While working on libgd-perl and libgd-graph-perl (#1014741) I noticed that gbrowse has issues with the new lbgd(3) as well: On ci.debian.net we have e.g. https://ci.debian.net/data/autopkgtest/testing/amd64/g/gbrowse/23582883/log.gz Test Summary Report - --- t/05.deferredrendering.t (Wstat: 6400 Tests: 15 Failed: 6) Failed tests: 5, 7, 9, 11, 13-14 Non-zero exit status: 25 Parse errors: Bad plan. You planned 19 tests but ran 15. Files=6, Tests=222, 17 wallclock secs ( 0.03 usr 0.01 sys + 4.67 cusr 0.79 csys = 5.50 CPU) Result: FAIL During a local rebuild, even more tests fail: Test Summary Report - --- t/03.render.t (Wstat: 6400 Tests: 48 Failed: 0) Non-zero exit status: 25 Parse errors: Bad plan. You planned 150 tests but ran 48. t/04.remoteserver.t (Wstat: 0 Tests: 39 Failed: 10) Failed tests: 8, 11, 14, 20, 23, 26, 32, 35, 38-39 Parse errors: Bad plan. You planned 43 tests but ran 39. t/05.deferredrendering.t (Wstat: 6400 Tests: 15 Failed: 6) Failed tests: 5, 7, 9, 11, 13-14 Non-zero exit status: 25 Parse errors: Bad plan. You planned 19 tests but ran 15. Files=10, Tests=338, 33 wallclock secs ( 0.08 usr 0.03 sys + 14.09 cusr 1.71 csys = 15.91 CPU) Result: FAIL In my limited understanding, error like GD Warning: GD2 image support has been disabled gdImageGd2Ptr error at /usr/lib/x86_64-linux-gnu/perl/5.34/Storable.pm line 285, at /build/gbrowse-2.56+dfsg/t/../lib/Bio/Graphics/Browser2/CachedTrack.pm line 158. come from the removal of some formats in libgd(3). Cheers, gregor -BEGIN PGP SIGNATURE- iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmLNMWBfFIAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZ+MRAAqCv4lC4CwC55QB4vGWqQTrvarhaXnGUFmJDxgyTRTI0rTpV8emBTNbhO n6ruxd/Y47kIcys6V4JXlfQORAiKBNe680k1kK0I+nSU11/udtHllElxFc9Lk6ng VTTtdNk6QQgtJUiHlNGkvGsEw3p6738ARJDcCeYD2nLYQRsgAG8m15lMP/DDVd1z 3CLC7Z7fER7CLbPdruLbuSMO9k5aq/BwfhRMJLHD6ieft3cWPjudOHy02PoyyP3d nFbWWnski5Go46RtVH4wWmCKHwjw/VmjxQ3Dk8cxhrWJjX2GMrwXyYb+iYFkOES2 VfPDEGnq1hH33rbib0mIFMuKc3hmyRsC4ncgrOySZz0Gl/MS/wIhnlozJYUNCO91 6wMjQvUYXs+0GuD4msJDtDxZaEkJo0uT8NzlhnJ4z8KioslyEY0vhwXdnptaDso7 96XM+tdS/+uibtjwMUe0lX32kMgM0X9NxCxeCE4yKIIXo8FnOhASahj4oYQz6VPZ J3M3nvu/G5PTwOPW/m8GkMe1iMXWBgQhKFDjY4e+qQZToNTot7lDvsuYPBfxcnRV SlxSUgAE+EDKtUpqrOWD9C/7dgR1sBmBtACYMzDhMtKbIptrXEjXBvOdZQ54yA2C Rwo8kus9L08fqQalrs1QZXkkNEPVLPAvkI4x8/lr8jz3HYL4zT8= =VAVx -END PGP SIGNATURE-
