Bug#1019488: bouncycastle: incomplete information in the manifest files
This problem still exists in 1.77 (to be released soon). That sounds like a bnd problem. I can find a reference to a bnd.sh script but it is not included in the source distribution. There is also a add_module.sh script. If we can't find a way to automate this build step, we could use jh_manifest which I would prefer over the patch. signature.asc Description: This is a digitally signed message part
Bug#1019488: bouncycastle: incomplete information in the manifest files
Le 30/10/2022 à 01:31, Sudip Mukherjee a écrit : The attached patch is the minimum required to unblock eclipse-tracecompass. But Emmanuel Bourg did not agree so I am not doing an upload but keeping the patch here for record. Ref: https://lists.debian.org/debian-java/2022/09/msg2.html My objection was about patching the Eclipse manifests, not Bouncy Castle. Regarding BC, the question is why the build system doesn't generate the same OSGi metadata than the ones in Maven Central. Is there a missing build step on our side? Emmanuel Bourg
Bug#1019488: bouncycastle: incomplete information in the manifest files
Control: tags -1 patch -- On Sat, Sep 10, 2022 at 01:09:06PM +0100, Sudip Mukherjee wrote: > Source: bouncycastle > Version: 1.71-1 > Severity: important > X-Debbugs-Cc: sudipm.mukher...@gmail.com > > Dear Maintainer, > > The META-INF/MANIFEST.MF file of libbcpg-java contains only the following: > > > Which is incomplete and does not contain all the other required information > like Bundle-Version, Bundle-Name, Export-Package etc. And this lack of > information > makes the package unusable when using a SimpleConfigurator based bundles.info > file. The attached patch is the minimum required to unblock eclipse-tracecompass. But Emmanuel Bourg did not agree so I am not doing an upload but keeping the patch here for record. Ref: https://lists.debian.org/debian-java/2022/09/msg2.html -- Regards Sudip diff -Nru bouncycastle-1.71/debian/changelog bouncycastle-1.71/debian/changelog --- bouncycastle-1.71/debian/changelog 2022-05-03 18:51:47.0 +0100 +++ bouncycastle-1.71/debian/changelog 2022-09-19 12:20:40.0 +0100 @@ -1,3 +1,10 @@ +bouncycastle (1.71-2) UNRELEASED; urgency=medium + + * Team upload. + * Fix Manifest. (Closes: #1019488) + + -- Sudip Mukherjee Mon, 19 Sep 2022 12:20:40 +0100 + bouncycastle (1.71-1) unstable; urgency=medium * New upstream release diff -Nru bouncycastle-1.71/debian/patches/manifest.patch bouncycastle-1.71/debian/patches/manifest.patch --- bouncycastle-1.71/debian/patches/manifest.patch 1970-01-01 01:00:00.0 +0100 +++ bouncycastle-1.71/debian/patches/manifest.patch 2022-09-19 12:20:40.0 +0100 @@ -0,0 +1,31 @@ +Description: Fix manifest + +Author: Sudip Mukherjee + +--- +Bug-Debian: https://bugs.debian.org/1019488 +Forwarded: no + +--- bouncycastle-1.71.orig/ant/bc+-build.xml bouncycastle-1.71/ant/bc+-build.xml +@@ -414,6 +414,10 @@ + + + ++ ++ ++ ++ + + + +@@ -882,6 +886,9 @@ + + + ++ ++ ++ + + + diff -Nru bouncycastle-1.71/debian/patches/series bouncycastle-1.71/debian/patches/series --- bouncycastle-1.71/debian/patches/series 2022-05-03 10:10:16.0 +0100 +++ bouncycastle-1.71/debian/patches/series 2022-09-19 12:20:40.0 +0100 @@ -1,3 +1,4 @@ 02_index.patch fix-encoding.patch backward-compatibility.patch +manifest.patch
Bug#1019488: bouncycastle: incomplete information in the manifest files
Source: bouncycastle Version: 1.71-1 Severity: important X-Debbugs-Cc: sudipm.mukher...@gmail.com Dear Maintainer, The META-INF/MANIFEST.MF file of libbcpg-java contains only the following: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.10.12 Application-Library-Allowable-Codebase: * Application-Name: Bouncy Castle OpenPGP API Automatic-Module-Name: org.bouncycastle.pg Caller-Allowable-Codebase: * Class-Path: bcprov.jar Codebase: * Created-By: 11.0.15+10-post-Debian-1 (Debian) Extension-Name: org.bouncycastle.bcpg Implementation-Vendor: BouncyCastle.org Implementation-Vendor-Id: org.bouncycastle Implementation-Version: 1.71.00.0 Permissions: all-permissions Specification-Vendor: BouncyCastle.org Specification-Version: 1.1 Trusted-Library: true Which is incomplete and does not contain all the other required information like Bundle-Version, Bundle-Name, Export-Package etc. And this lack of information makes the package unusable when using a SimpleConfigurator based bundles.info file. But if I see the jar file in the maven repository I can see the manifest file in that contains all the required information. The jar can be found at: https://repo1.maven.org/maven2/org/bouncycastle/bcpg-jdk18on/1.71/bcpg-jdk18on-1.71.jar -- Regards Sudip
