Bug#1020287: vcmi: new vcmi provides files conflicting with existing game-data-packager recipe

2022-09-21 Thread Alexandre Detiste
I wanted to be 100% sure.

My locally built package (it took forever) does install correctly when
built with this one-line fix:

>  override_dh_auto_install:
> dh_auto_install --destdir=debian/vcmi
> +   rm -vf debian/vcmi/usr/share/vcmi/Mods/vcmi/Maps/VCMI_Tests_2011b.h3m


> upstream confirmed that the file is indeed DFSG-free. Thank you for bringing 
> it up!
One DFSG file in the big core.zip no-one know what it's made of :-)


> Now we need to decide whether vcmi or homm3-en-data should drop the map.
>
> I'd offer to drop it in vcmi just by adding VCMI_Tests_2011b.h3m to
> Files-Excluded in d/copyright. The file is not needed at all to run vcmi, so
> there is no problem with excluding it from the source package.
>
> What do you think?

Please exclude this file in VCMI.

Maybe "Files-Excluded" will break your build, beware.

Greetings



Bug#1020287: vcmi: new vcmi provides files conflicting with existing game-data-packager recipe

2022-09-21 Thread Johannes Schauer Marin Rodrigues
Hi,

Quoting Alexandre Detiste (2022-09-19 12:57:29)
> The new vcmi tries to overwrite files previously provided by G-D-P generated
> homm3-en-data local package.  Which should be fixed ?
> 
> Is this VCMI_Tests_2011b.h3m file even free ?
> (then it would remain in G-D-P recipe)

upstream confirmed that the file is indeed DFSG-free. Thank you for bringing it
up!

> There might be other duplicated files.

Thanks for making sure that this is the only file!

Now we need to decide whether vcmi or homm3-en-data should drop the map.

I'd offer to drop it in vcmi just by adding VCMI_Tests_2011b.h3m to
Files-Excluded in d/copyright. The file is not needed at all to run vcmi, so
there is no problem with excluding it from the source package.

What do you think?

Thanks!

cheers, josch

signature.asc
Description: signature


Bug#1020287: vcmi: new vcmi provides files conflicting with existing game-data-packager recipe

2022-09-21 Thread Alexandre Detiste
Hi,

It's seems that it's just this only one file conflicting.

root@antec:~# diff -u <(dpkg -L homm3-en-data) <(dpkg -c
/var/cache/apt/archives/vcmi_1.0.0+dfsg-2_amd64.deb | awk '{print
substr($6,2)}') | grep ^\
 /usr/share/vcmi/Mods/vcmi/Maps/VCMI_Tests_2011b.h3m

The full details are in the recipe file here:
   
https://salsa.debian.org/games-team/game-data-packager/-/blob/master/data/heroes3.yaml

dpkg -L homm3-en-data
/.
/usr
/usr/share
/usr/share/doc
/usr/share/doc/homm3-en-data
/usr/share/doc/homm3-en-data/changelog.gz
/usr/share/doc/homm3-en-data/copyright
/usr/share/lintian
/usr/share/lintian/overrides
/usr/share/lintian/overrides/homm3-en-data
/usr/share/vcmi
/usr/share/vcmi/Data
/usr/share/vcmi/Data/H3ab_ahd.snd
/usr/share/vcmi/Data/H3ab_ahd.vid
/usr/share/vcmi/Data/H3ab_bmp.lod
/usr/share/vcmi/Data/H3ab_spr.lod
/usr/share/vcmi/Data/H3bitmap.lod
/usr/share/vcmi/Data/H3sprite.lod
/usr/share/vcmi/Data/Heroes3.snd
/usr/share/vcmi/Data/VIDEO.VID
/usr/share/vcmi/MP3
/usr/share/vcmi/MP3/AITHEME1.MP3
/usr/share/vcmi/MP3/AITHEME2.MP3
/usr/share/vcmi/MP3/AITheme0.mp3
/usr/share/vcmi/MP3/BladeABCampaign.mp3
/usr/share/vcmi/MP3/BladeDBCampaign.mp3
/usr/share/vcmi/MP3/BladeDSCampaign.mp3
/usr/share/vcmi/MP3/BladeFLCampaign.mp3
/usr/share/vcmi/MP3/BladeFWCampaign.mp3
/usr/share/vcmi/MP3/BladePFCampaign.mp3
/usr/share/vcmi/MP3/COMBAT01.MP3
/usr/share/vcmi/MP3/COMBAT02.MP3
/usr/share/vcmi/MP3/COMBAT03.MP3
/usr/share/vcmi/MP3/COMBAT04.MP3
/usr/share/vcmi/MP3/CampainMusic01.mp3
/usr/share/vcmi/MP3/CampainMusic02.mp3
/usr/share/vcmi/MP3/CampainMusic03.mp3
/usr/share/vcmi/MP3/CampainMusic04.mp3
/usr/share/vcmi/MP3/CampainMusic05.mp3
/usr/share/vcmi/MP3/CampainMusic06.mp3
/usr/share/vcmi/MP3/CampainMusic07.mp3
/usr/share/vcmi/MP3/CampainMusic08.mp3
/usr/share/vcmi/MP3/CampainMusic09.mp3
/usr/share/vcmi/MP3/CampainMusic10.mp3
/usr/share/vcmi/MP3/CampainMusic11.mp3
/usr/share/vcmi/MP3/CstleTown.mp3
/usr/share/vcmi/MP3/DIRT.MP3
/usr/share/vcmi/MP3/DUNGEON.MP3
/usr/share/vcmi/MP3/Defend Castle.mp3
/usr/share/vcmi/MP3/ElemTown.mp3
/usr/share/vcmi/MP3/EvilTheme.mp3
/usr/share/vcmi/MP3/FortressTown.mp3
/usr/share/vcmi/MP3/GRASS.MP3
/usr/share/vcmi/MP3/GoodTheme.mp3
/usr/share/vcmi/MP3/InfernoTown.mp3
/usr/share/vcmi/MP3/LAVA.MP3
/usr/share/vcmi/MP3/LoopLepr.mp3
/usr/share/vcmi/MP3/Lose Campain.mp3
/usr/share/vcmi/MP3/LoseCastle.mp3
/usr/share/vcmi/MP3/LoseCombat.mp3
/usr/share/vcmi/MP3/MAINMENU.MP3
/usr/share/vcmi/MP3/NeutralTheme.mp3
/usr/share/vcmi/MP3/RAMPART.MP3
/usr/share/vcmi/MP3/ROUGH.MP3
/usr/share/vcmi/MP3/Retreat Battle.mp3
/usr/share/vcmi/MP3/SAND.MP3
/usr/share/vcmi/MP3/SNOW.MP3
/usr/share/vcmi/MP3/SWAMP.MP3
/usr/share/vcmi/MP3/SecretTheme.mp3
/usr/share/vcmi/MP3/StrongHold.mp3
/usr/share/vcmi/MP3/Surrender Battle.mp3
/usr/share/vcmi/MP3/TowerTown.mp3
/usr/share/vcmi/MP3/UltimateLose.mp3
/usr/share/vcmi/MP3/Underground.mp3
/usr/share/vcmi/MP3/WATER.MP3
/usr/share/vcmi/MP3/Win Battle.mp3
/usr/share/vcmi/MP3/Win Scenario.mp3
/usr/share/vcmi/MP3/necroTown.mp3
/usr/share/vcmi/Maps
/usr/share/vcmi/Maps/A Viking We Shall Go Allied.h3m
/usr/share/vcmi/Maps/A Viking We Shall Go.h3m
/usr/share/vcmi/Maps/A Warm and Familiar Place.h3m
/usr/share/vcmi/Maps/Adventures of Jared Haret.h3m
/usr/share/vcmi/Maps/All for One.h3m
/usr/share/vcmi/Maps/And One for All.h3m
/usr/share/vcmi/Maps/Arrogance Allied.h3m
/usr/share/vcmi/Maps/Arrogance.h3m
/usr/share/vcmi/Maps/Ascension.h3m
/usr/share/vcmi/Maps/Back For Revenge - Allied.h3m
/usr/share/vcmi/Maps/Back For Revenge.h3m
/usr/share/vcmi/Maps/Barbarian Breakout.h3m
/usr/share/vcmi/Maps/Barbarian BreakoutA.h3m
/usr/share/vcmi/Maps/Battle of the Sexes Allied.h3m
/usr/share/vcmi/Maps/Battle of the Sexes.h3m
/usr/share/vcmi/Maps/Brave New World(Allies).h3m
/usr/share/vcmi/Maps/Brave New World.h3m
/usr/share/vcmi/Maps/Buried Treasure.h3m
/usr/share/vcmi/Maps/Carpe Diem - Allied.h3m
/usr/share/vcmi/Maps/Carpe Diem.h3m
/usr/share/vcmi/Maps/Caught in the Middle.h3m
/usr/share/vcmi/Maps/Chasing a Dream.h3m
/usr/share/vcmi/Maps/Crimson and Clover.h3m
/usr/share/vcmi/Maps/Crimson and CloverA.h3m
/usr/share/vcmi/Maps/Darwin's Prize(Allies).h3m
/usr/share/vcmi/Maps/Darwin's Prize.h3m
/usr/share/vcmi/Maps/Dawn of War.h3m
/usr/share/vcmi/Maps/Dead and Buried.h3m
/usr/share/vcmi/Maps/Deluge.h3m
/usr/share/vcmi/Maps/Divided Loyalties.h3m
/usr/share/vcmi/Maps/Divided LoyaltiesA.h3m
/usr/share/vcmi/Maps/Dragon Orb.h3m
/usr/share/vcmi/Maps/Dragon Pass (Allies).h3m
/usr/share/vcmi/Maps/Dragon Pass.h3m
/usr/share/vcmi/Maps/Dungeon Keeper.h3m
/usr/share/vcmi/Maps/Dwarven Gold.h3m
/usr/share/vcmi/Maps/Dwarven Tunnels(Allies).h3m
/usr/share/vcmi/Maps/Dwarven Tunnels.h3m
/usr/share/vcmi/Maps/Elbow Room(Allies).h3m
/usr/share/vcmi/Maps/Elbow Room.h3m
/usr/share/vcmi/Maps/Emerald Isles.h3m
/usr/share/vcmi/Maps/Emerald IslesA.h3m
/usr/share/vcmi/Maps/For Sale.h3m
/usr/share/vcmi/Maps/Fort Noxis.h3m
/usr/share/vcmi/Maps/Free for All.h3m
/usr/share/vcmi/Maps/Freedom.h3m
/usr/share/vcmi/Maps/Gelea's 

Bug#1020287: vcmi: new vcmi provides files conflicting with existing game-data-packager recipe

2022-09-19 Thread Johannes Schauer Marin Rodrigues
Control: forwarded -1 https://github.com/vcmi/vcmi/issues/951

Hi,

Quoting Alexandre Detiste (2022-09-19 12:57:29)
> The new vcmi tries to overwrite files previously provided by G-D-P generated
> homm3-en-data local package.  Which should be fixed ?
> 
> Is this VCMI_Tests_2011b.h3m file even free ?
> (then it would remain in G-D-P recipe)

I need some input from upstream on this matter. I forwarded the bug
accordingly.

> There might be other duplicated files.

can you send the output of `dpkg-deb -c` or similar so that we can check if
there are possibly other conflicts?

Thanks!

cheers, josch

signature.asc
Description: signature


Bug#1020287: vcmi: new vcmi provides files conflicting with existing game-data-packager recipe

2022-09-19 Thread Alexandre Detiste
Package: vcmi
Version: 1.0.0+dfsg-1
Severity: normal
X-Debbugs-Cc: debian-devel-ga...@lists.debian.org

Hi,

The new vcmi tries to overwrite files previously provided by G-D-P
generated homm3-en-data local package.
Which should be fixed ?

Is this VCMI_Tests_2011b.h3m file even free ?
(then it would remain in G-D-P recipe)

There might be other duplicated files.

Greetings,



LANG=C apt upgrade
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Calculating upgrade... Done
The following packages will be upgraded:
  vcmi
1 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/6052 kB of archives.
After this operation, 1665 kB of additional disk space will be used.
Do you want to continue? [Y/n] y
(Reading database ... 537215 files and directories currently installed.)
  
Preparing to unpack .../vcmi_1.0.0+dfsg-1_amd64.deb ... 
  
Unpacking vcmi (1.0.0+dfsg-1) over (0.99+dfsg+git20220621.54fab9f0-3) ...
dpkg: error processing archive 
/var/cache/apt/archives/vcmi_1.0.0+dfsg-1_amd64.deb (--unpack):
 trying to overwrite '/usr/share/vcmi/Mods/vcmi/Maps/VCMI_Tests_2011b.h3m', 
which is also in package homm3-en-data 54
dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)
Errors were encountered while processing:
 /var/cache/apt/archives/vcmi_1.0.0+dfsg-1_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

-- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
merged-usr: no
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.19.0-1-amd64 (SMP w/6 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_BE:fr
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled