Bug#1025744: greetd - FTBFS with new version of rust-nix.

2022-12-17 Thread Peter Green 

Control: severity -1 serious

On 14/12/2022 15:42, Marc Dequènes (duck) wrote:

Control: tags -1 + pending


Quack,

On 2022-12-08 22:21, Peter Green wrote:

I have updated rust-nix in experimental, and intend to do so in unstable
soon, the code in your package builds fine with the new version, but
the Cargo dependencies don't allow it to be used. The attached patch
updates the Debian and Cargo dependencies in your package to be consistent
with each other.


Thanks for the report and patch. I have never tested with 0.24 so I chose to 
enforce 0.25 instead.
I pushed the changes on Salsa and I intend to upload soon but I have other fixes pending that should land soon. 

The new version of rust-nix has just been uploaded to unstable, bumping 
severity.

Bug#1025744: greetd - FTBFS with new version of rust-nix.

2022-12-14 Thread duck 

Control: tags -1 + pending


Quack,

On 2022-12-08 22:21, Peter Green wrote:
I have updated rust-nix in experimental, and intend to do so in 
unstable

soon, the code in your package builds fine with the new version, but
the Cargo dependencies don't allow it to be used. The attached patch
updates the Debian and Cargo dependencies in your package to be 
consistent

with each other.


Thanks for the report and patch. I have never tested with 0.24 so I 
chose to enforce 0.25 instead.
I pushed the changes on Salsa and I intend to upload soon but I have 
other fixes pending that should land soon.


Regards.
\_o<

--
Marc Dequènes

Bug#1025744: greetd - FTBFS with new version of rust-nix.

2022-12-08 Thread Peter Green 

Package: greetd
Version: 0.8.0-1
Severity: important

I have updated rust-nix in experimental, and intend to do so in unstable
soon, the code in your package builds fine with the new version, but
the Cargo dependencies don't allow it to be used. The attached patch
updates the Debian and Cargo dependencies in your package to be consistent
with each other.

I may NMU this later.diff -Nru greetd-0.8.0/debian/changelog greetd-0.8.0/debian/changelog
--- greetd-0.8.0/debian/changelog   2022-10-03 05:22:59.0 +
+++ greetd-0.8.0/debian/changelog   2022-12-08 13:04:43.0 +
@@ -1,3 +1,12 @@
+greetd (0.8.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Consistently depend on version 0.24 or greater of the nix crate in both
+Debian packaging and Cargo.toml. 0.24 seems to be the minimum version 
needed
+to build the patched source code.
+
+ -- Peter Michael Green   Thu, 08 Dec 2022 13:04:43 +
+
 greetd (0.8.0-1) unstable; urgency=medium
 
   * Initial release (Closes: #1010247).
diff -Nru greetd-0.8.0/debian/control greetd-0.8.0/debian/control
--- greetd-0.8.0/debian/control 2022-10-03 05:22:59.0 +
+++ greetd-0.8.0/debian/control 2022-12-08 13:04:02.0 +
@@ -6,7 +6,7 @@
  debhelper-compat (= 13),
  dh-cargo,
 # greetd & greetd_ipc
- librust-nix-dev (>= 0.19),
+ librust-nix-dev (>= 0.24),
  librust-pam-sys-dev (>= 0.5.6),
  librust-users-dev (>= 0.11.0),
  librust-serde-derive-dev (>= 1.0),
diff -Nru greetd-0.8.0/debian/patches/relax_deps.patch 
greetd-0.8.0/debian/patches/relax_deps.patch
--- greetd-0.8.0/debian/patches/relax_deps.patch2022-10-03 
05:22:59.0 +
+++ greetd-0.8.0/debian/patches/relax_deps.patch2022-12-08 
13:03:31.0 +
@@ -4,22 +4,26 @@
 Description: Relax deps to avoid packaging extra versions
 ---
 This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
 a/agreety/Cargo.toml
-+++ b/agreety/Cargo.toml
-@@ -13,4 +13,4 @@
+Index: greetd-0.8.0/agreety/Cargo.toml
+===
+--- greetd-0.8.0.orig/agreety/Cargo.toml
 greetd-0.8.0/agreety/Cargo.toml
+@@ -13,4 +13,4 @@ inish = { path = "../inish"}
  rpassword = "5.0"
  getopts = "0.2"
  enquote = "1.0.3"
 -nix = "0.19"
-+nix = "~0.25.0"
 a/greetd/Cargo.toml
-+++ b/greetd/Cargo.toml
-@@ -11,7 +11,7 @@
++nix = ">= 0.24.0"
+Index: greetd-0.8.0/greetd/Cargo.toml
+===
+--- greetd-0.8.0.orig/greetd/Cargo.toml
 greetd-0.8.0/greetd/Cargo.toml
+@@ -11,7 +11,7 @@ repository = "https://git.sr.ht/~kennyle
  debug = []
  
  [dependencies]
 -nix = "0.19"
-+nix = "~0.25.0"
++nix = ">= 0.24.0"
  pam-sys = "0.5.6"
  users = "0.11.0"
  serde = { version = "1.0", features = ["derive"] }