Bug#1027048: FTBFS with zxing-cpp 1.4 from experimental

2022-12-27 Thread Rene Engelhard

Hallo,

Am 27.12.22 um 07:46 schrieb Johannes Schauer Marin Rodrigues:

[build CXX] cui/source/dialogs/QrCodeGenDialog.cxx
S=/<> && I=$S/instdir && W=$S/workdir &&  mkdir -p $W/CxxObject/cui/source/dialogs/ 
$W/Dep/CxxObject/cui/source/dialogs/ && cd /<> &&  aarch64-linux-gnu-g++ -DAARCH64 -DBOOST_ERROR_CODE_HEADER_ONLY 
-DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DUNIX -DUNX -D_FORTIFY_SOURCE=2 -D_PTHREADS -D_REENTRANT -Wdate-time -Wdate-time 
-D_FORTIFY_SOURCE=2 -DCUI_DLLIMPLEMENTATION  -DSYSTEM_LIBXML  -flto=4 -fuse-linker-plugin -O2 -fvisibility=hidden-Wall -Wno-missing-braces -Wnon-virtual-dtor 
-Wendif-labels -Wextra -Wundef -Wunreachable-code -Wshadow -Wunused-macros  -finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe  -Wdeprecated-copy-dtor 
-Wduplicated-cond -Wlogical-op -Wshift-overflow=2 -Wunused-const-variable=1 -Wno-cast-function-type -fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual 
-std=c++17 -pthread  -g1 -g1 -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat -Werror=format-security   -DEXCEPTIONS_ON 
-fexceptions -fno-enforce-eh-specs-DLIBO_INTERNAL_ONLY  -c $S/cui/source/dialogs/QrCodeGenDialog.cxx -o $W/CxxObject/cui/source/dialogs/QrCodeGenDialog.o -MMD 
-MT $W/CxxObject/cui/source/dialogs/QrCodeGenDialog.o -MP -MF $W/Dep/CxxObject/cui/source/dialogs/QrCodeGenDialog.d_ -DSYSTEM_ZXING 
-I$S/external/clew/source/include -I$S/include -I/usr/lib/jvm/default-java/include -I/usr/lib/jvm/default-java/include/linux -I$S/config_host  -I$S/cui/inc 
-I$S/cui/source/inc  -I$W/CustomTarget/officecfg/registry -I$W/UnoApiHeadersTarget/udkapi/normal -I$W/UnoApiHeadersTarget/offapi/normal -I/usr/include  
-isystem /usr/include/libxml2  -isystem /usr/include/liborcus-0.17  -isystem /usr/include/ZXing   && mv 
$W/Dep/CxxObject/cui/source/dialogs/QrCodeGenDialog.d_ $W/Dep/CxxObject/cui/source/dialogs/QrCodeGenDialog.d
[build CXX] cui/source/dialogs/GraphicTestsDialog.cxx
/<>/cui/source/dialogs/QrCodeGenDialog.cxx:30:10: fatal error: 
BitArray.h: No such file or directory
30 | #include 
   |  ^~~~
compilation terminated.
make[3]: *** [/<>/solenv/gbuild/LinkTarget.mk:337: 
/<>/workdir/CxxObject/cui/source/dialogs/QrCodeGenDialog.o] Error 1

The attached patch fixes the problem and makes libreoffice compile with
both zxing 1.2 from unstable as well as 1.4 from experimental.


Oh, dear.

Yeah, I read that zxing 1.4.0 had prolems. Then I recently saw 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=368116fb55eb83c9f8c7eb180044f848294638bb 
which suggested otherwise, but apparently they just pick up the internal 
header and it's continuing their work for the internal case...


This looks like a substantial change.

Can you nudge the author to submit it upstream so I don't need to carry 
it with me until eternity?

Please consider applying the attached patch for a smooth transition.


You don't really suggest doing this until the transition freeze in ~ 2 
weeks with libreoffice also being in python 3.11-defaults? I need to get 
7.4.4 in...



Regards,


Rene



Bug#1027048: FTBFS with zxing-cpp 1.4 from experimental

2022-12-26 Thread Johannes Schauer Marin Rodrigues
Source: libreoffice
Version: 1:7.4.3-2
Severity: important
Tags: patch

Hi,

libreoffice FTBFS with zxing-cpp 1.4 from experimental:

[build CXX] cui/source/dialogs/QrCodeGenDialog.cxx
S=/<> && I=$S/instdir && W=$S/workdir &&  mkdir -p 
$W/CxxObject/cui/source/dialogs/ $W/Dep/CxxObject/cui/source/dialogs/ && cd 
/<> &&  aarch64-linux-gnu-g++ -DAARCH64 
-DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 
-DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DUNIX -DUNX -D_FORTIFY_SOURCE=2 
-D_PTHREADS -D_REENTRANT -Wdate-time -Wdate-time -D_FORTIFY_SOURCE=2 
-DCUI_DLLIMPLEMENTATION  -DSYSTEM_LIBXML  -flto=4 -fuse-linker-plugin -O2 
-fvisibility=hidden-Wall -Wno-missing-braces -Wnon-virtual-dtor 
-Wendif-labels -Wextra -Wundef -Wunreachable-code -Wshadow -Wunused-macros  
-finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe  
-Wdeprecated-copy-dtor -Wduplicated-cond -Wlogical-op -Wshift-overflow=2 
-Wunused-const-variable=1 -Wno-cast-function-type -fvisibility-inlines-hidden 
-fPIC -Wshadow -Woverloaded-virtual -std=c++17 -pthread  -g1 -g1 -O2 
-ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat 
-Werror=format-security   -DEXCEPTIONS_ON -fexceptions -fno-enforce-eh-specs
-DLIBO_INTERNAL_ONLY  -c $S/cui/source/dialogs/QrCodeGenDialog.cxx -o 
$W/CxxObject/cui/source/dialogs/QrCodeGenDialog.o -MMD -MT 
$W/CxxObject/cui/source/dialogs/QrCodeGenDialog.o -MP -MF 
$W/Dep/CxxObject/cui/source/dialogs/QrCodeGenDialog.d_ -DSYSTEM_ZXING 
-I$S/external/clew/source/include -I$S/include 
-I/usr/lib/jvm/default-java/include -I/usr/lib/jvm/default-java/include/linux 
-I$S/config_host  -I$S/cui/inc -I$S/cui/source/inc  
-I$W/CustomTarget/officecfg/registry -I$W/UnoApiHeadersTarget/udkapi/normal 
-I$W/UnoApiHeadersTarget/offapi/normal -I/usr/include  -isystem 
/usr/include/libxml2  -isystem /usr/include/liborcus-0.17  -isystem 
/usr/include/ZXing   && mv 
$W/Dep/CxxObject/cui/source/dialogs/QrCodeGenDialog.d_ 
$W/Dep/CxxObject/cui/source/dialogs/QrCodeGenDialog.d 
[build CXX] cui/source/dialogs/GraphicTestsDialog.cxx
/<>/cui/source/dialogs/QrCodeGenDialog.cxx:30:10: fatal error: 
BitArray.h: No such file or directory
   30 | #include 
  |  ^~~~
compilation terminated.
make[3]: *** [/<>/solenv/gbuild/LinkTarget.mk:337: 
/<>/workdir/CxxObject/cui/source/dialogs/QrCodeGenDialog.o] Error 1

The attached patch fixes the problem and makes libreoffice compile with
both zxing 1.2 from unstable as well as 1.4 from experimental.

Please consider applying the attached patch for a smooth transition.

Thanks!

cheers, josch