Bug#1028310: hamster-time-tracker: please make the build reproducible

2023-02-25 Thread Raphael Hertzog
Control: tag -1 + pending

Hi,

On Mon, 09 Jan 2023, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> hamster-time-tracker could not be built reproducibly.
> 
> This is because it varied depending on whether it was built with a
> 32- or 64-bit kernel. This resulted in a different value for defs.LIB_DIR.
> 
> However, I don't believe this definition is actually used (it seems to
> be just one of many pre-populated fields from a generic build system),
> so the attached proof-of-concept patch simply removes the line from
> defs.py.in.

Thanks, I applied your patch to git but I will not make a new release
given that we are in a freeze.

Cheers,
-- 
  ⢀⣴⠾⠻⢶⣦⠀   Raphaël Hertzog 
  ⣾⠁⢠⠒⠀⣿⡁
  ⢿⡄⠘⠷⠚⠋The Debian Handbook: https://debian-handbook.info/get/
  ⠈⠳⣄   Debian Long Term Support: https://deb.li/LTS



Bug#1028310: hamster-time-tracker: please make the build reproducible

2023-01-09 Thread Chris Lamb
Source: hamster-time-tracker
Version: 3.0.2-3
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
hamster-time-tracker could not be built reproducibly.

This is because it varied depending on whether it was built with a
32- or 64-bit kernel. This resulted in a different value for defs.LIB_DIR.

However, I don't believe this definition is actually used (it seems to
be just one of many pre-populated fields from a generic build system),
so the attached proof-of-concept patch simply removes the line from
defs.py.in.

 [0] https://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- a/debian/patches/Reproducible-build.patch   1970-01-01 01:00:00.0 
+0100
--- b/debian/patches/Reproducible-build.patch   2023-01-09 12:45:39.028003054 
+
@@ -0,0 +1,12 @@
+Description: Make the build reproducible
+Author: Chris Lamb 
+Last-Update: 2023-01-09
+
+--- hamster-time-tracker-3.0.2.orig/src/hamster/defs.py.in
 hamster-time-tracker-3.0.2/src/hamster/defs.py.in
+@@ -1,5 +1,4 @@
+ DATA_DIR = "@DATADIR@"
+-LIB_DIR = "@LIBDIR@"
+ VERSION = "@VERSION@"
+ PACKAGE = "@PACKAGE@"
+ PYTHONDIR = "@PYTHONDIR@"
--- a/debian/patches/series 2023-01-09 12:39:24.698324294 +
--- b/debian/patches/series 2023-01-09 12:45:38.060047401 +
@@ -1 +1,2 @@
 Use-jquery-and-jquery-ui-from-local-system.patch
+Reproducible-build.patch