Bug#1031382: Re: Bug#1031382: RFS: libkysdk-base/1.0.1-1 [ITP] -- Kylin SDK basic library
Hi！
Thanks for receiving your letter! Based on your suggestion, I've reworked the
changelog, control and package.install files in the debian directory, adjusted
the version numbers, dependencies and installation paths of the binary
packages, etc
I've re-uploaded the adjusted version to mentors, so thank you again for
reviewing it!
Thanks,
KevinDuan
在2023年02月24 04时44分，"Boyuan Yang"写道：
Hi,
在 2023-02-22星期三的 17:25 +0800，Kevin Duan写道：
> HI!
>
> Thanks for the heads up, I have fixed this issue in the latest version and
> have also uploaded the latest to mentors.
> URL: https://mentors.debian.net/package/libkysdk-base/
> Version:1.0.1-3
>
> Thanks！
> KevinDuan
Several issues that need fix:
* Since your package has not entered Debian officially, please do not
increase the revision number. In your next source package provided, please
still use 1.0.1-1 as version number, not 1.0.1-4. Please only increase
revision numbers after your package is officially accepted into Debian
archive.
* For packages that only contains development headers (*-dev), they do not
include shared library files. As a result, the dependency substitution
${shlibs:Depends} is absolutely not needed. Please drop these lines from
debian/control file. However: please do not delete ${shlibs:Depends}
substitution from packages that actually contains shared library file.
* Compared with your previous 1.0.1-1 upload, the current packaging will
directly place header files under /usr/include/ instead of placing them
under subdirectories. While this behavior does not directly conflict with
packaging policy, I will have to let you know that your packaging is likely
to be problematic, buggy and will cause issues in the futures. For example
in the future libkysdk-system packaging
at https://mentors.debian.net/package/libkysdk-system/, some file (e.g.,
src/systeminfo/libkysisinfo.c) will look for header in , not /usr/include/cstring-extension.h. This means
that libkysdk-system will break when being built in the future. Please,
carefully review your packaging decision again; if you are sure that current
packaging is acceptable, I can upload it as-is. Otherwise I recommend you to
review the decision on header file path.
Thanks,
Boyuan Yang
> 在2023年02月22 06时34分，"Boyuan Yang"写道：
> >
> > Control: tags -1 +moreinfo
> >
> > Indeed, please fix the error listed below before we can proceed.
> >
> > Thanks,
> > Boyuan Yang
> >
> > On Thu, 16 Feb 2023 19:55:44 +0100 Adam Borowski
> > wrote:
> > > On Thu, Feb 16, 2023 at 11:05:42AM +0800, kevin wrote:
> > > > * Package name : libkysdk-base
> > > > Version : 1.0.1-1
> > >
> > > > libkysdk-base (1.0.1-1) unstable; urgency=medium
> > > > .
> > > > * Initial release. (Closes: #1031344)
> > >
> > > Hi!
> > > Alas, the package fails to build:
> > >
> > > .
> > > dh_missing: warning: etc/kysdk/kysdk-base/kylog-rotate-default exists
> > > in
> > debian/tmp but is not installed to anywhere (related file:
> > "src/log/kylog-
> > rotate-default")
> > > dh_missing: warning: usr/include/kysdk/kysdk-base/libkylog.h exists in
> > debian/tmp but is not installed to anywhere (related file:
> > "src/log/libkylog.h")
> > > dh_missing: warning: usr/include/kysdk/kysdk-base/listdata.h exists in
> > debian/tmp but is not installed to anywhere (related file:
> > "src/utils/data-
> > structure/linklist/listdata.h")
> > > dh_missing: warning: usr/include/kysdk/kysdk-base/skip_linklist.h
> > > exists
> > in debian/tmp but is not installed to anywhere (related file:
> > "src/utils/data-structure/linklist/skip_linklist/skip_linklist.h")
> > > dh_missing: error: missing files, aborting
> > >
> > >While detecting missing files, dh_missing noted some files with
> > > a
> > similar name to those
> > >that were missing. This error /might/ be resolved by replacing
> > references to the
> > >missing files with the similarly named ones that dh_missing
> > > found -
> > assuming the content
> > >is identical.
> > >
> > >As an example, you might want to replace:
> > > * src/log/kylog-rotate-default
> > >with:
> > > * etc/kysdk/kysdk-base/kylog-rotate-default
> > >in a file in debian/ or as argument to one of the dh_* tools
> > > called
> > from debian/rules.
> > >(Note it is possible the paths are not used verbatim but
> > > instead
> > directories
> > >containing or globs matching them are used instead)
> > >
> > >Alternatively, add the missing file to debian/not-installed if
> > > it
> > cannot and should not
> > >be used.
> > >
> > >The following debhelper tools have reported what they installed
> > (with files per package)
> > > * dh_install: libkysdk-base (0), libkysdk-base-dev (1),
> > > libkysdk-
> > config (2), libkysdk-config-dev (3), libkysdk-log (5), libkysdk-log-dev
> > (3),
> > libkysdk-timer (2), libkysdk-timer-dev (3), libkysdk-utils (4),
> >
Bug#1031382: Re: Bug#1031382: RFS: libkysdk-base/1.0.1-1 [ITP] -- Kylin SDK basic library
Hi,
在 2023-02-22星期三的 17:25 +0800，Kevin Duan写道：
> HI!
>
> Thanks for the heads up, I have fixed this issue in the latest version and
> have also uploaded the latest to mentors.
> URL: https://mentors.debian.net/package/libkysdk-base/
> Version: 1.0.1-3
>
> Thanks！
> KevinDuan
Several issues that need fix:
* Since your package has not entered Debian officially, please do not
increase the revision number. In your next source package provided, please
still use 1.0.1-1 as version number, not 1.0.1-4. Please only increase
revision numbers after your package is officially accepted into Debian
archive.
* For packages that only contains development headers (*-dev), they do not
include shared library files. As a result, the dependency substitution
${shlibs:Depends} is absolutely not needed. Please drop these lines from
debian/control file. However: please do not delete ${shlibs:Depends}
substitution from packages that actually contains shared library file.
* Compared with your previous 1.0.1-1 upload, the current packaging will
directly place header files under /usr/include/ instead of placing them
under subdirectories. While this behavior does not directly conflict with
packaging policy, I will have to let you know that your packaging is likely
to be problematic, buggy and will cause issues in the futures. For example
in the future libkysdk-system packaging
at https://mentors.debian.net/package/libkysdk-system/, some file (e.g.,
src/systeminfo/libkysisinfo.c) will look for header in , not /usr/include/cstring-extension.h. This means
that libkysdk-system will break when being built in the future. Please,
carefully review your packaging decision again; if you are sure that current
packaging is acceptable, I can upload it as-is. Otherwise I recommend you to
review the decision on header file path.
Thanks,
Boyuan Yang
> 在2023年02月22 06时34分，"Boyuan Yang"写道：
> >
> > Control: tags -1 +moreinfo
> >
> > Indeed, please fix the error listed below before we can proceed.
> >
> > Thanks,
> > Boyuan Yang
> >
> > On Thu, 16 Feb 2023 19:55:44 +0100 Adam Borowski
> > wrote:
> > > On Thu, Feb 16, 2023 at 11:05:42AM +0800, kevin wrote:
> > > > * Package name : libkysdk-base
> > > > Version : 1.0.1-1
> > >
> > > > libkysdk-base (1.0.1-1) unstable; urgency=medium
> > > > .
> > > > * Initial release. (Closes: #1031344)
> > >
> > > Hi!
> > > Alas, the package fails to build:
> > >
> > > .
> > > dh_missing: warning: etc/kysdk/kysdk-base/kylog-rotate-default exists
> > > in
> > debian/tmp but is not installed to anywhere (related file:
> > "src/log/kylog-
> > rotate-default")
> > > dh_missing: warning: usr/include/kysdk/kysdk-base/libkylog.h exists in
> > debian/tmp but is not installed to anywhere (related file:
> > "src/log/libkylog.h")
> > > dh_missing: warning: usr/include/kysdk/kysdk-base/listdata.h exists in
> > debian/tmp but is not installed to anywhere (related file:
> > "src/utils/data-
> > structure/linklist/listdata.h")
> > > dh_missing: warning: usr/include/kysdk/kysdk-base/skip_linklist.h
> > > exists
> > in debian/tmp but is not installed to anywhere (related file:
> > "src/utils/data-structure/linklist/skip_linklist/skip_linklist.h")
> > > dh_missing: error: missing files, aborting
> > >
> > > While detecting missing files, dh_missing noted some files with
> > > a
> > similar name to those
> > > that were missing. This error /might/ be resolved by replacing
> > references to the
> > > missing files with the similarly named ones that dh_missing
> > > found -
> > assuming the content
> > > is identical.
> > >
> > > As an example, you might want to replace:
> > > * src/log/kylog-rotate-default
> > > with:
> > > * etc/kysdk/kysdk-base/kylog-rotate-default
> > > in a file in debian/ or as argument to one of the dh_* tools
> > > called
> > from debian/rules.
> > > (Note it is possible the paths are not used verbatim but
> > > instead
> > directories
> > > containing or globs matching them are used instead)
> > >
> > > Alternatively, add the missing file to debian/not-installed if
> > > it
> > cannot and should not
> > > be used.
> > >
> > > The following debhelper tools have reported what they installed
> > (with files per package)
> > > * dh_install: libkysdk-base (0), libkysdk-base-dev (1),
> > > libkysdk-
> > config (2), libkysdk-config-dev (3), libkysdk-log (5), libkysdk-log-dev
> > (3),
> > libkysdk-timer (2), libkysdk-timer-dev (3), libkysdk-utils (4),
> > libkysdk-
> > utils-dev (9)
> > > * dh_installdocs: libkysdk-base (0), libkysdk-base-dev (0),
> > libkysdk-config (0), libkysdk-config-dev (0), libkysdk-log (0),
> > libkysdk-
> > log-dev (0), libkysdk-timer (0), libkysdk-timer-dev (0), libkysdk-utils
> > (0),
> > libkysdk-utils-dev (0)
> > > If the missing files are installed by another tool, please file
> > > a
> > bug against it.
> > >
Bug#1031382: Re: Bug#1031382: RFS: libkysdk-base/1.0.1-1 [ITP] -- Kylin SDK basic library
HI! Thanks for the heads up, I have fixed this issue in the latest version and have also uploaded the latest to mentors. URL: https://mentors.debian.net/package/libkysdk-base/ Version:1.0.1-3 Thanks！ KevinDuan 在2023年02月22 06时34分，"Boyuan Yang"写道： Control: tags -1 +moreinfo Indeed, please fix the error listed below before we can proceed. Thanks, Boyuan Yang On Thu, 16 Feb 2023 19:55:44 +0100 Adam Borowski wrote: > On Thu, Feb 16, 2023 at 11:05:42AM +0800, kevin wrote: > > * Package name : libkysdk-base > >Version : 1.0.1-1 > > > libkysdk-base (1.0.1-1) unstable; urgency=medium > > . > >* Initial release. (Closes: #1031344) > > Hi! > Alas, the package fails to build: > > . > dh_missing: warning: etc/kysdk/kysdk-base/kylog-rotate-default exists in debian/tmp but is not installed to anywhere (related file: "src/log/kylog- rotate-default") > dh_missing: warning: usr/include/kysdk/kysdk-base/libkylog.h exists in debian/tmp but is not installed to anywhere (related file: "src/log/libkylog.h") > dh_missing: warning: usr/include/kysdk/kysdk-base/listdata.h exists in debian/tmp but is not installed to anywhere (related file: "src/utils/data- structure/linklist/listdata.h") > dh_missing: warning: usr/include/kysdk/kysdk-base/skip_linklist.h exists in debian/tmp but is not installed to anywhere (related file: "src/utils/data-structure/linklist/skip_linklist/skip_linklist.h") > dh_missing: error: missing files, aborting > > While detecting missing files, dh_missing noted some files with a similar name to those > that were missing. This error /might/ be resolved by replacing references to the > missing files with the similarly named ones that dh_missing found - assuming the content > is identical. > > As an example, you might want to replace: >* src/log/kylog-rotate-default > with: >* etc/kysdk/kysdk-base/kylog-rotate-default > in a file in debian/ or as argument to one of the dh_* tools called from debian/rules. > (Note it is possible the paths are not used verbatim but instead directories > containing or globs matching them are used instead) > > Alternatively, add the missing file to debian/not-installed if it cannot and should not > be used. > > The following debhelper tools have reported what they installed (with files per package) >* dh_install: libkysdk-base (0), libkysdk-base-dev (1), libkysdk- config (2), libkysdk-config-dev (3), libkysdk-log (5), libkysdk-log-dev (3), libkysdk-timer (2), libkysdk-timer-dev (3), libkysdk-utils (4), libkysdk- utils-dev (9) >* dh_installdocs: libkysdk-base (0), libkysdk-base-dev (0), libkysdk-config (0), libkysdk-config-dev (0), libkysdk-log (0), libkysdk- log-dev (0), libkysdk-timer (0), libkysdk-timer-dev (0), libkysdk-utils (0), libkysdk-utils-dev (0) > If the missing files are installed by another tool, please file a bug against it. > When filing the report, if the tool is not part of debhelper itself, please reference the > "Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+). > (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz) > Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built > If the omission is intentional or no other helper can take care of this consider adding the > paths to debian/not-installed. > ` > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ Let's make a Debian conference in Yalta, Ukraine. > ⢿⡄⠘⠷⠚⠋⠀ > ⠈⠳⣄ > >
Bug#1031382: Re: Bug#1031382: RFS: libkysdk-base/1.0.1-1 [ITP] -- Kylin SDK basic library
HI! Thanks for the heads up, I have fixed this issue in the latest version and have also uploaded the latest to mentors. URL: https://mentors.debian.net/package/libkysdk-base/ Version:1.0.1-3 Thanks！ KevinDuan 在2023年02月17 02时55分，"Adam Borowski"写道： On Thu, Feb 16, 2023 at 11:05:42AM +0800, kevin wrote: > * Package name : libkysdk-base >Version : 1.0.1-1 > libkysdk-base (1.0.1-1) unstable; urgency=medium > . >* Initial release. (Closes: #1031344) Hi! Alas, the package fails to build: . dh_missing: warning: etc/kysdk/kysdk-base/kylog-rotate-default exists in debian/tmp but is not installed to anywhere (related file: "src/log/kylog-rotate-default") dh_missing: warning: usr/include/kysdk/kysdk-base/libkylog.h exists in debian/tmp but is not installed to anywhere (related file: "src/log/libkylog.h") dh_missing: warning: usr/include/kysdk/kysdk-base/listdata.h exists in debian/tmp but is not installed to anywhere (related file: "src/utils/data-structure/linklist/listdata.h") dh_missing: warning: usr/include/kysdk/kysdk-base/skip_linklist.h exists in debian/tmp but is not installed to anywhere (related file: "src/utils/data-structure/linklist/skip_linklist/skip_linklist.h") dh_missing: error: missing files, aborting While detecting missing files, dh_missing noted some files with a similar name to those that were missing. This error /might/ be resolved by replacing references to the missing files with the similarly named ones that dh_missing found - assuming the content is identical. As an example, you might want to replace: * src/log/kylog-rotate-default with: * etc/kysdk/kysdk-base/kylog-rotate-default in a file in debian/ or as argument to one of the dh_* tools called from debian/rules. (Note it is possible the paths are not used verbatim but instead directories containing or globs matching them are used instead) Alternatively, add the missing file to debian/not-installed if it cannot and should not be used. The following debhelper tools have reported what they installed (with files per package) * dh_install: libkysdk-base (0), libkysdk-base-dev (1), libkysdk-config (2), libkysdk-config-dev (3), libkysdk-log (5), libkysdk-log-dev (3), libkysdk-timer (2), libkysdk-timer-dev (3), libkysdk-utils (4), libkysdk-utils-dev (9) * dh_installdocs: libkysdk-base (0), libkysdk-base-dev (0), libkysdk-config (0), libkysdk-config-dev (0), libkysdk-log (0), libkysdk-log-dev (0), libkysdk-timer (0), libkysdk-timer-dev (0), libkysdk-utils (0), libkysdk-utils-dev (0) If the missing files are installed by another tool, please file a bug against it. When filing the report, if the tool is not part of debhelper itself, please reference the "Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+). (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz) Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built If the omission is intentional or no other helper can take care of this consider adding the paths to debian/not-installed. ` Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ Let's make a Debian conference in Yalta, Ukraine. ⢿⡄⠘⠷⠚⠋⠀ ⠈⠳⣄
