Bug#1033503: dgit autopkgtests broken by git 2.40 [and 2 more messages]

[Paul Gevers]

Control: severity -1 serious

Hi,

On Sun, 9 Apr 2023 12:37:16 +0100 Ian Jackson 
 wrote:

After the bookworm release, the severity of this bug should probably
be raised.  That will put this issue back on my radar.


Doing so now, thanks.

Paul


OpenPGP_signature
Description: OpenPGP digital signature

Bug#1033503: dgit autopkgtests broken by git 2.40 [and 2 more messages]

[Ian Jackson]

Recap:

  git's new check in "git hash-object" breaks some tests in src:dgit,
  which deliberately create broken objects eg to detect a regression
  like #849041.  Updating the tests looks nontrivial.

  git 1.2.40-1 doesn't seem like it's going to migrate anyway, given
  that it's a key package which was uploaded during the freeze, and
  the git maintainer hasn't filed an unblock.

My previous message didn't receive any response and we're well into
the hard freeze.  I therefore don't have any plans to update dgit's
test suite for bookworm.

I have taken this work item off my personal todo lists and tracking
machinery, including suppressing the nag emails that I usually get
when my autopkgtests are blocking some other package.

After the bookworm release, the severity of this bug should probably
be raised.  That will put this issue back on my radar.

Thanks,
Ian.

Bug#1033503: dgit autopkgtests broken by git 2.40

[Ian Jackson]

Package: dgit
Version: 10.7
Control: affects -1 git

Some of dgit's tests create strange git objects, to test error
handling.  For example, to avoid a repetition of #849041.

git 2.40, just uploaded to unstable, has this change:

 | * "git hash-object" now checks that the resulting object is well
 |   formed with the same code as "git fsck".
 |   (merge 8e4309038f jk/hash-object-fsck later to maint).

This was probably a good idea.  So, dgit's tests need to be updated.
Normally I would file this bug as RC and make the necessary changes.


However, we are currently in the freeze for bookworm.  Information on
tracker.d.o suggests that git is not going to migrate to bookworm
anyway, without an unblock from the release team.  I don't see an
unblock request in https://bugs.debian.org/release.debian.org .

Release team: do you think we (dgit maintainers) should update the
test suite now, for bookworm ?  The changes would be limited to tests,
but the new checks in git mean we'll need to take a different approach
for some of them, which might be complex or messy.


Unhelpfully, there is also #1032826, which prevents "dgit import-dsc"
working for the current git.dsc in bookworm.  I think this situation
is RC.  I haven't filed a bug against src:git because I think we can
fix this just by changing the infrastructure - I'm talking to DSA
about this - but if that turns out to be impossible, we may need to
upload a no-source-changes src:git :-/.


Thanks for everyone's attention and advice/opinions.

Thanks,
Ian.

-- 
Ian JacksonThese opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.