Bug#1036856: bookworm-pu: package mutter/43.6-1~deb12u1

2023-06-20 Thread Simon McVittie
On Wed, 21 Jun 2023 at 00:06:15 +0100, Simon McVittie wrote:
> On Wed, 07 Jun 2023 at 17:05:37 +0100, Simon McVittie wrote:
> > On Sun, 28 May 2023 at 00:15:26 +0100, Simon McVittie wrote:
> > > The mutter 43.5 release from GNOME upstream seems like something we should
> > > have in a bookworm update.
> > 
> > So does the 43.6 release.
> 
> Updated debdiff attached (everything is the same as mutter_43.6-pre.diff,
> except for debian/changelog)

Really attached now...

smcv
diffstat for mutter-43.4 mutter-43.6

 NEWS  |   21 
 debian/changelog  |   27 
 debian/libmutter-11-0.symbols |1 
 debian/patches/Update-Abkhazian-translation.patch | 4262 --
 debian/patches/clutter-actor-Get-next-action-from-list-before-handling-c.patch|   51 
 debian/patches/cursor-tracker-Don-t-leak-window-cursor-on-exit.patch  |   22 
 debian/patches/debian/Mark-xwayland-test-case-as-known-to-be-flaky-on-32-bit-AR.patch |4 
 debian/patches/debian/meson-Do-not-mark-CI-test-tools-as-required.patch   |4 
 debian/patches/debian/tests-Disable-restore-size-test.patch   |4 
 debian/patches/debian/tests-Tag-unstable-tests-as-flaky.patch |4 
 debian/patches/meson-add-back-default_driver-option.patch |6 
 debian/patches/series |7 
 debian/patches/tests-Break-up-stacking-installed-tests-into-more-smaller.patch|4 
 debian/patches/wayland-Skip-subsurface-desync-if-parent-is-NULL.patch |   35 
 debian/patches/wayland-cursor-surface-Update-cursor-on-dispose.patch  |  701 -
 debian/patches/wayland-outputs-Fix-potential-crash-when-output-has-no-mo.patch|   40 
 debian/patches/wayland-xdg-shell-Dismiss-instead-of-destroy-invalid-popu.patch|   28 
 meson.build   |2 
 src/backends/meta-screen-cast-window-stream.c |   14 
 src/backends/meta-screen-cast-window.c|   12 
 src/backends/meta-screen-cast-window.h|6 
 src/backends/native/meta-kms-impl-device-dummy.c  |7 
 src/compositor/meta-compositor-view.c |2 
 src/compositor/meta-surface-actor-wayland.c   |   50 
 src/compositor/meta-window-actor-private.h|2 
 src/compositor/meta-window-actor.c|   32 
 src/core/window-private.h |2 
 src/meta/window.h |3 
 src/wayland/meta-wayland-actor-surface.c  |   17 
 src/wayland/meta-wayland-outputs.c|7 
 30 files changed, 229 insertions(+), 5148 deletions(-)

diff -Nru mutter-43.4/debian/changelog mutter-43.6/debian/changelog
--- mutter-43.4/debian/changelog	2023-04-21 10:10:24.0 +0100
+++ mutter-43.6/debian/changelog	2023-06-10 22:59:13.0 +0100
@@ -1,3 +1,30 @@
+mutter (43.6-1~deb12u1) bookworm; urgency=medium
+
+  * Rebuild for bookworm
+
+ -- Simon McVittie   Sat, 10 Jun 2023 22:59:13 +0100
+
+mutter (43.6-1) unstable; urgency=medium
+
+  * New upstream stable release 43.5
+- Always update surfaces belonging to a window that is being recorded
+  or included in a screencast, even if the window is not visible
+  on a local display (mutter#2538, mutter!2789)
+- Export previously-private meta_window_has_pointer(), needed by
+  screenshot UI fixes in gnome-shell 43.5 (mutter!2928)
+  + d/libmutter-11-0.symbols: Update to add that symbol
+- All other changes were already present in 43.4-2
+  * New upstream stable release 43.6
+- Fix a resource leak when a compositor view is destroyed (mutter!2991)
+- Fix a crash when headless gdm greeter via gnome-remote-desktop
+  attempts to blank the screen (mutter#2841)
+  * d/patches: Drop patches that were applied upstream
+  * d/p/wayland-outputs-Fix-potential-crash-when-output-has-no-mo.patch:
+Backport patch from 44~beta to fix a crash during suspend/resume on
+some systems (mutter#2570, Closes: #1036268)
+
+ -- Simon McVittie   Sat, 10 Jun 2023 21:17:19 +0100
+
 mutter (43.4-2) unstable; urgency=medium
 
   * Team upload
diff -Nru mutter-43.4/debian/libmutter-11-0.symbols 

Bug#1036856: bookworm-pu: package mutter/43.6-1~deb12u1

2023-06-20 Thread Simon McVittie
On Wed, 07 Jun 2023 at 17:05:37 +0100, Simon McVittie wrote:
> On Sun, 28 May 2023 at 00:15:26 +0100, Simon McVittie wrote:
> > The mutter 43.5 release from GNOME upstream seems like something we should
> > have in a bookworm update.
> 
> So does the 43.6 release.
...
>   [ ] the issue is verified as fixed in unstable
>   - intentionally not done yet, due to full freeze

I uploaded the version from which this is a backport after the bookworm
release, and it has now migrated to testing.

Updated debdiff attached (everything is the same as mutter_43.6-pre.diff,
except for debian/changelog). I've uploaded this version in the hope that
it will be accepted.

I have only tested this and gnome-shell (#1036858) together, so please
accept both or neither.

smcv



Bug#1036856: bookworm-pu: package mutter/43.6-1~deb12u1

2023-06-07 Thread Simon McVittie
Control: retitle -1 bookworm-pu: package mutter/43.6-1~deb12u1

On Sun, 28 May 2023 at 00:15:26 +0100, Simon McVittie wrote:
> The mutter 43.5 release from GNOME upstream seems like something we should
> have in a bookworm update.

So does the 43.6 release.

[ Reason ]
New upstream stable release

[ Impact ]
If not accepted, our default desktop will have several known bugs including
a crash during suspend/resume under some circumstances, and selectively
recording/screencasting a window that is not visible on a display not being
reliable. Additionally, this update is a prerequisite for a bug fix in
gnome-shell which I would also like to get fixed in bookworm (separate
bookworm-pu request, #1036858).

[ Tests ]
Manual testing: I'm running this version on my main laptop, and I'll
upload to unstable as soon as bookworm has been released.

Automated testing: mutter's test-suite still passes at build-time and in
autopkgtest.

[ Risks ]
There's the potential for regressions of similar magnitude to what we're
fixing. GNOME is our default desktop, so any regressions will be highly
visible.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in bookworm
  [ ] the issue is verified as fixed in unstable
  - intentionally not done yet, due to full freeze

[ Changes ]
src/backends/meta-screen-cast-window-stream.c,
src/backends/meta-screen-cast-window.c,
src/compositor/meta-surface-actor-wayland.c,
src/compositor/meta-window-actor.c: make sure that if a window is being
recorded or screencasted, it gets updated at the refresh rate of at least
some arbitrary display, even if it's not actually visible on any display
(for example because it's obscured by a window in front).

src/backends/native/meta-kms-impl-device-dummy.c:
don't crash on trying to blank the screen when run "headless" by
gnome-remote-desktop

src/wayland/meta-wayland-actor-surface.c: consider updating windows even if
they're fully obscured, to make sure that single-window
recording/screencasting works as intended, at the cost of not optimizing
away as many non-user-visible window updates.

src/compositor/meta-compositor-view.c: simple change to fix a resource leak
by calling the parent class's destructor correctly

src/wayland/meta-wayland-outputs.c: backported patch from version 44
(not part of 43.x upstream) to avoid a known source of crashes during
suspend/resume, which might resolve Debian bug reports #1010478 and/or
#1036268

src/core/window-private.h, src/meta/window.h, debian/libmutter-11-0.symbols:
export a symbol needed by GNOME Shell 43.5 for a screenshot bug fix there,
already present in 44.1 in experimental

[ Other info ]
I have not uploaded to unstable due to the full freeze, and I can't
upload to experimental because GNOME 44 is already there.
git diff patch-queue/43.4.. | filterdiff -p1 -x'debian/patches/*.patch' -x'po/*.po'

diff --git a/NEWS b/NEWS
index 65e5d1cf89..410519419e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,24 @@
+43.6
+
+* Fix popup issues [Jonas; !2940]
+* Plugged leak [Jonas; !2991]
+* Fixed crash [Jonas; !3037]
+
+Contributors:
+  Jonas Ådahl
+
+43.5
+
+* Fix recording windows on non-active workspaces [Robert; !2789]
+* Fixed crashes [Colin, Sebastian, Jonas; !2917, !2955, !2969]
+* Misc. bug fixes and cleanups [Ivan; !2928]
+
+Contributors:
+  Jonas Ådahl, Sebastian Keller, Colin Kinloch, Robert Mader, Ivan Molodetskikh
+
+Translators:
+  Nart Tlisha [ab]
+
 43.4
 
 * Do not overwrite previously set offsets on attach [Matthias; !2843]
diff --git a/debian/changelog b/debian/changelog
index d7daed1235..5ec723d601 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,24 @@
+mutter (43.6-1) UNRELEASED; urgency=medium
+
+  * New upstream stable release 43.5
+- Always update surfaces belonging to a window that is being recorded
+  or included in a screencast, even if the window is not visible
+  on a local display (mutter#2538, mutter!2789)
+- Export previously-private meta_window_has_pointer(), needed by
+  screenshot UI fixes in gnome-shell 43.5 (mutter!2928)
+  + d/libmutter-11-0.symbols: Update to add that symbol
+- All other changes were already present in 43.4-2
+  * New upstream stable release 43.6
+- Fix a resource leak when a compositor view is destroyed (mutter!2991)
+- Fix a crash when headless gdm greeter via gnome-remote-desktop
+  attempts to blank the screen (mutter#2841)
+  * d/patches: Drop patches that were applied upstream
+  * d/p/wayland-outputs-Fix-potential-crash-when-output-has-no-mo.patch:
+Backport patch from 44~beta to fix a crash during suspend/resume on
+some systems (mutter#2570, Closes: #1036268)
+
+ -- Simon McVittie   Tue, 06 Jun 2023 18:33:18 +0100
+
 mutter (43.4-2) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/libmutter-11-0.symbols b/debian/libmutter-11-0.symbols
index 1128f2ab36..f3b181d85b 100644