Bug#1039119: darktable: use packaged lua

[roucaries bastien]

Le lun. 26 juin 2023 à 14:16, David Bremner  a écrit :
>
> roucaries bastien  writes:
> >
> > Yes in your case i cheched by grepping thé build log. Lua ils compiléd what
> > why i set rc severity.
>
> I suspect that you saw a different package with Lua in the name, namely
> LuaAutoC. The embedding of that library is a bug, but I'm not sure
> there's any practical benefit to filing it since it is not packaged
> seperately in Debian, and darktable is afaik the only package using it.

Yes I see it now, sorry for the noise..

> Personally there are higher priority issues with darktable, in
> particular the embedding of LibRaw (which is already tracked by it's own
> bug iirc).

Yes I agree

Bug#1039119: darktable: use packaged lua

[David Bremner]

roucaries bastien  writes:
>
> Yes in your case i cheched by grepping thé build log. Lua ils compiléd what
> why i set rc severity.

I suspect that you saw a different package with Lua in the name, namely
LuaAutoC. The embedding of that library is a bug, but I'm not sure
there's any practical benefit to filing it since it is not packaged
seperately in Debian, and darktable is afaik the only package using it.

Personally there are higher priority issues with darktable, in
particular the embedding of LibRaw (which is already tracked by it's own
bug iirc).

Bug#1039119: darktable: use packaged lua

[roucaries bastien]

Le lun. 26 juin 2023 à 06:45, David Bremner  a écrit :

> Bastien Roucariès  writes:
>
> > Source: darktable
> > Version: Use packaged lua
> > Severity: serious
> > Justification: embded code copy
> >
> > Dear Maintainer,
> >
> > It appear that your package embded and compile lua
> >
> > Could you:
> > - use the packaged lua lib
> > - repack in order to avoid accidental reintroduction of compiling lua
> >
> > rouca
>
> Since upstream already checks for the system lua (unless that changed)
> repackaging seems unecessary. Do you have some evidence (build logs ?)
> that the build is not using the system lua
>


Yes in your case i cheched by grepping thé build log. Lua ils compiléd what
why i set rc severity.


Bastien

> d
>

Bug#1039119: darktable: use packaged lua

[David Bremner]

Bastien Roucariès  writes:

> Source: darktable
> Version: Use packaged lua
> Severity: serious
> Justification: embded code copy
>
> Dear Maintainer,
>
> It appear that your package embded and compile lua
>
> Could you:
> - use the packaged lua lib
> - repack in order to avoid accidental reintroduction of compiling lua
>
> rouca

Since upstream already checks for the system lua (unless that changed)
repackaging seems unecessary. Do you have some evidence (build logs ?)
that the build is not using the system lua?

d

Bug#1039119: darktable: use packaged lua

[Bastien Roucariès]

Source: darktable
Version: Use packaged lua
Severity: serious
Justification: embded code copy

Dear Maintainer,

It appear that your package embded and compile lua

Could you:
- use the packaged lua lib
- repack in order to avoid accidental reintroduction of compiling lua

rouca


-- System Information:
Debian Release: trixie/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel

Kernel: Linux 6.1.0-9-rt-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled